@manyos/smileconnect-api 1.41.2 → 1.41.4

package/conf/clients.json

@@ -607,7 +607,8 @@
       "taskWorklog": {
         "fields": [
           "Summary",
-          "Notes"
+          "Notes",
+          "View Access"
         ],
         "constants": [
           {
@@ -621,10 +622,6 @@
           {
             "name": "Communication Source",
             "value": "Other"
-          },
-          {
-            "name": "View Access",
-            "value": "Internal"
           }
         ],
         "basequery": "",

package/conf/mapping.json

@@ -949,6 +949,10 @@
     {
       "oldName": "TaskOrTaskGroupInstanceId",
       "newName": "TaskOrTaskGroupInstanceId"
+    },
+    {
+      "oldName": "View Access",
+      "newName": "viewAccess"
     }
   ],
   "flowBuilder": [

package/controller/taskController.js

@@ -113,7 +113,7 @@ async function createTask(clientConfig, rootForm, rootRequestId, taskData, creat
     }
 }
 //Todo make dynamic
-async function createWorklog(clientConfig, taskId, summary, text, attachment, globalScriptParams) {
+async function createWorklog(clientConfig, taskId, data, globalScriptParams) {
     const task = await getTask(clientConfig,taskId)
     const fields = clientConfig.taskWorklog.fields;
 
@@ -124,19 +124,12 @@ async function createWorklog(clientConfig, taskId, summary, text, attachment, gl
     const mapping = config.getMapping('taskWorklog');
 
     log.debug('mapping', mapping);
-    let data = {
-        "Secure Log" : "Yes",
-        "summary" : summary,
-        "text" : text,
-        "TaskOrTaskGroupID" : taskId,
-        "TaskOrTaskGroupInstanceId" : taskInstanceId
-    };
-
-    fields.push(
+
+    /*fields.push(
         'Secure Log',
         'TaskOrTaskGroupID',
         'TaskOrTaskGroupInstanceId'
-    );
+    );*/
 
     //run preScripts
     if (scripts && scripts.preMapping) {
@@ -145,6 +138,10 @@ async function createWorklog(clientConfig, taskId, summary, text, attachment, gl
 
     data = mappingUtil.applyMapping2Remedy(data, mapping, clientConfig.taskWorklog.constants, fields);
 
+    //add task ID fields after Mapping
+    data["TaskOrTaskGroupID"] = taskId
+    data["TaskOrTaskGroupInstanceId"] = taskInstanceId
+
     //run postScripts
     if (scripts && scripts.postMapping) {
         await scriptController.runScripts(scripts.postMapping, data, clientConfig.clientId, globalScriptParams);

package/controller/ticketWorkLogController.js

@@ -50,7 +50,9 @@ async function createWorklog(ticketConfig, clientConfig, ticketId, data, globalS
     }
 
     const clientConstants = clientConfig[ticketConfig.requestTypeWorkLog].constants;
-    if (data.isPublic) {
+    const viewAccessConstant = clientConstants.find(element => element.name === "View Access")
+    //run only if isPublic is set and no Constant is defined
+    if (data.isPublic && !viewAccessConstant) {
         if (data.isPublic === true) {
             clientConstants.push({"name": "View Access", "value" : "Public"});
         } else {

package/docs/releases.md

@@ -2,12 +2,10 @@
 
 ## API 
 
-### 1.41.2 - 10.08.21
+### 1.41.4 - 10.08.21
 
 Fix mapping for Ticket Worklogs
-
-### 1.41.1 - 10.08.21
-
+Fix mapping for Task Worklogs
 Fix issue with sort in Remedy Adapter
 
 ### 1.41.0 - 03.08.21

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@manyos/smileconnect-api",
-  "version": "1.41.2",
+  "version": "1.41.4",
   "description": "A proxy and abstraction layer for BMCs IT Service Management Suite",
   "main": "app.js",
   "scripts": {

package/routes/taskRoutes.js

@@ -181,7 +181,7 @@ module.exports = (function () {
             req.errorStatus = 422;
             next(errors.array());
         } else {
-            task.createWorklog(req.user.config, taskId, req.body.data.summary, req.body.data.text, undefined, req.globalScriptParams)
+            task.createWorklog(req.user.config, taskId, req.body.data, req.globalScriptParams)
                 .then(createResult => {
                     const worklogId = createResult['0'];
                     task.getTaskWorklog(req.user.config, taskId, worklogId, req.globalScriptParams).then(result => {

package/test/workorderTest.js

@@ -273,7 +273,7 @@ describe('Integration Tests - Workorders', function () {
             chai.request(server)
                 .post(`/v1/workorders/${workorder.id}/worklogs`)
                 .set('Authorization', 'Bearer ' + authUser.access_token)
-                .send({data: {summary: "Worklog Summary", text: "Worklog Text", viewAccess: "Internal"}})
+                .send({data: {summary: "Worklog Summary", text: "Worklog Text", isPublic: true}})
                 .end(function (err, res) {
                     res.should.have.status(200);
                     res.body.data.should.be.an('object');
@@ -494,7 +494,7 @@ describe('Integration Tests - Workorders', function () {
                 chai.request(server)
                     .post(`/v1/workorders/${workorder.id}/tasks/${task.id}/worklogs`)
                     .set('Authorization', 'Bearer ' + authUser.access_token)
-                    .send({data: {summary: "Worklog Summary", text: "Worklog Text"}})
+                    .send({data: {summary: "Worklog Summary", text: "Worklog Text", "viewAccess": "Public"}})
                     .end(function (err, res) {
                         res.should.have.status(200);
                         res.body.data.should.be.an('object');