@manyos/smileconnect-api 1.41.1 → 1.41.3

package/conf/clients.json

@@ -495,7 +495,8 @@
       "workOrderWorklog": {
         "fields": [
           "Description",
-          "Detailed Description"
+          "Detailed Description",
+          "View Access"
         ],
         "constants": [
           {

package/conf/mapping.json

@@ -419,6 +419,10 @@
     {
       "oldName": "Work Log ID",
       "newName": "id"
+    },
+    {
+      "oldName": "View Access",
+      "newName": "viewAccess"
     }
   ],
   "incidentWorklog": [

package/controller/ticketWorkLogController.js

@@ -11,16 +11,13 @@ const scriptController = require('./scriptController');
 
 const ticketCache = new CacheService(process.env.CACHETTL_TICKETS || 1); // Create a new cache service instance
 
-async function createWorklog(ticketConfig, clientConfig, ticketId, summary, text, isPublic, globalScriptParams) {
+async function createWorklog(ticketConfig, clientConfig, ticketId, data, globalScriptParams) {
     const scripts = clientConfig[ticketConfig.requestTypeWorkLog].scripts.POST;
     const mapping = config.getMapping(ticketConfig.requestTypeWorkLog);
     const fields = clientConfig[ticketConfig.requestTypeWorkLog].fields;
 
     log.debug('mapping', mapping);
-    let data = {
-        "summary" : summary,
-        "text" : text
-    };
+
     const requestType = ticketConfig.requestType;
     if (requestType === 'incident') {
         data[searchUtil.mapFieldNameReverse('Incident Number', mapping)] = ticketId;
@@ -53,10 +50,14 @@ async function createWorklog(ticketConfig, clientConfig, ticketId, summary, text
     }
 
     const clientConstants = clientConfig[ticketConfig.requestTypeWorkLog].constants;
-    if (isPublic == true) {
-        clientConstants.push({"name": "View Access", "value" : "Public"});
-    } else {
-        clientConstants.push({"name": "View Access", "value" : "Internal"});
+    const viewAccessConstant = clientConstants.find(element => element.name === "View Access")
+    //run only if isPublic is set and no Constant is defined
+    if (data.isPublic && !viewAccessConstant) {
+        if (data.isPublic === true) {
+            clientConstants.push({"name": "View Access", "value" : "Public"});
+        } else {
+            clientConstants.push({"name": "View Access", "value" : "Internal"});
+        }
     }
 
     //run preScripts

package/docs/releases.md

@@ -2,6 +2,10 @@
 
 ## API 
 
+### 1.41.3 - 10.08.21
+
+Fix mapping for Ticket Worklogs
+
 ### 1.41.1 - 10.08.21
 
 Fix issue with sort in Remedy Adapter

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@manyos/smileconnect-api",
-  "version": "1.41.1",
+  "version": "1.41.3",
   "description": "A proxy and abstraction layer for BMCs IT Service Management Suite",
   "main": "app.js",
   "scripts": {

package/routes/ticketWorkLogRoutes.js

@@ -159,13 +159,8 @@ module.exports = (function() {
                 next({validationErrors: result.array()});
                 return;
             }
-            const reqPublic = req.body.data.isPublic;
-            let isPublic = false;
-            if (reqPublic != null && reqPublic != undefined && reqPublic === true) {
-                isPublic = true;
-            }
 
-            ticketWorkLogController.createWorklog(req.ticketConfig, req.user.config, ticketId, req.body.data.summary, req.body.data.text, isPublic, req.globalScriptParams)
+            ticketWorkLogController.createWorklog(req.ticketConfig, req.user.config, ticketId, req.body.data, req.globalScriptParams)
                 .then(result => {
                     const worklogId = result['0'];
                     req.eventData.ticketNumber2 = worklogId;

package/test/workorderTest.js

@@ -273,7 +273,7 @@ describe('Integration Tests - Workorders', function () {
             chai.request(server)
                 .post(`/v1/workorders/${workorder.id}/worklogs`)
                 .set('Authorization', 'Bearer ' + authUser.access_token)
-                .send({data: {summary: "Worklog Summary", text: "Worklog Text"}})
+                .send({data: {summary: "Worklog Summary", text: "Worklog Text", isPublic: true}})
                 .end(function (err, res) {
                     res.should.have.status(200);
                     res.body.data.should.be.an('object');