@manyos/smileconnect-api 1.41.0 → 1.41.2

package/conf/clients.json

@@ -495,7 +495,8 @@
       "workOrderWorklog": {
         "fields": [
           "Description",
-          "Detailed Description"
+          "Detailed Description",
+          "View Access"
         ],
         "constants": [
           {

package/conf/mapping.json

@@ -419,6 +419,10 @@
     {
       "oldName": "Work Log ID",
       "newName": "id"
+    },
+    {
+      "oldName": "View Access",
+      "newName": "viewAccess"
     }
   ],
   "incidentWorklog": [

package/controller/ticketWorkLogController.js

@@ -11,16 +11,13 @@ const scriptController = require('./scriptController');
 
 const ticketCache = new CacheService(process.env.CACHETTL_TICKETS || 1); // Create a new cache service instance
 
-async function createWorklog(ticketConfig, clientConfig, ticketId, summary, text, isPublic, globalScriptParams) {
+async function createWorklog(ticketConfig, clientConfig, ticketId, data, globalScriptParams) {
     const scripts = clientConfig[ticketConfig.requestTypeWorkLog].scripts.POST;
     const mapping = config.getMapping(ticketConfig.requestTypeWorkLog);
     const fields = clientConfig[ticketConfig.requestTypeWorkLog].fields;
 
     log.debug('mapping', mapping);
-    let data = {
-        "summary" : summary,
-        "text" : text
-    };
+
     const requestType = ticketConfig.requestType;
     if (requestType === 'incident') {
         data[searchUtil.mapFieldNameReverse('Incident Number', mapping)] = ticketId;
@@ -53,10 +50,12 @@ async function createWorklog(ticketConfig, clientConfig, ticketId, summary, text
     }
 
     const clientConstants = clientConfig[ticketConfig.requestTypeWorkLog].constants;
-    if (isPublic == true) {
-        clientConstants.push({"name": "View Access", "value" : "Public"});
-    } else {
-        clientConstants.push({"name": "View Access", "value" : "Internal"});
+    if (data.isPublic) {
+        if (data.isPublic === true) {
+            clientConstants.push({"name": "View Access", "value" : "Public"});
+        } else {
+            clientConstants.push({"name": "View Access", "value" : "Internal"});
+        }
     }
 
     //run preScripts

package/docs/_sidebar.md

@@ -1,25 +1,26 @@
 - Getting started
 
-  - [Quick start](quickstart.md)
-  - [Architecture](architecture.md)
+  - [Quick start](quickstart)
+  - [Architecture](architecture)
   - [API Specification](https://smileconnect.manyosdocs.de/spec/index.html)
+  - [Release notes](releases)
 
 - Configuration
 
-  - [Global Settings](configuration/config.md)
-  - [Mapping](configuration/mapping.md)
-  - [Client Configuration](configuration/clients.md)
-  - [Events](configuration/events.md)
+  - [Global Settings](configuration/config)
+  - [Mapping](configuration/mapping)
+  - [Client Configuration](configuration/clients)
+  - [Events](configuration/events)
 
 - Data manipulation
 
-  - [Scripts](scripts.md)
-  - [Adapter](adapter.md)
+  - [Scripts](scripts)
+  - [Adapter](adapter)
 
 - How-Tos
 
-  - [Authentication](howto/token.md)
-  - [Incident Requests](howto/incidents.md)
-  - [Handle Worklogs](howto/worklogs.md)
-  - [Handle Attachments](howto/attachments.md)
-  - [Read Configuration Items](howto/cmdbobjects.md)
+  - [Authentication](howto/token)
+  - [Incident Requests](howto/incidents)
+  - [Handle Worklogs](howto/worklogs)
+  - [Handle Attachments](howto/attachments)
+  - [Read Configuration Items](howto/cmdbobjects)

package/docs/adapter.md

@@ -49,11 +49,11 @@ return adapterParams;
 
 The different Adapter and their configuration values are described in detail below.
 
-## Remedy
+# Remedy
 
 The Remedy Adapter is used to connect to BMC Remedy Action Request Servers. It allows you to create, query and update records.
 
-### Configuration values
+## Configuration values
 
 **arServer**: The name of the arsystem server. e.g. ars1.mydomain.com
 
@@ -71,9 +71,9 @@ The Remedy Adapter is used to connect to BMC Remedy Action Request Servers. It a
 
 **limitMax**: The maximum number of records retrieved in a query. This parameter can be used to enforce a limit. The limit can not be overwritten by queries.
 
-### Functions
+## Functions
 
-#### Search
+### Search
 
 ```javascript
 async function search(form, query, fields, options)
@@ -125,7 +125,7 @@ Will return an object with a data array and some meta data.
 ```
 
 
-#### Create
+### Create
 
 ```javascript
 async function create(form, entry, options)
@@ -172,7 +172,7 @@ const resultCreate = await adapter.remedy.create(settings.createForm, settings.e
 
 Will return return the id of the created record. e.g. REQ00000002893 or throw an error.
 
-#### Update
+### Update
 
 ```javascript
 async function update(form, id, entry, options)
@@ -222,7 +222,7 @@ const resultUpdate = await adapter.remedy.update(settings.form, settings.id, set
 Will return return the id of the updated record. e.g. 000000000000115 or throw an error.
 
 
-#### Options
+### Options
 
 * limit
 
@@ -267,10 +267,10 @@ const options = {
 }
 ```
 
-## LDAP
+# LDAP
 
 
-### Configuration values
+## Configuration values
 
 * ldapUrl
 
@@ -284,10 +284,10 @@ The Bind DN to authenticate with. e.g. cn=smilecatalog-user,dc=example,dc=com
 
 The secret to use with the Bind DN. e.g. password
 
-### Functions
+## Functions
 
 
-#### Search
+### Search
 
 ```javascript
 async search(base, options)
@@ -338,11 +338,11 @@ Returns an array of records. e.g.
 ]
 ```
 
-## SMILEconnect
+# SMILEconnect
 
 The SMILEconnect Adapter can be used to do calls against SMILEconnect. It will act as it is called externally.
 
-### Configuration values
+## Configuration values
 
 **smileConnectUrl**: The url of your SMILEconnect installation e.g. https://smileconnect.mydomain.io
 
@@ -352,7 +352,7 @@ The SMILEconnect Adapter can be used to do calls against SMILEconnect. It will a
 
 **secret**: The secret of the client. e.g. jd92hd-03283d-2293s-232
 
-### Functions
+## Functions
 
 The SMILEconnect adapter is an open source project.
 

package/docs/releases.md

@@ -2,10 +2,17 @@
 
 ## API 
 
-### 1.41.0 - 02.08.21
+### 1.41.2 - 10.08.21
 
-Update Record added to [Remedy Adapter](adapter#remedy).
+Fix mapping for Ticket Worklogs
+
+### 1.41.1 - 10.08.21
+
+Fix issue with sort in Remedy Adapter
 
+### 1.41.0 - 03.08.21
+
+Update Record added to [Remedy Adapter](adapter#remedy).
 
 ### 1.40.0 - 30.07.21
 
@@ -19,8 +26,20 @@ e.g.
 
 ## Event Manager
 
+### 1.16.0 - 03.08.21
+
+Update Record added to [Remedy Adapter](adapter#remedy).
+
 ### 1.15.0 - 30.07.21
 
 The eventmanager will check all outbound webhooks for an event. If one fails, the whole Event will be set to error and the details will be added to the error message.
 
-## GUI
+## GUI
+
+### 1.4.17 - 09.08.21
+
+Multiple events caused an error in the UI.
+
+### 1.4.16 - 02.08.21
+
+Add Auth + Scripts to Event config

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@manyos/smileconnect-api",
-  "version": "1.41.0",
+  "version": "1.41.2",
   "description": "A proxy and abstraction layer for BMCs IT Service Management Suite",
   "main": "app.js",
   "scripts": {

package/routes/ticketWorkLogRoutes.js

@@ -159,13 +159,8 @@ module.exports = (function() {
                 next({validationErrors: result.array()});
                 return;
             }
-            const reqPublic = req.body.data.isPublic;
-            let isPublic = false;
-            if (reqPublic != null && reqPublic != undefined && reqPublic === true) {
-                isPublic = true;
-            }
 
-            ticketWorkLogController.createWorklog(req.ticketConfig, req.user.config, ticketId, req.body.data.summary, req.body.data.text, isPublic, req.globalScriptParams)
+            ticketWorkLogController.createWorklog(req.ticketConfig, req.user.config, ticketId, req.body.data, req.globalScriptParams)
                 .then(result => {
                     const worklogId = result['0'];
                     req.eventData.ticketNumber2 = worklogId;

package/test/workorderTest.js

@@ -273,7 +273,7 @@ describe('Integration Tests - Workorders', function () {
             chai.request(server)
                 .post(`/v1/workorders/${workorder.id}/worklogs`)
                 .set('Authorization', 'Bearer ' + authUser.access_token)
-                .send({data: {summary: "Worklog Summary", text: "Worklog Text"}})
+                .send({data: {summary: "Worklog Summary", text: "Worklog Text", viewAccess: "Internal"}})
                 .end(function (err, res) {
                     res.should.have.status(200);
                     res.body.data.should.be.an('object');