@manuscripts/track-changes-plugin 0.0.3 → 0.0.4

package/dist/index.es.js

@@ -1265,16 +1265,10 @@ function trackTransaction(tr, oldState, newTr, userID) {
             // } else if (step instanceof AddMarkStep) {
             // } else if (step instanceof RemoveMarkStep) {
         }
-        // TODO: here we could check whether adjacent inserts & deletes cancel each other out.
-        // However, this should not be done by diffing and only matching node or char by char instead since
-        // it's A easier and B more intuitive to user.
-        const { meta } = tr;
-        // This is quite non-optimal in some sense but to ensure no information is lost
-        // we have to re-add all the old meta keys, such as inputType or uiEvent.
-        // This should prevent bugs incase other plugins/widgets rely upon them existing (and they
-        // are not able to process the transactions before track-changes).
-        // TODO: will this cause race-condition if a meta causes another appendTransaction to fire
-        Object.keys(meta).forEach((key) => newTr.setMeta(key, tr.getMeta(key)));
+        // The old meta keys are not copied to the new transaction since this will cause race-conditions
+        // when a single meta-field is thought to be processed. MAYBE only the generic meta keys, such as
+        // inputType or uiEvent, could be copied over but it remains to be seen if it's necessary.
+        // Object.keys(meta).forEach((key) => newTr.setMeta(key, tr.getMeta(key)))
     });
     // This is kinda hacky solution at the moment to maintain NodeSelections over transactions
     // These are required by at least cross-references that need it to activate the selector pop-up

package/dist/index.js

@@ -1273,16 +1273,10 @@ function trackTransaction(tr, oldState, newTr, userID) {
             // } else if (step instanceof AddMarkStep) {
             // } else if (step instanceof RemoveMarkStep) {
         }
-        // TODO: here we could check whether adjacent inserts & deletes cancel each other out.
-        // However, this should not be done by diffing and only matching node or char by char instead since
-        // it's A easier and B more intuitive to user.
-        const { meta } = tr;
-        // This is quite non-optimal in some sense but to ensure no information is lost
-        // we have to re-add all the old meta keys, such as inputType or uiEvent.
-        // This should prevent bugs incase other plugins/widgets rely upon them existing (and they
-        // are not able to process the transactions before track-changes).
-        // TODO: will this cause race-condition if a meta causes another appendTransaction to fire
-        Object.keys(meta).forEach((key) => newTr.setMeta(key, tr.getMeta(key)));
+        // The old meta keys are not copied to the new transaction since this will cause race-conditions
+        // when a single meta-field is thought to be processed. MAYBE only the generic meta keys, such as
+        // inputType or uiEvent, could be copied over but it remains to be seen if it's necessary.
+        // Object.keys(meta).forEach((key) => newTr.setMeta(key, tr.getMeta(key)))
     });
     // This is kinda hacky solution at the moment to maintain NodeSelections over transactions
     // These are required by at least cross-references that need it to activate the selector pop-up

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@manuscripts/track-changes-plugin",
-  "version": "0.0.3",
+  "version": "0.0.4",
   "author": "Atypon Systems LLC",
   "license": "Apache-2.0",
   "homepage": "https://github.com/Atypon-OpenSource/manuscripts-quarterback/tree/main/quarterback-packages/track-changes-plugin",