@luquimbo/bi-superpowers 3.1.1 → 4.1.0

package/bin/lib/mcp-config.test.js

@@ -1,310 +0,0 @@
-/**
- * Tests for the multi-agent MCP config writer.
- */
-
-const { test, describe, beforeEach, afterEach } = require('node:test');
-const assert = require('node:assert');
-const fs = require('node:fs');
-const os = require('node:os');
-const path = require('node:path');
-
-const {
-  MCP_WRITERS,
-  MODELING_SERVER_NAME,
-  LEARN_SERVER_NAME,
-  MICROSOFT_LEARN_URL,
-  tomlEscape,
-  escapeRegex,
-  assertNotSymlink,
-  getLauncherAbsolutePath,
-} = require('./mcp-config');
-
-describe('mcp-config helpers', () => {
-  test('getLauncherAbsolutePath returns absolute launcher path', () => {
-    const pkgDir = '/tmp/fake-pkg';
-    const launcher = getLauncherAbsolutePath(pkgDir);
-    assert.strictEqual(launcher, path.join(pkgDir, 'bin', 'mcp', 'powerbi-modeling-launcher.js'));
-  });
-
-  test('tomlEscape escapes backslashes and quotes', () => {
-    assert.strictEqual(tomlEscape('plain'), 'plain');
-    assert.strictEqual(tomlEscape('C:\\path\\to\\file'), 'C:\\\\path\\\\to\\\\file');
-    assert.strictEqual(tomlEscape('say "hello"'), 'say \\"hello\\"');
-  });
-
-  test('tomlEscape escapes TOML control characters', () => {
-    assert.strictEqual(tomlEscape('line1\nline2'), 'line1\\nline2');
-    assert.strictEqual(tomlEscape('tab\there'), 'tab\\there');
-    assert.strictEqual(tomlEscape('cr\rhere'), 'cr\\rhere');
-    // \x08 = backspace, \f = form feed
-    assert.strictEqual(tomlEscape('\x08\f'), '\\b\\f');
-  });
-
-  test('escapeRegex escapes all regex metacharacters', () => {
-    assert.strictEqual(escapeRegex('plain'), 'plain');
-    assert.strictEqual(escapeRegex('a.b'), 'a\\.b');
-    assert.strictEqual(escapeRegex('a[b]c'), 'a\\[b\\]c');
-    assert.strictEqual(escapeRegex('a+b*c?'), 'a\\+b\\*c\\?');
-    assert.strictEqual(escapeRegex('(hello)'), '\\(hello\\)');
-  });
-});
-
-describe('assertNotSymlink', () => {
-  let tempDir;
-
-  beforeEach(() => {
-    tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'bi-mcp-symlink-'));
-  });
-
-  afterEach(() => {
-    fs.rmSync(tempDir, { recursive: true, force: true });
-  });
-
-  test('allows non-existent paths', () => {
-    assert.doesNotThrow(() => {
-      assertNotSymlink(path.join(tempDir, 'nope.json'));
-    });
-  });
-
-  test('allows regular files', () => {
-    const file = path.join(tempDir, 'regular.json');
-    fs.writeFileSync(file, '{}');
-    assert.doesNotThrow(() => assertNotSymlink(file));
-  });
-
-  test('throws on symbolic links', () => {
-    const target = path.join(tempDir, 'target.json');
-    const link = path.join(tempDir, 'link.json');
-    fs.writeFileSync(target, '{}');
-    fs.symlinkSync(target, link);
-
-    assert.throws(() => assertNotSymlink(link), /is a symbolic link/);
-  });
-});
-
-describe('MCP_WRITERS registry', () => {
-  test('covers all 5 supported agents', () => {
-    const ids = Object.keys(MCP_WRITERS).sort();
-    assert.deepStrictEqual(ids, ['claude-code', 'codex', 'gemini-cli', 'github-copilot', 'kilo']);
-  });
-
-  test('each writer is a function', () => {
-    for (const [id, writer] of Object.entries(MCP_WRITERS)) {
-      assert.strictEqual(typeof writer, 'function', `${id} writer should be a function`);
-    }
-  });
-});
-
-describe('MCP writers — JSON agents', () => {
-  let tempHome;
-  let origHome;
-  const fakePkgDir = '/tmp/fake-bi-superpowers';
-
-  beforeEach(() => {
-    tempHome = fs.mkdtempSync(path.join(os.tmpdir(), 'bi-mcp-home-'));
-    origHome = os.homedir;
-    os.homedir = () => tempHome;
-  });
-
-  afterEach(() => {
-    os.homedir = origHome;
-    fs.rmSync(tempHome, { recursive: true, force: true });
-  });
-
-  test('claude-code writer produces mcpServers JSON at ~/.claude.json', () => {
-    const configPath = MCP_WRITERS['claude-code'](fakePkgDir);
-
-    assert.strictEqual(configPath, path.join(tempHome, '.claude.json'));
-    assert.ok(fs.existsSync(configPath));
-
-    const config = JSON.parse(fs.readFileSync(configPath, 'utf8'));
-    assert.ok(config.mcpServers);
-    assert.ok(config.mcpServers[MODELING_SERVER_NAME]);
-    assert.strictEqual(config.mcpServers[MODELING_SERVER_NAME].command, 'node');
-    assert.ok(
-      config.mcpServers[MODELING_SERVER_NAME].args[0].includes('powerbi-modeling-launcher.js')
-    );
-    assert.deepStrictEqual(config.mcpServers[LEARN_SERVER_NAME], {
-      type: 'http',
-      url: MICROSOFT_LEARN_URL,
-    });
-  });
-
-  test('github-copilot writer uses "servers" key (not mcpServers)', () => {
-    const configPath = MCP_WRITERS['github-copilot'](fakePkgDir);
-
-    assert.strictEqual(configPath, path.join(tempHome, '.copilot', 'mcp-config.json'));
-    const config = JSON.parse(fs.readFileSync(configPath, 'utf8'));
-    assert.ok(config.servers);
-    assert.strictEqual(config.mcpServers, undefined);
-    assert.strictEqual(config.servers[MODELING_SERVER_NAME].type, 'stdio');
-    assert.strictEqual(config.servers[LEARN_SERVER_NAME].type, 'http');
-  });
-
-  test('gemini-cli writer uses httpUrl (not url)', () => {
-    const configPath = MCP_WRITERS['gemini-cli'](fakePkgDir);
-
-    assert.strictEqual(configPath, path.join(tempHome, '.gemini', 'settings.json'));
-    const config = JSON.parse(fs.readFileSync(configPath, 'utf8'));
-    assert.ok(config.mcpServers);
-    assert.strictEqual(config.mcpServers[LEARN_SERVER_NAME].httpUrl, MICROSOFT_LEARN_URL);
-    assert.strictEqual(config.mcpServers[LEARN_SERVER_NAME].url, undefined);
-  });
-
-  test('kilo writer uses url (standard)', () => {
-    const configPath = MCP_WRITERS.kilo(fakePkgDir);
-
-    assert.strictEqual(configPath, path.join(tempHome, '.kilo', 'mcp_settings.json'));
-    const config = JSON.parse(fs.readFileSync(configPath, 'utf8'));
-    assert.ok(config.mcpServers);
-    assert.strictEqual(config.mcpServers[LEARN_SERVER_NAME].url, MICROSOFT_LEARN_URL);
-  });
-
-  test('claude-code writer preserves existing config', () => {
-    const configPath = path.join(tempHome, '.claude.json');
-    fs.writeFileSync(
-      configPath,
-      JSON.stringify({
-        otherSetting: 'value',
-        mcpServers: { 'existing-mcp': { command: 'echo' } },
-      })
-    );
-
-    MCP_WRITERS['claude-code'](fakePkgDir);
-
-    const config = JSON.parse(fs.readFileSync(configPath, 'utf8'));
-    assert.strictEqual(config.otherSetting, 'value');
-    assert.ok(config.mcpServers['existing-mcp']);
-    assert.ok(config.mcpServers[MODELING_SERVER_NAME]);
-    assert.ok(config.mcpServers[LEARN_SERVER_NAME]);
-  });
-
-  // Re-install de-duplication for JSON writers — each should replace its
-  // own entries cleanly without duplicating them on repeated runs.
-  for (const agentId of ['claude-code', 'github-copilot', 'gemini-cli', 'kilo']) {
-    test(`${agentId} re-install replaces entries without duplicating`, () => {
-      // First install
-      MCP_WRITERS[agentId](fakePkgDir);
-      // Second install (same args)
-      const configPath = MCP_WRITERS[agentId](fakePkgDir);
-
-      const config = JSON.parse(fs.readFileSync(configPath, 'utf8'));
-      const serversKey = agentId === 'github-copilot' ? 'servers' : 'mcpServers';
-      const servers = config[serversKey];
-
-      // Our 2 servers should each appear exactly once (via object keys)
-      assert.ok(servers[MODELING_SERVER_NAME], 'modeling server missing after re-install');
-      assert.ok(servers[LEARN_SERVER_NAME], 'learn server missing after re-install');
-
-      // And no stray duplicates of our keys
-      const ourKeys = Object.keys(servers).filter(
-        (k) => k === MODELING_SERVER_NAME || k === LEARN_SERVER_NAME
-      );
-      assert.strictEqual(ourKeys.length, 2, `expected 2 of our keys, found ${ourKeys.length}`);
-    });
-  }
-
-  // Cross-agent sanity check: verifies each JSON agent writes the HTTP
-  // URL under the correct key per its spec. Catches copy-paste errors
-  // where someone might accidentally use `url` for Gemini (which expects
-  // `httpUrl`) or vice versa.
-  test('each JSON agent uses the correct HTTP field name', () => {
-    const expectations = {
-      'claude-code': { key: 'url', wrapperKey: 'mcpServers' },
-      'github-copilot': { key: 'url', wrapperKey: 'servers' },
-      'gemini-cli': { key: 'httpUrl', wrapperKey: 'mcpServers' },
-      kilo: { key: 'url', wrapperKey: 'mcpServers' },
-    };
-
-    for (const [agentId, expected] of Object.entries(expectations)) {
-      // Reset home for each agent so configs don't leak between writes.
-      fs.rmSync(tempHome, { recursive: true, force: true });
-      fs.mkdirSync(tempHome, { recursive: true });
-
-      const configPath = MCP_WRITERS[agentId](fakePkgDir);
-      const config = JSON.parse(fs.readFileSync(configPath, 'utf8'));
-      const learnEntry = config[expected.wrapperKey][LEARN_SERVER_NAME];
-
-      assert.strictEqual(
-        learnEntry[expected.key],
-        MICROSOFT_LEARN_URL,
-        `${agentId} should use "${expected.key}" for HTTP URL`
-      );
-
-      // And it should NOT use the wrong key (defensive check)
-      const wrongKey = expected.key === 'url' ? 'httpUrl' : 'url';
-      assert.strictEqual(
-        learnEntry[wrongKey],
-        undefined,
-        `${agentId} should NOT have "${wrongKey}"`
-      );
-    }
-  });
-
-  test('writeJson refuses to overwrite symlinked target', () => {
-    const realFile = path.join(tempHome, 'real-claude.json');
-    const linkFile = path.join(tempHome, '.claude.json');
-    fs.writeFileSync(realFile, '{"mcpServers":{}}');
-    fs.symlinkSync(realFile, linkFile);
-
-    assert.throws(() => MCP_WRITERS['claude-code'](fakePkgDir), /symbolic link/);
-
-    // The real file content must not have been touched.
-    const content = JSON.parse(fs.readFileSync(realFile, 'utf8'));
-    assert.deepStrictEqual(content, { mcpServers: {} });
-  });
-});
-
-describe('codex writer — TOML', () => {
-  let tempHome;
-  let origHome;
-
-  beforeEach(() => {
-    tempHome = fs.mkdtempSync(path.join(os.tmpdir(), 'bi-mcp-codex-'));
-    origHome = os.homedir;
-    os.homedir = () => tempHome;
-  });
-
-  afterEach(() => {
-    os.homedir = origHome;
-    fs.rmSync(tempHome, { recursive: true, force: true });
-  });
-
-  test('writes TOML with [mcp_servers.*] sections', () => {
-    const configPath = MCP_WRITERS.codex('/tmp/fake-pkg');
-
-    assert.strictEqual(configPath, path.join(tempHome, '.codex', 'config.toml'));
-    const content = fs.readFileSync(configPath, 'utf8');
-
-    assert.ok(content.includes('[mcp_servers.powerbi-modeling]'));
-    assert.ok(content.includes('command = "node"'));
-    assert.ok(content.includes('[mcp_servers.microsoft-learn]'));
-    assert.ok(content.includes(`url = "${MICROSOFT_LEARN_URL}"`));
-  });
-
-  test('preserves existing non-MCP TOML content', () => {
-    const configPath = path.join(tempHome, '.codex', 'config.toml');
-    fs.mkdirSync(path.dirname(configPath), { recursive: true });
-    fs.writeFileSync(configPath, '[profile]\nname = "default"\n');
-
-    MCP_WRITERS.codex('/tmp/fake-pkg');
-
-    const content = fs.readFileSync(configPath, 'utf8');
-    assert.ok(content.includes('[profile]'));
-    assert.ok(content.includes('name = "default"'));
-    assert.ok(content.includes('[mcp_servers.powerbi-modeling]'));
-  });
-
-  test('re-running install replaces MCP sections, does not duplicate', () => {
-    MCP_WRITERS.codex('/tmp/fake-pkg');
-    MCP_WRITERS.codex('/tmp/fake-pkg');
-
-    const content = fs.readFileSync(path.join(tempHome, '.codex', 'config.toml'), 'utf8');
-
-    // Each section name should appear exactly once
-    const modelingCount = (content.match(/\[mcp_servers\.powerbi-modeling\]/g) || []).length;
-    const learnCount = (content.match(/\[mcp_servers\.microsoft-learn\]/g) || []).length;
-    assert.strictEqual(modelingCount, 1);
-    assert.strictEqual(learnCount, 1);
-  });
-});

package/bin/lib/microsoft-mcp.test.js

@@ -1,115 +0,0 @@
-/**
- * Tests for official Microsoft MCP config helpers.
- */
-
-const { test, describe } = require('node:test');
-const assert = require('node:assert');
-const path = require('node:path');
-
-const {
-  ABSOLUTE_LAUNCHER_MODE,
-  PLUGIN_ROOT_LAUNCHER_MODE,
-  MICROSOFT_LEARN_URL,
-  createPluginMcpConfig,
-  createMcpConfigForFormat,
-  mergeMcpConfig,
-  resolveModelingLauncherPath,
-} = require('./microsoft-mcp');
-
-describe('resolveModelingLauncherPath', () => {
-  test('uses plugin root placeholder for plugin builds', () => {
-    const launcherPath = resolveModelingLauncherPath({
-      launcherMode: PLUGIN_ROOT_LAUNCHER_MODE,
-    });
-
-    assert.strictEqual(launcherPath, '${CLAUDE_PLUGIN_ROOT}/bin/mcp/powerbi-modeling-launcher.js');
-  });
-
-  test('uses absolute package path for generated project configs', () => {
-    const launcherPath = resolveModelingLauncherPath({
-      packageDir: '/tmp/bi-superpowers',
-      launcherMode: ABSOLUTE_LAUNCHER_MODE,
-    });
-
-    assert.strictEqual(
-      launcherPath,
-      path.join('/tmp/bi-superpowers', 'bin', 'mcp', 'powerbi-modeling-launcher.js')
-    );
-  });
-});
-
-describe('createPluginMcpConfig', () => {
-  test('returns the 2 official Microsoft MCP defaults', () => {
-    const config = createPluginMcpConfig({
-      packageDir: '/tmp/bi-superpowers',
-      launcherMode: ABSOLUTE_LAUNCHER_MODE,
-    });
-
-    // Should have exactly 2 servers
-    assert.strictEqual(Object.keys(config).length, 2);
-
-    // powerbi-modeling-mcp: local stdio launcher
-    assert.strictEqual(config['powerbi-modeling-mcp'].type, 'stdio');
-    assert.strictEqual(config['powerbi-modeling-mcp'].command, 'node');
-    assert.ok(config['powerbi-modeling-mcp'].args[0].endsWith('powerbi-modeling-launcher.js'));
-
-    // microsoft-learn: HTTP MCP
-    assert.deepStrictEqual(config['microsoft-learn'], {
-      type: 'http',
-      url: MICROSOFT_LEARN_URL,
-    });
-  });
-
-  test('does not include the old removed servers', () => {
-    const config = createPluginMcpConfig({
-      packageDir: '/tmp/bi-superpowers',
-      launcherMode: ABSOLUTE_LAUNCHER_MODE,
-    });
-
-    assert.strictEqual(config['powerbi-remote'], undefined);
-    assert.strictEqual(config['fabric-mcp-server'], undefined);
-  });
-});
-
-describe('createMcpConfigForFormat', () => {
-  test('returns flat plugin config for plugin/cursor outputs', () => {
-    const pluginConfig = createMcpConfigForFormat('plugin');
-    const cursorConfig = createMcpConfigForFormat('cursor');
-
-    assert.ok(pluginConfig['powerbi-modeling-mcp']);
-    assert.ok(cursorConfig['microsoft-learn']);
-    assert.strictEqual(pluginConfig['microsoft-learn'].type, 'http');
-  });
-
-  test('returns nested mcpServers config for claude-like outputs', () => {
-    const config = createMcpConfigForFormat('claude');
-
-    assert.ok(config.mcpServers);
-    assert.ok(config.mcpServers['powerbi-modeling-mcp']);
-    assert.ok(config.mcpServers['microsoft-learn']);
-  });
-});
-
-describe('mergeMcpConfig', () => {
-  test('merges plugin configs without dropping existing entries', () => {
-    const merged = mergeMcpConfig(
-      { existing: { type: 'http', url: 'https://example.com' } },
-      { 'microsoft-learn': { type: 'http', url: MICROSOFT_LEARN_URL } },
-      'plugin'
-    );
-
-    assert.ok(merged.existing);
-    assert.ok(merged['microsoft-learn']);
-  });
-
-  test('merges claude configs inside mcpServers', () => {
-    const merged = mergeMcpConfig(
-      { mcpServers: { existing: { type: 'http', url: 'https://example.com' } } },
-      { mcpServers: { 'microsoft-learn': { type: 'http', url: MICROSOFT_LEARN_URL } } },
-      'claude'
-    );
-
-    assert.ok(merged.mcpServers.existing);
-    assert.ok(merged.mcpServers['microsoft-learn']);
-  });
-});

package/bin/utils/errors.js

@@ -1,159 +0,0 @@
-/**
- * Error Handling Utilities
- * ========================
- *
- * Standardized error handling for the CLI.
- * Provides consistent error messages and exit codes.
- *
- * @module utils/errors
- */
-
-/**
- * Custom CLI Error class
- * Extends Error with exit code and optional suggestion
- */
-class CLIError extends Error {
-  /**
-   * Create a CLI error
-   * @param {string} message - Error message
-   * @param {number} code - Exit code (default: 1)
-   * @param {string|null} suggestion - Optional suggestion for fixing the error
-   */
-  constructor(message, code = 1, suggestion = null) {
-    super(message);
-    this.name = 'CLIError';
-    this.code = code;
-    this.suggestion = suggestion;
-  }
-}
-
-/**
- * Error codes for common scenarios
- */
-const ErrorCodes = {
-  GENERAL: 1,
-  INVALID_INPUT: 2,
-  FILE_NOT_FOUND: 3,
-  PERMISSION_DENIED: 4,
-  NETWORK_ERROR: 5,
-  CONFIG_ERROR: 6,
-  GIT_ERROR: 7,
-  VALIDATION_ERROR: 8,
-};
-
-/**
- * Handle an error with consistent formatting
- * @param {Error} error - The error to handle
- * @param {Object} options - Options for handling
- * @param {boolean} options.exit - Whether to exit the process (default: true)
- * @param {boolean} options.verbose - Show stack trace (default: false)
- */
-function handleError(error, options = {}) {
-  const { exit = true, verbose = process.env.DEBUG === 'true' } = options;
-
-  if (error instanceof CLIError) {
-    console.error(`Error: ${error.message}`);
-    if (error.suggestion) {
-      console.error(`\nSuggestion: ${error.suggestion}`);
-    }
-    if (exit) {
-      process.exit(error.code);
-    }
-  } else if (error instanceof Error) {
-    console.error(`Error: ${error.message}`);
-    if (verbose && error.stack) {
-      console.error(`\nStack trace:\n${error.stack}`);
-    }
-    if (exit) {
-      process.exit(ErrorCodes.GENERAL);
-    }
-  } else {
-    console.error(`Error: ${String(error)}`);
-    if (exit) {
-      process.exit(ErrorCodes.GENERAL);
-    }
-  }
-}
-
-/**
- * Wrap an async function with error handling
- * @param {Function} fn - Async function to wrap
- * @param {Object} options - Error handling options
- * @returns {Function} Wrapped function
- */
-function withErrorHandling(fn, options = {}) {
-  return async (...args) => {
-    try {
-      return await fn(...args);
-    } catch (error) {
-      handleError(error, options);
-    }
-  };
-}
-
-/**
- * Log a warning without exiting
- * @param {string} message - Warning message
- * @param {Object} context - Additional context (optional)
- */
-function logWarning(message, context = null) {
-  console.warn(`Warning: ${message}`);
-  if (context && process.env.DEBUG === 'true') {
-    console.warn('Context:', context);
-  }
-}
-
-/**
- * Create a CLIError for common scenarios
- */
-const createError = {
-  fileNotFound: (path) =>
-    new CLIError(
-      `File not found: ${path}`,
-      ErrorCodes.FILE_NOT_FOUND,
-      'Check that the file path is correct.'
-    ),
-
-  invalidInput: (message, suggestion = null) =>
-    new CLIError(message, ErrorCodes.INVALID_INPUT, suggestion),
-
-  configError: (message) =>
-    new CLIError(
-      message,
-      ErrorCodes.CONFIG_ERROR,
-      'Run "bi-superpowers setup" to configure the repository.'
-    ),
-
-  gitError: (message) =>
-    new CLIError(
-      message,
-      ErrorCodes.GIT_ERROR,
-      'Make sure Git is installed and you are in a Git repository.'
-    ),
-
-  networkError: (message) =>
-    new CLIError(
-      message,
-      ErrorCodes.NETWORK_ERROR,
-      'Check your internet connection and try again.'
-    ),
-
-  permissionDenied: (path) =>
-    new CLIError(
-      `Permission denied: ${path}`,
-      ErrorCodes.PERMISSION_DENIED,
-      'Check file permissions.'
-    ),
-
-  validationError: (message, suggestion = null) =>
-    new CLIError(message, ErrorCodes.VALIDATION_ERROR, suggestion),
-};
-
-module.exports = {
-  CLIError,
-  ErrorCodes,
-  handleError,
-  withErrorHandling,
-  logWarning,
-  createError,
-};