@linimin/pi-letscook 0.1.67 → 0.1.68

package/scripts/release-check.sh

@@ -16,17 +16,17 @@ from pathlib import Path
 checks = {
     "README.md": [
         "You can still implement directly in ordinary chat when you do not need workflow state.",
-        "When you explicitly run `/cook`, it first checks for a fresh explicit primary-agent startup-plan preview.",
+        "When you explicitly run `/cook`, it always calls a same-entry primary-agent startup-plan synthesis step from the current task context, then asks you to **Start** or **Cancel** before rewriting canonical workflow state.",
         "After **Start**, the approved startup plan is written into `.agent/startup-plan.json` / `.agent/startup-plan.md`, and `completion-regrounder` uses it to derive canonical slices from current repo truth.",
-        "Explicit `/cook` capsules are still valid startup intake, but they are no longer the only path because `/cook` can synthesize the primary-agent startup plan in the same entry when needed.",
+        "Optional preview capsules in ordinary chat are advisory only. `/cook` does not directly consume them as approval-ready workflow state; it synthesizes a fresh startup plan in the `/cook` entry.",
     ],
     "CHANGELOG.md": [
-        "rewrote `/cook` startup around an approved startup plan that is captured under `.agent/startup-plan.json` / `.agent/startup-plan.md` after Start instead of leaving startup intent only as advisory intake in `state.json`",
-        "kept `/cook` confirm-first while handing the approved startup plan to `completion-regrounder`, which now derives canonical slices from repo truth instead of treating startup intake like an implementation-ready first-slice contract",
+        "simplified `/cook` startup sourcing so workflow proposals now come only from same-entry primary-agent startup-plan synthesis",
+        "stopped `/cook` from directly adopting old preview capsules or falling back to transcript-derived startup proposals",
     ],
     "extensions/completion/prompt-surfaces.ts": [
         '"If the user explicitly runs /cook, the extension should call a primary-agent startup-plan synthesis step from the current task context, show Start/Cancel confirmation in the same /cook entry, and only write the approved plan into .agent after Start."',
-        '"When /cook starts, the approved startup plan should be written into .agent and then handed to completion-regrounder so canonical slices can be derived from repo truth."',
+        '"Do not expect /cook to infer or guess startup intent from recent discussion alone, and do not expect /cook to directly reuse an old preview capsule; /cook should always synthesize the startup plan fresh in the same entry from current task context."',
         '"In ordinary chat, do not load or follow completion-protocol, and do not call completion_role."',
     ],
     "extensions/completion/index.ts": [
@@ -40,6 +40,7 @@ checks = {
     "skills/cook-handoff-boundary/SKILL.md": [
         '- load or follow `completion-protocol` while still in ordinary chat',
         '- call `completion_role` before the user has explicitly entered `/cook`',
+        '- `/cook` should always synthesize the startup plan fresh in the same entry from current task context',
     ],
     "skills/completion-protocol/SKILL.md": [
         'Load this skill only after the user explicitly enters `/cook` and you are operating inside the `completion` workflow as the workflow driver or a completion role.',
@@ -51,6 +52,7 @@ forbidden = {
     "README.md": [
         "asks the primary agent to prepare one in the main chat and leaves canonical state unchanged until you rerun /cook",
         "Explicit `/cook` capsules are the required startup intake for new-workflow, next-round, and replacement entry.",
+        "When you explicitly run `/cook`, it first checks for a fresh explicit primary-agent startup-plan preview.",
     ],
     "extensions/completion/prompt-surfaces.ts": [
         '"If the user explicitly asks to enter /cook workflow, generate one fresh ```cook_handoff``` capsule in ordinary chat from the primary-agent view of the task, then tell the user to run /cook."',

package/scripts/role-runner-contract-test.sh

@@ -30,9 +30,9 @@ assertIncludes('extensions/completion/role-runner.ts', 'const transcription = ex
 assertIncludes('extensions/completion/role-runner.ts', 'env: { ...process.env, PI_COMPLETION_ROLE: params.role },');
 assertIncludes('extensions/completion/role-runner.ts', 'async function runContextProposalAnalystSubprocess(');
 assertIncludes('extensions/completion/role-runner.ts', 'export async function analyzeContextProposalWithAgent(');
-assertIncludes('extensions/completion/index.ts', 'import { analyzeContextProposalWithAgent, runCompletionRole } from "./role-runner";');
+assertIncludes('extensions/completion/index.ts', 'import { runCompletionRole } from "./role-runner";');
 assertIncludes('extensions/completion/index.ts', 'const result = await runCompletionRole({');
-assertIncludes('extensions/completion/index.ts', 'await analyzeContextProposalWithAgent({');
+assertNotIncludes('extensions/completion/index.ts', 'analyzeContextProposalWithAgent');
 assertNotIncludes('extensions/completion/index.ts', 'const systemPromptTemp = await writeTempFile(runCwd, "pi-cook-proposal-analyst-", CONTEXT_PROPOSAL_ANALYST_SYSTEM_PROMPT);');
 assertNotIncludes('extensions/completion/index.ts', 'const invocation = getPiInvocation(args);');
 assertNotIncludes('extensions/completion/index.ts', 'async function loadAgentDefinition(');

package/scripts/smoke-test.sh

@@ -103,13 +103,12 @@ INLINE_REJECTION_ROUTING_SNAPSHOT="$TMPDIR/inline-arg-routing.json"
 INLINE_REJECTION_PROPOSAL_SNAPSHOT="$TMPDIR/inline-arg-proposal.json"
 INLINE_REJECTION_CHOOSER_SNAPSHOT="$TMPDIR/inline-arg-chooser.json"
 BOOTSTRAP_SESSION="$TMPDIR/session-smoke-bootstrap.jsonl"
-BOOTSTRAP_MESSAGES="$(python3 - <<'PY'
+BOOTSTRAP_DISCUSSION=$'Please prepare the packaged smoke-test bootstrap path and tell me when it is ready for /cook.'
+GENERATED_HANDOFF="$(python3 - <<'PY'
 import json
 capsule = {
     "kind": "cook_handoff",
     "source": "primary_agent",
-    "captured_at": "2026-01-01T00:00:02.000Z",
-    "source_turn_id": "m0002",
     "mission": "Exercise smoke-test bootstrap.",
     "scope": [
         "Materialize the canonical completion control-plane files.",
@@ -123,7 +122,7 @@ capsule = {
         "Keep scripts/smoke-test.sh and kickoff-prompt coverage truthful for packaged bootstrap."
     ],
     "risks": [
-        "Smoke-test bootstrap should stay anchored to the fresh explicit startup-plan preview."
+        "Smoke-test bootstrap should stay anchored to same-entry primary-agent startup-plan synthesis."
     ],
     "notes": [
         "Keep the smoke fixture aligned with the shipped startup-plan-driven startup contract."
@@ -145,11 +144,7 @@ capsule = {
     "evaluation_profile": "completion-rubric-v1",
     "why_cook_now": "The startup plan is concrete enough to bootstrap canonical workflow files."
 }
-messages = [
-    {"role": "user", "content": "Please prepare the packaged smoke-test bootstrap path and tell me when it is ready for /cook."},
-    {"role": "assistant", "content": "This bootstrap path is ready for /cook. Run /cook to confirm the startup plan.\n\n```cook_handoff\n" + json.dumps(capsule, ensure_ascii=False, indent=2) + "\n```"},
-]
-print(json.dumps(messages, ensure_ascii=False))
+print("```cook_handoff\n" + json.dumps(capsule, ensure_ascii=False, indent=2) + "\n```")
 PY
 )"
 
@@ -180,10 +175,10 @@ assert not chooser.exists(), 'startup /cook inline-args rejection should not ope
 assert '/cook no longer accepts inline arguments.' in output, 'startup /cook inline-args rejection should explain the bare-only entry contract'
 PY
 
-write_session_messages "$BOOTSTRAP_SESSION" "$ROOT" "$BOOTSTRAP_MESSAGES"
+write_session "$BOOTSTRAP_SESSION" "$ROOT" "$BOOTSTRAP_DISCUSSION"
 
 PI_COMPLETION_CONTEXT_PROPOSAL_ACTION=accept \
-PI_COMPLETION_DISABLE_CONTEXT_PROPOSAL_ANALYST=1 \
+PI_COMPLETION_PRIMARY_HANDOFF_OUTPUT="$GENERATED_HANDOFF" \
 PI_COMPLETION_SKIP_DRIVER_KICKOFF=1 \
 PI_COMPLETION_TEST_DRIVER_PROMPT_PATH="$KICKOFF_PROMPT" \
 pi --session "$BOOTSTRAP_SESSION" -e "$PKG_ROOT" -p "/cook" \
@@ -226,13 +221,13 @@ assert active['implementation_surfaces'] == [], 'active-slice.json should scaffo
 assert active['verification_commands'] == [], 'active-slice.json should scaffold empty verification_commands'
 brief = state['advisory_startup_brief']
 assert brief['kind'] == 'startup_brief', 'state.json should preserve the confirmed startup brief as advisory intake'
-assert brief['source'] == 'primary_agent_handoff', 'smoke bootstrap should record the explicit handoff source in advisory intake'
+assert brief['source'] == 'deferred_primary_agent_handoff', 'smoke bootstrap should record same-entry primary-agent synthesis in advisory intake'
 assert brief['mission'] == state['mission_anchor'], 'advisory startup brief mission should match the canonical mission anchor after bootstrap'
 assert brief['scope'] == ['Materialize the canonical completion control-plane files.', 'Keep the smoke test on supported /cook startup behavior.'], 'advisory startup brief should preserve scope items'
 assert brief['constraints'] == ['Keep startup proposal confirmation approval-only.'], 'advisory startup brief should preserve constraints'
 assert startup_plan['artifact_type'] == 'completion-startup-plan', 'startup-plan.json should persist the approved startup plan canonically'
 assert startup_plan['mission_anchor'] == state['mission_anchor'], 'startup-plan.json mission anchor should match canonical workflow state'
-assert startup_plan['source'] == 'primary_agent_handoff', 'startup-plan.json should preserve the primary-agent startup source'
+assert startup_plan['source'] == 'deferred_primary_agent_handoff', 'startup-plan.json should preserve the same-entry primary-agent startup source'
 assert startup_plan['scope'] == brief['scope'], 'startup-plan.json should preserve approved scope items'
 assert startup_plan['constraints'] == brief['constraints'], 'startup-plan.json should preserve approved constraints'
 assert startup_plan['planned_surfaces'] == ['.agent/README.md', 'scripts/smoke-test.sh'], 'startup-plan.json should preserve planned surfaces derived from startup hints'
@@ -243,7 +238,7 @@ assert brief['acceptance'] == [
     'Scaffold .agent/profile.json, .agent/state.json, .agent/plan.json, .agent/active-slice.json, and .agent/verification-evidence.json for the smoke fixture.',
     'Keep scripts/smoke-test.sh and kickoff-prompt coverage truthful for packaged bootstrap.'
 ], 'advisory startup brief should preserve acceptance'
-assert brief['risks'] == ['Smoke-test bootstrap should stay anchored to the fresh explicit startup-plan preview.'], 'advisory startup brief should preserve startup-plan risks'
+assert brief['risks'] == ['Smoke-test bootstrap should stay anchored to same-entry primary-agent startup-plan synthesis.'], 'advisory startup brief should preserve startup-plan risks'
 assert 'First slice goal: Scaffold canonical completion files and verify the packaged startup contract.' in brief['notes'], 'advisory startup brief should preserve the first_slice_goal in notes'
 assert 'Verification commands: npm run smoke-test' in brief['notes'], 'advisory startup brief should preserve verification_commands in notes'
 assert evidence['artifact_type'] == 'completion-verification-evidence', 'verification-evidence.json artifact_type mismatch after bootstrap'
@@ -314,10 +309,10 @@ assert f'- task_type: {expected_task_type}' in resume, 'resume prompt missing ca
 assert f'- evaluation_profile: {expected_eval_profile}' in resume, 'resume prompt missing canonical evaluation_profile'
 assert routing['mode'] == 'bare', 'active bare /cook should snapshot bare routing mode'
 assert routing['action'] == 'continue', 'no-discussion active bare /cook should resume from canonical state without a concrete replacement mission'
-assert routing['reason'] == 'missing_explicit_handoff', 'no-discussion active bare /cook should explain that resume happened because no fresh explicit handoff existed'
+assert routing['reason'] == 'no_generated_startup_plan', 'no-discussion active bare /cook should explain that resume happened because no synthesized replacement startup plan existed'
 assert routing['currentMissionAnchor'] == state['mission_anchor'], 'resume routing snapshot should keep the current mission anchor'
 assert routing['proposedMissionAnchor'] is None, 'no-discussion active bare /cook should not propose a replacement mission'
-assert not chooser_path.exists(), 'active bare /cook resume should not open the chooser without a fresh explicit handoff'
+assert not chooser_path.exists(), 'active bare /cook resume should not open the chooser without a synthesized replacement startup plan'
 PY
 
 PI_COMPLETION_SKIP_DRIVER_KICKOFF=1 \

package/skills/cook-handoff-boundary/SKILL.md

@@ -58,15 +58,15 @@ But even in those cases:
 
 If the user explicitly runs or clearly chooses `/cook` workflow mode, the system behavior should be:
 
-1. check for a fresh explicit primary-agent `cook_handoff` preview when one already exists
-2. if none exists, call a primary-agent startup-plan synthesis step immediately from the current task context
-3. use that startup plan to show Start / Cancel confirmation in the same `/cook` entry
-4. after Start, write the approved startup plan into `.agent/startup-plan.json` / `.agent/startup-plan.md`, then let `completion-regrounder` derive canonical slices from repo truth
+1. call a primary-agent startup-plan synthesis step immediately from the current task context
+2. use that synthesized startup plan to show Start / Cancel confirmation in the same `/cook` entry
+3. after Start, write the approved startup plan into `.agent/startup-plan.json` / `.agent/startup-plan.md`, then let `completion-regrounder` derive canonical slices from repo truth
 
 That means:
 
 - `/cook` must not infer or guess canonical slices from recent discussion alone
-- `/cook` should use primary-agent-authored startup-plan data
+- `/cook` should always synthesize the startup plan fresh in the same entry from current task context
+- `/cook` should not directly reuse an old preview capsule as canonical or approval-ready workflow state
 - `/cook` should not require a manual rerun just to consume a startup plan it can synthesize immediately from the primary-agent view
 
 ## Optional Preview Behavior
@@ -106,7 +106,7 @@ Notes:
 
 - `constraints` may be replaced or supplemented by `non_goals` when clearer.
 - `first_slice_goal`, `first_slice_non_goals`, `implementation_surfaces`, `verification_commands`, and `why_this_slice_first` are optional sequencing hints. They help `completion-regrounder` split slices later when they are already obvious, but the approved startup plan may still be startable without them.
-- Any capsule is startup intake for `/cook` only. It is not canonical `.agent/**` state, not active-slice state, and not a second repo contract source.
+- Any capsule is advisory preview only. It is not canonical `.agent/**` state, not active-slice state, not a second repo contract source, and not something `/cook` should directly reuse without same-entry primary-agent synthesis.
 
 Suggested wording:
 
@@ -127,6 +127,7 @@ When the user does explicitly choose `/cook`, the system must not:
 
 - let `/cook` invent canonical slices from recent discussion alone
 - let `/cook` replace missing startup-plan data with generic transcript guessing
+- let `/cook` directly consume an old preview capsule instead of rerunning same-entry primary-agent startup-plan synthesis
 - require a second `/cook` invocation when same-entry primary-agent startup-plan synthesis is possible
 
 ## Relationship To `completion-protocol`