@krotovm/gitlab-ai-review 1.0.29 → 1.0.31

package/dist/cli/ci-review.js

@@ -1,6 +1,6 @@
 /** @format */
 import OpenAI from "openai";
-import { buildAnswer, buildConsolidatePrompt, buildFileReviewPrompt, buildPrompt, buildTriagePrompt, buildVerificationPrompt, extractCompletionText, parseTriageResponse, } from "../prompt/index.js";
+import { buildAnswer, buildConsolidatePrompt, buildFileReviewPrompt, buildPrompt, buildTriagePrompt, buildVerificationPrompt, extractCompletionText, parseTriageResponseDetailed, parseTriageResponse, } from "../prompt/index.js";
 import { fetchFileAtRef, searchRepository, } from "../gitlab/services.js";
 import { logToolUsageMinimal, MAX_FILE_TOOL_ROUNDS, MAX_TOOL_ROUNDS, MAX_VERIFICATION_TOOL_ROUNDS, TOOL_NAME_GET_FILE, TOOL_NAME_GREP, } from "./tooling.js";
 async function appendDebugDump(_debugDumpFile, debugRecordWriter, record) {
@@ -164,6 +164,7 @@ async function mapWithConcurrency(items, concurrency, fn) {
 export async function reviewMergeRequestWithTools(params) {
     const { openaiInstance, aiModel, promptLimits, changes, refs, gitLabProjectApiUrl, projectId, headers, forceTools, loggers, debugDumpFile, debugRecordWriter, } = params;
     const { logDebug, logStep } = loggers;
+    logStep(`Single-pass review started for ${changes.length} file(s) (fallback mode).`);
     const messages = buildPrompt({
         changes: changes.map((change) => ({ diff: change.diff })),
         limits: promptLimits,
@@ -217,6 +218,7 @@ export async function reviewMergeRequestWithTools(params) {
         },
     ];
     for (let round = 0; round < MAX_TOOL_ROUNDS; round += 1) {
+        logStep(`Single-pass round ${round + 1}/${MAX_TOOL_ROUNDS}: requesting model response...`);
         const completion = await createCompletionWithDebug({
             openaiInstance,
             requestLabel: `main_review_round_${round + 1}`,
@@ -236,6 +238,7 @@ export async function reviewMergeRequestWithTools(params) {
             return buildAnswer(completion);
         const toolCalls = message.tool_calls ?? [];
         logDebug(`main-review round=${round + 1} tool_calls=${toolCalls.length} finish_reason=${completion.choices[0]?.finish_reason ?? "unknown"}`);
+        logStep(`Single-pass round ${round + 1}: model returned ${toolCalls.length} tool call(s).`);
         if (toolCalls.length === 0)
             return buildAnswer(completion);
         messages.push({
@@ -290,6 +293,7 @@ export async function reviewMergeRequestWithTools(params) {
         role: "user",
         content: `Tool-call limit reached (${MAX_TOOL_ROUNDS}). Do not call any tools. Provide your best-effort final review now, strictly following the required output format. If confidence is low, return the exact no-issues sentence.`,
     });
+    logStep("Single-pass tool-call limit reached. Requesting final answer.");
     const finalCompletion = await createCompletionWithDebug({
         openaiInstance,
         requestLabel: "main_review_final_after_tool_limit",
@@ -598,6 +602,9 @@ export async function reviewMergeRequestMultiPass(params) {
     }));
     const triageMessages = buildTriagePrompt(triageInputs);
     let triageResult = null;
+    let triageText = null;
+    let triageParseReason = null;
+    let triageParseError = null;
     try {
         const triageCompletion = await createCompletionWithDebug({
             openaiInstance,
@@ -612,15 +619,31 @@ export async function reviewMergeRequestMultiPass(params) {
                 response_format: { type: "json_object" },
             },
         });
-        const triageText = extractCompletionText(triageCompletion);
-        if (triageText != null)
-            triageResult = parseTriageResponse(triageText);
+        triageText = extractCompletionText(triageCompletion);
+        if (triageText != null) {
+            const triageParse = parseTriageResponseDetailed(triageText);
+            triageResult = triageParse.result;
+            triageParseReason = triageParse.reason;
+            triageParseError = triageParse.parseError;
+        }
     }
     catch (error) {
         logStep(`Triage pass failed: ${error?.message ?? error}. Falling back to single-pass.`);
     }
     if (triageResult == null) {
-        logStep("Triage parse failed. Falling back to single-pass pipeline.");
+        if (triageText != null) {
+            const triagePreview = triageText.replace(/\s+/g, " ").trim().slice(0, 200);
+            const looksLikeHtml = /<html|<!doctype html/i.test(triageText);
+            const parseReasonText = triageParseReason != null
+                ? `reason=${triageParseReason}`
+                : `reason=${looksLikeHtml ? "html_response" : "unknown_non_json"}`;
+            const parseErrorText = triageParseError != null ? ` parse_error=${triageParseError}` : "";
+            logStep(`Triage parse failed: ${parseReasonText}.${parseErrorText} Preview: ${triagePreview || "<empty>"}`);
+        }
+        else {
+            logStep("Triage parse failed: model returned empty response body.");
+        }
+        logStep("Falling back to single-pass pipeline.");
         return await reviewMergeRequestWithTools({
             openaiInstance,
             aiModel,

package/dist/prompt/index.js

@@ -58,29 +58,48 @@ export function buildTriagePrompt(changes) {
     ];
 }
 export function parseTriageResponse(text) {
+    return parseTriageResponseDetailed(text).result;
+}
+export function parseTriageResponseDetailed(text) {
+    const cleaned = text
+        .replace(/```json?\s*/g, "")
+        .replace(/```\s*/g, "")
+        .trim();
+    if (cleaned === "") {
+        return { result: null, reason: "empty_response", parseError: null };
+    }
     try {
-        const cleaned = text
-            .replace(/```json?\s*/g, "")
-            .replace(/```\s*/g, "")
-            .trim();
         const parsed = JSON.parse(cleaned);
         if (typeof parsed.summary === "string" && Array.isArray(parsed.files)) {
             return {
-                summary: parsed.summary,
-                files: parsed.files
-                    .filter((f) => typeof f.path === "string" &&
-                    (f.verdict === "NEEDS_REVIEW" || f.verdict === "SKIP"))
-                    .map((f) => ({
-                    path: f.path,
-                    verdict: f.verdict,
-                })),
+                result: {
+                    summary: parsed.summary,
+                    files: parsed.files
+                        .filter((f) => typeof f.path === "string" &&
+                        (f.verdict === "NEEDS_REVIEW" || f.verdict === "SKIP"))
+                        .map((f) => ({
+                        path: f.path,
+                        verdict: f.verdict,
+                    })),
+                },
+                reason: null,
+                parseError: null,
             };
         }
+        return { result: null, reason: "invalid_schema", parseError: null };
     }
-    catch {
+    catch (error) {
         // JSON parse failure — caller will fall back to single-pass.
+        return {
+            result: null,
+            reason: "invalid_json",
+            parseError: error instanceof Error
+                ? error.message
+                : typeof error === "string"
+                    ? error
+                    : JSON.stringify(error),
+        };
     }
-    return null;
 }
 export function buildFileReviewPrompt(params) {
     const { filePath, fileDiff, summary, otherChangedFiles, allowTools = false, } = params;
@@ -126,7 +145,7 @@ export function buildConsolidatePrompt(params) {
     ];
 }
 export function buildVerificationPrompt(params) {
-    const { perFileFindings, summary, consolidatedFindings, maxFindings, refs, } = params;
+    const { perFileFindings, summary, consolidatedFindings, maxFindings, refs } = params;
     const findingsText = perFileFindings
         .map((f) => `### ${f.path}\n${f.findings}`)
         .join("\n\n");

package/package.json

@@ -1,7 +1,7 @@
 {
   "type": "module",
   "name": "@krotovm/gitlab-ai-review",
-  "version": "1.0.29",
+  "version": "1.0.31",
   "description": "CLI tool to generate AI code reviews for GitLab merge requests.",
   "main": "dist/cli.js",
   "bin": {