@kineticdata/react 5.0.16 → 5.1.0

package/lib/apis/core/webhooks.js

@@ -3,11 +3,10 @@ import { bundle } from '../../helpers';
 import { handleErrors, headerBuilder, paramBuilder } from '../http';
 
 var validateOptions = function validateOptions(functionName, requiredOptions, options) {
-  var typesRequiringKapp = ['Kapp', 'Form', 'Submission'];
   var kappSlug = options.kappSlug,
       _options$webhook = options.webhook,
       webhook = _options$webhook === void 0 ? {} : _options$webhook;
-  var kappSlugMissing = typesRequiringKapp.includes(webhook.type) && !kappSlug;
+  var kappSlugMissing = webhook.type === 'Kapp' && !kappSlug;
   var missing = requiredOptions.filter(function (requiredOption) {
     return !options[requiredOption];
   });

package/lib/apis/discussions/index.js

@@ -170,6 +170,7 @@ export var fetchDiscussions = function fetchDiscussions(_ref4) {
       _ref4$relatedItem = _ref4.relatedItem,
       relatedItem = _ref4$relatedItem === void 0 ? {} : _ref4$relatedItem,
       isArchived = _ref4.isArchived,
+      limit = _ref4.limit,
       start = _ref4.start,
       end = _ref4.end;
   var type = relatedItem.type,
@@ -177,7 +178,7 @@ export var fetchDiscussions = function fetchDiscussions(_ref4) {
   return axios.get("".concat(baseUrl(), "/api/v1/discussions"), {
     params: {
       title: title && title.length > 0 ? title : null,
-      limit: DEFAULT_DISCUSSION_LIMIT,
+      limit: limit || DEFAULT_DISCUSSION_LIMIT,
       type: type,
       key: key,
       pageToken: pageToken,

package/lib/apis/http.js

@@ -24,7 +24,8 @@ export var handleErrors = function handleErrors(error) {
       _error$response$data = _error$response.data,
       data = _error$response$data === void 0 ? {} : _error$response$data,
       statusCode = _error$response.status,
-      statusText = _error$response.statusText;
+      statusText = _error$response.statusText,
+      headers = _error$response.headers;
   var type = types[statusCode];
 
   var errorMessage = data.error,
@@ -33,7 +34,13 @@ export var handleErrors = function handleErrors(error) {
       message = data.message,
       rest = _objectWithoutProperties(data, ["error", "errorKey", "message"]);
 
-  var result = typeof data === 'string' ? {
+  var result = headers && !headers['content-type'].startsWith('application/json') ? {
+    message: 'An unexpected error occurred.',
+    statusCode: statusCode
+  } : statusCode === 503 ? {
+    statusCode: statusCode,
+    message: 'The platform component you are using is not available. Please contact your administrator.'
+  } : typeof data === 'string' ? {
     message: data,
     statusCode: statusCode,
     key: key
@@ -54,7 +61,7 @@ export var handleErrors = function handleErrors(error) {
 export var paramBuilder = function paramBuilder(options) {
   var params = {};
   if (options.include) params.include = options.include;
-  if (options.limit) params.limit = options.limit;
+  if (options.limit >= 0) params.limit = options.limit;
   if (options.pageToken) params.pageToken = options.pageToken;
   if (options.q) params.q = options.q;
   if (options.direction) params.direction = options.direction;
@@ -93,9 +100,10 @@ export var apiFunction = function apiFunction(_ref) {
   return function () {
     var options = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : {};
     validateOptions(name, dataOption ? [].concat(_toConsumableArray(requiredOptions), [dataOption]) : requiredOptions, options);
+    var urlPostfix = url(options);
     return axios({
       method: method,
-      url: bundle.apiLocation() + url(options),
+      url: urlPostfix.startsWith('/app') ? urlPostfix : bundle.apiLocation() + urlPostfix,
       data: dataOption && options[dataOption],
       params: paramBuilder(options),
       headers: headerBuilder(options)
@@ -132,9 +140,8 @@ export var apiGroup = function apiGroup(_ref2) {
 };
 export var formPath = function formPath(_ref4) {
   var form = _ref4.form,
-      kapp = _ref4.kapp,
-      datastore = _ref4.datastore;
-  return datastore ? form ? "".concat(bundle.spaceLocation(), "/app/datastore/forms/").concat(form) : "".concat(bundle.spaceLocation(), "/app/datastore/forms") : form ? "".concat(bundle.spaceLocation(), "/").concat(kapp || bundle.kappSlug(), "/").concat(form) : "".concat(bundle.spaceLocation(), "/").concat(kapp || bundle.kappSlug());
+      kapp = _ref4.kapp;
+  return !kapp ? form ? "".concat(bundle.spaceLocation(), "/app/forms/").concat(form) : "".concat(bundle.spaceLocation(), "/app/forms") : form ? "".concat(bundle.spaceLocation(), "/").concat(kapp || bundle.kappSlug(), "/").concat(form) : "".concat(bundle.spaceLocation(), "/").concat(kapp || bundle.kappSlug());
 };
 export var submissionPath = function submissionPath(_ref5) {
   var submission = _ref5.submission,
@@ -145,15 +152,13 @@ export var corePath = function corePath(_ref6) {
   var submission = _ref6.submission,
       kapp = _ref6.kapp,
       form = _ref6.form,
-      _ref6$datastore = _ref6.datastore,
-      datastore = _ref6$datastore === void 0 ? false : _ref6$datastore;
+      datastore = _ref6.datastore;
   return submission ? submissionPath({
-    submission: submission,
-    datastore: datastore
+    datastore: datastore,
+    submission: submission
   }) : formPath({
     form: form,
-    kapp: kapp,
-    datastore: datastore
+    kapp: kapp
   });
 };
 export var operations = Map({
@@ -234,4 +239,14 @@ export var generateCESearchParams = function generateCESearchParams(_ref9) {
     limit: pageSize,
     pageToken: nextPageToken
   }, searchFilters(filters)), sortParams(sortColumn, sortDirection));
+};
+export var transformCoreResult = function transformCoreResult(envelope) {
+  return function (result, paramData) {
+    var count = paramData.nextPageToken ? result.count + paramData.pageTokens.size * paramData.pageSize : result.count;
+    return {
+      data: result[envelope],
+      nextPageToken: result.nextPageToken,
+      count: count
+    };
+  };
 };

package/lib/apis/http.test.js

@@ -1,4 +1,5 @@
 import _defineProperty from "@babel/runtime/helpers/esm/defineProperty";
+import _slicedToArray from "@babel/runtime/helpers/esm/slicedToArray";
 import { headerBuilder, corePath, handleErrors, paramBuilder, operations } from './http';
 import { List } from 'immutable';
 jest.mock('../helpers', function () {
@@ -62,11 +63,6 @@ describe('http module', function () {
   });
   describe('corePath', function () {
     describe('kapp forms and submissions', function () {
-      test('builds url with default kapp', function () {
-        expect(corePath({
-          form: 'ipad-request'
-        })).toBe('/kinetic/acme/catalog/ipad-request');
-      });
       test('builds url with specified kapp', function () {
         expect(corePath({
           form: 'ipad-request',
@@ -79,18 +75,16 @@ describe('http module', function () {
         })).toBe('/kinetic/acme/submissions/abc123');
       });
     });
-    describe('datastore forms and submissions', function () {
+    describe('space forms and submissions', function () {
       test('builds url to form', function () {
         expect(corePath({
-          form: 'cars',
-          datastore: true
-        })).toBe('/kinetic/acme/app/datastore/forms/cars');
+          form: 'cars'
+        })).toBe('/kinetic/acme/app/forms/cars');
       });
       test('builds url with the submission id', function () {
         expect(corePath({
-          submission: 'abc123',
-          datastore: true
-        })).toBe('/kinetic/acme/app/datastore/submissions/abc123');
+          submission: 'abc123'
+        })).toBe('/kinetic/acme/submissions/abc123');
       });
     });
   });
@@ -109,9 +103,13 @@ describe('http module', function () {
 
   describe('#paramBuilder', function () {
     test('returns parameter values', function () {
-      var params = ['include', 'limit', 'pageToken', 'q', 'direction', 'orderBy', 'manage', 'export'];
-      params.forEach(function (param) {
-        return expect(paramBuilder(_defineProperty({}, param, param))).toMatchObject(_defineProperty({}, param, param));
+      var params = [['include', 'include'], ['limit', 1], ['pageToken', 'pageToken'], ['q', 'q'], ['direction', 'direction'], ['orderBy', 'orderBy'], ['manage', 'manage'], ['export', 'export']];
+      params.forEach(function (_ref) {
+        var _ref2 = _slicedToArray(_ref, 2),
+            param = _ref2[0],
+            value = _ref2[1];
+
+        return expect(paramBuilder(_defineProperty({}, param, value))).toMatchObject(_defineProperty({}, param, value));
       });
     });
     test('does not return non-parameter values', function () {

package/lib/apis/index.js

@@ -11,6 +11,8 @@ export * from './core/bridgeModelMappings';
 export * from './core/bridgeModelQualifications';
 export * from './core/bridgeModelQualificationMappings';
 export * from './core/categories';
+export * from './core/fileResources';
+export * from './core/filestores';
 export * from './core/forms';
 export * from './core/formTypes';
 export * from './core/kapps';

package/lib/apis/system/index.js

@@ -269,7 +269,7 @@ export var updateSystemFilestore = function updateSystemFilestore() {
     };
   })["catch"](handleErrors);
 };
-var VALID_RESTARTABLE_COMPONENTS = ['agent', 'core', 'discussions', 'loghub', 'topics'];
+var VALID_RESTARTABLE_COMPONENTS = ['agent', 'core', 'discussions', 'loghub', 'topics', 'indexer'];
 export var postPlatformComponentRestart = function postPlatformComponentRestart() {
   var options = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : {};
 
@@ -336,6 +336,34 @@ export var fetchElasticSearchConfig = function fetchElasticSearchConfig() {
     };
   })["catch"](handleErrors);
 };
+export var fetchSystemSecurity = function fetchSystemSecurity() {
+  var options = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : {};
+  return axios.get('/app/system-coordinator/api/v1/platform/system-security', {}, {
+    params: paramBuilder(options),
+    headers: headerBuilder(options)
+  }).then(function (response) {
+    return {
+      systemSecurity: response.data
+    };
+  })["catch"](handleErrors);
+};
+export var updateSystemSecurity = function updateSystemSecurity() {
+  var options = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : {};
+  var systemSecurity = options.systemSecurity;
+
+  if (!systemSecurity) {
+    throw new Error('updateSystemSecurity failed! The option "systemSecurity" is required.');
+  }
+
+  return axios.put("/app/system-coordinator/api/v1/platform/system-security", systemSecurity, {
+    params: paramBuilder(options),
+    headers: headerBuilder(options)
+  }).then(function (response) {
+    return {
+      systemSecurity: response.data
+    };
+  })["catch"](handleErrors);
+};
 export var fetchSystemLicense = function fetchSystemLicense() {
   var options = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : {};
   return axios.get('/app/system-coordinator/components/core/app/api/v1/license', {
@@ -406,4 +434,61 @@ export var fetchSystemLicenseCheck = function fetchSystemLicenseCheck() {
       system: response.data
     };
   })["catch"](handleErrors);
+};
+export var fetchSystemBackgroundTasks = function fetchSystemBackgroundTasks() {
+  var options = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : {};
+  return axios.get('/app/system-coordinator/api/v1/backgroundTasks', {
+    params: paramBuilder(options),
+    headers: headerBuilder(options)
+  }).then(function (response) {
+    return {
+      backgroundTasks: response.data.backgroundTasks
+    };
+  })["catch"](handleErrors);
+};
+export var fetchSystemBackgroundTask = function fetchSystemBackgroundTask() {
+  var options = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : {};
+  var id = options.id;
+
+  if (!id) {
+    throw new Error('fetchSystemBackgroundTask failed! The option "id" is required.');
+  }
+
+  return axios.get("/app/system-coordinator/api/v1/backgroundTasks/".concat(id), {
+    params: paramBuilder(options),
+    headers: headerBuilder(options)
+  }).then(function (response) {
+    return {
+      backgroundTask: response.data.backgroundTask
+    };
+  })["catch"](handleErrors);
+};
+export var deleteSystemBackgroundTask = function deleteSystemBackgroundTask() {
+  var options = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : {};
+  var id = options.id;
+
+  if (!id) {
+    throw new Error('deleteSystemBackgroundTask failed! The option "id" is required.');
+  }
+
+  return axios["delete"]("/app/system-coordinator/api/v1/backgroundTasks/".concat(id), {
+    params: paramBuilder(options),
+    headers: headerBuilder(options)
+  }).then(function (response) {
+    return {
+      backgroundTask: response.data.backgroundTask
+    };
+  })["catch"](handleErrors);
+};
+export var rotateEncryptionKey = function rotateEncryptionKey() {
+  var options = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : {};
+  var spaceSlug = options.spaceSlug;
+  return axios.post(spaceSlug ? "/app/system-coordinator/api/v1/tenants/".concat(spaceSlug, "/rotateEncryptionKey") : '/app/system-coordinator/api/v1/platform/rotateEncryptionKey', {}, {
+    params: paramBuilder(options),
+    headers: headerBuilder(options)
+  }).then(function (response) {
+    return {
+      system: response.data
+    };
+  })["catch"](handleErrors);
 };

package/lib/apis/task/index.js

@@ -1,5 +1,5 @@
-import _defineProperty from "@babel/runtime/helpers/esm/defineProperty";
 import axios from 'axios';
+import { get } from 'immutable';
 import { handleErrors, validateOptions } from '../http';
 import { bundle } from '../../helpers';
 export var buildTreeId = function buildTreeId(options) {
@@ -7,7 +7,12 @@ export var buildTreeId = function buildTreeId(options) {
 };
 
 var generateNextPageToken = function generateNextPageToken(data) {
-  return data.offset >= 0 && data.limit && data.count ? data.offset + data.limit > data.count ? null : data.limit + data.offset : null;
+  var offset = data.offset,
+      limit = data.limit,
+      count = data.count,
+      more = data.more;
+  var nextPageToken = data.limit + data.offset;
+  return typeof more !== 'undefined' && more ? nextPageToken : offset >= 0 && limit && count ? offset + limit > count ? null : limit + offset : null;
 };
 
 export var fetchTrees = function fetchTrees() {
@@ -114,7 +119,7 @@ export var importTree = function importTree() {
   var content = options.content,
       contentUrl = options.contentUrl,
       force = options.force;
-  var data = {};
+  var data;
   var headers = {};
 
   if (contentUrl) {
@@ -452,7 +457,7 @@ export var createHandler = function createHandler() {
   var packageUrl = options.packageUrl,
       packageFile = options.packageFile,
       force = options.force;
-  var data = {};
+  var data;
   var headers = {};
 
   if (packageUrl) {
@@ -620,9 +625,11 @@ export var fetchTaskRuns = function fetchTaskRuns() {
       status: options.status || undefined,
       orderBy: options.orderBy,
       direction: options.direction,
-      count: options.count || undefined,
+      count: get(options, 'count'),
       start: options.start || undefined,
-      end: options.end || undefined
+      end: options.end || undefined,
+      afterId: options.afterId || undefined,
+      beforeId: options.beforeId || undefined
     }
   }).then(function (response) {
     return {
@@ -700,7 +707,8 @@ export var fetchTaskTriggers = function fetchTaskTriggers() {
   }).then(function (response) {
     return {
       triggers: response.data.triggers,
-      nextPageToken: generateNextPageToken(response.data)
+      nextPageToken: generateNextPageToken(response.data),
+      count: response.data.count
     };
   })["catch"](handleErrors);
 };
@@ -765,16 +773,17 @@ export var fetchTaskRunError = function fetchTaskRunError() {
 };
 export var updateRunTaskResults = function updateRunTaskResults() {
   var options = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : {};
-  validateOptions('updateRunTaskResults', ['runId', 'taskId', 'results'], options);
-  var resultKey = options.type || 'results';
-  return axios.put("".concat(bundle.spaceLocation(), "/app/components/task/app/api/v2/runs/").concat(options.runId, "/tasks/").concat(options.taskId), _defineProperty({}, resultKey, options.results), {
+  validateOptions('updateRunTaskResults', ['runId', 'taskId'], options);
+  return axios.put("".concat(bundle.spaceLocation(), "/app/components/task/app/api/v2/runs/").concat(options.runId, "/tasks/").concat(options.taskId), {
+    deferredResults: options.deferredResults,
+    results: options.results,
+    message: options.message
+  }, {
     params: {
       include: options.include
     }
   }).then(function (response) {
-    return {
-      message: response.data
-    };
+    return response.data;
   })["catch"](handleErrors);
 };
 export var resolveTaskErrors = function resolveTaskErrors() {
@@ -794,7 +803,6 @@ export var resolveTaskErrors = function resolveTaskErrors() {
   })["catch"](handleErrors);
 };
 export var fetchTaskVersion = function fetchTaskVersion() {
-  var options = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : {};
   return axios.get("".concat(bundle.spaceLocation(), "/app/components/task/app/api/v2/version")).then(function (response) {
     return {
       version: response.data

package/lib/components/agent/filestore/FilestoreForm.js

@@ -0,0 +1,132 @@
+import _toConsumableArray from "@babel/runtime/helpers/esm/toConsumableArray";
+import { createFilestore, fetchFilestore, updateFilestore } from '../../../apis';
+import { fetchAdapters } from '../../../apis';
+import { get, getIn, List, Map } from 'immutable';
+import { buildPropertyFields, handleFormErrors } from '../../form/Form.helpers';
+import { generateForm } from '../../form/Form';
+
+var dataSources = function dataSources(_ref) {
+  var agentSlug = _ref.agentSlug,
+      filestoreSlug = _ref.filestoreSlug,
+      adapterClass = _ref.adapterClass;
+  return {
+    filestore: {
+      fn: fetchFilestore,
+      params: agentSlug && filestoreSlug && [{
+        agentSlug: agentSlug,
+        filestoreSlug: filestoreSlug,
+        include: 'details'
+      }],
+      transform: function transform(result) {
+        return result.filestore;
+      }
+    },
+    adapters: {
+      fn: fetchAdapters,
+      params: [{
+        include: 'details',
+        type: 'filestore',
+        agentSlug: agentSlug
+      }],
+      transform: function transform(result) {
+        return result.adapters;
+      }
+    },
+    adapterProperties: {
+      fn: function fn(adapters, filestore) {
+        var appliedAdapterClass = filestore ? filestore.get('adapterClass') : adapterClass;
+        var adapter = adapters.find(function (adapter) {
+          return adapter.get('class') === appliedAdapterClass;
+        });
+        return adapter ? List(adapter.get('properties')) : List();
+      },
+      params: function params(_ref2) {
+        var adapters = _ref2.adapters,
+            filestore = _ref2.filestore;
+        return (!filestoreSlug || filestore) && adapters && [adapters, filestore];
+      }
+    }
+  };
+};
+
+var handleSubmit = function handleSubmit(_ref3) {
+  var agentSlug = _ref3.agentSlug,
+      filestoreSlug = _ref3.filestoreSlug;
+  return function (values) {
+    return (filestoreSlug ? updateFilestore : createFilestore)({
+      agentSlug: agentSlug,
+      filestoreSlug: filestoreSlug,
+      filestore: values.toJS()
+    }).then(handleFormErrors('filestore', 'There was a problem saving the filestore.'));
+  };
+};
+
+var fields = function fields(_ref4) {
+  var adapterClass = _ref4.adapterClass;
+  return function (_ref5) {
+    var filestore = _ref5.filestore,
+        adapters = _ref5.adapters,
+        adapterProperties = _ref5.adapterProperties;
+
+    if (adapterProperties) {
+      var _buildPropertyFields = buildPropertyFields({
+        isNew: !filestore,
+        properties: adapterProperties,
+        getName: function getName(property) {
+          return property.get('name');
+        },
+        getRequired: function getRequired(property) {
+          return property.get('required');
+        },
+        getSensitive: function getSensitive(property) {
+          return property.get('sensitive');
+        },
+        getOptions: function getOptions(property) {
+          return property.get('options');
+        },
+        getValue: function getValue(property) {
+          return getIn(filestore, ['properties', property.get('name')], '');
+        }
+      }),
+          propertiesFields = _buildPropertyFields.propertiesFields,
+          propertiesSerialize = _buildPropertyFields.propertiesSerialize;
+
+      return [{
+        name: 'slug',
+        label: 'Filestore Slug',
+        type: 'text',
+        required: true,
+        initialValue: get(filestore, 'slug', ''),
+        pattern: /^[a-z\d-]+$/,
+        patternMessage: 'File Store Slug may only contain letters, numbers, and dashes',
+        helpText: 'Unique name used in the bridge path.'
+      }, {
+        name: 'adapterClass',
+        label: 'Adapter Class',
+        type: 'text',
+        enabled: false,
+        required: false,
+        initialValue: filestore ? filestore.get('adapterClass') : adapterClass,
+        options: adapters.map(function (adapter) {
+          return Map({
+            value: adapter.get('class'),
+            label: adapter.get('name')
+          });
+        })
+      }].concat(_toConsumableArray(propertiesFields), [{
+        name: 'properties',
+        visible: false,
+        initialValue: get(filestore, 'properties', {}),
+        serialize: propertiesSerialize
+      }]);
+    }
+  };
+};
+
+export var FilestoreForm = generateForm({
+  formOptions: ['filestoreSlug', 'adapterClass', 'agentSlug'],
+  dataSources: dataSources,
+  fields: fields,
+  handleSubmit: handleSubmit
+});
+FilestoreForm.displayName = 'FilestoreForm';

package/lib/components/agent/filestore/FilestoreTable.js

@@ -0,0 +1,53 @@
+import { defineFilter } from '../../../helpers';
+import { fetchFilestores } from '../../../apis';
+import { generateTable } from '../../table/Table';
+var clientSide = defineFilter(true).startsWith('slug', 'slug').end();
+
+var dataSource = function dataSource(_ref) {
+  var agentSlug = _ref.agentSlug;
+  return {
+    fn: fetchFilestores,
+    clientSide: clientSide,
+    params: function params() {
+      return [{
+        agentSlug: agentSlug,
+        include: 'details'
+      }];
+    },
+    transform: function transform(result) {
+      return {
+        data: result.filestores
+      };
+    }
+  };
+};
+
+var filters = function filters() {
+  return function () {
+    return [{
+      name: 'slug',
+      label: 'Slug',
+      type: 'text'
+    }];
+  };
+};
+
+var columns = [{
+  value: 'slug',
+  title: 'Slug',
+  sortable: true
+}, {
+  value: 'adapterClass',
+  title: 'Adapter',
+  sortable: true,
+  valueTransform: function valueTransform(_value) {
+    return _value.split('.').pop().match(/[A-Z][a-z]+/g).join(' ');
+  }
+}];
+export var FilestoreTable = generateTable({
+  tableOptions: ['agentSlug'],
+  columns: columns,
+  filters: filters,
+  dataSource: dataSource
+});
+FilestoreTable.displayName = 'FilestoreTable';

package/lib/components/common/BridgeSelect.js

@@ -20,7 +20,8 @@ var searchOptions = function searchOptions(_ref) {
         var name = _ref2.name,
             staticValue = _ref2.value;
         return _objectSpread(_objectSpread({}, values), {}, _defineProperty({}, name, staticValue || value));
-      }, {})
+      }, {}),
+      "public": !!search.get('public')
     }).then(function (_ref3) {
       var records = _ref3.records,
           error = _ref3.error;

package/lib/components/common/FormSelect.js

@@ -75,7 +75,8 @@ var searchForms = function searchForms(_ref3) {
       kappSlug: search.get('kappSlug'),
       q: buildQuery(searchFields, value),
       include: search.get('include') || (search.get('datastore') ? '' : 'categorizations.category'),
-      limit: search.get('limit') || 25
+      limit: search.get('limit') || 25,
+      "public": !!search.get('public')
     }).then(function (_ref4) {
       var forms = _ref4.forms,
           error = _ref4.error,

package/lib/components/common/Scroller.js

@@ -50,13 +50,13 @@ export var Scroller = /*#__PURE__*/function (_Component) {
           }
         } // when scrolling up...
         else if (childTop < this.lastTop) {
-            // check to see if the top of the child element is above the top of the
-            // scrollable parent
-            if (childTop < parent.scrollTop) {
-              // scroll the child into view (passing true which aligns by top)
-              child.scrollIntoView(true);
-            }
+          // check to see if the top of the child element is above the top of the
+          // scrollable parent
+          if (childTop < parent.scrollTop) {
+            // scroll the child into view (passing true which aligns by top)
+            child.scrollIntoView(true);
           }
+        }
 
         this.lastTop = child.offsetTop;
       }