@jvs-milkdown/components 1.2.2 → 1.2.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jvs-milkdown/components",
-  "version": "1.2.2",
+  "version": "1.2.4",
   "keywords": [
     "milkdown",
     "milkdown plugin"
@@ -50,15 +50,15 @@
   },
   "dependencies": {
     "@floating-ui/dom": "^1.5.1",
-    "@jvs-milkdown/core": "^1.2.2",
-    "@jvs-milkdown/ctx": "^1.2.2",
-    "@jvs-milkdown/exception": "^1.2.2",
-    "@jvs-milkdown/plugin-tooltip": "^1.2.2",
-    "@jvs-milkdown/preset-commonmark": "^1.2.2",
-    "@jvs-milkdown/preset-gfm": "^1.2.2",
-    "@jvs-milkdown/prose": "^1.2.2",
-    "@jvs-milkdown/transformer": "^1.2.2",
-    "@jvs-milkdown/utils": "^1.2.2",
+    "@jvs-milkdown/core": "^1.2.4",
+    "@jvs-milkdown/ctx": "^1.2.4",
+    "@jvs-milkdown/exception": "^1.2.4",
+    "@jvs-milkdown/plugin-tooltip": "^1.2.4",
+    "@jvs-milkdown/preset-commonmark": "^1.2.4",
+    "@jvs-milkdown/preset-gfm": "^1.2.4",
+    "@jvs-milkdown/prose": "^1.2.4",
+    "@jvs-milkdown/transformer": "^1.2.4",
+    "@jvs-milkdown/utils": "^1.2.4",
     "@types/lodash-es": "^4.17.12",
     "clsx": "^2.0.0",
     "dompurify": "^3.2.5",

package/src/image-block/convert-plugin.ts

@@ -30,7 +30,7 @@ export const imageBlockConvertPlugin = $prose((ctx) => {
 
       // Debug: log all paragraphs with their children
       let foundImages = 0
-      newState.doc.descendants((node, pos) => {
+      newState.doc.descendants((node) => {
         if (node.type === imageType) foundImages++
       })
       if (foundImages > 0) {

package/src/image-block/paste-rule.ts

@@ -21,27 +21,7 @@ function toImageBlock(
   })
 }
 
-/// Check if a paragraph contains only images (and trailing hard_breaks / empty text).
-/// Returns the list of image nodes found, or null if there's other content.
-function extractParagraphImages(
-  node: ProsemirrorNode,
-  imageType: ProsemirrorNode['type']
-): ProsemirrorNode[] | null {
-  const images: ProsemirrorNode[] = []
-  for (let i = 0; i < node.childCount; i++) {
-    const child = node.child(i)
-    if (child.type === imageType) {
-      images.push(child)
-    } else if (child.type.name === 'hardbreak') {
-      continue
-    } else if (child.isText && child.text?.trim() === '') {
-      continue
-    } else {
-      return null
-    }
-  }
-  return images.length > 0 ? images : null
-}
+
 
 /// A paste rule that converts standalone inline images to image-block nodes.
 /// Handles the slice structures produced when pasting HTML from external pages

package/src/link-tooltip/edit/component.tsx

@@ -87,7 +87,6 @@ export const EditLink = defineComponent<EditLinkProps>({
               class={clsx('button confirm', !isValidUrl(link.value) && 'disabled')}
               icon={config.value.confirmButton}
               onClick={onConfirmEdit}
-              style={!isValidUrl(link.value) ? { opacity: 0.5, cursor: 'not-allowed' } : undefined}
             />
           ) : null}
         </div>

package/src/table-block/view/component.tsx

@@ -7,6 +7,7 @@ import {
   CellSelection,
   mergeCells,
   splitCell,
+  selectedRect,
 } from '@jvs-milkdown/prose/tables'
 import {
   defineComponent,
@@ -195,7 +196,8 @@ export const TableBlock = defineComponent<TableBlockProps>({
       addColByIndex,
       selectCol,
       selectRow,
-      deleteSelected,
+      deleteRowByIndex,
+      deleteColByIndex,
       onAlign,
       onMergeCells,
       onSplitCell,
@@ -397,18 +399,34 @@ export const TableBlock = defineComponent<TableBlockProps>({
 
         if (isCellSelection(selection)) {
           const selAny = selection as any
+          const rect = selectedRect(view.state)
+          
           if (selAny.isColSelection()) {
-            const $headCell = selAny.$headCell
-            activeColIndex.value = $headCell
-              ? $headCell.index($headCell.depth)
-              : -1
+            if (
+              activeColIndex.value >= rect.left &&
+              activeColIndex.value < rect.right
+            ) {
+              // Keep current col index if it's within the selection
+            } else {
+              const $headCell = selAny.$headCell
+              activeColIndex.value = $headCell
+                ? $headCell.index($headCell.depth)
+                : -1
+            }
             activeRowIndex.value = -1
           } else if (selAny.isRowSelection()) {
-            const $headCell = selAny.$headCell
+            if (
+              activeRowIndex.value >= rect.top &&
+              activeRowIndex.value < rect.bottom
+            ) {
+              // Keep current row index if it's within the selection
+            } else {
+              const $headCell = selAny.$headCell
+              activeRowIndex.value = $headCell
+                ? $headCell.index($headCell.depth - 1)
+                : -1
+            }
             activeColIndex.value = -1
-            activeRowIndex.value = $headCell
-              ? $headCell.index($headCell.depth - 1)
-              : -1
           } else {
             activeColIndex.value = -1
             activeRowIndex.value = -1
@@ -603,9 +621,9 @@ export const TableBlock = defineComponent<TableBlockProps>({
                     </button>
                     <button
                       type="button"
-                      onPointerdown={(e) => {
+                      onPointerdown={() => {
                         hoverIndex.value = [0, i]
-                        deleteSelected(e)
+                        deleteColByIndex(i)
                       }}
                     >
                       <Icon icon={config.renderButton('delete_col')} />
@@ -691,9 +709,9 @@ export const TableBlock = defineComponent<TableBlockProps>({
                     ) : undefined}
                     <button
                       type="button"
-                      onPointerdown={(e) => {
+                      onPointerdown={() => {
                         hoverIndex.value = [i, 0]
-                        deleteSelected(e)
+                        deleteRowByIndex(i)
                       }}
                     >
                       <Icon icon={config.renderButton('delete_row')} />

package/src/table-block/view/operation.ts

@@ -17,6 +17,8 @@ import {
   TableMap,
   type TableRect,
   addColumn,
+  removeRow,
+  removeColumn,
 } from '@jvs-milkdown/prose/tables'
 
 import type { Refs } from './types'
@@ -116,6 +118,64 @@ export function useOperation(
     })
   }
 
+  const deleteRowByIndex = (index: number) => {
+    if (!ctx || !ctx.get(editorViewCtx).editable) return
+    const view = ctx.get(editorViewCtx)
+    const tablePos = getPos?.()
+    if (tablePos == null) return
+
+    const table = view.state.doc.nodeAt(tablePos)
+    if (!table) return
+
+    const tableStart = tablePos + 1
+    const map = TableMap.get(table)
+    const tr = view.state.tr
+    const rect: TableRect = {
+      map,
+      tableStart,
+      table,
+      left: 0,
+      right: map.width,
+      top: 0,
+      bottom: map.height,
+    }
+
+    removeRow(tr, rect, index)
+    view.dispatch(tr)
+    requestAnimationFrame(() => {
+      ctx.get(editorViewCtx).focus()
+    })
+  }
+
+  const deleteColByIndex = (index: number) => {
+    if (!ctx || !ctx.get(editorViewCtx).editable) return
+    const view = ctx.get(editorViewCtx)
+    const tablePos = getPos?.()
+    if (tablePos == null) return
+
+    const table = view.state.doc.nodeAt(tablePos)
+    if (!table) return
+
+    const tableStart = tablePos + 1
+    const map = TableMap.get(table)
+    const tr = view.state.tr
+    const rect: TableRect = {
+      map,
+      tableStart,
+      table,
+      left: 0,
+      right: map.width,
+      top: 0,
+      bottom: map.height,
+    }
+
+    removeColumn(tr, rect, index)
+    view.dispatch(tr)
+    requestAnimationFrame(() => {
+      ctx.get(editorViewCtx).focus()
+    })
+  }
+
   const onAlign =
     (direction: 'left' | 'center' | 'right') => (e: PointerEvent) => {
       if (!ctx) return
@@ -225,6 +285,8 @@ export function useOperation(
     selectCol,
     selectRow,
     deleteSelected,
+    deleteRowByIndex,
+    deleteColByIndex,
     onAlign,
     onMergeCells,
     onSplitCell,

package/src/table-block/view/utils.ts

@@ -3,7 +3,8 @@ import type { EditorView } from '@jvs-milkdown/prose/view'
 import type { Ref } from 'vue'
 
 import { findParent } from '@jvs-milkdown/prose'
-import { CellSelection, findTable } from '@jvs-milkdown/prose/tables'
+import { findTable } from '@jvs-milkdown/prose/tables'
+import type { CellSelection } from '@jvs-milkdown/prose/tables'
 
 import type { CellIndex, Refs } from './types'
 
@@ -99,13 +100,13 @@ export function recoveryStateBetweenUpdate(
   const table = findTable($from)
   if (!table || table.node !== node) return
 
-  if (selection.isColSelection()) {
+  if ((selection as any as CellSelection).isColSelection()) {
     const { $head } = selection
     const colIndex = $head.index($head.depth - 1)
     refs.hoverIndex.value = [0, colIndex]
     return
   }
-  if (selection.isRowSelection()) {
+  if ((selection as any as CellSelection).isRowSelection()) {
     const { $head } = selection
     const rowNode = findParent(
       (node) =>