@futdevpro/nts-dynamo 1.10.5 → 1.10.7

package/src/_services/base/db.service.ts

@@ -991,7 +991,9 @@ export class DyNTS_DBService<T extends DyFM_Metadata> {
   ): DyFM_Error_Settings {
     return {
       status: (error as DyFM_Error)?.___status ?? 500,
-      message: (error as Error)?.message ?? `${fnName} was UNSUCCESSFUL (NTS-DB)`,
+      message: (error as Error)?.message ?? 
+        (error as DyFM_Error)?._message ??
+        `${fnName} was UNSUCCESSFUL (NTS-DB)`,
       addECToUserMsg: !(error as DyFM_Error)?.__userMessage,
       userMessage: (error as DyFM_Error)?.__userMessage ?? this.defaultErrorUserMsg,
       issuer: issuer,

package/src/_services/base/singleton.service.ts

@@ -20,6 +20,7 @@ export class DyNTS_SingletonService extends DyNTS_SingletonServiceBase {
     return {
       status: (error as DyFM_Error)?.___status ?? 500,
       message: (error as Error)?.message ??
+        (error as DyFM_Error)?._message ??
         `${fnName} was UNSUCCESSFUL (${DyNTS_global_settings.systemShortCodeName})`,
       addECToUserMsg: !(error as DyFM_Error)?.__userMessage,
       userMessage: (error as DyFM_Error)?.__userMessage ?? this.defaultErrorUserMsg,

package/src/_services/core/api.service.spec.ts

@@ -11,9 +11,9 @@ describe('DyNTS_ApiService', () => {
   let inputParams: DyNTS_ApiCallInput_Params;
 
   beforeEach(() => {
-    callParams = {
+    callParams = new DyNTS_ApiCall_Params({
       baseUrl: 'http://example.com',
-      endPoint: '/api/test',
+      endpoint: '/api/test',
       type: DyFM_HttpCallType.get,
       httpOptions: {
         headers: {},
@@ -21,7 +21,7 @@ describe('DyNTS_ApiService', () => {
       },
       name: 'Test API Call',
       getFullResponse: false,
-    };
+    });
 
     inputParams = {
       pathParams: { id: '123' },

package/src/_services/core/api.service.ts

@@ -30,7 +30,7 @@ export interface DyNTS_ApiCallInput_Params<T_Body = any> {
  */
 export class DyNTS_ApiService {
 
-  static defaultErrorUserMsg =
+  static readonly defaultErrorUserMsg =
     `We encountered a BackEnd API Error, ` +
     `\nplease contact the responsible development team.\n` +
     `\n(Internal BE to BE error)`;
@@ -56,9 +56,23 @@ export class DyNTS_ApiService {
   ): Promise<T_Response /* | Axios.AxiosResponse */> {
     try {
       let a: T_Response;
-      let url: string = callParams.baseUrl + callParams.endPoint;
+      let url: string = callParams.baseUrl + callParams.endpoint;
       const axios = Axios.default.create();
 
+      if (callParams.pathParamKeys.length) {
+        callParams.pathParamKeys.forEach(key => {
+          if (!inputParams?.pathParams?.[key]) {
+            throw new DyFM_Error({
+              ...this._getDefaultErrorSettings(
+                'startApiCall',
+                new Error(`missing pathParam: "${key}"`)
+              ),
+              errorCode: 'NTS-API-SAC1',
+            });
+          }
+        });
+      }
+
       if (callParams?.httpOptions?.headers) {
         this.setupHeaders(callParams, axios);
       }
@@ -169,7 +183,7 @@ export class DyNTS_ApiService {
   ): void {
     DyFM_Log.error(
       `\n--->   API ERROR: '${callParams?.name}' failed...` +
-      `\n${callParams?.baseUrl}${callParams?.endPoint}`
+      `\n${callParams?.baseUrl}${callParams?.endpoint}`
     );
 
     if (DyNTS_global_settings.log_settings.detailedErrors) {
@@ -189,7 +203,7 @@ export class DyNTS_ApiService {
           error.response.data
         ),
 
-        errorCode: 'NTS-API-SAC1',
+        errorCode: 'NTS-API-HE1',
         message: 'API call failed on the other end! error response found...',
         additionalContent: {
           callParams,
@@ -207,7 +221,7 @@ export class DyNTS_ApiService {
         ),
 
         status: 404,
-        errorCode: 'NTS-API-SAC2',
+        errorCode: 'NTS-API-HE2',
         message: 'DNS error; address cannot be resolved!',
         additionalContent: {
           callParams,
@@ -225,7 +239,7 @@ export class DyNTS_ApiService {
         ),
 
         status: 404,
-        errorCode: 'NTS-API-SAC3',
+        errorCode: 'NTS-API-HE3',
         message: `Can't connect to the endpoint!`,
         additionalContent: {
           callParams,
@@ -242,7 +256,7 @@ export class DyNTS_ApiService {
         ),
 
         status: +error.message.substring(error.message.length - 4, 3),
-        errorCode: 'NTS-API-SAC4',
+        errorCode: 'NTS-API-HE4',
         additionalContent: {
           callParams,
           inputParams,
@@ -448,7 +462,9 @@ export class DyNTS_ApiService {
   ): DyFM_Error_Settings {
     return {
       status: (error as DyFM_Error)?.___status ?? 500,
-      message: (error as Error)?.message ?? `${fnName} was UNSUCCESSFUL (NTS)`,
+      message: (error as Error)?.message ?? 
+        (error as DyFM_Error)?._message ??
+        `${fnName} was UNSUCCESSFUL (NTS)`,
       addECToUserMsg: !(error as DyFM_Error)?.__userMessage,
       userMessage: (error as DyFM_Error)?.__userMessage ?? this.defaultErrorUserMsg,
       issuerService: `${this?.constructor?.name}-${this?.name}-DyNTS_ApiService`,

package/src/_services/core/auth.service.ts

@@ -150,6 +150,7 @@ export abstract class DyNTS_AuthService extends DyNTS_SingletonService {
 
   /**
    * The DynamoBE System is using this to get issuer, that will be set on DBServices
+   * Don't throw error in this function, since it will be used in every request
    * @param req 
    * 
    * @example

package/src/_services/core/email.service.ts

@@ -679,7 +679,9 @@ export class DyNTS_EmailService /* extends DyNTS_SingletonService */ {
   ): DyFM_Error_Settings {
     return {
       status: (error as DyFM_Error)?.___status ?? 500,
-      message: (error as Error)?.message ?? `${fnName} was UNSUCCESSFUL (NTS; ${this.serviceName})`,
+      message: (error as Error)?.message ?? 
+        (error as DyFM_Error)?._message ??
+        `${fnName} was UNSUCCESSFUL (NTS; ${this.serviceName})`,
       addECToUserMsg: !(error as DyFM_Error)?.__userMessage,
       userMessage: (error as DyFM_Error)?.__userMessage ?? this.defaultErrorUserMsg,
       issuer: issuer,
@@ -696,6 +698,7 @@ export class DyNTS_EmailService /* extends DyNTS_SingletonService */ {
     return {
       status: (error as DyFM_Error)?.___status ?? 500,
       message: (error as Error)?.message ?? 
+        (error as DyFM_Error)?._message ??
         `${fnName} was UNSUCCESSFUL (${DyNTS_global_settings.systemShortCodeName})`,
       addECToUserMsg: !(error as DyFM_Error)?.__userMessage,
       userMessage: (error as DyFM_Error)?.__userMessage ?? this.defaultErrorUserMsg,

package/src/_services/core/global.service.ts

@@ -396,6 +396,7 @@ export class DyNTS_GlobalService extends DyNTS_SingletonService {
     return {
       status: (error as DyFM_Error)?.___status ?? 500,
       message: (error as Error)?.message ?? 
+        (error as DyFM_Error)?._message ??
         `${fnName} was UNSUCCESSFUL (${DyNTS_global_settings.systemShortCodeName})`,
       addECToUserMsg: !(error as DyFM_Error)?.__userMessage,
       userMessage: (error as DyFM_Error)?.__userMessage ?? this.defaultErrorUserMsg,

package/src/_services/route/routing-module.service.ts

@@ -307,7 +307,9 @@ export class DyNTS_RoutingModule {
   ): DyFM_Error_Settings {
     return {
       status: 500,
-      message: (error as Error)?.message ?? `${fnName} was UNSUCCESSFUL (NTS)`,
+      message: (error as Error)?.message ??   
+        (error as DyFM_Error)?._message ??
+        `${fnName} was UNSUCCESSFUL (NTS)`,
       issuerService: this.constructor?.name,
       userMessage: (error as DyFM_Error)?.__userMessage ?? this.defaultErrorUserMsg,
       addECToUserMsg: true,

package/src/_services/server/app.server.ts

@@ -1234,7 +1234,9 @@ export abstract class DyNTS_App extends DyNTS_SingletonService {
   ): DyFM_Error_Settings {
     return {
       status: (error as DyFM_Error)?.___status ?? 500,
-      message: (error as Error)?.message ?? `${fnName} was UNSUCCESSFUL (NTS)`,
+      message: (error as Error)?.message ?? 
+        (error as DyFM_Error)?._message ??
+        `${fnName} was UNSUCCESSFUL (NTS)`,
       userMessage: (error as DyFM_Error)?.__userMessage ?? this.defaultErrorUserMsg,
       addECToUserMsg: !(error as DyFM_Error)?.__userMessage,
       issuerService: `${this?.constructor?.name}-DyNTS_App`,