@friggframework/devtools 2.0.0--canary.482.c063a2a.0 → 2.0.0--canary.482.7be62db.0

package/infrastructure/domains/shared/utilities/prisma-layer-manager.js

@@ -13,11 +13,16 @@ const { buildPrismaLayer } = require('../../../scripts/build-prisma-layer');
 
 /**
  * Ensure Prisma Lambda Layer exists
- * 
+ *
  * Automatically builds the layer if it doesn't exist.
  * The layer contains ONLY the Prisma runtime client (minimal, ~10-15MB).
  * Prisma CLI is bundled separately in the dbMigrate function.
- * 
+ *
+ * Domain Concept: Build Completion State
+ * - Uses .build-complete marker file to track successful builds
+ * - Prevents race conditions during concurrent infrastructure composition
+ * - Cleans incomplete builds before retry
+ *
  * @param {Object} databaseConfig - Database configuration from app definition
  * @returns {Promise<void>}
  * @throws {Error} If layer build fails
@@ -25,14 +30,33 @@ const { buildPrismaLayer } = require('../../../scripts/build-prisma-layer');
 async function ensurePrismaLayerExists(databaseConfig = {}) {
     const projectRoot = process.cwd();
     const layerPath = path.join(projectRoot, 'layers/prisma');
+    const completionMarkerPath = path.join(layerPath, '.build-complete');
 
-    // Check if layer already exists
-    if (fs.existsSync(layerPath)) {
+    // Check if build is complete (marker exists)
+    if (fs.existsSync(completionMarkerPath)) {
         console.log('✓ Prisma Lambda Layer already exists at', layerPath);
         return;
     }
 
-    // Layer doesn't exist - build it automatically
+    // Check if incomplete build exists (directory without marker)
+    if (fs.existsSync(layerPath)) {
+        console.log('⚠ Incomplete Prisma layer detected');
+
+        // Wait briefly to see if another process completes the build
+        console.log('⏳ Checking if concurrent build is in progress...');
+        await new Promise(resolve => setTimeout(resolve, 1000));
+
+        // Check if concurrent build completed while we waited
+        if (fs.existsSync(completionMarkerPath)) {
+            console.log('✓ Concurrent build completed');
+            return;
+        }
+
+        // Incomplete build still exists - will be cleaned by buildPrismaLayer()
+        console.log('⚠ Proceeding with rebuild (buildPrismaLayer will clean incomplete build)');
+    }
+
+    // Build layer
     console.log('📦 Prisma Lambda Layer not found - building automatically...');
     console.log('   Building MINIMAL layer (runtime only, NO CLI)');
     console.log('   CLI is packaged separately in dbMigrate function');
@@ -41,8 +65,24 @@ async function ensurePrismaLayerExists(databaseConfig = {}) {
     try {
         // Build layer WITHOUT CLI (runtime only for minimal size)
         await buildPrismaLayer(databaseConfig);
+
+        // Create completion marker
+        fs.writeFileSync(
+            completionMarkerPath,
+            `Build completed: ${new Date().toISOString()}\nNode: ${process.version}\nPlatform: ${process.platform}\n`
+        );
+
         console.log('✓ Prisma Lambda Layer built successfully (~10-15MB)\n');
     } catch (error) {
+        // Clean up partial build on failure
+        if (fs.existsSync(layerPath)) {
+            try {
+                fs.rmSync(layerPath, { recursive: true, force: true });
+            } catch (cleanupError) {
+                console.warn('⚠ Could not clean failed build:', cleanupError.message);
+            }
+        }
+
         console.error('✗ Failed to build Prisma Lambda Layer:', error.message);
         console.error('  You may need to run: npm install @friggframework/core\n');
         throw error;

package/infrastructure/domains/shared/utilities/prisma-layer-manager.test.js

@@ -16,6 +16,33 @@ jest.mock('../../../scripts/build-prisma-layer', () => ({
 
 const { buildPrismaLayer } = require('../../../scripts/build-prisma-layer');
 
+// Helper to mock fs methods for different scenarios
+const mockFs = {
+    completedBuild: () => {
+        fs.existsSync = jest.fn((path) => {
+            if (path.endsWith('.build-complete')) return true;
+            if (path.endsWith('layers/prisma')) return true;
+            return false;
+        });
+        fs.writeFileSync = jest.fn();
+        fs.rmSync = jest.fn();
+    },
+    incompleteBuild: () => {
+        fs.existsSync = jest.fn((path) => {
+            if (path.endsWith('.build-complete')) return false;
+            if (path.endsWith('layers/prisma')) return true;
+            return false;
+        });
+        fs.writeFileSync = jest.fn();
+        fs.rmSync = jest.fn();
+    },
+    noBuild: () => {
+        fs.existsSync = jest.fn().mockReturnValue(false);
+        fs.writeFileSync = jest.fn();
+        fs.rmSync = jest.fn();
+    },
+};
+
 describe('Prisma Layer Manager', () => {
     let originalCwd;
 
@@ -31,11 +58,15 @@ describe('Prisma Layer Manager', () => {
 
     describe('ensurePrismaLayerExists()', () => {
         it('should skip build if layer already exists', async () => {
-            fs.existsSync = jest.fn().mockReturnValue(true);
+            fs.existsSync = jest.fn((path) => {
+                // Completion marker exists
+                if (path.endsWith('.build-complete')) return true;
+                return false;
+            });
 
             await ensurePrismaLayerExists();
 
-            expect(fs.existsSync).toHaveBeenCalledWith('/project/layers/prisma');
+            expect(fs.existsSync).toHaveBeenCalledWith('/project/layers/prisma/.build-complete');
             expect(buildPrismaLayer).not.toHaveBeenCalled();
         });
 
@@ -79,11 +110,15 @@ describe('Prisma Layer Manager', () => {
 
         it('should use correct layer path relative to project root', async () => {
             process.cwd = jest.fn().mockReturnValue('/custom/project/path');
-            fs.existsSync = jest.fn().mockReturnValue(true);
+            fs.existsSync = jest.fn((path) => {
+                // Completion marker exists
+                if (path.endsWith('.build-complete')) return true;
+                return false;
+            });
 
             await ensurePrismaLayerExists();
 
-            expect(fs.existsSync).toHaveBeenCalledWith('/custom/project/path/layers/prisma');
+            expect(fs.existsSync).toHaveBeenCalledWith('/custom/project/path/layers/prisma/.build-complete');
         });
 
         it('should log success when layer already exists', async () => {
@@ -133,6 +168,122 @@ describe('Prisma Layer Manager', () => {
 
             consoleErrorSpy.mockRestore();
         });
+
+        describe('Concurrent Build Protection', () => {
+            it('should skip build if completion marker exists (TDD)', async () => {
+                mockFs.completedBuild();
+
+                await ensurePrismaLayerExists();
+
+                expect(fs.existsSync).toHaveBeenCalledWith('/project/layers/prisma/.build-complete');
+                expect(buildPrismaLayer).not.toHaveBeenCalled();
+            });
+
+            it('should wait and rebuild if directory exists without completion marker (TDD)', async () => {
+                jest.useFakeTimers();
+                mockFs.incompleteBuild();
+                buildPrismaLayer.mockResolvedValue();
+
+                const promise = ensurePrismaLayerExists();
+
+                // Fast-forward through the wait
+                jest.advanceTimersByTime(1000);
+
+                await promise;
+
+                // Should NOT manually clean (buildPrismaLayer handles this)
+                expect(fs.rmSync).not.toHaveBeenCalled();
+                // Should rebuild
+                expect(buildPrismaLayer).toHaveBeenCalled();
+                // Should create completion marker
+                expect(fs.writeFileSync).toHaveBeenCalledWith(
+                    '/project/layers/prisma/.build-complete',
+                    expect.any(String)
+                );
+
+                jest.useRealTimers();
+            });
+
+            it('should create completion marker after successful build (TDD)', async () => {
+                mockFs.noBuild();
+                buildPrismaLayer.mockResolvedValue();
+
+                await ensurePrismaLayerExists();
+
+                expect(fs.writeFileSync).toHaveBeenCalledWith(
+                    '/project/layers/prisma/.build-complete',
+                    expect.any(String)
+                );
+            });
+
+            it('should clean up partial build on failure (TDD)', async () => {
+                mockFs.noBuild();
+                buildPrismaLayer.mockRejectedValue(new Error('Build failed'));
+
+                // After build attempt fails, directory exists
+                fs.existsSync = jest.fn((path) => {
+                    if (path.endsWith('.build-complete')) return false;
+                    if (path.endsWith('layers/prisma')) return true;
+                    return false;
+                });
+
+                await expect(ensurePrismaLayerExists()).rejects.toThrow('Build failed');
+
+                // Should clean up after failure
+                expect(fs.rmSync).toHaveBeenCalledWith(
+                    '/project/layers/prisma',
+                    { recursive: true, force: true }
+                );
+            });
+
+            it('should wait for potential concurrent build before rebuilding (TDD)', async () => {
+                jest.useFakeTimers();
+                mockFs.incompleteBuild();
+                buildPrismaLayer.mockResolvedValue();
+
+                const promise = ensurePrismaLayerExists();
+
+                // Fast-forward through the wait
+                jest.advanceTimersByTime(1000);
+
+                await promise;
+
+                // Should wait before rebuilding
+                // Should still attempt to build
+                expect(buildPrismaLayer).toHaveBeenCalled();
+
+                jest.useRealTimers();
+            });
+
+            it('should detect when concurrent process completes during wait (TDD)', async () => {
+                jest.useFakeTimers();
+
+                // After 1 second, completion marker appears (concurrent process finished)
+                let callCount = 0;
+                fs.existsSync = jest.fn((path) => {
+                    callCount++;
+                    if (path.endsWith('.build-complete')) {
+                        return callCount > 2; // Appears after setTimeout
+                    }
+                    if (path.endsWith('layers/prisma')) return true;
+                    return false;
+                });
+                fs.writeFileSync = jest.fn();
+                fs.rmSync = jest.fn();
+
+                const promise = ensurePrismaLayerExists();
+
+                // Fast-forward through the wait
+                jest.advanceTimersByTime(1000);
+
+                await promise;
+
+                // Should not rebuild (concurrent process completed)
+                expect(buildPrismaLayer).not.toHaveBeenCalled();
+
+                jest.useRealTimers();
+            });
+        });
     });
 });
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@friggframework/devtools",
   "prettier": "@friggframework/prettier-config",
-  "version": "2.0.0--canary.482.c063a2a.0",
+  "version": "2.0.0--canary.482.7be62db.0",
   "dependencies": {
     "@aws-sdk/client-ec2": "^3.835.0",
     "@aws-sdk/client-kms": "^3.835.0",
@@ -12,8 +12,8 @@
     "@babel/eslint-parser": "^7.18.9",
     "@babel/parser": "^7.25.3",
     "@babel/traverse": "^7.25.3",
-    "@friggframework/schemas": "2.0.0--canary.482.c063a2a.0",
-    "@friggframework/test": "2.0.0--canary.482.c063a2a.0",
+    "@friggframework/schemas": "2.0.0--canary.482.7be62db.0",
+    "@friggframework/test": "2.0.0--canary.482.7be62db.0",
     "@hapi/boom": "^10.0.1",
     "@inquirer/prompts": "^5.3.8",
     "axios": "^1.7.2",
@@ -35,8 +35,8 @@
     "serverless-http": "^2.7.0"
   },
   "devDependencies": {
-    "@friggframework/eslint-config": "2.0.0--canary.482.c063a2a.0",
-    "@friggframework/prettier-config": "2.0.0--canary.482.c063a2a.0",
+    "@friggframework/eslint-config": "2.0.0--canary.482.7be62db.0",
+    "@friggframework/prettier-config": "2.0.0--canary.482.7be62db.0",
     "aws-sdk-client-mock": "^4.1.0",
     "aws-sdk-client-mock-jest": "^4.1.0",
     "jest": "^30.1.3",
@@ -68,5 +68,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "c063a2aaaaae0e4eaac6338f6adc250cf46b9103"
+  "gitHead": "7be62db49f55502252f0139a12562832210f8a74"
 }