@friggframework/devtools 2.0.0--canary.395.495dc7d.0 → 2.0.0--canary.395.ada1d9d.0

package/frigg-cli/start-command/start-command.test.js

@@ -15,7 +15,6 @@
 const mockValidator = {
     validateDatabaseUrl: jest.fn(),
     getDatabaseType: jest.fn(),
-    testDatabaseConnection: jest.fn(),
     checkPrismaClientGenerated: jest.fn()
 };
 
@@ -36,21 +35,26 @@ describe('startCommand', () => {
     let mockProcessExit;
 
     beforeEach(() => {
-        // Mock process.exit BEFORE clearAllMocks to prevent actual exits
-        mockProcessExit = jest.spyOn(process, 'exit').mockImplementation(() => {});
+        // Mock process.exit to throw error and stop execution (prevents actual exits)
+        const exitError = new Error('process.exit called');
+        exitError.code = 'PROCESS_EXIT';
+        mockProcessExit = jest.spyOn(process, 'exit').mockImplementation(() => {
+            throw exitError;
+        });
 
         // Reset mocks
         jest.clearAllMocks();
 
         // Re-apply process.exit mock after clearAllMocks
-        mockProcessExit = jest.spyOn(process, 'exit').mockImplementation(() => {});
+        mockProcessExit = jest.spyOn(process, 'exit').mockImplementation(() => {
+            throw exitError;
+        });
 
         // Set up default database validator mocks for all tests
         const defaultValidator = createMockDatabaseValidator();
-        mockValidator.validateDatabaseUrl.mockImplementation(defaultValidator.validateDatabaseUrl);
-        mockValidator.getDatabaseType.mockImplementation(defaultValidator.getDatabaseType);
-        mockValidator.testDatabaseConnection.mockImplementation(defaultValidator.testDatabaseConnection);
-        mockValidator.checkPrismaClientGenerated.mockImplementation(defaultValidator.checkPrismaClientGenerated);
+        mockValidator.validateDatabaseUrl.mockReturnValue(defaultValidator.validateDatabaseUrl());
+        mockValidator.getDatabaseType.mockReturnValue(defaultValidator.getDatabaseType());
+        mockValidator.checkPrismaClientGenerated.mockReturnValue(defaultValidator.checkPrismaClientGenerated());
 
         // Mock dotenv
         dotenv.config = jest.fn();
@@ -207,7 +211,6 @@ describe('startCommand', () => {
 
             expect(mockValidator.validateDatabaseUrl).toHaveBeenCalled();
             expect(mockValidator.getDatabaseType).toHaveBeenCalled();
-            expect(mockValidator.testDatabaseConnection).toHaveBeenCalled();
             expect(mockValidator.checkPrismaClientGenerated).toHaveBeenCalled();
             expect(mockProcessExit).not.toHaveBeenCalled();
             expect(spawn).toHaveBeenCalled();
@@ -219,7 +222,7 @@ describe('startCommand', () => {
                 error: 'DATABASE_URL not found'
             });
 
-            await startCommand({});
+            await expect(startCommand({})).rejects.toThrow('process.exit called');
 
             expect(mockConsoleError).toHaveBeenCalled();
             expect(mockProcessExit).toHaveBeenCalledWith(1);
@@ -231,20 +234,7 @@ describe('startCommand', () => {
                 error: 'Database not configured'
             });
 
-            await startCommand({});
-
-            expect(mockConsoleError).toHaveBeenCalled();
-            expect(mockProcessExit).toHaveBeenCalledWith(1);
-            expect(spawn).not.toHaveBeenCalled();
-        });
-
-        it('should fail when database connection fails', async () => {
-            mockValidator.testDatabaseConnection.mockResolvedValue({
-                connected: false,
-                error: 'Connection failed'
-            });
-
-            await startCommand({});
+            await expect(startCommand({})).rejects.toThrow('process.exit called');
 
             expect(mockConsoleError).toHaveBeenCalled();
             expect(mockProcessExit).toHaveBeenCalledWith(1);
@@ -257,7 +247,7 @@ describe('startCommand', () => {
                 error: 'Client not found'
             });
 
-            await startCommand({});
+            await expect(startCommand({})).rejects.toThrow('process.exit called');
 
             expect(mockConsoleError).toHaveBeenCalled();
             expect(mockConsoleError).toHaveBeenCalledWith(expect.stringContaining('frigg db:setup'));
@@ -271,7 +261,7 @@ describe('startCommand', () => {
                 error: 'Client not generated'
             });
 
-            await startCommand({});
+            await expect(startCommand({})).rejects.toThrow('process.exit called');
 
             expect(mockConsoleError).toHaveBeenCalledWith(expect.stringContaining('frigg db:setup'));
         });
@@ -281,7 +271,7 @@ describe('startCommand', () => {
                 valid: false
             });
 
-            await startCommand({});
+            await expect(startCommand({})).rejects.toThrow('process.exit called');
 
             expect(mockProcessExit).toHaveBeenCalledWith(1);
         });

package/frigg-cli/utils/database-validator.js

@@ -104,24 +104,28 @@ async function testDatabaseConnection(databaseUrl, dbType, timeout = 5000) {
 
 /**
  * Checks if Prisma client is generated for the database type
- * Uses require.resolve() to find the client regardless of package manager hoisting
+ * Uses require.resolve to find the client in node_modules
  *
  * @param {'mongodb'|'postgresql'} dbType - Database type
  * @param {string} projectRoot - Project root directory (used for require.resolve context)
  * @returns {Object} { generated: boolean, path?: string, error?: string }
  */
 function checkPrismaClientGenerated(dbType, projectRoot = process.cwd()) {
-    const clientPackageName = dbType === 'mongodb' ? '@prisma-mongo/client' : '@prisma-postgres/client';
+    const clientPackageName = `@prisma-${dbType}/client`;
 
     try {
-        // Use require.resolve to locate the client package
-        // This works with any package manager (npm, yarn, pnpm) and hoisting strategy
+        // First, resolve where @friggframework/core actually is
+        // This handles file: dependencies and symlinks correctly
+        const corePackagePath = require.resolve('@friggframework/core', {
+            paths: [projectRoot]
+        });
+        const corePackageDir = path.dirname(corePackagePath);
+
+        // Now look for the Prisma client within the resolved core package
         const clientPath = require.resolve(clientPackageName, {
             paths: [
-                // Try from @friggframework/core first (most likely location)
-                path.join(projectRoot, 'node_modules', '@friggframework', 'core'),
-                // Fallback to project root (in case of different hoisting)
-                projectRoot
+                corePackageDir,  // Look in the actual core package location
+                projectRoot      // Fallback to project root
             ]
         });
 

package/frigg-cli/utils/error-messages.js

@@ -161,7 +161,7 @@ ${chalk.gray('5.')} Verify network/firewall settings
  * @returns {string} Formatted error message
  */
 function getPrismaClientNotGeneratedError(dbType) {
-    const clientName = dbType === 'mongodb' ? '@prisma-mongo/client' : '@prisma-postgres/client';
+    const clientName = `@prisma-${dbType}/client`;
 
     return `
 ${chalk.red(`❌ Prisma client not generated for ${dbType}`)}

package/frigg-cli/utils/prisma-runner.js

@@ -16,23 +16,27 @@ const chalk = require('chalk');
  * @throws {Error} If schema file doesn't exist
  */
 function getPrismaSchemaPath(dbType, projectRoot = process.cwd()) {
-    const schemaPath = path.join(
-        projectRoot,
-        'node_modules',
-        '@friggframework',
-        'core',
-        `prisma-${dbType}`,
-        'schema.prisma'
-    );
-
-    if (!fs.existsSync(schemaPath)) {
-        throw new Error(
-            `Prisma schema not found at ${schemaPath}. ` +
-            'Ensure @friggframework/core is installed.'
-        );
+    // Try multiple locations for the schema file
+    // Priority order:
+    // 1. Local node_modules (where @friggframework/core is installed - production scenario)
+    // 2. Parent node_modules (workspace/monorepo setup)
+    const possiblePaths = [
+        // Check where Frigg is installed via npm (production scenario)
+        path.join(projectRoot, 'node_modules', '@friggframework', 'core', `prisma-${dbType}`, 'schema.prisma'),
+        path.join(projectRoot, '..', 'node_modules', '@friggframework', 'core', `prisma-${dbType}`, 'schema.prisma')
+    ];
+
+    for (const schemaPath of possiblePaths) {
+        if (fs.existsSync(schemaPath)) {
+            return schemaPath;
+        }
     }
 
-    return schemaPath;
+    // If not found in any location, throw error
+    throw new Error(
+        `Prisma schema not found at:\n${possiblePaths.join('\n')}\n\n` +
+        'Ensure @friggframework/core is installed.'
+    );
 }
 
 /**

package/infrastructure/IAM-POLICY-TEMPLATES.md

@@ -83,27 +83,45 @@ aws cloudformation update-stack \
 For custom policy generation based on your app definition:
 
 ```javascript
-const { generateIAMPolicy, generateIAMCloudFormation } = require('./iam-generator');
+const { generateIAMPolicy, generateIAMCloudFormation, getFeatureSummary } = require('./iam-generator');
 
 // Generate basic JSON policy
 const basicPolicy = generateIAMPolicy('basic');
 
-// Generate full JSON policy  
+// Generate full JSON policy
 const fullPolicy = generateIAMPolicy('full');
 
-// Generate CloudFormation template with auto-detection
-const autoTemplate = generateIAMCloudFormation(appDefinition, { mode: 'auto' });
-
-// Generate CloudFormation template with specific mode
-const basicTemplate = generateIAMCloudFormation(appDefinition, { mode: 'basic' });
-const fullTemplate = generateIAMCloudFormation(appDefinition, { mode: 'full' });
+// Generate CloudFormation template with auto-detected features
+const summary = getFeatureSummary(appDefinition);
+const template = generateIAMCloudFormation({
+    appName: summary.appName,
+    features: summary.features,
+    userPrefix: 'frigg-deployment-user',
+    stackName: 'frigg-deployment-iam'
+});
+
+// Or manually specify features
+const customTemplate = generateIAMCloudFormation({
+    appName: 'my-app',
+    features: {
+        vpc: true,
+        kms: true,
+        ssm: true,
+        websockets: false
+    },
+    userPrefix: 'my-deployment-user',
+    stackName: 'my-deployment-stack'
+});
 ```
 
-### Generator Modes
+### Feature Detection
+
+Use `getFeatureSummary(appDefinition)` to automatically detect features from your app definition:
 
-- **`basic`** - Core permissions only, ignores app definition features
-- **`full`** - All features enabled, ignores app definition features  
-- **`auto`** - Analyzes app definition and enables features as needed (default)
+```javascript
+const summary = getFeatureSummary(appDefinition);
+// Returns: { appName, features: { core, vpc, kms, ssm, websockets }, integrationCount }
+```
 
 ## Security Best Practices
 

package/infrastructure/iam-generator.js

@@ -1,52 +1,31 @@
 const path = require('path');
 
 /**
- * Generate IAM CloudFormation template based on AppDefinition
- * @param {Object} appDefinition - Application definition object
+ * Generate IAM CloudFormation template
  * @param {Object} options - Generation options
- * @param {string} [options.deploymentUserName='frigg-deployment-user'] - IAM user name
+ * @param {string} [options.appName='Frigg'] - Application name
+ * @param {Object} [options.features={}] - Enabled features { vpc, kms, ssm, websockets }
+ * @param {string} [options.userPrefix='frigg-deployment-user'] - IAM user name prefix
  * @param {string} [options.stackName='frigg-deployment-iam'] - CloudFormation stack name
- * @param {string} [options.mode='auto'] - Policy mode: 'basic', 'full', or 'auto' (auto-detect from appDefinition)
  * @returns {string} CloudFormation YAML template
  */
-function generateIAMCloudFormation(appDefinition, options = {}) {
-    const { deploymentUserName = 'frigg-deployment-user', mode = 'auto' } =
-        options;
-
-    // Determine which features are enabled based on mode
-    let features;
-    if (mode === 'basic') {
-        features = {
-            vpc: false,
-            kms: false,
-            ssm: false,
-            websockets: appDefinition.websockets?.enable === true,
-        };
-    } else if (mode === 'full') {
-        features = {
-            vpc: true,
-            kms: true,
-            ssm: true,
-            websockets: appDefinition.websockets?.enable === true,
-        };
-    } else {
-        // mode === 'auto'
-        features = {
-            vpc: appDefinition.vpc?.enable === true,
-            kms:
-                appDefinition.encryption
-                    ?.fieldLevelEncryptionMethod === 'kms',
-            ssm: appDefinition.ssm?.enable === true,
-            websockets: appDefinition.websockets?.enable === true,
-        };
-    }
+function generateIAMCloudFormation(options = {}) {
+    const {
+        appName = 'Frigg',
+        features = {},
+        userPrefix = 'frigg-deployment-user',
+        stackName = 'frigg-deployment-iam'
+    } = options;
+
+    const deploymentUserName = userPrefix;
+
+    // Features are already analyzed by caller (use getFeatureSummary to extract features from appDefinition)
+    // Expected features: { vpc, kms, ssm, websockets }
 
     // Build the CloudFormation template
     const template = {
         AWSTemplateFormatVersion: '2010-09-09',
-        Description: `IAM roles and policies for ${
-            appDefinition.name || 'Frigg'
-        } application deployment pipeline`,
+        Description: `IAM roles and policies for ${appName} application deployment pipeline`,
 
         Parameters: {
             DeploymentUserName: {
@@ -829,6 +808,7 @@ function generateIAMPolicy(mode = 'basic') {
 
 module.exports = {
     generateIAMCloudFormation,
+    generateCloudFormationTemplate: generateIAMCloudFormation, // Alias for generate-command/index.js compatibility
     getFeatureSummary,
     generateBasicIAMPolicy,
     generateFullIAMPolicy,

package/infrastructure/iam-generator.test.js

@@ -51,7 +51,11 @@ describe('IAM Generator', () => {
                 websockets: { enable: false }
             };
 
-            const yaml = generateIAMCloudFormation(appDefinition);
+            const summary = getFeatureSummary(appDefinition);
+            const yaml = generateIAMCloudFormation({
+                appName: summary.appName,
+                features: summary.features
+            });
 
             expect(yaml).toContain('AWSTemplateFormatVersion');
             expect(yaml).toContain('FriggDeploymentUser');
@@ -66,7 +70,11 @@ describe('IAM Generator', () => {
                 vpc: { enable: true }
             };
 
-            const yaml = generateIAMCloudFormation(appDefinition);
+            const summary = getFeatureSummary(appDefinition);
+            const yaml = generateIAMCloudFormation({
+                appName: summary.appName,
+                features: summary.features
+            });
 
             expect(yaml).toContain('FriggVPCPolicy');
             expect(yaml).toContain('CreateVPCPermissions');
@@ -81,7 +89,11 @@ describe('IAM Generator', () => {
                 encryption: { fieldLevelEncryptionMethod: 'kms' }
             };
 
-            const yaml = generateIAMCloudFormation(appDefinition);
+            const summary = getFeatureSummary(appDefinition);
+            const yaml = generateIAMCloudFormation({
+                appName: summary.appName,
+                features: summary.features
+            });
 
             expect(yaml).toContain('FriggKMSPolicy');
             expect(yaml).toContain('CreateKMSPermissions');
@@ -97,7 +109,11 @@ describe('IAM Generator', () => {
                 ssm: { enable: true }
             };
 
-            const yaml = generateIAMCloudFormation(appDefinition);
+            const summary = getFeatureSummary(appDefinition);
+            const yaml = generateIAMCloudFormation({
+                appName: summary.appName,
+                features: summary.features
+            });
 
             expect(yaml).toContain('FriggSSMPolicy');
             expect(yaml).toContain('CreateSSMPermissions');
@@ -113,7 +129,11 @@ describe('IAM Generator', () => {
                 ssm: { enable: true }
             };
 
-            const yaml = generateIAMCloudFormation(appDefinition);
+            const summary = getFeatureSummary(appDefinition);
+            const yaml = generateIAMCloudFormation({
+                appName: summary.appName,
+                features: summary.features
+            });
 
             // Check parameter defaults match the enabled features
             expect(yaml).toContain("Default: 'true'"); // VPC enabled
@@ -127,7 +147,11 @@ describe('IAM Generator', () => {
                 integrations: []
             };
 
-            const yaml = generateIAMCloudFormation(appDefinition);
+            const summary = getFeatureSummary(appDefinition);
+            const yaml = generateIAMCloudFormation({
+                appName: summary.appName,
+                features: summary.features
+            });
 
             // Check for core permissions
             expect(yaml).toContain('cloudformation:CreateStack');
@@ -149,7 +173,11 @@ describe('IAM Generator', () => {
                 integrations: []
             };
 
-            const yaml = generateIAMCloudFormation(appDefinition);
+            const summary = getFeatureSummary(appDefinition);
+            const yaml = generateIAMCloudFormation({
+                appName: summary.appName,
+                features: summary.features
+            });
 
             expect(yaml).toContain('internal-error-queue-*');
         });
@@ -160,7 +188,11 @@ describe('IAM Generator', () => {
                 integrations: []
             };
 
-            const yaml = generateIAMCloudFormation(appDefinition);
+            const summary = getFeatureSummary(appDefinition);
+            const yaml = generateIAMCloudFormation({
+                appName: summary.appName,
+                features: summary.features
+            });
 
             expect(yaml).toContain('Outputs:');
             expect(yaml).toContain('DeploymentUserArn:');

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@friggframework/devtools",
   "prettier": "@friggframework/prettier-config",
-  "version": "2.0.0--canary.395.495dc7d.0",
+  "version": "2.0.0--canary.395.ada1d9d.0",
   "dependencies": {
     "@aws-sdk/client-ec2": "^3.835.0",
     "@aws-sdk/client-kms": "^3.835.0",
@@ -9,8 +9,8 @@
     "@babel/eslint-parser": "^7.18.9",
     "@babel/parser": "^7.25.3",
     "@babel/traverse": "^7.25.3",
-    "@friggframework/schemas": "2.0.0--canary.395.495dc7d.0",
-    "@friggframework/test": "2.0.0--canary.395.495dc7d.0",
+    "@friggframework/schemas": "2.0.0--canary.395.ada1d9d.0",
+    "@friggframework/test": "2.0.0--canary.395.ada1d9d.0",
     "@hapi/boom": "^10.0.1",
     "@inquirer/prompts": "^5.3.8",
     "axios": "^1.7.2",
@@ -32,8 +32,8 @@
     "serverless-http": "^2.7.0"
   },
   "devDependencies": {
-    "@friggframework/eslint-config": "2.0.0--canary.395.495dc7d.0",
-    "@friggframework/prettier-config": "2.0.0--canary.395.495dc7d.0",
+    "@friggframework/eslint-config": "2.0.0--canary.395.ada1d9d.0",
+    "@friggframework/prettier-config": "2.0.0--canary.395.ada1d9d.0",
     "aws-sdk-client-mock": "^4.1.0",
     "aws-sdk-client-mock-jest": "^4.1.0",
     "jest": "^30.1.3",
@@ -68,5 +68,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "495dc7d533e5d12c04e51dc04cb696f372682001"
+  "gitHead": "ada1d9dff6aa44abc366cf9b1c5a2b76b1bb9d6c"
 }

package/frigg-cli/__tests__/utils/command-tester.js

@@ -1,170 +0,0 @@
-const { Command } = require('commander');
-
-/**
- * CommandTester - Utility class for testing CLI commands
- * Provides a fluent interface for setting up mocks and executing commands
- */
-class CommandTester {
-  constructor(commandDefinition) {
-    this.commandDefinition = commandDefinition;
-    this.mocks = new Map();
-    this.originalEnv = process.env;
-    this.capturedLogs = {
-      info: [],
-      error: [],
-      debug: [],
-      warn: []
-    };
-  }
-
-  /**
-   * Set up a mock for a module
-   * @param {string} modulePath - Path to the module to mock
-   * @param {object} implementation - Mock implementation
-   * @returns {CommandTester} - Fluent interface
-   */
-  mock(modulePath, implementation) {
-    this.mocks.set(modulePath, implementation);
-    return this;
-  }
-
-  /**
-   * Set environment variables for the test
-   * @param {object} env - Environment variables to set
-   * @returns {CommandTester} - Fluent interface
-   */
-  withEnv(env) {
-    process.env = { ...process.env, ...env };
-    return this;
-  }
-
-  /**
-   * Capture console output during test execution
-   * @returns {CommandTester} - Fluent interface
-   */
-  captureOutput() {
-    const originalConsole = { ...console };
-    
-    console.log = (...args) => {
-      this.capturedLogs.info.push(args.join(' '));
-      originalConsole.log(...args);
-    };
-    
-    console.error = (...args) => {
-      this.capturedLogs.error.push(args.join(' '));
-      originalConsole.error(...args);
-    };
-    
-    console.warn = (...args) => {
-      this.capturedLogs.warn.push(args.join(' '));
-      originalConsole.warn(...args);
-    };
-    
-    console.debug = (...args) => {
-      this.capturedLogs.debug.push(args.join(' '));
-      originalConsole.debug(...args);
-    };
-    
-    return this;
-  }
-
-  /**
-   * Execute the command with given arguments
-   * @param {string[]} args - Command arguments
-   * @param {object} options - Command options
-   * @returns {Promise<object>} - Execution result
-   */
-  async execute(args = [], options = {}) {
-    // Set up mocks
-    for (const [path, impl] of this.mocks) {
-      jest.mock(path, () => impl, { virtual: true });
-    }
-
-    try {
-      const program = new Command();
-      
-      // Set up the command
-      const cmd = program
-        .command(this.commandDefinition.name)
-        .description(this.commandDefinition.description);
-      
-      // Add options if defined
-      if (this.commandDefinition.options) {
-        this.commandDefinition.options.forEach(option => {
-          cmd.option(option.flags, option.description, option.defaultValue);
-        });
-      }
-      
-      // Add action
-      cmd.action(this.commandDefinition.action);
-      
-      // Mock process.exit to prevent actual exit
-      const originalExit = process.exit;
-      let exitCode = 0;
-      process.exit = (code) => {
-        exitCode = code;
-        throw new Error(`Process exited with code ${code}`);
-      };
-      
-      try {
-        await program.parseAsync(['node', 'cli', ...args]);
-        
-        return {
-          success: true,
-          exitCode: 0,
-          logs: this.capturedLogs,
-          args,
-          options
-        };
-      } catch (error) {
-        if (error.message.includes('Process exited with code')) {
-          return {
-            success: false,
-            exitCode,
-            error: error.message,
-            logs: this.capturedLogs,
-            args,
-            options
-          };
-        }
-        throw error;
-      } finally {
-        process.exit = originalExit;
-      }
-    } finally {
-      // Clean up mocks
-      for (const [path] of this.mocks) {
-        jest.unmock(path);
-      }
-      
-      // Restore environment
-      process.env = this.originalEnv;
-    }
-  }
-
-  /**
-   * Get captured logs
-   * @returns {object} - Captured logs by type
-   */
-  getLogs() {
-    return this.capturedLogs;
-  }
-
-  /**
-   * Reset the tester state
-   * @returns {CommandTester} - Fluent interface
-   */
-  reset() {
-    this.mocks.clear();
-    this.capturedLogs = {
-      info: [],
-      error: [],
-      debug: [],
-      warn: []
-    };
-    process.env = this.originalEnv;
-    return this;
-  }
-}
-
-module.exports = { CommandTester };