@finos/legend-extension-dsl-data-quality 2.0.25 → 2.0.26

package/src/components/DataQualityDataSpaceBuilder.tsx

@@ -17,7 +17,7 @@
 import { observer } from 'mobx-react-lite';
 import { useApplicationStore } from '@finos/legend-application';
 import { useEffect } from 'react';
-import { guaranteeType } from '@finos/legend-shared';
+import { guaranteeNonNullable, guaranteeType } from '@finos/legend-shared';
 import { flowResult } from 'mobx';
 import {
   type Runtime,
@@ -81,7 +81,9 @@ export const DataQualityDataSpaceBuilderSetupPanelContent = observer(
       buildExecutionContextOption,
     );
     const runtimeOptions = getMappingCompatibleRuntimes(
-      dataQualityQueryBuilderState.executionContextState.mapping!,
+      guaranteeNonNullable(
+        dataQualityQueryBuilderState.executionContextState.mapping,
+      ),
       dataQualityState.graphManagerState.usableRuntimes,
     )
       .map(
@@ -98,7 +100,9 @@ export const DataQualityDataSpaceBuilderSetupPanelContent = observer(
       : null;
     const classes = resolveUsableDataSpaceClasses(
       dataSpace,
-      dataQualityQueryBuilderState.executionContextState.mapping!,
+      guaranteeNonNullable(
+        dataQualityQueryBuilderState.executionContextState.mapping,
+      ),
       dataQualityState.graphManagerState,
     );
 

package/src/components/DataQualityMappingAndRuntimeBuilder.tsx

@@ -41,6 +41,7 @@ import {
   buildRuntimeValueOption,
   getRuntimeOptionFormatter,
 } from '@finos/legend-query-builder';
+import { at, guaranteeNonNullable } from '@finos/legend-shared';
 
 export const DataQualityMappingAndRuntimeBuilder = observer(
   (props: { dataQualityState: DataQualityClassValidationState }) => {
@@ -82,15 +83,17 @@ export const DataQualityMappingAndRuntimeBuilder = observer(
       dataQualityState.changeMapping(val.value);
       const runtimeOptions = getRuntimesBasedOnMapping();
       if (runtimeOptions.length) {
-        dataQualityQueryBuilderState.changeRuntime(runtimeOptions[0]!);
+        dataQualityQueryBuilderState.changeRuntime(at(runtimeOptions, 0));
       }
       dataQualityState.updateElementOnMappingChange();
       const classes = getMappingCompatibleClasses(
-        dataQualityQueryBuilderState.executionContextState.mapping!,
+        guaranteeNonNullable(
+          dataQualityQueryBuilderState.executionContextState.mapping,
+        ),
         dataQualityState.graphManagerState.usableClasses,
       );
       if (runtimeOptions.length && classes.length) {
-        dataQualityState.changeClass(classes[0]!);
+        dataQualityState.changeClass(at(classes, 0));
         dataQualityState.updateElementOnClassChange();
       }
     };
@@ -116,7 +119,9 @@ export const DataQualityMappingAndRuntimeBuilder = observer(
 
     const classes = selectedRuntimeOption
       ? getMappingCompatibleClasses(
-          dataQualityQueryBuilderState.executionContextState.mapping!,
+          guaranteeNonNullable(
+            dataQualityQueryBuilderState.executionContextState.mapping,
+          ),
           dataQualityState.graphManagerState.usableClasses,
         )
       : [];

package/src/components/DataQualityResultPanel.tsx

@@ -87,7 +87,9 @@ export const DataQualityResultPanel = observer(
         );
         return;
       }
-      const genericType = new GenericType(queryBuilderState.class!);
+      const genericType = new GenericType(
+        guaranteeNonNullable(queryBuilderState.class),
+      );
       const genericTypeReference =
         GenericTypeExplicitReference.create(genericType);
 

package/src/components/states/DataQualityClassValidationState.ts

@@ -45,7 +45,6 @@ import {
   type GeneratorFn,
   assertType,
   filterByType,
-  getNullableFirstEntry,
   guaranteeNonNullable,
   guaranteeType,
 } from '@finos/legend-shared';
@@ -122,7 +121,9 @@ export class DataQualityClassValidationState extends DataQualityState {
         ),
       );
       classOptions = getMappingCompatibleClasses(
-        this.dataQualityQueryBuilderState.executionContextState.mapping!,
+        guaranteeNonNullable(
+          this.dataQualityQueryBuilderState.executionContextState.mapping,
+        ),
         this.graphManagerState.usableClasses,
       );
     } else if (
@@ -144,7 +145,9 @@ export class DataQualityClassValidationState extends DataQualityState {
       );
       classOptions = resolveUsableDataSpaceClasses(
         this.dataSpace,
-        this.dataQualityQueryBuilderState.executionContextState.mapping!,
+        guaranteeNonNullable(
+          this.dataQualityQueryBuilderState.executionContextState.mapping,
+        ),
         this.graphManagerState,
       );
     }
@@ -159,9 +162,7 @@ export class DataQualityClassValidationState extends DataQualityState {
           .value,
       );
     } else {
-      this.dataQualityQueryBuilderState.setClass(
-        getNullableFirstEntry(classOptions),
-      );
+      this.dataQualityQueryBuilderState.setClass(classOptions[0]);
       this.dataQualityGraphFetchTreeState = new DataQualityGraphFetchTreeState(
         this,
       );
@@ -200,7 +201,9 @@ export class DataQualityClassValidationState extends DataQualityState {
       new MappingAndRuntimeDataQualityExecutionContext();
     mappingAndRuntimeExecutionContext.mapping =
       PackageableElementExplicitReference.create(
-        this.dataQualityQueryBuilderState.executionContextState.mapping!,
+        guaranteeNonNullable(
+          this.dataQualityQueryBuilderState.executionContextState.mapping,
+        ),
       );
     guaranteeNonNullable(
       this.dataQualityQueryBuilderState.executionContextState.runtimeValue,
@@ -248,7 +251,7 @@ export class DataQualityClassValidationState extends DataQualityState {
       new RuntimePointer(executionContext.defaultRuntime),
     );
     const compatibleClasses = resolveUsableDataSpaceClasses(
-      this.dataSpace!,
+      guaranteeNonNullable(this.dataSpace),
       mapping,
       this.graphManagerState,
     );
@@ -258,7 +261,7 @@ export class DataQualityClassValidationState extends DataQualityState {
       !this.dataQualityQueryBuilderState.class ||
       !compatibleClasses.includes(this.dataQualityQueryBuilderState.class)
     ) {
-      const possibleNewClass = getNullableFirstEntry(compatibleClasses);
+      const possibleNewClass = compatibleClasses[0];
       if (possibleNewClass) {
         this.changeClass(possibleNewClass);
       }
@@ -281,7 +284,9 @@ export class DataQualityClassValidationState extends DataQualityState {
       new DataSpaceDataQualityExecutionContext();
     dataSpaceExecutionContext.context = this.executionContext.name;
     dataSpaceExecutionContext.dataSpace =
-      PackageableElementExplicitReference.create(this.dataSpace!);
+      PackageableElementExplicitReference.create(
+        guaranteeNonNullable(this.dataSpace),
+      );
     dataQualityClassValidation_setDataQualityContext(
       this.constraintsConfigurationElement,
       dataSpaceExecutionContext,

package/src/components/states/DataQualityRelationValidationLambdaEditorState.ts

@@ -98,10 +98,13 @@ export class DataQualityRelationValidationLambdaEditorState extends LambdaEditor
     pretty?: boolean | undefined;
     preserveCompilationError?: boolean | undefined;
   }): GeneratorFn<void> {
-    if (!isStubbed_RawLambda(this.relationValidation.rowMapFunction!)) {
+    if (
+      this.relationValidation.rowMapFunction &&
+      !isStubbed_RawLambda(this.relationValidation.rowMapFunction)
+    ) {
       try {
         const lambdas = new Map<string, RawLambda>();
-        lambdas.set(this.lambdaId, this.relationValidation.rowMapFunction!);
+        lambdas.set(this.lambdaId, this.relationValidation.rowMapFunction);
         const isolatedLambdas =
           (yield this.editorStore.graphManagerState.graphManager.lambdasToPureCode(
             lambdas,

package/src/components/states/DataQualityState.ts

@@ -65,6 +65,7 @@ import {
   hashArray,
   isNonNullable,
   assertType,
+  at,
 } from '@finos/legend-shared';
 import { type GenericLegendApplicationStore } from '@finos/legend-application';
 import { DataQualityResultState } from './DataQualityResultState.js';
@@ -296,7 +297,7 @@ export abstract class DataQualityState extends ElementEditorState {
       `Can't build filter state: data quality filter only support lambda`,
     );
     processFilterLambda(
-      compiledValueSpecification.values[0]!,
+      at(compiledValueSpecification.values, 0),
       this.dataQualityQueryBuilderState,
     );
   }
@@ -359,7 +360,7 @@ export abstract class DataQualityState extends ElementEditorState {
       return;
     }
     const genericType = new GenericType(
-      this.dataQualityQueryBuilderState.class!,
+      guaranteeNonNullable(this.dataQualityQueryBuilderState.class),
     );
     const genericTypeReference =
       GenericTypeExplicitReference.create(genericType);
@@ -415,7 +416,7 @@ export abstract class DataQualityState extends ElementEditorState {
     this.resultState = new DataQualityResultState(this);
     this.initializeGraphFetchTreeState(
       buildDefaultDataQualityRootGraphFetchTree(
-        this.dataQualityQueryBuilderState.class!,
+        guaranteeNonNullable(this.dataQualityQueryBuilderState.class),
       ),
     );
     this.updateElementOnClassChange();
@@ -425,7 +426,7 @@ export abstract class DataQualityState extends ElementEditorState {
     dataQualityClassValidation_setDataQualityGraphFetchTree(
       this
         .constraintsConfigurationElement as DataQualityClassValidationsConfiguration,
-      this.dataQualityGraphFetchTreeState.treeData!.tree,
+      guaranteeNonNullable(this.dataQualityGraphFetchTreeState.treeData).tree,
     );
     dataQualityClassValidation_setFilter(
       this

package/src/graph-manager/protocol/pure/v1/transformation/V1_DSL_DataQuality_ValueSpecificationBuilderHelper.ts

@@ -16,6 +16,7 @@
 
 import { V1_DataQualityPropertyGraphFetchTree } from '../model/graphFetch/V1_DataQualityPropertyGraphFetchTree.js';
 import {
+  at,
   guaranteeNonNullable,
   UnsupportedOperationError,
 } from '@finos/legend-shared';
@@ -219,7 +220,7 @@ function transformRootGraphFetchTreeToDataQualityRootGraphFetchTree(
     (_propertyTree, index) =>
       transformGraphFetchTreeToDataQualityGraphFetchTree(
         _propertyTree,
-        V1_rootGraphFetchTree.subTrees[index]!,
+        at(V1_rootGraphFetchTree.subTrees, index),
       ),
   );
   return dataQualityRootGraphFetchTree;
@@ -241,7 +242,7 @@ function transformPropertyGraphFetchTreeToDataQualityPropertyGraphFetchTree(
     propertyGraphFetchTree.subTrees.map((_propertyTree, index) =>
       transformGraphFetchTreeToDataQualityGraphFetchTree(
         _propertyTree,
-        V1_propertyGraphFetchTree.subTrees[index]!,
+        at(V1_propertyGraphFetchTree.subTrees, index),
       ),
     );
   dataQualityPropertyGraphFetchTree.constraints =

package/src/graph-manager/protocol/pure/v1/transformation/V1_DSL_DataQuality_ValueSpecificationTransformer.ts

@@ -29,7 +29,12 @@ import {
   V1_RawValueSpecificationTransformer,
 } from '@finos/legend-graph';
 import { V1_DataQualityRootGraphFetchTree } from '../model/graphFetch/V1_DataQualityRootGraphFetchTree.js';
-import { assertType, UnsupportedOperationError } from '@finos/legend-shared';
+import {
+  assertType,
+  at,
+  guaranteeNonNullable,
+  UnsupportedOperationError,
+} from '@finos/legend-shared';
 import { V1_DataQualityPropertyGraphFetchTree } from '../model/graphFetch/V1_DataQualityPropertyGraphFetchTree.js';
 import {
   DataQualityPropertyGraphFetchTree,
@@ -88,7 +93,7 @@ export function V1_transformGraphFetchTreeToDataQualityGraphFetchTree(
       (subTree, index) =>
         V1_transformGraphFetchTreeToDataQualityGraphFetchTree(
           subTree,
-          graphFetchTree.subTrees[index]!,
+          at(graphFetchTree.subTrees, index),
         ),
     );
     return v1_DataQualityRootGraphFetchTree;
@@ -108,7 +113,7 @@ export function V1_transformGraphFetchTreeToDataQualityGraphFetchTree(
       v1_graphFetchTree.subTrees.map((subTree, index) =>
         V1_transformGraphFetchTreeToDataQualityGraphFetchTree(
           subTree,
-          graphFetchTree.subTrees[index]!,
+          at(graphFetchTree.subTrees, index),
         ),
       );
     return v1_DataQualityPropertyGraphFetchTree;
@@ -124,7 +129,7 @@ export function V1_transformDataQualityExecutionContext(
   if (value instanceof DataSpaceDataQualityExecutionContext) {
     const dataSpaceExecutionContext =
       new V1_DataSpaceDataQualityExecutionContext();
-    dataSpaceExecutionContext.context = value.context!;
+    dataSpaceExecutionContext.context = guaranteeNonNullable(value.context);
     dataSpaceExecutionContext.dataSpace = new V1_PackageableElementPointer(
       DATA_SPACE_ELEMENT_POINTER,
       value.dataSpace.valueForSerialization ?? '',

package/style/_data-quality-relation-validation-builder.scss

@@ -92,7 +92,7 @@
       height: 100%;
       width: 100%;
       padding: 1rem;
-      overflow: overlay;
+      overflow: auto;
     }
   }
 
@@ -109,7 +109,7 @@
     height: 2.8rem;
     z-index: 1;
     display: flex;
-    overflow-x: overlay;
+    overflow-x: auto;
     overflow-y: hidden;
   }
 
@@ -166,7 +166,7 @@
     &__description {
       display: -webkit-box;
       -webkit-box-orient: vertical;
-      -webkit-line-clamp: 2;
+      line-clamp: 2;
       overflow: hidden;
       text-align: left;
       height: calc(100% - 2.8rem);
@@ -180,7 +180,7 @@
     height: 100%;
     width: 100%;
     padding: 1rem;
-    overflow: overlay;
+    overflow: auto;
 
     &__item {
       padding-top: 1rem;