@financial-times/n-myft-ui 23.1.3 → 24.0.0

Sign up to get free protection for your applications and to get access to all the features.
@@ -2,7 +2,6 @@
2
2
  # template: component
3
3
 
4
4
  references:
5
-
6
5
  container_config_node12: &container_config_node12
7
6
  working_directory: ~/project/build
8
7
  docker:
@@ -13,8 +12,7 @@ references:
13
12
  docker:
14
13
  - image: lambci/lambda:build-nodejs12.x
15
14
 
16
- workspace_root: &workspace_root
17
- ~/project
15
+ workspace_root: &workspace_root ~/project
18
16
 
19
17
  attach_workspace: &attach_workspace
20
18
  attach_workspace:
@@ -22,31 +20,31 @@ references:
22
20
 
23
21
  npm_cache_keys: &npm_cache_keys
24
22
  keys:
25
- - v3-dependency-npm-{{ checksum "package.json" }}-
26
- - v3-dependency-npm-{{ checksum "package.json" }}
27
- - v3-dependency-npm-
23
+ - v3-dependency-npm-{{ checksum "package.json" }}-
24
+ - v3-dependency-npm-{{ checksum "package.json" }}
25
+ - v3-dependency-npm-
28
26
 
29
27
  cache_npm_cache: &cache_npm_cache
30
28
  save_cache:
31
- key: v3-dependency-npm-{{ checksum "package.json" }}-{{ epoch }}
32
- paths:
29
+ key: v3-dependency-npm-{{ checksum "package.json" }}-{{ epoch }}
30
+ paths:
33
31
  - ./node_modules/
34
32
 
35
33
  restore_npm_cache: &restore_npm_cache
36
34
  restore_cache:
37
- <<: *npm_cache_keys
35
+ <<: *npm_cache_keys
38
36
 
39
37
  filters_ignore_gh_pages: &filters_ignore_gh_pages
40
38
  branches:
41
39
  ignore: gh_pages
42
40
 
43
- filters_only_master: &filters_only_master
41
+ filters_only_main: &filters_only_main
44
42
  branches:
45
- only: master
43
+ only: main
46
44
 
47
- filters_ignore_master: &filters_ignore_master
45
+ filters_ignore_main: &filters_ignore_main
48
46
  branches:
49
- ignore: master
47
+ ignore: main
50
48
 
51
49
  filters_ignore_tags: &filters_ignore_tags
52
50
  tags:
@@ -62,7 +60,6 @@ references:
62
60
  version: 2
63
61
 
64
62
  jobs:
65
-
66
63
  build:
67
64
  <<: *container_config_node12
68
65
  steps:
@@ -149,7 +146,7 @@ workflows:
149
146
  - build
150
147
  - deploy:
151
148
  filters:
152
- <<: *filters_only_master
149
+ <<: *filters_only_main
153
150
  requires:
154
151
  - build
155
152
  build-test-publish:
@@ -173,7 +170,7 @@ workflows:
173
170
  - schedule:
174
171
  cron: "0 0 * * *"
175
172
  filters:
176
- <<: *filters_only_master
173
+ <<: *filters_only_main
177
174
  jobs:
178
175
  - build:
179
176
  context: next-nightly-build
@@ -11,10 +11,10 @@
11
11
  #
12
12
  # Why we pass the flags we do to `npm install`:
13
13
  #
14
- # --no-package-lock - While we now use package-lock.json
15
- # in our repos, skip package-lock.json in this instance
16
- # as we don't want to accidentally modify the file
17
- # for subsequent steps in the workflow, e.g cache keys
14
+ # --no-package-lock - While we now use package-lock.json
15
+ # in our repos, skip package-lock.json in this instance
16
+ # as we don't want to accidentally modify the file
17
+ # for subsequent steps in the workflow, e.g cache keys
18
18
  # and artefact generation.
19
19
  #
20
20
  # --no-save - We don't want to modify package.json as we
@@ -34,6 +34,7 @@ if [ -e package.json ]; then
34
34
 
35
35
  npm ls --production --parseable 2>&1 >/dev/null | \
36
36
  sed -n -e 's/^npm ERR! peer dep missing: \(.*\),.*/\1/p' | \
37
- xargs -I{} npm install --no-package-lock --no-save "{}"
37
+ xargs -I{} echo -n '"{}" ' | \
38
+ xargs npm install --no-package-lock --no-save
38
39
 
39
40
  fi
@@ -1,7 +1,7 @@
1
1
  _extends: github-apps-config-next
2
2
 
3
3
  branches:
4
- - name: master
4
+ - name: main
5
5
  protection:
6
6
  required_pull_request_reviews: null
7
7
  required_status_checks:
package/.scss-lint.yml CHANGED
@@ -1,7 +1,6 @@
1
1
  linters:
2
-
3
2
  # Documentation:
4
- # https://github.com/causes/scss-lint/blob/master/lib/scss_lint/linter/README.md
3
+ # https://github.com/causes/scss-lint/blob/HEAD/lib/scss_lint/linter/README.md
5
4
 
6
5
  # "value !important;" not "value!important ;"
7
6
  BangFormat:
@@ -262,7 +261,8 @@ linters:
262
261
  enabled: true
263
262
  identifier_list: base
264
263
  additional_identifiers: []
265
- excluded_identifiers: ["user-select", "appearance", "font-smoothing", "osx-font-smoothing"]
264
+ excluded_identifiers:
265
+ ["user-select", "appearance", "font-smoothing", "osx-font-smoothing"]
266
266
  severity: warning
267
267
 
268
268
  # No units on zero values: 0 not 0px
package/Makefile CHANGED
@@ -46,3 +46,4 @@ test:
46
46
  make test-unit
47
47
  make test-build
48
48
  make a11y
49
+ jest
package/README.md CHANGED
@@ -16,22 +16,25 @@ These subdirectories may contain a README. If not, please speak to the myft team
16
16
  n-myft-ui provides the CSS, JS and most templates for the myFT components on FT.com. We use semver to control rollout of the code.
17
17
 
18
18
  As of August 2017, The following apps use n-myft-ui:
19
- * next-front-page
20
- * next-stream-page
21
- * next-article
22
- * next-myft-page
23
- * next-tour-page
24
- * next-video-page
25
- * next-search-page
26
19
 
27
- When you merge to master, you should make a new release and then roll it out to the apps, plus n-topic-card which contains a reference to this so that there aren't missing dependencies.
20
+ - next-front-page
21
+ - next-stream-page
22
+ - next-article
23
+ - next-myft-page
24
+ - next-tour-page
25
+ - next-video-page
26
+ - next-search-page
27
+
28
+ When you merge to main, you should make a new release and then roll it out to the apps, plus n-topic-card which contains a reference to this so that there aren't missing dependencies.
28
29
 
29
30
  If you are making a major change, you will need to update the bower.json and package.json files for the above apps. For minor and patch updates, you can rebuild without cache from CircleCI.
30
31
 
31
32
  ## Running locally
33
+
32
34
  ```
33
35
  make install
34
36
  make build
35
37
  make demo
36
38
  ```
39
+
37
40
  View the demo on `localhost:5005`