@fiado/type-kit 3.59.0 → 3.60.0

package/_test_/unit/cognitoBackofficeConnector/dtos/CreateUserRequest.test.ts

@@ -1,53 +1,53 @@
-import 'reflect-metadata';
-import { plainToInstance } from 'class-transformer';
-import { validate } from 'class-validator';
-import { CreateUserRequest } from '../../../../src/cognitoBackofficeConnector/dtos/CreateUserRequest';
-
-describe('CreateUserRequest', () => {
-    const valid = {
-        userPoolId: 'us-east-1_abc123',
-        region: 'us-east-1',
-        email: 'user@acme.com',
-        tenantId: 'somosfiado',
-    };
-
-    it('valida happy path con tenantId slug (0 errores)', async () => {
-        const dto = plainToInstance(CreateUserRequest, valid);
-        const errors = await validate(dto);
-        expect(errors).toEqual([]);
-    });
-
-    it('acepta un tenantId slug con guiones (acme-mx)', async () => {
-        const dto = plainToInstance(CreateUserRequest, { ...valid, tenantId: 'acme-mx' });
-        const errors = await validate(dto);
-        expect(errors.some(e => e.property === 'tenantId')).toBe(false);
-    });
-
-    it('acepta un tenantId con forma de UUID (sigue siendo string válido)', async () => {
-        const dto = plainToInstance(CreateUserRequest, {
-            ...valid,
-            tenantId: '11111111-1111-1111-1111-111111111111',
-        });
-        const errors = await validate(dto);
-        expect(errors.some(e => e.property === 'tenantId')).toBe(false);
-    });
-
-    it('falla si tenantId está vacío', async () => {
-        const dto = plainToInstance(CreateUserRequest, { ...valid, tenantId: '' });
-        const errors = await validate(dto);
-        expect(errors.some(e => e.property === 'tenantId')).toBe(true);
-    });
-
-    it('preserva los campos opcionales legítimos', async () => {
-        const dto = plainToInstance(CreateUserRequest, {
-            ...valid,
-            displayName: 'Usuario Demo',
-            temporaryPassword: 'Temp1234!',
-            suppressInvitationEmail: true,
-        });
-        const errors = await validate(dto);
-        expect(errors).toEqual([]);
-        expect(dto.displayName).toBe('Usuario Demo');
-        expect(dto.suppressInvitationEmail).toBe(true);
-    });
-});
+import 'reflect-metadata';
+import { plainToInstance } from 'class-transformer';
+import { validate } from 'class-validator';
+import { CreateUserRequest } from '../../../../src/cognitoBackofficeConnector/dtos/CreateUserRequest';
+
+describe('CreateUserRequest', () => {
+    const valid = {
+        userPoolId: 'us-east-1_abc123',
+        region: 'us-east-1',
+        email: 'user@acme.com',
+        tenantId: 'somosfiado',
+    };
+
+    it('valida happy path con tenantId slug (0 errores)', async () => {
+        const dto = plainToInstance(CreateUserRequest, valid);
+        const errors = await validate(dto);
+        expect(errors).toEqual([]);
+    });
+
+    it('acepta un tenantId slug con guiones (acme-mx)', async () => {
+        const dto = plainToInstance(CreateUserRequest, { ...valid, tenantId: 'acme-mx' });
+        const errors = await validate(dto);
+        expect(errors.some(e => e.property === 'tenantId')).toBe(false);
+    });
+
+    it('acepta un tenantId con forma de UUID (sigue siendo string válido)', async () => {
+        const dto = plainToInstance(CreateUserRequest, {
+            ...valid,
+            tenantId: '11111111-1111-1111-1111-111111111111',
+        });
+        const errors = await validate(dto);
+        expect(errors.some(e => e.property === 'tenantId')).toBe(false);
+    });
+
+    it('falla si tenantId está vacío', async () => {
+        const dto = plainToInstance(CreateUserRequest, { ...valid, tenantId: '' });
+        const errors = await validate(dto);
+        expect(errors.some(e => e.property === 'tenantId')).toBe(true);
+    });
+
+    it('preserva los campos opcionales legítimos', async () => {
+        const dto = plainToInstance(CreateUserRequest, {
+            ...valid,
+            displayName: 'Usuario Demo',
+            temporaryPassword: 'Temp1234!',
+            suppressInvitationEmail: true,
+        });
+        const errors = await validate(dto);
+        expect(errors).toEqual([]);
+        expect(dto.displayName).toBe('Usuario Demo');
+        expect(dto.suppressInvitationEmail).toBe(true);
+    });
+});

package/_test_/unit/cognitoBackofficeConnector/dtos/VerifyPasswordResponse.test.ts

@@ -1,32 +1,32 @@
-import 'reflect-metadata';
-import { plainToInstance } from 'class-transformer';
-import { validate } from 'class-validator';
-import { VerifyPasswordResponse } from '../../../../src/cognitoBackofficeConnector/dtos/VerifyPasswordResponse';
-import { CognitoChallengeType } from '../../../../src/cognitoBackofficeConnector/enums/CognitoChallengeType';
-
-describe('VerifyPasswordResponse', () => {
-    it('solo valid (backward-compatible)', async () => {
-        const dto = plainToInstance(VerifyPasswordResponse, { valid: true });
-        expect(await validate(dto)).toEqual([]);
-    });
-
-    it('valid + challenge nativo NEW_PASSWORD_REQUIRED + session', async () => {
-        const dto = plainToInstance(VerifyPasswordResponse, {
-            valid: true,
-            challengeType: CognitoChallengeType.NEW_PASSWORD_REQUIRED,
-            session: 'sess-123',
-            challengeParameters: { USER_ID_FOR_SRP: 'sub' },
-        });
-        expect(await validate(dto)).toEqual([]);
-    });
-
-    it('falla si challengeType no es del enum', async () => {
-        const dto = plainToInstance(VerifyPasswordResponse, { valid: true, challengeType: 'BOGUS' });
-        expect((await validate(dto)).some(e => e.property === 'challengeType')).toBe(true);
-    });
-
-    it('falla si valid no es boolean', async () => {
-        const dto = plainToInstance(VerifyPasswordResponse, { valid: 'yes' });
-        expect((await validate(dto)).some(e => e.property === 'valid')).toBe(true);
-    });
-});
+import 'reflect-metadata';
+import { plainToInstance } from 'class-transformer';
+import { validate } from 'class-validator';
+import { VerifyPasswordResponse } from '../../../../src/cognitoBackofficeConnector/dtos/VerifyPasswordResponse';
+import { CognitoChallengeType } from '../../../../src/cognitoBackofficeConnector/enums/CognitoChallengeType';
+
+describe('VerifyPasswordResponse', () => {
+    it('solo valid (backward-compatible)', async () => {
+        const dto = plainToInstance(VerifyPasswordResponse, { valid: true });
+        expect(await validate(dto)).toEqual([]);
+    });
+
+    it('valid + challenge nativo NEW_PASSWORD_REQUIRED + session', async () => {
+        const dto = plainToInstance(VerifyPasswordResponse, {
+            valid: true,
+            challengeType: CognitoChallengeType.NEW_PASSWORD_REQUIRED,
+            session: 'sess-123',
+            challengeParameters: { USER_ID_FOR_SRP: 'sub' },
+        });
+        expect(await validate(dto)).toEqual([]);
+    });
+
+    it('falla si challengeType no es del enum', async () => {
+        const dto = plainToInstance(VerifyPasswordResponse, { valid: true, challengeType: 'BOGUS' });
+        expect((await validate(dto)).some(e => e.property === 'challengeType')).toBe(true);
+    });
+
+    it('falla si valid no es boolean', async () => {
+        const dto = plainToInstance(VerifyPasswordResponse, { valid: 'yes' });
+        expect((await validate(dto)).some(e => e.property === 'valid')).toBe(true);
+    });
+});

package/bin/messagesConnector/dtos/VerifyOtpRequest.js

@@ -17,7 +17,8 @@ class VerifyOtpRequest {
 exports.VerifyOtpRequest = VerifyOtpRequest;
 __decorate([
     (0, class_transformer_1.Expose)(),
-    (0, class_validator_1.IsUUID)(),
+    (0, class_validator_1.IsString)(),
+    (0, class_validator_1.IsNotEmpty)(),
     __metadata("design:type", String)
 ], VerifyOtpRequest.prototype, "directoryId", void 0);
 __decorate([

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fiado/type-kit",
-  "version": "3.59.0",
+  "version": "3.60.0",
   "description": "",
   "main": "bin/index.js",
   "types": "bin/index.d.ts",

package/src/cognitoBackofficeConnector/dtos/VerifyPasswordResponse.ts

@@ -1,24 +1,24 @@
-import { Expose } from 'class-transformer';
-import { IsBoolean, IsEnum, IsObject, IsOptional, IsString } from 'class-validator';
-import { CognitoChallengeType } from '../enums/CognitoChallengeType';
-
-/**
- * Respuesta de `POST /auth/verify-password`.
- *
- * `valid` es el único campo siempre presente (consumidores legacy hacen
- * `const { valid } = ...`). Los campos opcionales surfacean el challenge nativo
- * que `ADMIN_USER_PASSWORD_AUTH` devuelve sin throw: para un usuario en
- * `FORCE_CHANGE_PASSWORD`, Cognito responde `ChallengeName:'NEW_PASSWORD_REQUIRED'`
- * + `Session`, y el caller (rbac) los usa para emitir ese challenge nativo FUERA
- * de CUSTOM_AUTH en vez de arrancar el MFA (F-12). Backward-compatible: todos los
- * campos nuevos son opcionales.
- */
-export class VerifyPasswordResponse {
-    @Expose() @IsBoolean() valid!: boolean;
-
-    @Expose() @IsOptional() @IsEnum(CognitoChallengeType) challengeType?: CognitoChallengeType;
-
-    @Expose() @IsOptional() @IsString() session?: string;
-
-    @Expose() @IsOptional() @IsObject() challengeParameters?: Record<string, string>;
-}
+import { Expose } from 'class-transformer';
+import { IsBoolean, IsEnum, IsObject, IsOptional, IsString } from 'class-validator';
+import { CognitoChallengeType } from '../enums/CognitoChallengeType';
+
+/**
+ * Respuesta de `POST /auth/verify-password`.
+ *
+ * `valid` es el único campo siempre presente (consumidores legacy hacen
+ * `const { valid } = ...`). Los campos opcionales surfacean el challenge nativo
+ * que `ADMIN_USER_PASSWORD_AUTH` devuelve sin throw: para un usuario en
+ * `FORCE_CHANGE_PASSWORD`, Cognito responde `ChallengeName:'NEW_PASSWORD_REQUIRED'`
+ * + `Session`, y el caller (rbac) los usa para emitir ese challenge nativo FUERA
+ * de CUSTOM_AUTH en vez de arrancar el MFA (F-12). Backward-compatible: todos los
+ * campos nuevos son opcionales.
+ */
+export class VerifyPasswordResponse {
+    @Expose() @IsBoolean() valid!: boolean;
+
+    @Expose() @IsOptional() @IsEnum(CognitoChallengeType) challengeType?: CognitoChallengeType;
+
+    @Expose() @IsOptional() @IsString() session?: string;
+
+    @Expose() @IsOptional() @IsObject() challengeParameters?: Record<string, string>;
+}

package/src/messagesConnector/dtos/VerifyOtpRequest.ts

@@ -1,8 +1,12 @@
 import { Expose } from 'class-transformer';
-import { IsNotEmpty, IsString, IsUUID } from 'class-validator';
+import { IsNotEmpty, IsString } from 'class-validator';
 
 export class VerifyOtpRequest {
-    @Expose() @IsUUID() directoryId!: string;
+    // directoryId NO se valida como @IsUUID: los cognitoSub de los pools backoffice son UUID v7
+    // (nibble de versión = 7), que class-validator @IsUUID() (v1-5) rechaza → el verify de OTP
+    // tiraba 400 "directoryId must be a UUID" para TODOS esos users. El SEND
+    // (NotificationQueueMessageRequestV2.directoryId) ya usa @IsString — esto lo deja consistente.
+    @Expose() @IsString() @IsNotEmpty() directoryId!: string;
     @Expose() @IsString() @IsNotEmpty() typeOfDirectoryId!: string;
     @Expose() @IsString() @IsNotEmpty() message!: string;
 }