@envoy/envoy-integrations-sdk 1.3.1 → 1.3.3

package/index.js

@@ -11,6 +11,7 @@ const HttpStatus = require('./lib/HttpStatus');
 const middleware = require('./lib/middleware');
 const errorMiddleware = require('./lib/errorMiddleware');
 const asyncHandler = require('./lib/asyncHandler');
+const createAxiosClient = require('./lib/axios');
 
 /**
  * @typedef {Object} Envoy
@@ -44,4 +45,5 @@ module.exports = {
   middleware,
   errorMiddleware,
   asyncHandler,
+  createAxiosClient,
 };

package/lib/axios.js

@@ -1,23 +1,26 @@
 const { AxiosError } = require('axios');
 const axios = require('axios');
 
-function createClient(config) {
+function createAxiosClient(config) {
     const client = axios.create(config);
     client.interceptors.response.use(
         (response) => {
            return response 
         },
         (error) => {
-            // if the response class type is AxiosError, scrub config fields containing sensitive data
-            if (error instanceof AxiosError) {
-                delete error.config.headers;
-                delete error.config.proxy;
+            const safeError = {
+                code: error.code,
+                message: error.message,
+                name: error.name,
+                baseURL: error.request?.baseURL ?? error.config?.baseURL,
+                url: error.request?.url ?? error.config?.url,
+                method: error.request?.method ?? error.config?.method,
             }
-            return Promise.reject(error);
+            return Promise.reject(safeError);
         },
     );
 
     return client;
 }
 
-module.exports = createClient;
+module.exports = createAxiosClient;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@envoy/envoy-integrations-sdk",
-  "version": "1.3.1",
+  "version": "1.3.3",
   "description": "",
   "main": "index.js",
   "scripts": {

package/test/axios.test.js

@@ -1,5 +1,5 @@
 const axios = require('axios');
-const createClient = require('../lib/axios')
+const createClient = require('../lib/axios');
 
 describe('axios', () => {
     it('default client should leak credentials in AxiosError', async () => {
@@ -18,8 +18,7 @@ describe('axios', () => {
         try {
             await client.get('http://localhost:3000/axios-error');
         } catch (error) {
-            expect(error.config.headers).toBeDefined();
-            expect(error.config.proxy).toBeDefined();
+            expect(error.config).toBeDefined();
             const errorStr = JSON.stringify(error);
             expect(errorStr).toContain('Bearer 1234');
             expect(errorStr).toContain('myWhackyUsername');
@@ -43,8 +42,12 @@ describe('axios', () => {
         try {
             await client.get('http://localhost:3000/axios-error');
         } catch (error) {
-            expect(error.config.headers).toBeUndefined();
-            expect(error.config.proxy).toBeUndefined();
+            expect(error.config).toBeUndefined();
+            expect(error.code).toBe('ECONNREFUSED');
+            expect(error.message).toBe('connect ECONNREFUSED 127.0.0.1:80');
+            expect(error.name).toBe('Error');
+            expect(error.url).toBe('http://localhost:3000/axios-error');
+            expect(error.method).toBe('get');
             const errorStr = JSON.stringify(error);
             expect(errorStr).not.toContain('Bearer 1234');
             expect(errorStr).not.toContain('myWhackyUsername');