@domternal/extension-block-menu 0.7.0 → 0.7.2

package/dist/index.d.cts

@@ -242,14 +242,14 @@ interface BlockHandleOptions {
      */
     nestThreshold?: number;
     /**
-     * Show a custom drop indicator line during drag-from-handle that
-     * mirrors EXACTLY where the drop will land. Replaces the need for
-     * `prosemirror-dropcursor` for our drag flow - `dropcursor` uses
-     * PM's default `posAtCoords` which can disagree with our resolver
-     * (especially in side-gutter / inter-block-gap drops).
-     *
-     * Set to `false` if you want the standard `prosemirror-dropcursor`
-     * behaviour or are providing your own indicator.
+     * Custom drop indicator that mirrors exactly where a handle-drag will
+     * land. Replaces `prosemirror-dropcursor` for handle drags (PM's
+     * `posAtCoords` can disagree with our resolver in the side gutter /
+     * inter-block gap). While dragging, the editor gets a
+     * `dm-block-handle-dragging` class so the theme can hide the native
+     * `.prosemirror-dropcursor-block`/`-inline` for this drag only;
+     * non-handle drags (text selection, external file drops) keep the
+     * native cursor. Set to `false` to use the native dropcursor instead.
      * @default true
      */
     dropIndicator?: boolean;

package/dist/index.d.ts

@@ -242,14 +242,14 @@ interface BlockHandleOptions {
      */
     nestThreshold?: number;
     /**
-     * Show a custom drop indicator line during drag-from-handle that
-     * mirrors EXACTLY where the drop will land. Replaces the need for
-     * `prosemirror-dropcursor` for our drag flow - `dropcursor` uses
-     * PM's default `posAtCoords` which can disagree with our resolver
-     * (especially in side-gutter / inter-block-gap drops).
-     *
-     * Set to `false` if you want the standard `prosemirror-dropcursor`
-     * behaviour or are providing your own indicator.
+     * Custom drop indicator that mirrors exactly where a handle-drag will
+     * land. Replaces `prosemirror-dropcursor` for handle drags (PM's
+     * `posAtCoords` can disagree with our resolver in the side gutter /
+     * inter-block gap). While dragging, the editor gets a
+     * `dm-block-handle-dragging` class so the theme can hide the native
+     * `.prosemirror-dropcursor-block`/`-inline` for this drag only;
+     * non-handle drags (text selection, external file drops) keep the
+     * native cursor. Set to `false` to use the native dropcursor instead.
      * @default true
      */
     dropIndicator?: boolean;

package/dist/index.js

@@ -115,6 +115,11 @@ function createFloatingMenuPlugin(options) {
     cleanupFloating = null;
     element.removeAttribute("data-show");
   };
+  const clearTriggeredFlag = (view) => {
+    if (!requireExplicitTrigger) return;
+    const triggered = pluginKey.getState(view.state)?.triggered ?? false;
+    if (triggered) view.dispatch(view.state.tr.setMeta(FLOATING_MENU_META, "hide"));
+  };
   const focusFirstItem = () => {
     const first = element.querySelector('[data-floating-menu-item]:not([aria-disabled="true"])') ?? element.querySelector('button, [tabindex]:not([tabindex="-1"])');
     if (!first) return false;
@@ -164,12 +169,7 @@ function createFloatingMenuPlugin(options) {
       }
       const dismiss = () => {
         hideMenu();
-        if (requireExplicitTrigger) {
-          const triggered = pluginKey.getState(editor.view.state)?.triggered ?? false;
-          if (triggered) {
-            editor.view.dispatch(editor.view.state.tr.setMeta(FLOATING_MENU_META, "hide"));
-          }
-        }
+        clearTriggeredFlag(editor.view);
       };
       const onFocus = () => {
         if (isVisibleNow(editor.view)) updatePosition(editor.view);
@@ -202,12 +202,7 @@ function createFloatingMenuPlugin(options) {
           if (isVisibleNow(view)) updatePosition(view);
           else {
             hideMenu();
-            if (requireExplicitTrigger) {
-              const triggered = pluginKey.getState(view.state)?.triggered ?? false;
-              if (triggered) {
-                view.dispatch(view.state.tr.setMeta(FLOATING_MENU_META, "hide"));
-              }
-            }
+            clearTriggeredFlag(view);
           }
         },
         destroy: () => {
@@ -1165,6 +1160,7 @@ function createBlockHandlePlugin(options) {
     }, 0);
     startAutoScroll();
     startDragListeners();
+    if (dropIndicator) editorEl?.classList.add("dm-block-handle-dragging");
   };
   const teardownDragPreview = () => {
     if (dragPreview) {
@@ -1181,6 +1177,7 @@ function createBlockHandlePlugin(options) {
     hideDropIndicator();
     teardownDragPreview();
     releaseDragPress();
+    editorEl?.classList.remove("dm-block-handle-dragging");
   };
   return new Plugin({
     key: pluginKey,
@@ -1276,6 +1273,7 @@ function createBlockHandlePlugin(options) {
           dragBtn.removeEventListener("dragstart", onDragStart);
           dragBtn.removeEventListener("dragend", onDragEnd);
           editorEl?.classList.remove("dm-editor--has-block-handle");
+          editorEl?.classList.remove("dm-block-handle-dragging");
           root.remove();
           editorEl = null;
           hoverEl = null;
@@ -1816,11 +1814,9 @@ function createBlockContextMenuPlugin(options) {
     editorEl.dispatchEvent(new Event("dm:dismiss-overlays", { bubbles: false }));
     root.setAttribute("data-show", "");
     lockScroll();
-    {
-      const tr = editor.view.state.tr.setMeta(pluginKey, { activeBlockPos: detail.blockPos });
-      tr.setMeta("addToHistory", false);
-      editor.view.dispatch(tr);
-    }
+    const openTr = editor.view.state.tr.setMeta(pluginKey, { activeBlockPos: detail.blockPos });
+    openTr.setMeta("addToHistory", false);
+    editor.view.dispatch(openTr);
     cleanupFloating?.();
     let anchorEl = detail.anchorElement;
     const bubbleMenuRef = anchorEl.closest(".dm-bubble-menu");