@commercetools-frontend/eslint-config-mc-app 20.8.0 → 20.10.6

package/CHANGELOG.md

@@ -1,5 +1,78 @@
 # @commercetools-frontend/eslint-config-mc-app
 
+## 20.10.6
+
+### Patch Changes
+
+- [#2386](https://github.com/commercetools/merchant-center-application-kit/pull/2386) [`d7fcf6fc`](https://github.com/commercetools/merchant-center-application-kit/commit/d7fcf6fc8495d4eae68e0a4f4c1f1b3e0e394454) Thanks [@emmenko](https://github.com/emmenko)! - Upgrade to Yarn v3
+
+## 20.10.1
+
+### Patch Changes
+
+- [#2356](https://github.com/commercetools/merchant-center-application-kit/pull/2356) [`e34fe076`](https://github.com/commercetools/merchant-center-application-kit/commit/e34fe076aab6681cdcc54622d84123f2c22020e6) Thanks [@ByronDWall](https://github.com/ByronDWall)! - set node version to 16.8 in nvmrc to avoid a bug in node/v8
+
+## 20.9.3
+
+### Patch Changes
+
+- [#2318](https://github.com/commercetools/merchant-center-application-kit/pull/2318) [`83f2add2`](https://github.com/commercetools/merchant-center-application-kit/commit/83f2add2a56ba6696c51fd930a0a1dadbf36c134) Thanks [@renovate](https://github.com/apps/renovate)! - Update all dependencies
+
+## 20.9.0
+
+### Minor Changes
+
+- [#2317](https://github.com/commercetools/merchant-center-application-kit/pull/2317) [`487fcca6`](https://github.com/commercetools/merchant-center-application-kit/commit/487fcca6bcc03a4df59830e5204ca89cc5395df4) Thanks [@emmenko](https://github.com/emmenko)! - Add support for defining the Custom Application config as JS files.
+
+  Until now a Custom Application config file had to be defined as a JSON file with one of the following names:
+
+  - `.custom-application-configrc`
+  - `.custom-application-config.json`
+  - `custom-application-config.json`
+
+  On top of that, we built some "syntax features" to allow [variable placeholders](https://docs.commercetools.com/custom-applications/development/application-config#using-variable-placeholders) as a way to inject dynamic information into the static configuration file.
+
+  However, there are still some use cases where the information you need to provide must be imported from another file, for example a constants file or something similar.
+
+  To support such use cases, we now allow additional JS files to be used as a Custom Application config, specifically the following file extensions:
+
+  - `.js`
+  - `.cjs`
+  - `.mjs`
+  - `.ts`
+
+  The file must obviously return the configuration object.
+
+  > NOTE that you can still use variable placeholders.
+
+  For example:
+
+  ```js
+  // constants.js
+  const entryPointUriPath = 'test';
+  module.exports = { entryPointUriPath };
+
+  // custom-application-config.js
+  const { entryPointUriPath } = require('./constants');
+
+  const name = 'Test application';
+
+  /**
+   * @type {import('@commercetools-frontend/application-config').ConfigOptions}
+   */
+  const config = {
+    name,
+    cloudIdentifier: 'gcp-eu',
+    entryPointUriPath,
+    env: {
+      production: {
+        url: '${env:APP_URL}',
+      },
+    },
+  };
+  module.exports = config;
+  ```
+
 ## 20.8.0
 
 ### Patch Changes

package/index.js

@@ -1,6 +1,9 @@
 const { statusCode, allSupportedExtensions } = require('./helpers/eslint');
 const hasJsxRuntime = require('./helpers/has-jsx-runtime');
 
+/**
+ * @type {import("eslint").Linter.Config}
+ */
 module.exports = {
   extends: [
     // https://github.com/facebook/create-react-app/tree/master/packages/eslint-config-react-app
@@ -30,7 +33,7 @@ module.exports = {
   ],
   rules: {
     // NOTE: The regular rule does not support do-expressions. The equivalent rule of babel does.
-    'no-unused-expressions': 0,
+    'no-unused-expressions': statusCode.off,
 
     // Imports
     'import/extensions': [
@@ -110,7 +113,7 @@ module.exports = {
         '@typescript-eslint/ban-ts-comment': statusCode.off,
         '@typescript-eslint/explicit-function-return-type': statusCode.off,
         '@typescript-eslint/explicit-member-accessibility': [
-          2,
+          statusCode.error,
           { accessibility: 'no-public' },
         ],
         '@typescript-eslint/no-require-imports': statusCode.off,
@@ -136,5 +139,14 @@ module.exports = {
         },
       },
     },
+    {
+      files: [
+        '.custom-application-config.{js,cjs,mjs,ts}',
+        'custom-application-config.{js,cjs,mjs,ts}',
+      ],
+      rules: {
+        'no-template-curly-in-string': statusCode.off,
+      },
+    },
   ],
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@commercetools-frontend/eslint-config-mc-app",
-  "version": "20.8.0",
+  "version": "20.10.6",
   "description": "ESLint config used by a Custom Application.",
   "bugs": "https://github.com/commercetools/merchant-center-application-kit/issues",
   "repository": {
@@ -11,11 +11,9 @@
   "homepage": "https://docs.commercetools.com/custom-applications",
   "keywords": ["javascript", "frontend", "react", "toolkit", "eslint"],
   "license": "MIT",
-  "private": false,
   "publishConfig": {
     "access": "public"
   },
-  "scripts": {},
   "dependencies": {
     "@typescript-eslint/eslint-plugin": "^4.14.0",
     "@typescript-eslint/parser": "^4.14.0",
@@ -39,6 +37,6 @@
     "eslint": ">=7.0.0"
   },
   "devDependencies": {
-    "eslint": "7.31.0"
+    "eslint": "7.32.0"
   }
 }