@codingame/monaco-vscode-api 31.0.1 → 32.0.0

package/vscode/src/vs/platform/actionWidget/browser/actionList.js

@@ -92,7 +92,9 @@ let ActionItemRenderer = class ActionItemRenderer {
         _onRemoveItem,
         _onShowSubmenu,
         _hasAnySubmenuActions,
+        _groupTitleByIndex,
         _linkHandler,
+        _hideDefaultKeybindingTooltip,
         _keybindingService,
         _openerService
     ) {
@@ -100,7 +102,9 @@ let ActionItemRenderer = class ActionItemRenderer {
         this._onRemoveItem = _onRemoveItem;
         this._onShowSubmenu = _onShowSubmenu;
         this._hasAnySubmenuActions = _hasAnySubmenuActions;
+        this._groupTitleByIndex = _groupTitleByIndex;
         this._linkHandler = _linkHandler;
+        this._hideDefaultKeybindingTooltip = _hideDefaultKeybindingTooltip;
         this._keybindingService = _keybindingService;
         this._openerService = _openerService;
     }
@@ -118,6 +122,12 @@ let ActionItemRenderer = class ActionItemRenderer {
         const description = createElement("span");
         description.className = "description";
         container.append(description);
+        const groupTitle = createElement("span");
+        groupTitle.className = "group-title";
+        container.append(groupTitle);
+        const detail = createElement("span");
+        detail.className = "detail";
+        container.append(detail);
         const keybinding = ( new KeybindingLabel(container, OS));
         const toolbar = createElement("div");
         toolbar.className = "action-list-item-toolbar";
@@ -130,8 +140,10 @@ let ActionItemRenderer = class ActionItemRenderer {
             container,
             icon,
             text,
+            detail,
             badge,
             description,
+            groupTitle,
             keybinding,
             toolbar,
             submenuIndicator,
@@ -204,6 +216,21 @@ let ActionItemRenderer = class ActionItemRenderer {
             data.description.textContent = "";
             data.description.style.display = "none";
         }
+        const groupTitleText = this._groupTitleByIndex.get(_index);
+        if (groupTitleText) {
+            data.groupTitle.textContent = groupTitleText;
+            data.groupTitle.style.display = "";
+        } else {
+            data.groupTitle.textContent = "";
+            data.groupTitle.style.display = "none";
+        }
+        if (element.detail) {
+            data.detail.textContent = stripNewlines(element.detail);
+            data.detail.style.display = "";
+        } else {
+            data.detail.textContent = "";
+            data.detail.style.display = "none";
+        }
         const actionTitle = this._keybindingService.lookupKeybinding(acceptSelectedActionCommand)?.getLabel();
         const previewTitle = this._keybindingService.lookupKeybinding(previewSelectedActionCommand)?.getLabel();
         data.container.classList.toggle("option-disabled", !!element.disabled);
@@ -213,11 +240,13 @@ let ActionItemRenderer = class ActionItemRenderer {
             data.container.title = element.tooltip;
         } else if (element.disabled) {
             data.container.title = element.label;
+        } else if (this._hideDefaultKeybindingTooltip) {
+            data.container.title = "";
         } else if (actionTitle && previewTitle) {
             if (this._supportsPreview && element.canPreview) {
-                data.container.title = ( localize(1778, "{0} to Apply, {1} to Preview", actionTitle, previewTitle));
+                data.container.title = ( localize(1790, "{0} to Apply, {1} to Preview", actionTitle, previewTitle));
             } else {
-                data.container.title = ( localize(1779, "{0} to Apply", actionTitle));
+                data.container.title = ( localize(1791, "{0} to Apply", actionTitle));
             }
         } else {
             data.container.title = "";
@@ -227,10 +256,10 @@ let ActionItemRenderer = class ActionItemRenderer {
         if (element.onRemove) {
             toolbarActions.push(toAction({
                 id: "actionList.remove",
-                label: ( localize(1780, "Remove")),
+                label: ( localize(1792, "Remove")),
                 class: ThemeIcon.asClassName(Codicon.close),
-                run: () => {
-                    element.onRemove();
+                run: async () => {
+                    await element.onRemove();
                     this._onRemoveItem?.(element);
                 }
             }));
@@ -268,7 +297,7 @@ let ActionItemRenderer = class ActionItemRenderer {
         templateData.elementDisposables.dispose();
     }
 };
-ActionItemRenderer = ( __decorate([( __param(5, IKeybindingService)), ( __param(6, IOpenerService))], ActionItemRenderer));
+ActionItemRenderer = ( __decorate([( __param(7, IKeybindingService)), ( __param(8, IOpenerService))], ActionItemRenderer));
 class AcceptSelectedEvent extends UIEvent {
     constructor() {
         super("acceptSelectedAction");
@@ -303,7 +332,6 @@ let ActionListWidget = ActionListWidget_1 = class ActionListWidget extends Dispo
         this._keybindingService = _keybindingService;
         this._openerService = _openerService;
         this._instantiationService = _instantiationService;
-        this._baseLineHeight = 24;
         this._headerLineHeight = 24;
         this._separatorLineHeight = 8;
         this.cts = this._register(( new CancellationTokenSource()));
@@ -313,14 +341,15 @@ let ActionListWidget = ActionListWidget_1 = class ActionListWidget extends Dispo
         this._suppressHover = false;
         this._hasLaidOut = false;
         this._filterCts = this._register(( new MutableDisposable()));
+        this._groupTitleByIndex = ( new Map());
         this._onDidRequestLayout = this._register(( new Emitter()));
         this.onDidRequestLayout = this._onDidRequestLayout.event;
         this.domNode = createElement("div");
         this.domNode.classList.add("actionList");
-        if (this._options?.descriptionBelow) {
-            this.domNode.classList.add("description-below");
+        if (this._options?.inlineDescription) {
+            this.domNode.classList.add("inline-description");
         }
-        this._actionLineHeight = this._options?.descriptionBelow ? 48 : 24;
+        this._actionLineHeight = 24;
         this._submenuContainer = createElement("div");
         this._submenuContainer.className = "action-list-submenu-panel action-widget";
         this._submenuContainer.style.display = "none";
@@ -353,7 +382,9 @@ let ActionListWidget = ActionListWidget_1 = class ActionListWidget extends Dispo
             item => this._removeItem(item),
             item => this._showSubmenuForItem(item),
             hasAnySubmenuActions,
+            this._groupTitleByIndex,
             this._options?.linkHandler,
+            this._options?.hideDefaultKeybindingTooltip ?? false,
             this._keybindingService,
             this._openerService
         )), ( new HeaderRenderer()), ( new SeparatorRenderer())], {
@@ -366,21 +397,27 @@ let ActionListWidget = ActionListWidget_1 = class ActionListWidget extends Dispo
                 getAriaLabel: element => {
                     if (element.kind === ActionListItemKind.Action) {
                         let label = element.label ? stripNewlines(element?.label) : "";
+                        if (element.detail) {
+                            label = label + ", " + stripNewlines(element.detail);
+                        }
                         if (element.description) {
                             const descText = typeof element.description === "string" ? element.description : element.description.value;
                             label = label + ", " + stripNewlines(descText);
                         }
+                        if (element.group?.title) {
+                            label = label + ", " + element.group.title;
+                        }
                         if (element.disabled) {
-                            label = ( localize(1781, "{0}, Disabled Reason: {1}", label, element.disabled));
+                            label = ( localize(1793, "{0}, Disabled Reason: {1}", label, element.disabled));
                         }
                         if (element.submenuActions?.length) {
-                            label = ( localize(1782, "{0}, use right arrow to access options", label));
+                            label = ( localize(1794, "{0}, use right arrow to access options", label));
                         }
                         return label;
                     }
                     return null;
                 },
-                getWidgetAriaLabel: () => ( localize(1783, "Action Widget")),
+                getWidgetAriaLabel: () => ( localize(1795, "Action Widget")),
                 getRole: e => {
                     switch (e.kind) {
                     case ActionListItemKind.Action:
@@ -401,29 +438,40 @@ let ActionListWidget = ActionListWidget_1 = class ActionListWidget extends Dispo
         this._register(this._list.onDidChangeFocus(() => this.onFocus()));
         this._register(this._list.onDidChangeSelection(e => this.onListSelection(e)));
         this._allMenuItems = [...items];
-        if (this._options?.showFilter) {
+        if (this._options?.showFilter || this._options?.secondaryHeading) {
             this._filterContainer = createElement("div");
             this._filterContainer.className = "action-list-filter";
             const filterRow = append(this._filterContainer, $(".action-list-filter-row"));
-            this._filterInput = createElement("input");
-            this._filterInput.type = "text";
-            this._filterInput.className = "action-list-filter-input";
-            this._filterInput.placeholder = this._options?.filterPlaceholder ?? ( localize(1784, "Search..."));
-            this._filterInput.setAttribute("aria-label", ( localize(1785, "Filter items")));
-            filterRow.appendChild(this._filterInput);
-            const filterActions = this._options?.filterActions ?? [];
-            if (filterActions.length > 0) {
-                const filterActionsContainer = append(filterRow, $(".action-list-filter-actions"));
-                const filterActionBar = this._register(( new ActionBar(filterActionsContainer)));
-                filterActionBar.push(filterActions, {
-                    icon: true,
-                    label: false
-                });
+            if (this._options?.showFilter) {
+                this._filterInput = createElement("input");
+                this._filterInput.type = "text";
+                this._filterInput.className = "action-list-filter-input";
+                this._filterInput.placeholder = this._options?.filterPlaceholder ?? ( localize(1796, "Search..."));
+                this._filterInput.setAttribute("aria-label", ( localize(1797, "Filter items")));
+                filterRow.appendChild(this._filterInput);
+                const filterActions = this._options?.filterActions ?? [];
+                if (filterActions.length > 0) {
+                    const filterActionsContainer = append(filterRow, $(".action-list-filter-actions"));
+                    const filterActionBar = this._register(( new ActionBar(filterActionsContainer)));
+                    filterActionBar.push(filterActions, {
+                        icon: true,
+                        label: false
+                    });
+                }
+                this._register(addDisposableListener(this._filterInput, "input", () => {
+                    this._filterText = this._filterInput.value;
+                    this._applyOrUpdateFilter();
+                }));
             }
-            this._register(addDisposableListener(this._filterInput, "input", () => {
-                this._filterText = this._filterInput.value;
-                this._applyOrUpdateFilter();
-            }));
+            if (this._options?.secondaryHeading) {
+                const filterLabelEl = append(filterRow, $(".action-list-filter-label"));
+                filterLabelEl.textContent = this._options.secondaryHeading;
+            }
+        }
+        if (this._options?.footerText) {
+            this._footerContainer = createElement("div");
+            this._footerContainer.className = "action-list-footer";
+            this._footerContainer.textContent = this._options.footerText;
         }
         this._applyFilter();
         if (this._list.length) {
@@ -493,39 +541,59 @@ let ActionListWidget = ActionListWidget_1 = class ActionListWidget extends Dispo
         if (focusedIndexes.length > 0) {
             focusedItem = this._list.element(focusedIndexes[0]);
         }
-        for (const item of this._allMenuItems) {
-            if (item.kind === ActionListItemKind.Header) {
-                if (isFiltering) {
-                    continue;
+        if (isFiltering) {
+            let pendingSeparator;
+            let filteredSectionItems = [];
+            let hasMatchingActionInSection = false;
+            const flushFilteredSection = () => {
+                if (pendingSeparator && hasMatchingActionInSection) {
+                    visible.push(pendingSeparator);
                 }
-                visible.push(item);
-                continue;
-            }
-            if (item.kind === ActionListItemKind.Separator) {
-                if (isFiltering) {
+                visible.push(...filteredSectionItems);
+                pendingSeparator = undefined;
+                filteredSectionItems = [];
+                hasMatchingActionInSection = false;
+            };
+            const matchesFilter = item => {
+                const label = (item.label ?? "").toLowerCase();
+                const descValue = typeof item.description === "string" ? item.description : (item.description?.value ?? "");
+                return label.includes(filterLower) || descValue.toLowerCase().includes(filterLower);
+            };
+            for (const item of this._allMenuItems) {
+                if (item.kind === ActionListItemKind.Header) {
                     continue;
                 }
-                if (item.section && ( this._collapsedSections.has(item.section))) {
+                if (item.kind === ActionListItemKind.Separator) {
+                    flushFilteredSection();
+                    pendingSeparator = item.label ? item : undefined;
                     continue;
                 }
-                visible.push(item);
-                continue;
-            }
-            if (isFiltering) {
                 if (item.showAlways) {
-                    visible.push(item);
+                    filteredSectionItems.push(item);
                     continue;
                 }
                 if (item.isSectionToggle) {
                     continue;
                 }
-                const label = (item.label ?? "").toLowerCase();
-                const descValue = typeof item.description === "string" ? item.description : item.description?.value ?? "";
-                const desc = descValue.toLowerCase();
-                if (label.includes(filterLower) || desc.includes(filterLower)) {
+                if (matchesFilter(item)) {
+                    hasMatchingActionInSection = true;
+                    filteredSectionItems.push(item);
+                }
+            }
+            flushFilteredSection();
+        } else {
+            for (const item of this._allMenuItems) {
+                if (item.kind === ActionListItemKind.Header) {
                     visible.push(item);
+                    continue;
+                }
+                if (item.kind === ActionListItemKind.Separator) {
+                    if (item.section && ( this._collapsedSections.has(item.section))) {
+                        continue;
+                    }
+                    visible.push(item);
+                    continue;
                 }
-            } else {
                 if (item.isSectionToggle && item.section) {
                     const collapsed = ( this._collapsedSections.has(item.section));
                     visible.push({
@@ -543,6 +611,41 @@ let ActionListWidget = ActionListWidget_1 = class ActionListWidget extends Dispo
                 visible.push(item);
             }
         }
+        const hasActionBefore = [];
+        let seenAction = false;
+        for (let i = 0; i < visible.length; i++) {
+            hasActionBefore[i] = seenAction;
+            if (visible[i].kind === ActionListItemKind.Action) {
+                seenAction = true;
+            }
+        }
+        const hasActionBeforeNextSeparator = [];
+        let seenActionInSection = false;
+        for (let i = visible.length - 1; i >= 0; i--) {
+            if (visible[i].kind === ActionListItemKind.Action) {
+                seenActionInSection = true;
+                continue;
+            }
+            if (visible[i].kind !== ActionListItemKind.Separator) {
+                continue;
+            }
+            hasActionBeforeNextSeparator[i] = seenActionInSection;
+            seenActionInSection = false;
+        }
+        for (let i = visible.length - 1; i >= 0; i--) {
+            const item = visible[i];
+            if (item.kind !== ActionListItemKind.Separator) {
+                continue;
+            }
+            const hasFollowingActionInSection = hasActionBeforeNextSeparator[i];
+            const isLeadingUnlabeledDivider = !item.label && !hasActionBefore[i];
+            if (!hasFollowingActionInSection || isLeadingUnlabeledDivider) {
+                visible.splice(i, 1);
+            }
+        }
+        if (this._options?.showGroupTitleOnFirstItem) {
+            this._recomputeGroupTitles(visible);
+        }
         const filterInputHasFocus = this._filterInput && isActiveElement(this._filterInput);
         this._list.splice(0, this._list.length, visible);
         this._onDidRequestLayout.fire();
@@ -568,6 +671,9 @@ let ActionListWidget = ActionListWidget_1 = class ActionListWidget extends Dispo
     get filterContainer() {
         return this._filterContainer;
     }
+    get footerContainer() {
+        return this._footerContainer;
+    }
     get filterInput() {
         return this._filterInput;
     }
@@ -583,6 +689,9 @@ let ActionListWidget = ActionListWidget_1 = class ActionListWidget extends Dispo
         this._list.domFocus();
         this._focusCheckedOrFirst();
     }
+    clearFocus() {
+        this._list.setFocus([]);
+    }
     getFocusedElement() {
         const focused = this._list.getFocus();
         if (focused.length > 0) {
@@ -640,12 +749,9 @@ let ActionListWidget = ActionListWidget_1 = class ActionListWidget extends Dispo
         case ActionListItemKind.Header:
             return this._headerLineHeight;
         case ActionListItemKind.Separator:
-            return this._separatorLineHeight;
+            return item.label ? this._actionLineHeight : this._separatorLineHeight;
         default:
-            if (this._options?.descriptionBelow && !item.description) {
-                return this._baseLineHeight;
-            }
-            return this._actionLineHeight;
+            return item.detail ? (this._options?.detailItemHeight ?? 48) : this._actionLineHeight;
         }
     }
     computeFullHeight() {
@@ -675,10 +781,13 @@ let ActionListWidget = ActionListWidget_1 = class ActionListWidget extends Dispo
     computeMaxWidth(minWidth) {
         const visibleCount = this._list.length;
         const effectiveMinWidth = Math.max(minWidth, this._options?.minWidth ?? 0);
+        const rawMaxWidthCap = this._options?.maxWidth ?? Number.POSITIVE_INFINITY;
+        const maxWidthCap = Math.max(rawMaxWidthCap, effectiveMinWidth);
+        const clamp = w => Math.min(Math.max(w, effectiveMinWidth), maxWidthCap);
         let maxWidth = effectiveMinWidth;
         const totalItemCount = this._allMenuItems.length;
         if (totalItemCount >= 50) {
-            return Math.max(380, effectiveMinWidth);
+            return clamp(380);
         }
         if (totalItemCount > visibleCount) {
             const visibleItems = [];
@@ -702,7 +811,7 @@ let ActionListWidget = ActionListWidget_1 = class ActionListWidget extends Dispo
                     itemWidths.push(width + this._computeToolbarWidth(allItems[i]));
                 }
             }
-            maxWidth = Math.max(...itemWidths, effectiveMinWidth);
+            maxWidth = clamp(Math.max(...itemWidths));
             this._list.splice(0, allItems.length, visibleItems);
             return maxWidth;
         }
@@ -716,7 +825,7 @@ let ActionListWidget = ActionListWidget_1 = class ActionListWidget extends Dispo
                 itemWidths.push(width + this._computeToolbarWidth(this._list.element(i)));
             }
         }
-        return Math.max(...itemWidths, effectiveMinWidth);
+        return clamp(Math.max(...itemWidths));
     }
     focusPrevious() {
         if (this._filterInput && isActiveElement(this._filterInput)) {
@@ -875,6 +984,17 @@ let ActionListWidget = ActionListWidget_1 = class ActionListWidget extends Dispo
             this._applyFilter();
         }
     }
+    _recomputeGroupTitles(items) {
+        this._groupTitleByIndex.clear();
+        const seenTitles = ( new Set());
+        for (let i = 0; i < items.length; i++) {
+            const item = items[i];
+            if (item.kind === ActionListItemKind.Action && item.group?.title && !( seenTitles.has(item.group.title))) {
+                seenTitles.add(item.group.title);
+                this._groupTitleByIndex.set(i, item.group.title);
+            }
+        }
+    }
     _computeToolbarWidth(item) {
         let actionCount = item.toolbarActions?.length ?? 0;
         if (item.onRemove) {
@@ -905,7 +1025,7 @@ let ActionListWidget = ActionListWidget_1 = class ActionListWidget extends Dispo
             }
             return;
         }
-        this._submenuDisposables.clear();
+        this._hideSubmenu();
     }
     _showSubmenuForItem(item) {
         const index = this._list.indexOf(item);
@@ -926,22 +1046,29 @@ let ActionListWidget = ActionListWidget_1 = class ActionListWidget extends Dispo
         let hoverHeader;
         const hoverContent = element.hover?.content;
         if (hoverContent) {
-            const markdown = typeof hoverContent === "string" ? ( new MarkdownString(hoverContent)) : hoverContent;
-            const linkHandler = this._options?.linkHandler;
-            const rendered = renderMarkdown(markdown, {
-                actionHandler: url => {
-                    const uri = ( URI.parse(url));
-                    if (linkHandler) {
-                        linkHandler(uri, element);
-                    } else {
-                        this._openerService.open(uri, {
-                            allowCommands: true
-                        });
-                    }
+            if (isHTMLElement(hoverContent)) {
+                hoverHeader = hoverContent;
+                if (element.hover?.disposable) {
+                    this._submenuDisposables.add(element.hover.disposable);
                 }
-            });
-            this._submenuDisposables.add(rendered);
-            hoverHeader = rendered.element;
+            } else {
+                const markdown = typeof hoverContent === "string" ? ( new MarkdownString(hoverContent)) : hoverContent;
+                const linkHandler = this._options?.linkHandler;
+                const rendered = renderMarkdown(markdown, {
+                    actionHandler: url => {
+                        const uri = ( URI.parse(url));
+                        if (linkHandler) {
+                            linkHandler(uri, element);
+                        } else {
+                            this._openerService.open(uri, {
+                                allowCommands: true
+                            });
+                        }
+                    }
+                });
+                this._submenuDisposables.add(rendered);
+                hoverHeader = rendered.element;
+            }
             hoverHeader.classList.add("action-list-submenu-hover-header");
             if (element.submenuActions?.length) {
                 hoverHeader.classList.add("has-submenu");
@@ -974,6 +1101,9 @@ let ActionListWidget = ActionListWidget_1 = class ActionListWidget extends Dispo
                 }
                 for (let ci = 0; ci < group.actions.length; ci++) {
                     const child = group.actions[ci];
+                    const extendedChild = child;
+                    const icon = extendedChild.icon ?? ThemeIcon.fromId(child.checked ? Codicon.check.id : Codicon.blank.id);
+                    const hoverContent = extendedChild.hoverContent;
                     submenuItems.push({
                         item: child,
                         kind: ActionListItemKind.Action,
@@ -981,10 +1111,13 @@ let ActionListWidget = ActionListWidget_1 = class ActionListWidget extends Dispo
                         description: child.tooltip || undefined,
                         group: {
                             title: "",
-                            icon: ThemeIcon.fromId(child.checked ? Codicon.check.id : Codicon.blank.id)
+                            icon
                         },
                         hideIcon: false,
-                        hover: {}
+                        hover: hoverContent ? {
+                            content: hoverContent
+                        } : {},
+                        onRemove: extendedChild.onRemove
                     });
                 }
                 if (gi < groupsWithActions.length - 1) {
@@ -996,6 +1129,7 @@ let ActionListWidget = ActionListWidget_1 = class ActionListWidget extends Dispo
             }
             for (const action of element.submenuActions) {
                 if (!(action instanceof SubmenuAction)) {
+                    const extendedAction = action;
                     submenuItems.push({
                         item: action,
                         kind: ActionListItemKind.Action,
@@ -1005,7 +1139,8 @@ let ActionListWidget = ActionListWidget_1 = class ActionListWidget extends Dispo
                             title: ""
                         },
                         hideIcon: false,
-                        hover: {}
+                        hover: {},
+                        onRemove: extendedAction.onRemove
                     });
                 }
             }
@@ -1032,6 +1167,7 @@ let ActionListWidget = ActionListWidget_1 = class ActionListWidget extends Dispo
             ));
             this._submenuContainer.appendChild(submenuWidget.domNode);
             this._currentSubmenuWidget = submenuWidget;
+            submenuWidget.clearFocus();
             totalHeight = submenuWidget.computeListHeight();
             submenuWidget.layout(totalHeight);
             const submenuMaxWidth = submenuWidget.computeMaxWidth(0);
@@ -1077,11 +1213,15 @@ let ActionListWidget = ActionListWidget_1 = class ActionListWidget extends Dispo
         const hoverHeaderHeight = hoverHeader ? hoverHeader.offsetHeight : 0;
         const totalPanelHeight = totalHeight + hoverHeaderHeight;
         const viewportHeight = targetWindow.innerHeight;
-        let top = anchorRect.top - parentRect.top - 4;
+        const anchorHeight = anchorRect.height;
+        let top = anchorRect.top - parentRect.top + (anchorHeight - totalPanelHeight) / 2;
         const panelBottom = parentRect.top + top + totalPanelHeight;
         if (panelBottom > viewportHeight) {
             top -= (panelBottom - viewportHeight + 8);
         }
+        if (parentRect.top + top < 0) {
+            top = -parentRect.top;
+        }
         this._submenuContainer.style.top = `${top}px`;
     }
     _hideSubmenu() {
@@ -1168,8 +1308,13 @@ let ActionListWidget = ActionListWidget_1 = class ActionListWidget extends Dispo
                 }
             }
         } else if (element && element.hover?.content && typeof e.index === "number") {
-            this._hideSubmenu();
-            this._scheduleSubmenuShow(element, e.index);
+            if (this._currentSubmenuElement === element) {
+                this._cancelSubmenuHide();
+                this._cancelSubmenuShow();
+            } else {
+                this._hideSubmenu();
+                this._scheduleSubmenuShow(element, e.index);
+            }
         }
     }
     onListClick(e) {
@@ -1186,6 +1331,9 @@ let ActionList = class ActionList extends Disposable {
     get filterContainer() {
         return this._widget.filterContainer;
     }
+    get footerContainer() {
+        return this._widget.footerContainer;
+    }
     get filterInput() {
         return this._widget.filterInput;
     }
@@ -1263,21 +1411,24 @@ let ActionList = class ActionList extends Disposable {
     computeHeight() {
         const listHeight = this._widget.computeListHeight();
         const filterHeight = this._widget.filterContainer ? 36 : 0;
-        const padding = 10;
+        const footerHeight = this._widget.footerContainer ? 32 : 0;
+        const chromeHeight = filterHeight + footerHeight;
         const targetWindow = getWindow(this.domNode);
         let availableHeight;
         if (this.hasDynamicHeight()) {
             const viewportHeight = targetWindow.innerHeight;
             const anchorRect = getAnchorRect(this._anchor);
             const anchorTopInViewport = anchorRect.top - targetWindow.pageYOffset;
-            const spaceBelow = viewportHeight - anchorTopInViewport - anchorRect.height - padding;
-            const spaceAbove = anchorTopInViewport - padding;
+            const bottomGap = 30;
+            const spaceBelow = viewportHeight - anchorTopInViewport - anchorRect.height - bottomGap;
+            const spaceAbove = anchorTopInViewport;
             if (this._showAbove === undefined) {
-                const fullHeight = filterHeight + this._widget.computeFullHeight();
+                const fullHeight = chromeHeight + this._widget.computeFullHeight();
                 this._showAbove = fullHeight > spaceBelow && spaceAbove > spaceBelow;
             }
             availableHeight = this._showAbove ? spaceAbove : spaceBelow;
         } else {
+            const padding = 10;
             const windowHeight = this._layoutService.getContainer(targetWindow).clientHeight;
             const widgetTop = this.domNode.getBoundingClientRect().top;
             availableHeight = widgetTop > 0 ? windowHeight - widgetTop - padding : windowHeight * 0.7;
@@ -1285,18 +1436,19 @@ let ActionList = class ActionList extends Disposable {
         const viewportMaxHeight = Math.floor(targetWindow.innerHeight * 0.6);
         const actionLineHeight = this._widget.lineHeight;
         const maxHeight = Math.min(
-            Math.max(availableHeight, actionLineHeight * 3 + filterHeight),
+            Math.max(availableHeight, actionLineHeight * 3 + chromeHeight),
             viewportMaxHeight
         );
-        const height = Math.min(listHeight + filterHeight, maxHeight);
-        return height - filterHeight;
+        const height = Math.min(listHeight + chromeHeight, maxHeight);
+        return height - chromeHeight;
     }
     layout(minWidth) {
         this._hasLaidOut = true;
         this._lastMinWidth = minWidth;
         const listHeight = this.computeHeight();
         this._widget.layout(listHeight);
-        this._cachedMaxWidth = this._widget.computeMaxWidth(minWidth);
+        const computedWidth = this._widget.computeMaxWidth(minWidth);
+        this._cachedMaxWidth = computedWidth;
         this._widget.layout(listHeight, this._cachedMaxWidth);
         return this._cachedMaxWidth;
     }