@cleartrip/frontguard 0.3.0 → 0.3.2

package/dist/cli.js

@@ -5130,11 +5130,12 @@ function tokenizeCommand(cmd) {
 }
 function npmScriptFromBuildCommand(cmd) {
   const t3 = cmd.trim();
-  if (/^yarn\s+build\b/i.test(t3)) return "build";
   const np = /^(?:npm|pnpm)\s+run\s+(\S+)/i.exec(t3);
   if (np?.[1]) return np[1];
   const yr = /^yarn\s+run\s+(\S+)/i.exec(t3);
   if (yr?.[1]) return yr[1];
+  const yPlain = /^yarn\s+(?!run\b)(\S+)/i.exec(t3);
+  if (yPlain?.[1]) return yPlain[1];
   return null;
 }
 async function bundleBuildPrecheck(cwd, buildCommand) {
@@ -5148,15 +5149,29 @@ async function bundleBuildPrecheck(cwd, buildCommand) {
   } catch {
     return {
       run: false,
-      message: "Skipped bundle build \u2014 no readable package.json",
-      detail: "Set checks.bundle.buildCommand to your real build (e.g. `vite build`), set checks.bundle.runBuild to false, or add a package.json with the matching script."
+      message: "Bundle check: build not run (unreadable package.json)",
+      detail: [
+        "Front Guard did not start the build because package.json could not be read next to the project root.",
+        "No bundle size was measured.",
+        "",
+        "Fix: ensure package.json exists, or set checks.bundle.runBuild to false to only measure files already on disk."
+      ].join("\n")
     };
   }
   if (!scripts?.[script]) {
+    const keys = scripts ? Object.keys(scripts).sort().join(", ") : "(none)";
     return {
       run: false,
-      message: `Skipped bundle build \u2014 no scripts.${script} in package.json`,
-      detail: "The bundle check runs a production build, then measures the output. Libraries and non-web repos often have no `build` script \u2014 set checks.bundle.runBuild to false, or set checks.bundle.buildCommand to whatever produces your artifacts."
+      message: `Bundle check: build not run (missing scripts["${script}"])`,
+      detail: [
+        `Configured checks.bundle.buildCommand is: \`${buildCommand}\``,
+        `That maps to package.json scripts["${script}"], which is not defined.`,
+        `Existing script names: ${keys}`,
+        "",
+        "Front Guard did not run a production build, so no bundle size was measured (nothing to compare to a baseline).",
+        "",
+        "Fix: set buildCommand to an existing script (e.g. `npm run build:prod` / `yarn run prod:build`), add the missing script, or set checks.bundle.runBuild to false if artifacts are produced elsewhere."
+      ].join("\n")
     };
   }
   return { run: true };
@@ -5183,6 +5198,7 @@ async function runBundle(cwd, config, stack) {
   const strategy = resolveStrategy(cfg.bundleSizeStrategy, stack);
   const preFindings = [];
   let buildStdout = "";
+  let buildExecuted = false;
   if (cfg.runBuild) {
     const parts = tokenizeCommand(cfg.buildCommand);
     if (parts.length === 0) {
@@ -5224,6 +5240,7 @@ async function runBundle(cwd, config, stack) {
         };
       }
       buildStdout = (res.stdout ?? "") + "\n" + (res.stderr ?? "");
+      buildExecuted = true;
     }
   }
   let sizeResult = null;
@@ -5274,6 +5291,23 @@ async function runBundle(cwd, config, stack) {
   const total = sizeResult?.bytes ?? 0;
   const sizeLabel = sizeResult?.label ?? `(no bundle output detected for strategy "${strategy}")`;
   if (total === 0) {
+    const buildSkippedPrecheck = preFindings.some((f4) => f4.id === "bundle-build-skipped");
+    if (buildSkippedPrecheck) {
+      return {
+        checkId: "bundle",
+        findings: preFindings,
+        durationMs: Math.round(performance.now() - t0)
+      };
+    }
+    const emptyDetail = buildExecuted ? [
+      `Strategy "${strategy}" did not find a size after the build finished.`,
+      sizeLabel,
+      "",
+      "For Next.js, confirm `next build` still prints the line `First Load JS shared by all`, or that `.next/static/**/*.js` exists. You can try bundleSizeStrategy `glob` or `custom` if your setup differs."
+    ].join("\n") : [
+      sizeLabel,
+      cfg.runBuild ? "No production build ran successfully before this measurement (unexpected)." : "checks.bundle.runBuild is false \u2014 only existing files on disk are measured. Run a build earlier in the pipeline, or set runBuild to true."
+    ].join("\n");
     return {
       checkId: "bundle",
       findings: [
@@ -5281,9 +5315,8 @@ async function runBundle(cwd, config, stack) {
         {
           id: "bundle-empty",
           severity: "info",
-          message: `No bundle size detected (strategy: ${strategy})`,
-          detail: `${sizeLabel}
-Ensure the build produces artifacts, or switch to a different bundleSizeStrategy.`
+          message: buildExecuted ? `No bundle size extracted (strategy: ${strategy})` : `No bundle size detected (strategy: ${strategy})`,
+          detail: emptyDetail
         }
       ],
       durationMs: Math.round(performance.now() - t0)