@buildinternet/uploads 0.37.1 → 0.37.3

package/dist/commands.js

@@ -4,7 +4,7 @@ import { mapBounded } from "./async.js";
 import { createUploadsClient, } from "./client.js";
 import { parseCommandArgs, flagString, flagBool, flagInt, flagValues, UsageError, } from "./cli-args.js";
 import { resolvePutDefaults, workspaceMismatch, workspaceFromToken, } from "./config.js";
-import { buildMarkdown } from "./embed.js";
+import { buildUploadMarkdown } from "./embed.js";
 import { readLocalRepoCommentConfig, resolveCommentOptions } from "./comment-config.js";
 import { urlForGithubEmbed } from "./public-urls.js";
 import { UploadsError } from "./errors.js";
@@ -411,9 +411,10 @@ export async function uploadPreparedImage(client, bytes, sourceName, opts) {
         }),
         metadata,
     });
-    const markdown = buildMarkdown(urlForGithubEmbed(result.url, result.embedUrl), {
+    const markdown = buildUploadMarkdown(urlForGithubEmbed(result.url, result.embedUrl), {
         alt: opts.alt(prepared),
         width: opts.width,
+        key: result.key,
     });
     return { result, prepared, markdown, sentMetadata: metadata };
 }
@@ -748,8 +749,9 @@ async function uploadAttachmentBatch(opts) {
                 upload: {
                     ...result,
                     file,
-                    markdown: buildMarkdown(urlForGithubEmbed(result.url, result.embedUrl), {
+                    markdown: buildUploadMarkdown(urlForGithubEmbed(result.url, result.embedUrl), {
                         alt: sourceName,
+                        key: result.key,
                     }),
                     optimize: {
                         optimized: prepared.optimized,

package/dist/embed.d.ts

@@ -4,3 +4,13 @@ export declare function buildMarkdown(url: string, opts: {
     alt: string;
     width?: number;
 }): string;
+/**
+ * Null-safe wrapper for upload flows: workspaces with no public base URL
+ * (BYO signed-URLs-only) upload fine but have no embeddable URL, and the
+ * markdown must degrade to honest plain text instead of `![alt](null)`.
+ */
+export declare function buildUploadMarkdown(url: string | null | undefined, opts: {
+    alt: string;
+    width?: number;
+    key: string;
+}): string;

package/dist/embed.js

@@ -28,3 +28,14 @@ export function buildMarkdown(url, opts) {
     }
     return `![${opts.alt}](${url})`;
 }
+/**
+ * Null-safe wrapper for upload flows: workspaces with no public base URL
+ * (BYO signed-URLs-only) upload fine but have no embeddable URL, and the
+ * markdown must degrade to honest plain text instead of `![alt](null)`.
+ */
+export function buildUploadMarkdown(url, opts) {
+    if (!url) {
+        return `\`${opts.key}\` uploaded (no public URL — this workspace serves signed URLs only)`;
+    }
+    return buildMarkdown(url, opts);
+}

package/dist/github.js

@@ -460,8 +460,6 @@ export function attachmentsCommentBody(items, galleries = [], marker = ATTACHMEN
         }
         lines.push("");
     }
-    if (sorted.length > 0 || sortedGalleries.length === 0)
-        lines.push("### 📎 Attachments", "");
     const isImageAt = sorted.map((item) => {
         const name = item.key.slice(item.key.lastIndexOf("/") + 1);
         const src = item.embedUrl ?? item.url;
@@ -564,9 +562,8 @@ export function attachmentsCommentBody(items, galleries = [], marker = ATTACHMEN
     }
     // Emptied state: a PR/issue whose attachments and galleries were all removed
     // still keeps its managed comment (a later push can repopulate it) — show a
-    // neutral resting state under the heading rather than a bare heading. Only
-    // the truly-empty case (no attachments, no galleries); a galleries-only
-    // comment has no Attachments heading and must not get this line.
+    // neutral resting state rather than a bare footer. Only the truly-empty case
+    // (no attachments, no galleries); a galleries-only comment must not get this.
     if (sorted.length === 0 && sortedGalleries.length === 0) {
         lines.push("_No attachments are currently associated with this pull request._", "");
     }

package/dist/index.d.ts

@@ -1,4 +1,4 @@
-export { inferContentType, buildMarkdown } from "./embed.js";
+export { inferContentType, buildMarkdown, buildUploadMarkdown } from "./embed.js";
 export { DEFAULT_EMBED_PUBLIC_BASE_URL, embedBaseUrlFromEnv, embedUrlFromPublic, resolveEmbedBaseUrl, resolveEmbedUrl, urlForGithubEmbed, } from "./public-urls.js";
 export { sanitizeKeySegment, sha256Short, deriveRepoFromGit, buildScreenshotKey } from "./keys.js";
 export { BUILTIN_DESTINATIONS, isBuiltinDestination, keyMatchesDestination, resolveDestinationRoot, resolvePutPrefix, type BuiltinDestinationId, } from "./destinations.js";

package/dist/index.js

@@ -1,4 +1,4 @@
-export { inferContentType, buildMarkdown } from "./embed.js";
+export { inferContentType, buildMarkdown, buildUploadMarkdown } from "./embed.js";
 export { DEFAULT_EMBED_PUBLIC_BASE_URL, embedBaseUrlFromEnv, embedUrlFromPublic, resolveEmbedBaseUrl, resolveEmbedUrl, urlForGithubEmbed, } from "./public-urls.js";
 export { sanitizeKeySegment, sha256Short, deriveRepoFromGit, buildScreenshotKey } from "./keys.js";
 export { BUILTIN_DESTINATIONS, isBuiltinDestination, keyMatchesDestination, resolveDestinationRoot, resolvePutPrefix, } from "./destinations.js";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@buildinternet/uploads",
-  "version": "0.37.1",
+  "version": "0.37.3",
   "description": "CLI and client for uploads.sh — workspace-scoped image hosting for GitHub embeds",
   "type": "module",
   "sideEffects": false,