@bobfrankston/rmfmail 1.1.86 → 1.1.88

package/.commitmsg

@@ -1,14 +1,11 @@
-Fix: update banner wiped by next sync; raise server-search timeout
+Fix: highlighted row with an empty viewer (selection/preview desync)
 
-Update banner: the "update available" notice shares the alert-banner
-element, and the sync-success path calls hideAlert() unconditionally —
-so the banner the auto-update poller raised was cleared within seconds
-by the next sync and the user never saw it (the daemon log confirms the
-poller has been detecting every release). The banner is now tagged
-dataset.key="update-available"; hideAlert() leaves that key alone unless
-forced, and the X dismiss button passes force:true.
+A list row could stay highlighted while the viewer showed "Select a
+message to read". releaseFocus() only un-selected the tracked focusedRow,
+so a stray .selected (multi-select remnant, or a row that kept the class
+through an incremental rerender) was left highlighted after the viewer
+had been cleared.
 
-Server search: a "Server"-checkbox search goes out to IMAP/Gmail and
-can exceed the default 30s IPC ceiling, surfacing as "mailxapi timeout:
-searchMessages". searchMessages now gets a 120s ceiling like the
-attachment actions.
+releaseFocus() now strips every .selected row. focusRow() also sweeps
+stray .selected in single-select mode before highlighting its row, so
+the list can never show a highlight that doesn't match the viewer.

package/client/app.bundle.js

@@ -1665,6 +1665,19 @@ async function showMessage(accountId, uid, folderId, specialUse, isRetry = false
         chip.title = `${att.filename} (${att.mimeType})`;
         chip.addEventListener("click", async (e) => {
           e.preventDefault();
+          if (chip.dataset.opening === "1")
+            return;
+          chip.dataset.opening = "1";
+          const chipLabel = chip.textContent || "";
+          chip.textContent = "\u23F3 Opening\u2026";
+          const tStart = Date.now();
+          const restoreChip = () => {
+            const wait = Math.max(0, 600 - (Date.now() - tStart));
+            setTimeout(() => {
+              chip.textContent = chipLabel;
+              chip.dataset.opening = "";
+            }, wait);
+          };
           try {
             const bridge = window._nativeBridge;
             if (bridge?.openAttachment) {
@@ -1693,6 +1706,8 @@ async function showMessage(accountId, uid, folderId, specialUse, isRetry = false
             const m = `Couldn't open "${att.filename}": ${err?.message || err}`;
             console.error(m);
             window.dispatchEvent(new CustomEvent("mailx-alert", { detail: { message: m, key: "attachment-open" } }));
+          } finally {
+            restoreChip();
           }
         });
         chip.draggable = true;
@@ -2507,6 +2522,13 @@ function rowKey(accountId, uid) {
   return `${accountId}:${uid}`;
 }
 function focusRow(row, opts = {}) {
+  const body = row.el.parentElement;
+  if (!body?.classList.contains("multi-select-on")) {
+    body?.querySelectorAll(".ml-row.selected").forEach((r) => {
+      if (r !== row.el)
+        r.classList.remove("selected");
+    });
+  }
   if (focusedRow && focusedRow !== row)
     focusedRow.setSelected(false);
   row.setSelected(true);
@@ -2544,9 +2566,9 @@ function scrollFocusedIntoView() {
     focusedRow.el.scrollIntoView({ block: "center" });
 }
 function releaseFocus() {
-  if (focusedRow)
-    focusedRow.setSelected(false);
   focusedRow = null;
+  const body = document.getElementById("ml-body");
+  body?.querySelectorAll(".ml-row.selected").forEach((r) => r.classList.remove("selected"));
   clearViewer();
   document.dispatchEvent(new CustomEvent("mailx-focus-changed", { detail: null }));
 }