@bobfrankston/rmfmail 1.1.80 → 1.1.81

package/.commitmsg

@@ -1,12 +1,20 @@
-Fix: opening an attachment did nothing on desktop
-
-Clicking an attachment chip fired a programmatic <a download> click,
-which msger's WebView2 silently drops — so nothing happened and the
-failure was swallowed by a console-only catch.
-
-New service method openAttachment saves the attachment to
-~/.rmfmail/attachments/ and opens it with the OS default app (start /
-open / xdg-open), the same in-process pattern as openInWord. The viewer
-now calls it on desktop, keeps the native-bridge path for Android, and
-falls back to the blob download only for a real browser / --server
-mode. Failures now surface via an alert instead of vanishing.
+Fix spurious attachment-open error + blocking alert that stalled sync
+
+Three faults behind "failed to open" appearing after the file had
+actually opened in Acrobat:
+
+1. The openAttachment IPC call used the default 30s ceiling. A cold
+   parse worker (14-25s) plus a 1.7 MB PDF blew past it, so the client
+   rejected even though the service succeeded. getAttachment/
+   openAttachment now get a 120s ceiling in mailxapi.js.
+
+2. On that spurious rejection the viewer ran the browser-only blob
+   fallback, whose atob() threw "string not correctly encoded". The
+   fallback now runs ONLY when openAttachment returns undefined (real
+   browser / --server mode); a genuine IPC failure is reported, not
+   retried via blob.
+
+3. The failure was shown with window.alert() — a modal that freezes the
+   WebView event loop, stalling IPC event delivery so sync looked
+   stopped. Replaced with a non-blocking banner via a mailx-alert
+   CustomEvent handled by app.ts showAlert().

package/client/app.bundle.js

@@ -1672,13 +1672,9 @@ async function showMessage(accountId, uid, folderId, specialUse, isRetry = false
               await bridge.openAttachment(att.filename, data2.contentType, data2.content);
               return;
             }
-            try {
-              const res = await openAttachment(accountId, uid, i, msg.folderId);
-              if (res?.ok)
-                return;
-            } catch (svcErr) {
-              console.warn(`[attachment] service open failed, falling back to blob: ${svcErr?.message || svcErr}`);
-            }
+            const res = await openAttachment(accountId, uid, i, msg.folderId);
+            if (res)
+              return;
             const data = await getAttachment(accountId, uid, i, msg.folderId);
             const bytes = Uint8Array.from(atob(data.content), (c) => c.charCodeAt(0));
             const blob = new Blob([bytes], { type: data.contentType });
@@ -1694,8 +1690,9 @@ async function showMessage(accountId, uid, folderId, specialUse, isRetry = false
               URL.revokeObjectURL(url);
             }, 5e3);
           } catch (err) {
-            console.error(`Attachment open failed: ${err?.message || err}`);
-            alert(`Couldn't open "${att.filename}": ${err?.message || err}`);
+            const m = `Couldn't open "${att.filename}": ${err?.message || err}`;
+            console.error(m);
+            window.dispatchEvent(new CustomEvent("mailx-alert", { detail: { message: m, key: "attachment-open" } }));
           }
         });
         chip.draggable = true;
@@ -6681,6 +6678,10 @@ function showAlert(message, key, opts) {
     }
   }
 }
+window.addEventListener("mailx-alert", (e) => {
+  const d = e.detail || {};
+  if (d.message) showAlert(String(d.message), d.key);
+});
 function hideAlert() {
   if (alertBanner) {
     const key = alertBanner.dataset.key;