@bananapus/router-terminal-v6 0.0.3 → 0.0.5

package/foundry.toml

@@ -1,7 +1,7 @@
 [profile.default]
 solc = '0.8.26'
 evm_version = 'cancun'
-optimizer_runs = 100000000
+optimizer_runs = 200
 libs = ["node_modules", "lib"]
 fs_permissions = [{ access = "read-write", path = "./"}]
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bananapus/router-terminal-v6",
-  "version": "0.0.3",
+  "version": "0.0.5",
   "license": "MIT",
   "repository": {
     "type": "git",

package/src/JBRouterTerminal.sol

@@ -71,16 +71,20 @@ contract JBRouterTerminal is
     /// @notice The default TWAP window used for auto-discovered pools.
     uint256 public constant DEFAULT_TWAP_WINDOW = 10 minutes;
 
+    /// @notice The denominator used for slippage tolerance basis points.
+    uint256 public constant SLIPPAGE_DENOMINATOR = 10_000;
+
+    //*********************************************************************//
+    // ---------------------- internal stored properties ----------------- //
+    //*********************************************************************//
+
     /// @notice The fee tiers to search when auto-discovering V3 pools, ordered by commonality.
     /// 3000 = 0.3%, 500 = 0.05%, 10000 = 1%, 100 = 0.01%.
-    uint24[4] public FEE_TIERS = [uint24(3000), uint24(500), uint24(10_000), uint24(100)];
+    uint24[4] internal _FEE_TIERS = [uint24(3000), uint24(500), uint24(10_000), uint24(100)];
 
     /// @notice The fee/tickSpacing pairings to search for V4 vanilla pools.
-    uint24[4] public V4_FEES = [uint24(3000), uint24(500), uint24(10_000), uint24(100)];
-    int24[4] public V4_TICK_SPACINGS = [int24(60), int24(10), int24(200), int24(1)];
-
-    /// @notice The denominator used for slippage tolerance basis points.
-    uint256 public constant SLIPPAGE_DENOMINATOR = 10_000;
+    uint24[4] internal _V4_FEES = [uint24(3000), uint24(500), uint24(10_000), uint24(100)];
+    int24[4] internal _V4_TICK_SPACINGS = [int24(60), int24(10), int24(200), int24(1)];
 
     //*********************************************************************//
     // ---------------- public immutable stored properties --------------- //
@@ -571,6 +575,7 @@ contract JBRouterTerminal is
         bool hasFallback;
 
         for (uint256 i; i < terminals.length; i++) {
+            // slither-disable-next-line calls-loop
             JBAccountingContext[] memory contexts = terminals[i].accountingContextsOf(projectId);
 
             for (uint256 j; j < contexts.length; j++) {
@@ -607,46 +612,34 @@ contract JBRouterTerminal is
     function _bestPoolLiquidity(address tokenA, address tokenB) internal view returns (uint128 bestLiquidity) {
         // Search V3.
         for (uint256 i; i < 4; i++) {
-            address poolAddr = FACTORY.getPool(tokenA, tokenB, FEE_TIERS[i]);
+            // slither-disable-next-line calls-loop
+            address poolAddr = FACTORY.getPool(tokenA, tokenB, _FEE_TIERS[i]);
             if (poolAddr == address(0)) continue;
 
+            // slither-disable-next-line calls-loop
             uint128 liquidity = IUniswapV3Pool(poolAddr).liquidity();
             if (liquidity > bestLiquidity) bestLiquidity = liquidity;
         }
 
-        // Search V4.
-        uint128 v4Best = _bestV4PoolLiquidity(tokenA, tokenB);
-        if (v4Best > bestLiquidity) bestLiquidity = v4Best;
-    }
-
-    /// @notice Find the highest liquidity across V4 vanilla pools for a token pair.
-    /// @param tokenA One token in the pair.
-    /// @param tokenB The other token in the pair.
-    /// @return bestLiquidity The highest liquidity found across V4 pools.
-    function _bestV4PoolLiquidity(address tokenA, address tokenB) internal view returns (uint128 bestLiquidity) {
-        if (address(POOL_MANAGER) == address(0)) return 0;
-
-        // Convert WETH -> address(0) for V4 native ETH representation.
-        address v4A = tokenA == address(WETH) ? address(0) : tokenA;
-        address v4B = tokenB == address(WETH) ? address(0) : tokenB;
-
-        // Sort currencies (currency0 < currency1).
-        (address sorted0, address sorted1) = v4A < v4B ? (v4A, v4B) : (v4B, v4A);
-
-        for (uint256 i; i < 4; i++) {
-            PoolKey memory key = PoolKey({
-                currency0: Currency.wrap(sorted0),
-                currency1: Currency.wrap(sorted1),
-                fee: V4_FEES[i],
-                tickSpacing: V4_TICK_SPACINGS[i],
-                hooks: IHooks(address(0))
-            });
-
-            (uint160 sqrtPriceX96,,,) = POOL_MANAGER.getSlot0(key.toId());
-            if (sqrtPriceX96 == 0) continue;
-
-            uint128 liquidity = POOL_MANAGER.getLiquidity(key.toId());
-            if (liquidity > bestLiquidity) bestLiquidity = liquidity;
+        // Search V4 — reuse _discoverV4Pool with current best.
+        PoolInfo memory v4Result = _discoverV4Pool(
+            tokenA,
+            tokenB,
+            bestLiquidity,
+            PoolInfo({
+                isV4: false,
+                v3Pool: IUniswapV3Pool(address(0)),
+                v4Key: PoolKey({
+                    currency0: Currency.wrap(address(0)),
+                    currency1: Currency.wrap(address(0)),
+                    fee: 0,
+                    tickSpacing: 0,
+                    hooks: IHooks(address(0))
+                })
+            })
+        );
+        if (v4Result.isV4) {
+            bestLiquidity = POOL_MANAGER.getLiquidity(v4Result.v4Key.toId());
         }
     }
 
@@ -821,11 +814,13 @@ contract JBRouterTerminal is
     function _settleV4(Currency currency, uint256 amount) internal {
         if (Currency.unwrap(currency) == address(0)) {
             // Native ETH: contract already holds raw ETH.
+            // slither-disable-next-line unused-return
             POOL_MANAGER.settle{value: amount}();
         } else {
             // ERC20: sync then transfer then settle.
             POOL_MANAGER.sync(currency);
             IERC20(Currency.unwrap(currency)).safeTransfer(address(POOL_MANAGER), amount);
+            // slither-disable-next-line unused-return
             POOL_MANAGER.settle();
         }
     }
@@ -945,6 +940,7 @@ contract JBRouterTerminal is
         returns (uint256 minAmountOut)
     {
         PoolId id = key.toId();
+        // slither-disable-next-line unused-return
         (, int24 tick,,) = POOL_MANAGER.getSlot0(id);
         uint128 liquidity = POOL_MANAGER.getLiquidity(id);
 
@@ -986,15 +982,27 @@ contract JBRouterTerminal is
 
         // Search V3.
         for (uint256 i; i < 4; i++) {
-            address poolAddr = FACTORY.getPool(normalizedTokenIn, normalizedTokenOut, FEE_TIERS[i]);
+            // slither-disable-next-line calls-loop
+            address poolAddr = FACTORY.getPool(normalizedTokenIn, normalizedTokenOut, _FEE_TIERS[i]);
 
             if (poolAddr == address(0)) continue;
 
+            // slither-disable-next-line calls-loop
             uint128 poolLiquidity = IUniswapV3Pool(poolAddr).liquidity();
 
             if (poolLiquidity > bestLiquidity) {
                 bestLiquidity = poolLiquidity;
-                bestPool = PoolInfo({isV4: false, v3Pool: IUniswapV3Pool(poolAddr), v4Key: _emptyPoolKey()});
+                bestPool = PoolInfo({
+                    isV4: false,
+                    v3Pool: IUniswapV3Pool(poolAddr),
+                    v4Key: PoolKey({
+                        currency0: Currency.wrap(address(0)),
+                        currency1: Currency.wrap(address(0)),
+                        fee: 0,
+                        tickSpacing: 0,
+                        hooks: IHooks(address(0))
+                    })
+                });
             }
         }
 
@@ -1030,14 +1038,16 @@ contract JBRouterTerminal is
             PoolKey memory key = PoolKey({
                 currency0: Currency.wrap(sorted0),
                 currency1: Currency.wrap(sorted1),
-                fee: V4_FEES[i],
-                tickSpacing: V4_TICK_SPACINGS[i],
+                fee: _V4_FEES[i],
+                tickSpacing: _V4_TICK_SPACINGS[i],
                 hooks: IHooks(address(0))
             });
 
+            // slither-disable-next-line unused-return,calls-loop
             (uint160 sqrtPriceX96,,,) = POOL_MANAGER.getSlot0(key.toId());
             if (sqrtPriceX96 == 0) continue;
 
+            // slither-disable-next-line calls-loop
             uint128 poolLiquidity = POOL_MANAGER.getLiquidity(key.toId());
             if (poolLiquidity > currentBestLiquidity) {
                 currentBestLiquidity = poolLiquidity;
@@ -1099,6 +1109,7 @@ contract JBRouterTerminal is
         while (true) {
             // Skip the destination check on the first iteration if we have a credit override.
             if (sourceProjectIdOverride == 0) {
+                // slither-disable-next-line calls-loop
                 destTerminal = DIRECTORY.primaryTerminalOf({projectId: destProjectId, token: token});
                 if (address(destTerminal) != address(0)) {
                     return (destTerminal, token, amount);
@@ -1106,6 +1117,7 @@ contract JBRouterTerminal is
             }
 
             // Use the override if provided, otherwise look up the project ID from the token.
+            // slither-disable-next-line calls-loop
             uint256 sourceProjectId =
                 sourceProjectIdOverride != 0 ? sourceProjectIdOverride : TOKENS.projectIdOf(IJBToken(token));
 
@@ -1119,6 +1131,7 @@ contract JBRouterTerminal is
                 _findCashOutPath({sourceProjectId: sourceProjectId, destProjectId: destProjectId});
 
             // Cash out the source project's tokens.
+            // slither-disable-next-line calls-loop
             amount = cashOutTerminal.cashOutTokensOf({
                 holder: address(this),
                 projectId: sourceProjectId,
@@ -1155,11 +1168,13 @@ contract JBRouterTerminal is
         address baseFallbackToken;
         IJBCashOutTerminal baseFallbackTerminal;
 
+        // slither-disable-next-line calls-loop
         IJBTerminal[] memory terminals = DIRECTORY.terminalsOf(sourceProjectId);
 
         for (uint256 i; i < terminals.length; i++) {
             // Check if this terminal supports the IJBCashOutTerminal interface.
             {
+                // slither-disable-next-line calls-loop
                 try IERC165(address(terminals[i])).supportsInterface(type(IJBCashOutTerminal).interfaceId) returns (
                     bool supported
                 ) {
@@ -1170,6 +1185,7 @@ contract JBRouterTerminal is
             }
 
             IJBCashOutTerminal terminal = IJBCashOutTerminal(address(terminals[i]));
+            // slither-disable-next-line calls-loop
             JBAccountingContext[] memory contexts = terminals[i].accountingContextsOf(sourceProjectId);
 
             for (uint256 j; j < contexts.length; j++) {
@@ -1177,6 +1193,7 @@ contract JBRouterTerminal is
 
                 // Priority 1: Does the destination project directly accept this token?
                 {
+                    // slither-disable-next-line calls-loop
                     IJBTerminal destTerminal =
                         DIRECTORY.primaryTerminalOf({projectId: destProjectId, token: contextToken});
                     if (address(destTerminal) != address(0)) {
@@ -1186,6 +1203,7 @@ contract JBRouterTerminal is
 
                 // Priority 2: Is this a JB project token (so we can recurse)?
                 if (address(fallbackTerminal) == address(0) && contextToken != JBConstants.NATIVE_TOKEN) {
+                    // slither-disable-next-line calls-loop
                     if (TOKENS.projectIdOf(IJBToken(contextToken)) != 0) {
                         fallbackToken = contextToken;
                         fallbackTerminal = terminal;
@@ -1258,6 +1276,7 @@ contract JBRouterTerminal is
                 sigDeadline: allowance.sigDeadline
             });
 
+            // slither-disable-next-line reentrancy-events
             try PERMIT2.permit({owner: _msgSender(), permitSingle: permitSingle, signature: allowance.signature}) {}
             catch (bytes memory reason) {
                 emit Permit2AllowanceFailed(token, _msgSender(), reason);
@@ -1309,17 +1328,6 @@ contract JBRouterTerminal is
         PERMIT2.transferFrom(from, to, uint160(amount), token);
     }
 
-    /// @notice Returns an empty PoolKey for use in V3-only PoolInfo structs.
-    function _emptyPoolKey() internal pure returns (PoolKey memory) {
-        return PoolKey({
-            currency0: Currency.wrap(address(0)),
-            currency1: Currency.wrap(address(0)),
-            fee: 0,
-            tickSpacing: 0,
-            hooks: IHooks(address(0))
-        });
-    }
-
     //*********************************************************************//
     // ---------------------------- receive  ----------------------------- //
     //*********************************************************************//