@bananapus/omnichain-deployers-v6 0.0.6 → 0.0.7
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/STYLE_GUIDE.md +11 -0
- package/foundry.toml +0 -3
- package/package.json +4 -4
- package/src/JBOmnichainDeployer.sol +4 -0
package/STYLE_GUIDE.md
CHANGED
|
@@ -371,6 +371,8 @@ jobs:
|
|
|
371
371
|
uses: foundry-rs/foundry-toolchain@v1
|
|
372
372
|
- name: Run tests
|
|
373
373
|
run: forge test --fail-fast --summary --detailed --skip "*/script/**"
|
|
374
|
+
env:
|
|
375
|
+
RPC_ETHEREUM_MAINNET: ${{ secrets.RPC_ETHEREUM_MAINNET }}
|
|
374
376
|
- name: Check contract sizes
|
|
375
377
|
run: FOUNDRY_PROFILE=ci_sizes forge build --sizes --skip "*/test/**" --skip "*/script/**" --skip SphinxUtils
|
|
376
378
|
```
|
|
@@ -435,6 +437,15 @@ Run `forge fmt` before committing. The `[fmt]` config in `foundry.toml` enforces
|
|
|
435
437
|
|
|
436
438
|
CI checks formatting via `forge fmt --check`.
|
|
437
439
|
|
|
440
|
+
### CI Secrets
|
|
441
|
+
|
|
442
|
+
| Secret | Purpose |
|
|
443
|
+
|--------|--------|
|
|
444
|
+
| `NPM_TOKEN` | npm publish access (used by `publish.yml`) |
|
|
445
|
+
| `RPC_ETHEREUM_MAINNET` | Ethereum mainnet RPC URL for fork tests (used by `test.yml`) |
|
|
446
|
+
|
|
447
|
+
Fork tests require `RPC_ETHEREUM_MAINNET` — they fail if it's missing.
|
|
448
|
+
|
|
438
449
|
### Branching
|
|
439
450
|
|
|
440
451
|
- `main` is the primary branch
|
package/foundry.toml
CHANGED
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@bananapus/omnichain-deployers-v6",
|
|
3
|
-
"version": "0.0.
|
|
3
|
+
"version": "0.0.7",
|
|
4
4
|
"license": "MIT",
|
|
5
5
|
"repository": {
|
|
6
6
|
"type": "git",
|
|
@@ -18,12 +18,12 @@
|
|
|
18
18
|
},
|
|
19
19
|
"dependencies": {
|
|
20
20
|
"@bananapus/721-hook-v6": "^0.0.13",
|
|
21
|
-
"@bananapus/buyback-hook-v6": "^0.0.
|
|
22
|
-
"@bananapus/core-v6": "^0.0.
|
|
21
|
+
"@bananapus/buyback-hook-v6": "^0.0.10",
|
|
22
|
+
"@bananapus/core-v6": "^0.0.14",
|
|
23
23
|
"@bananapus/ownable-v6": "^0.0.7",
|
|
24
24
|
"@bananapus/permission-ids-v6": "^0.0.6",
|
|
25
25
|
"@bananapus/suckers-v6": "^0.0.8",
|
|
26
|
-
"@openzeppelin/contracts": "^5.
|
|
26
|
+
"@openzeppelin/contracts": "^5.6.1",
|
|
27
27
|
"@uniswap/v4-core": "^1.0.2"
|
|
28
28
|
},
|
|
29
29
|
"devDependencies": {
|
|
@@ -209,6 +209,7 @@ contract JBOmnichainDeployer is
|
|
|
209
209
|
bool usesTiered721Hook = address(tiered721Hook) != address(0);
|
|
210
210
|
if (usesTiered721Hook) {
|
|
211
211
|
JBPayHookSpecification[] memory tiered721HookSpecs;
|
|
212
|
+
// slither-disable-next-line unused-return
|
|
212
213
|
(, tiered721HookSpecs) = IJBRulesetDataHook(address(tiered721Hook)).beforePayRecordedWith(context);
|
|
213
214
|
// The 721 hook returns a single spec (itself) whose amount is the total split amount.
|
|
214
215
|
if (tiered721HookSpecs.length > 0) {
|
|
@@ -386,6 +387,7 @@ contract JBOmnichainDeployer is
|
|
|
386
387
|
});
|
|
387
388
|
|
|
388
389
|
// Store the 721 hook separately from the custom data hook.
|
|
390
|
+
// slither-disable-next-line reentrancy-benign
|
|
389
391
|
tiered721HookOf[projectId] = hook;
|
|
390
392
|
|
|
391
393
|
// Launch the project, and sanity check the project ID.
|
|
@@ -469,6 +471,7 @@ contract JBOmnichainDeployer is
|
|
|
469
471
|
});
|
|
470
472
|
|
|
471
473
|
// Store the 721 hook separately from the custom data hook.
|
|
474
|
+
// slither-disable-next-line reentrancy-benign
|
|
472
475
|
tiered721HookOf[projectId] = hook;
|
|
473
476
|
|
|
474
477
|
// Transfer the hook's ownership to the project.
|
|
@@ -644,6 +647,7 @@ contract JBOmnichainDeployer is
|
|
|
644
647
|
});
|
|
645
648
|
|
|
646
649
|
// Store the 721 hook separately from the custom data hook.
|
|
650
|
+
// slither-disable-next-line reentrancy-benign
|
|
647
651
|
tiered721HookOf[projectId] = hook;
|
|
648
652
|
|
|
649
653
|
// Transfer the hook's ownership to the project.
|