@bananapus/721-hook-v6 0.0.14 → 0.0.16

package/src/JB721TiersHook.sol

@@ -7,7 +7,6 @@ import {IJBPrices} from "@bananapus/core-v6/src/interfaces/IJBPrices.sol";
 import {IJBRulesetDataHook} from "@bananapus/core-v6/src/interfaces/IJBRulesetDataHook.sol";
 import {IJBRulesets} from "@bananapus/core-v6/src/interfaces/IJBRulesets.sol";
 import {IJBSplits} from "@bananapus/core-v6/src/interfaces/IJBSplits.sol";
-import {JBConstants} from "@bananapus/core-v6/src/libraries/JBConstants.sol";
 import {JBMetadataResolver} from "@bananapus/core-v6/src/libraries/JBMetadataResolver.sol";
 import {JBRulesetMetadataResolver} from "@bananapus/core-v6/src/libraries/JBRulesetMetadataResolver.sol";
 import {JBAfterPayRecordedContext} from "@bananapus/core-v6/src/structs/JBAfterPayRecordedContext.sol";
@@ -17,8 +16,6 @@ import {JBRuleset} from "@bananapus/core-v6/src/structs/JBRuleset.sol";
 import {JBOwnable} from "@bananapus/ownable-v6/src/JBOwnable.sol";
 import {JBPermissionIds} from "@bananapus/permission-ids-v6/src/JBPermissionIds.sol";
 import {ERC2771Context} from "@openzeppelin/contracts/metatx/ERC2771Context.sol";
-import {IERC20} from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
-import {SafeERC20} from "@openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol";
 import {Context} from "@openzeppelin/contracts/utils/Context.sol";
 import {IERC165} from "@openzeppelin/contracts/utils/introspection/IERC165.sol";
 import {JB721Hook} from "./abstract/JB721Hook.sol";
@@ -26,7 +23,6 @@ import {IJB721TiersHook} from "./interfaces/IJB721TiersHook.sol";
 import {IJB721TiersHookStore} from "./interfaces/IJB721TiersHookStore.sol";
 import {IJB721TokenUriResolver} from "./interfaces/IJB721TokenUriResolver.sol";
 import {JB721TiersHookLib} from "./libraries/JB721TiersHookLib.sol";
-import {mulDiv} from "@prb/math/src/Common.sol";
 import {JB721TiersRulesetMetadataResolver} from "./libraries/JB721TiersRulesetMetadataResolver.sol";
 import {JB721InitTiersConfig} from "./structs/JB721InitTiersConfig.sol";
 import {JB721Tier} from "./structs/JB721Tier.sol";
@@ -41,8 +37,6 @@ import {JB721TiersSetDiscountPercentConfig} from "./structs/JB721TiersSetDiscoun
 /// information specified by the payer. The project's owner can enable NFT cash outs through this hook, allowing
 /// holders to burn their NFTs to reclaim funds from the project (in proportion to the NFT's price).
 contract JB721TiersHook is JBOwnable, ERC2771Context, JB721Hook, IJB721TiersHook {
-    using SafeERC20 for IERC20;
-
     //*********************************************************************//
     // --------------------------- custom errors ------------------------- //
     //*********************************************************************//
@@ -59,6 +53,9 @@ contract JB721TiersHook is JBOwnable, ERC2771Context, JB721Hook, IJB721TiersHook
     // --------------- public immutable stored properties ---------------- //
     //*********************************************************************//
 
+    /// @notice The contract that exposes price feeds for currency conversions.
+    IJBPrices public immutable override PRICES;
+
     /// @notice The contract storing and managing project rulesets.
     IJBRulesets public immutable override RULESETS;
 
@@ -94,9 +91,8 @@ contract JB721TiersHook is JBOwnable, ERC2771Context, JB721Hook, IJB721TiersHook
 
     /// @notice Packed context for the pricing of this contract's tiers.
     /// @dev Packed into a uint256:
-    /// - currency in bits 0-31 (32 bits),
-    /// - pricing decimals in bits 32-39 (8 bits), and
-    /// - prices contract in bits 40-199 (160 bits).
+    /// - currency in bits 0-31 (32 bits), and
+    /// - pricing decimals in bits 32-39 (8 bits).
     uint256 internal _packedPricingContext;
 
     //*********************************************************************//
@@ -105,6 +101,7 @@ contract JB721TiersHook is JBOwnable, ERC2771Context, JB721Hook, IJB721TiersHook
 
     /// @param directory A directory of terminals and controllers for projects.
     /// @param permissions A contract storing permissions.
+    /// @param prices A contract that exposes price feeds for currency conversions.
     /// @param rulesets A contract storing and managing project rulesets.
     /// @param store The contract which stores the NFT's data.
     /// @param splits The contract that stores and manages splits.
@@ -112,6 +109,7 @@ contract JB721TiersHook is JBOwnable, ERC2771Context, JB721Hook, IJB721TiersHook
     constructor(
         IJBDirectory directory,
         IJBPermissions permissions,
+        IJBPrices prices,
         IJBRulesets rulesets,
         IJB721TiersHookStore store,
         IJBSplits splits,
@@ -121,6 +119,7 @@ contract JB721TiersHook is JBOwnable, ERC2771Context, JB721Hook, IJB721TiersHook
         JB721Hook(directory)
         ERC2771Context(trustedForwarder)
     {
+        PRICES = prices;
         RULESETS = rulesets;
         STORE = store;
         SPLITS = splits;
@@ -146,19 +145,17 @@ contract JB721TiersHook is JBOwnable, ERC2771Context, JB721Hook, IJB721TiersHook
     }
 
     /// @notice Context for the pricing of this hook's tiers.
-    /// @dev If the `prices` contract is the zero address, this contract only accepts payments in the `currency` token.
     /// @return currency The currency used for tier prices.
     /// @return decimals The amount of decimals being used in tier prices.
-    /// @return prices The prices contract used to resolve the value of payments in currencies other than `currency`.
-    function pricingContext() external view override returns (uint256 currency, uint256 decimals, IJBPrices prices) {
+    function pricingContext() external view override returns (uint256 currency, uint256 decimals) {
         // Get a reference to the packed pricing context.
         uint256 packed = _packedPricingContext;
         // currency in bits 0-31 (32 bits).
+        // forge-lint: disable-next-line(unsafe-typecast)
         currency = uint256(uint32(packed));
         // pricing decimals in bits 32-39 (8 bits).
+        // forge-lint: disable-next-line(unsafe-typecast)
         decimals = uint256(uint8(packed >> 32));
-        // prices contract in bits 40-199 (160 bits).
-        prices = IJBPrices(address(uint160(packed >> 40)));
     }
 
     //*********************************************************************//
@@ -188,32 +185,30 @@ contract JB721TiersHook is JBOwnable, ERC2771Context, JB721Hook, IJB721TiersHook
         hookSpecifications = new JBPayHookSpecification[](1);
 
         // Calculate per-tier split amounts via the library.
-        (uint256 totalSplitAmount, bytes memory splitMetadata) =
-            JB721TiersHookLib.calculateSplitAmounts(STORE, address(this), METADATA_ID_TARGET, context.metadata);
+        (uint256 totalSplitAmount, bytes memory splitMetadata) = JB721TiersHookLib.calculateSplitAmounts({
+            store: STORE, hook: address(this), metadataIdTarget: METADATA_ID_TARGET, metadata: context.metadata
+        });
 
         // Convert split amounts from tier pricing to payment token denomination if currencies differ.
         if (totalSplitAmount != 0) {
-            (totalSplitAmount, splitMetadata) = JB721TiersHookLib.convertSplitAmounts(
-                totalSplitAmount,
-                splitMetadata,
-                _packedPricingContext,
-                context.projectId,
-                context.amount.currency,
-                context.amount.decimals
-            );
+            (totalSplitAmount, splitMetadata) = JB721TiersHookLib.convertSplitAmounts({
+                totalSplitAmount: totalSplitAmount,
+                splitMetadata: splitMetadata,
+                packedPricingContext: _packedPricingContext,
+                prices: PRICES,
+                projectId: context.projectId,
+                amountCurrency: context.amount.currency,
+                amountDecimals: context.amount.decimals
+            });
         }
 
         // Adjust weight so the terminal mints tokens only for the amount that actually enters the project.
-        if (totalSplitAmount == 0 || STORE.flagsOf(address(this)).issueTokensForSplits) {
-            // No splits, or hook configured to give full token credit regardless — full weight.
-            weight = context.weight;
-        } else if (context.amount.value > totalSplitAmount) {
-            // Partial splits — scale weight by the fraction that enters the project.
-            weight = mulDiv(context.weight, context.amount.value - totalSplitAmount, context.amount.value);
-        } else {
-            // Splits consume the entire payment — no tokens should be minted.
-            weight = 0;
-        }
+        weight = JB721TiersHookLib.calculateWeight({
+            contextWeight: context.weight,
+            amountValue: context.amount.value,
+            totalSplitAmount: totalSplitAmount,
+            issueTokensForSplits: STORE.flagsOf(address(this)).issueTokensForSplits
+        });
 
         hookSpecifications[0] = JBPayHookSpecification({hook: this, amount: totalSplitAmount, metadata: splitMetadata});
     }
@@ -268,8 +263,6 @@ contract JB721TiersHook is JBOwnable, ERC2771Context, JB721Hook, IJB721TiersHook
         packed |= uint256(tiersConfig.currency);
         // pack the pricing decimals in bits 32-39 (8 bits).
         packed |= uint256(tiersConfig.decimals) << 32;
-        // pack the prices contract in bits 40-199 (160 bits).
-        packed |= uint256(uint160(address(tiersConfig.prices))) << 40;
         // Store the packed value.
         // slither-disable-next-line events-maths
         _packedPricingContext = packed;
@@ -287,9 +280,14 @@ contract JB721TiersHook is JBOwnable, ERC2771Context, JB721Hook, IJB721TiersHook
 
         // Record the tiers in this hook's store and set any tier split groups.
         if (tiersConfig.tiers.length != 0) {
-            JB721TiersHookLib.recordAddTiersFor(
-                STORE, SPLITS, projectId, address(this), _msgSender(), tiersConfig.tiers
-            );
+            JB721TiersHookLib.recordAddTiersFor({
+                store: STORE,
+                splits: SPLITS,
+                projectId: projectId,
+                hookAddress: address(this),
+                caller: _msgSender(),
+                tiersToAdd: tiersConfig.tiers
+            });
         }
 
         // Set the flags if needed.
@@ -343,9 +341,15 @@ contract JB721TiersHook is JBOwnable, ERC2771Context, JB721Hook, IJB721TiersHook
         });
 
         // Delegate to the library (via DELEGATECALL) for tier removal, addition, event emission, and split setting.
-        JB721TiersHookLib.adjustTiersFor(
-            STORE, SPLITS, PROJECT_ID, address(this), _msgSender(), tiersToAdd, tierIdsToRemove
-        );
+        JB721TiersHookLib.adjustTiersFor({
+            store: STORE,
+            splits: SPLITS,
+            projectId: PROJECT_ID,
+            hookAddress: address(this),
+            caller: _msgSender(),
+            tiersToAdd: tiersToAdd,
+            tierIdsToRemove: tierIdsToRemove
+        });
     }
 
     /// @notice Manually mint NFTs from the provided tiers .
@@ -376,7 +380,7 @@ contract JB721TiersHook is JBOwnable, ERC2771Context, JB721Hook, IJB721TiersHook
             uint256 tokenId = tokenIds[i];
 
             // Mint the NFT.
-            _mint(beneficiary, tokenId);
+            _mint({to: beneficiary, tokenId: tokenId});
 
             emit Mint({
                 tokenId: tokenId, tierId: tierIds[i], beneficiary: beneficiary, totalAmountPaid: 0, caller: _msgSender()
@@ -427,18 +431,24 @@ contract JB721TiersHook is JBOwnable, ERC2771Context, JB721Hook, IJB721TiersHook
         }
     }
 
-    /// @notice Update this hook's URI metadata properties.
-    /// @dev Only this contract's owner can set the metadata.
+    /// @notice Update this hook's metadata properties.
+    /// @dev Only this contract's owner or an operator with the `SET_721_METADATA` permission can set the metadata.
+    /// @param name The new collection name. Send empty to leave unchanged.
+    /// @param symbol The new collection symbol. Send empty to leave unchanged.
     /// @param baseUri The new base URI.
     /// @param contractUri The new contract URI.
     /// @param tokenUriResolver The new URI resolver.
     /// @param encodedIPFSUriTierId The ID of the tier to set the encoded IPFS URI of.
     /// @param encodedIPFSUri The encoded IPFS URI to set.
     function setMetadata(
+        string calldata name,
+        string calldata symbol,
         string calldata baseUri,
         string calldata contractUri,
         IJB721TokenUriResolver tokenUriResolver,
+        // forge-lint: disable-next-line(mixed-case-variable)
         uint256 encodedIPFSUriTierId,
+        // forge-lint: disable-next-line(mixed-case-variable)
         bytes32 encodedIPFSUri
     )
         external
@@ -449,6 +459,16 @@ contract JB721TiersHook is JBOwnable, ERC2771Context, JB721Hook, IJB721TiersHook
             account: owner(), projectId: PROJECT_ID, permissionId: JBPermissionIds.SET_721_METADATA
         });
 
+        if (bytes(name).length != 0) {
+            // Store the new collection name.
+            _setName(name);
+            emit SetName({name: name, caller: _msgSender()});
+        }
+        if (bytes(symbol).length != 0) {
+            // Store the new collection symbol.
+            _setSymbol(symbol);
+            emit SetSymbol({symbol: symbol, caller: _msgSender()});
+        }
         if (bytes(baseUri).length != 0) {
             // Store the new base URI.
             baseURI = baseUri;
@@ -509,7 +529,7 @@ contract JB721TiersHook is JBOwnable, ERC2771Context, JB721Hook, IJB721TiersHook
 
             // Mint the NFT.
             // slither-disable-next-line reentrency-events
-            _mint(reserveBeneficiary, tokenId);
+            _mint({to: reserveBeneficiary, tokenId: tokenId});
         }
     }
 
@@ -593,7 +613,7 @@ contract JB721TiersHook is JBOwnable, ERC2771Context, JB721Hook, IJB721TiersHook
 
             // Mint the NFT.
             // slither-disable-next-line reentrancy-events
-            _mint(beneficiary, tokenId);
+            _mint({to: beneficiary, tokenId: tokenId});
         }
     }
 
@@ -607,100 +627,106 @@ contract JB721TiersHook is JBOwnable, ERC2771Context, JB721Hook, IJB721TiersHook
         uint256 value;
         {
             bool valid;
-            (value, valid) = JB721TiersHookLib.normalizePaymentValue(
-                _packedPricingContext,
-                PROJECT_ID,
-                context.amount.value,
-                context.amount.currency,
-                context.amount.decimals
-            );
+            (value, valid) = JB721TiersHookLib.normalizePaymentValue({
+                packedPricingContext: _packedPricingContext,
+                prices: PRICES,
+                projectId: PROJECT_ID,
+                amountValue: context.amount.value,
+                amountCurrency: context.amount.currency,
+                amountDecimals: context.amount.decimals
+            });
             if (!valid) return;
         }
 
-        // Keep a reference to the number of NFT credits the beneficiary already has.
-        uint256 payCredits = payCreditsOf[context.beneficiary];
+        // Scope block to free stack slots before the distributeAll call below.
+        {
+            // Keep a reference to the number of NFT credits the beneficiary already has.
+            uint256 payCredits = payCreditsOf[context.beneficiary];
 
-        // Set the leftover amount as the initial value.
-        uint256 leftoverAmount = value;
+            // Set the leftover amount as the initial value.
+            uint256 leftoverAmount = value;
 
-        // If the payer is the beneficiary, combine their NFT credits with the amount paid.
-        uint256 unusedPayCredits;
-        if (context.payer == context.beneficiary) {
-            leftoverAmount += payCredits;
-        } else {
-            // Otherwise, the payer's NFT credits won't be used, and we keep track of the unused credits.
-            unusedPayCredits = payCredits;
-        }
+            // If the payer is the beneficiary, combine their NFT credits with the amount paid.
+            uint256 unusedPayCredits;
+            if (context.payer == context.beneficiary) {
+                leftoverAmount += payCredits;
+            } else {
+                // Otherwise, the payer's NFT credits won't be used, and we keep track of the unused credits.
+                unusedPayCredits = payCredits;
+            }
 
-        // Keep a reference to the boolean indicating whether paying more than the price of the NFTs being minted is
-        // allowed. Defaults to the collection's flag.
-        bool allowOverspending = !STORE.flagsOf(address(this)).preventOverspending;
+            // Keep a reference to the boolean indicating whether paying more than the price of the NFTs being minted
+            // is allowed. Defaults to the collection's flag.
+            bool allowOverspending = !STORE.flagsOf(address(this)).preventOverspending;
 
-        // Resolve the metadata.
-        (bool found, bytes memory metadata) = JBMetadataResolver.getDataFor({
-            id: JBMetadataResolver.getId({purpose: "pay", target: METADATA_ID_TARGET}), metadata: context.payerMetadata
-        });
+            // Resolve the metadata.
+            (bool found, bytes memory metadata) = JBMetadataResolver.getDataFor({
+                id: JBMetadataResolver.getId({purpose: "pay", target: METADATA_ID_TARGET}),
+                metadata: context.payerMetadata
+            });
 
-        if (found) {
-            // Keep a reference to the IDs of the tier be to minted.
-            uint16[] memory tierIdsToMint;
+            if (found) {
+                // Keep a reference to the IDs of the tier be to minted.
+                uint16[] memory tierIdsToMint;
 
-            // Keep a reference to the payer's flag indicating whether overspending is allowed.
-            bool payerAllowsOverspending;
+                // Keep a reference to the payer's flag indicating whether overspending is allowed.
+                bool payerAllowsOverspending;
 
-            // Decode the metadata.
-            (payerAllowsOverspending, tierIdsToMint) = abi.decode(metadata, (bool, uint16[]));
+                // Decode the metadata.
+                (payerAllowsOverspending, tierIdsToMint) = abi.decode(metadata, (bool, uint16[]));
 
-            // Make sure overspending is allowed if requested.
-            if (allowOverspending && !payerAllowsOverspending) {
-                allowOverspending = false;
-            }
+                // Make sure overspending is allowed if requested.
+                if (allowOverspending && !payerAllowsOverspending) {
+                    allowOverspending = false;
+                }
 
-            // Mint NFTs from the tiers as specified.
-            if (tierIdsToMint.length != 0) {
-                // slither-disable-next-line reentrancy-events,reentrancy-no-eth
-                leftoverAmount =
-                    _mintAll({amount: leftoverAmount, mintTierIds: tierIdsToMint, beneficiary: context.beneficiary});
+                // Mint NFTs from the tiers as specified.
+                if (tierIdsToMint.length != 0) {
+                    // slither-disable-next-line reentrancy-events,reentrancy-no-eth
+                    leftoverAmount = _mintAll({
+                        amount: leftoverAmount, mintTierIds: tierIdsToMint, beneficiary: context.beneficiary
+                    });
+                }
             }
-        }
-
-        // If overspending isn't allowed, revert.
-        if (leftoverAmount != 0 && !allowOverspending) revert JB721TiersHook_Overspending(leftoverAmount);
 
-        // Update NFT credits if they changed.
-        uint256 newPayCredits = leftoverAmount + unusedPayCredits;
-
-        if (newPayCredits != payCredits) {
-            if (newPayCredits > payCredits) {
-                emit AddPayCredits({
-                    amount: newPayCredits - payCredits,
-                    newTotalCredits: newPayCredits,
-                    account: context.beneficiary,
-                    caller: _msgSender()
-                });
-            } else {
-                emit UsePayCredits({
-                    amount: payCredits - newPayCredits,
-                    newTotalCredits: newPayCredits,
-                    account: context.beneficiary,
-                    caller: _msgSender()
-                });
+            // If overspending isn't allowed, revert.
+            if (leftoverAmount != 0 && !allowOverspending) revert JB721TiersHook_Overspending(leftoverAmount);
+
+            // Update NFT credits if they changed.
+            uint256 newPayCredits = leftoverAmount + unusedPayCredits;
+
+            if (newPayCredits != payCredits) {
+                if (newPayCredits > payCredits) {
+                    emit AddPayCredits({
+                        amount: newPayCredits - payCredits,
+                        newTotalCredits: newPayCredits,
+                        account: context.beneficiary,
+                        caller: _msgSender()
+                    });
+                } else {
+                    emit UsePayCredits({
+                        amount: payCredits - newPayCredits,
+                        newTotalCredits: newPayCredits,
+                        account: context.beneficiary,
+                        caller: _msgSender()
+                    });
+                }
+
+                payCreditsOf[context.beneficiary] = newPayCredits;
             }
-
-            payCreditsOf[context.beneficiary] = newPayCredits;
         }
 
         // Distribute any forwarded funds to tier split groups.
         if (context.hookMetadata.length != 0 && context.forwardedAmount.value != 0) {
-            // For ERC20 tokens, pull from terminal using the allowance it granted via _beforeTransferTo.
-            if (context.forwardedAmount.token != JBConstants.NATIVE_TOKEN) {
-                IERC20(context.forwardedAmount.token)
-                    .safeTransferFrom(msg.sender, address(this), context.forwardedAmount.value);
-            }
-
-            JB721TiersHookLib.distributeAll(
-                DIRECTORY, SPLITS, PROJECT_ID, address(this), context.forwardedAmount.token, context.hookMetadata
-            );
+            JB721TiersHookLib.distributeAll({
+                directory: DIRECTORY,
+                splits: SPLITS,
+                projectId: PROJECT_ID,
+                hookAddress: address(this),
+                token: context.forwardedAmount.token,
+                amount: context.forwardedAmount.value,
+                encodedSplitData: context.hookMetadata
+            });
         }
     }
 
@@ -732,7 +758,7 @@ contract JB721TiersHook is JBOwnable, ERC2771Context, JB721Hook, IJB721TiersHook
         JB721Tier memory tier = STORE.tierOfTokenId({hook: address(this), tokenId: tokenId, includeResolvedUri: false});
 
         // Record the transfers and keep a reference to where the token is coming from.
-        from = super._update(to, tokenId, auth);
+        from = super._update({to: to, tokenId: tokenId, auth: auth});
 
         // Transfers must not be paused (when not minting or burning).
         if (from != address(0)) {

package/src/JB721TiersHookProjectDeployer.sol

@@ -124,6 +124,7 @@ contract JB721TiersHookProjectDeployer is ERC2771Context, JBPermissioned, IJB721
         returns (uint256 rulesetId, IJB721TiersHook hook)
     {
         // Get the project's projects contract.
+        // forge-lint: disable-next-line(mixed-case-variable)
         IJBProjects PROJECTS = DIRECTORY.PROJECTS();
 
         // Enforce permissions.
@@ -256,7 +257,7 @@ contract JB721TiersHookProjectDeployer is ERC2771Context, JBPermissioned, IJB721
                     pausePay: payDataRulesetConfig.metadata.pausePay,
                     pauseCreditTransfers: payDataRulesetConfig.metadata.pauseCreditTransfers,
                     allowOwnerMinting: payDataRulesetConfig.metadata.allowOwnerMinting,
-                    allowSetCustomToken: false,
+                    allowSetCustomToken: payDataRulesetConfig.metadata.allowSetCustomToken,
                     allowTerminalMigration: payDataRulesetConfig.metadata.allowTerminalMigration,
                     allowSetTerminals: payDataRulesetConfig.metadata.allowSetTerminals,
                     allowSetController: payDataRulesetConfig.metadata.allowSetController,
@@ -324,7 +325,7 @@ contract JB721TiersHookProjectDeployer is ERC2771Context, JBPermissioned, IJB721
                     pausePay: payDataRulesetConfig.metadata.pausePay,
                     pauseCreditTransfers: payDataRulesetConfig.metadata.pauseCreditTransfers,
                     allowOwnerMinting: payDataRulesetConfig.metadata.allowOwnerMinting,
-                    allowSetCustomToken: false,
+                    allowSetCustomToken: payDataRulesetConfig.metadata.allowSetCustomToken,
                     allowTerminalMigration: payDataRulesetConfig.metadata.allowTerminalMigration,
                     allowSetTerminals: payDataRulesetConfig.metadata.allowSetTerminals,
                     allowSetController: payDataRulesetConfig.metadata.allowSetController,
@@ -390,7 +391,7 @@ contract JB721TiersHookProjectDeployer is ERC2771Context, JBPermissioned, IJB721
                     pausePay: payDataRulesetConfig.metadata.pausePay,
                     pauseCreditTransfers: payDataRulesetConfig.metadata.pauseCreditTransfers,
                     allowOwnerMinting: payDataRulesetConfig.metadata.allowOwnerMinting,
-                    allowSetCustomToken: false,
+                    allowSetCustomToken: payDataRulesetConfig.metadata.allowSetCustomToken,
                     allowTerminalMigration: payDataRulesetConfig.metadata.allowTerminalMigration,
                     allowSetTerminals: payDataRulesetConfig.metadata.allowSetTerminals,
                     allowSetController: payDataRulesetConfig.metadata.allowSetController,

package/src/JB721TiersHookStore.sol

@@ -62,6 +62,7 @@ contract JB721TiersHookStore is IJB721TiersHookStore {
     /// @custom:param hook The 721 contract that the tier belongs to.
     /// @custom:param tierId The ID of the tier to get the encoded IPFS URI of.
     /// @custom:returns The encoded IPFS URI.
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(address hook => mapping(uint256 tierId => bytes32)) public override encodedIPFSUriOf;
 
     /// @notice Returns the largest tier ID currently used on the provided 721 contract.
@@ -155,6 +156,7 @@ contract JB721TiersHookStore is IJB721TiersHookStore {
     /// @param hook The 721 contract that the encoded IPFS URI belongs to.
     /// @param tokenId The token ID of the 721 to get the encoded tier IPFS URI of.
     /// @return The encoded IPFS URI.
+    // forge-lint: disable-next-line(mixed-case-function)
     function encodedTierIPFSUriOf(address hook, uint256 tokenId) external view override returns (bytes32) {
         return encodedIPFSUriOf[hook][tierIdOfToken(tokenId)];
     }
@@ -532,6 +534,7 @@ contract JB721TiersHookStore is IJB721TiersHookStore {
 
         // slither-disable-next-line calls-loop
         return JB721Tier({
+            // forge-lint: disable-next-line(unsafe-typecast)
             id: uint32(tierId),
             price: storedTier.price,
             remainingSupply: storedTier.remainingSupply,
@@ -1067,7 +1070,9 @@ contract JB721TiersHookStore is IJB721TiersHookStore {
 
             // Apply a discount if needed.
             if (storedTier.discountPercent > 0) {
-                price -= mulDiv(price, storedTier.discountPercent, JB721Constants.DISCOUNT_DENOMINATOR);
+                price -= mulDiv({
+                    x: price, y: storedTier.discountPercent, denominator: JB721Constants.DISCOUNT_DENOMINATOR
+                });
             }
 
             // Make sure the `amount` is greater than or equal to the tier's price.
@@ -1178,12 +1183,14 @@ contract JB721TiersHookStore is IJB721TiersHookStore {
         }
 
         // Set the discount.
+        // forge-lint: disable-next-line(unsafe-typecast)
         storedTier.discountPercent = uint8(discountPercent);
     }
 
     /// @notice Record a new encoded IPFS URI for a tier.
     /// @param tierId The ID of the tier to set the encoded IPFS URI of.
     /// @param encodedIPFSUri The encoded IPFS URI to set for the tier.
+    // forge-lint: disable-next-line(mixed-case-function, mixed-case-variable)
     function recordSetEncodedIPFSUriOf(uint256 tierId, bytes32 encodedIPFSUri) external override {
         encodedIPFSUriOf[msg.sender][tierId] = encodedIPFSUri;
     }