@atlaskit/pragmatic-drag-and-drop 1.7.0 → 1.7.2

package/CHANGELOG.md

@@ -1,5 +1,43 @@
 # @atlaskit/pragmatic-drag-and-drop
 
+## 1.7.2
+
+### Patch Changes
+
+- [#164244](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/164244)
+  [`65021fc0267e2`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/65021fc0267e2) -
+  The cleanup functions returned by the following utilities now only work on the first call. This
+  was done to prevent unexpected side effects of calling a cleanup function multiple times.
+
+  - `@atlaskit/pragmatic-drag-and-drop/adapter/element`
+    - `draggable`
+    - `dropTargetForElements`
+    - `monitorForElements`
+  - `@atlaskit/pragmatic-drag-and-drop/adapter/text-selection`
+    - `dropTargetForTextSelection`
+    - `monitorForTextSelection`
+  - `@atlaskit/pragmatic-drag-and-drop/adapter/external`
+    - `dropTargetForExternal`
+    - `monitorForExternal`
+  - `@atlaskit/pragmatic-drag-and-drop-auto-scroll/element`
+    - `autoScrollForElements`
+    - `autoScrollWindowForElements`
+  - `@atlaskit/pragmatic-drag-and-drop-auto-scroll/external`
+    - `autoScrollForExternal`
+    - `autoScrollWindowForExternal`
+  - `@atlaskit/pragmatic-drag-and-drop-auto-scroll/text-selection`
+    - `autoScrollForTextSelection`
+    - `autoScrollWindowForTextSelection`
+
+## 1.7.1
+
+### Patch Changes
+
+- [#162456](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/162456)
+  [`f916af5aab898`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/f916af5aab898) -
+  Removes `@atlaskit/platform-feature-flags` as a dependency. Removes `@atlaskit/link` as a runtime
+  dependency, although it is still used in examples.
+
 ## 1.7.0
 
 ### Minor Changes

package/dist/cjs/adapter/element-adapter.js

@@ -12,6 +12,7 @@ var _getElementFromPointWithoutHoneyPot = require("../honey-pot-fix/get-element-
 var _makeHoneyPotFix = require("../honey-pot-fix/make-honey-pot-fix");
 var _makeAdapter = require("../make-adapter/make-adapter");
 var _combine = require("../public-utils/combine");
+var _once = require("../public-utils/once");
 var _addAttribute = require("../util/add-attribute");
 var _android = require("../util/android");
 var _getInput = require("../util/get-input");
@@ -271,7 +272,7 @@ function draggable(args) {
       });
     }
   }
-  return (0, _combine.combine)(
+  var cleanup = (0, _combine.combine)(
   // making the draggable register the adapter rather than drop targets
   // this is because you *must* have a draggable element to start a drag
   // but you _might_ not have any drop targets immediately
@@ -280,6 +281,10 @@ function draggable(args) {
     attribute: 'draggable',
     value: 'true'
   }));
+
+  // Wrapping in `once` to prevent unexpected side effects if consumers call
+  // the clean up function multiple times.
+  return (0, _once.once)(cleanup);
 }
 
 /** Common event payload for all events */

package/dist/cjs/make-adapter/make-drop-target.js

@@ -8,6 +8,7 @@ exports.makeDropTarget = makeDropTarget;
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
 var _toConsumableArray2 = _interopRequireDefault(require("@babel/runtime/helpers/toConsumableArray"));
 var _combine = require("../public-utils/combine");
+var _once = require("../public-utils/once");
 var _addAttribute = require("../util/add-attribute");
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
@@ -46,10 +47,14 @@ function makeDropTarget(_ref) {
         .replace(/\s{2,}/g, ' ').trim());
       }
     }
-    return (0, _combine.combine)((0, _addAttribute.addAttribute)(args.element, {
+    var cleanup = (0, _combine.combine)((0, _addAttribute.addAttribute)(args.element, {
       attribute: dropTargetDataAtt,
       value: 'true'
     }), addToRegistry(args));
+
+    // Wrapping in `once` to prevent unexpected side effects if consumers call
+    // the clean up function multiple times.
+    return (0, _once.once)(cleanup);
   }
   function getActualDropTargets(_ref2) {
     var _args$getData, _args$getData2, _args$getDropEffect, _args$getDropEffect2;

package/dist/cjs/make-adapter/make-monitor.js

@@ -6,6 +6,7 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.makeMonitor = makeMonitor;
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
+var _once = require("../public-utils/once");
 function _createForOfIteratorHelper(r, e) { var t = "undefined" != typeof Symbol && r[Symbol.iterator] || r["@@iterator"]; if (!t) { if (Array.isArray(r) || (t = _unsupportedIterableToArray(r)) || e && r && "number" == typeof r.length) { t && (r = t); var _n = 0, F = function F() {}; return { s: F, n: function n() { return _n >= r.length ? { done: !0 } : { done: !1, value: r[_n++] }; }, e: function e(r) { throw r; }, f: F }; } throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); } var o, a = !0, u = !1; return { s: function s() { t = t.call(r); }, n: function n() { var r = t.next(); return a = r.done, r; }, e: function e(r) { u = !0, o = r; }, f: function f() { try { a || null == t.return || t.return(); } finally { if (u) throw o; } } }; }
 function _unsupportedIterableToArray(r, a) { if (r) { if ("string" == typeof r) return _arrayLikeToArray(r, a); var t = {}.toString.call(r).slice(8, -1); return "Object" === t && r.constructor && (t = r.constructor.name), "Map" === t || "Set" === t ? Array.from(r) : "Arguments" === t || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(t) ? _arrayLikeToArray(r, a) : void 0; } }
 function _arrayLikeToArray(r, a) { (null == a || a > r.length) && (a = r.length); for (var e = 0, n = Array(a); e < a; e++) n[e] = r[e]; return n; }
@@ -33,14 +34,18 @@ function makeMonitor() {
 
     // if there is an active drag we need to see if this new monitor is relevant
     tryAddToActive(entry);
-    return function cleanup() {
+    function cleanup() {
       registry.delete(entry);
 
       // We need to stop publishing events during a drag to this monitor!
       if (dragging) {
         dragging.active.delete(entry);
       }
-    };
+    }
+
+    // Wrapping in `once` to prevent unexpected side effects if consumers call
+    // the clean up function multiple times.
+    return (0, _once.once)(cleanup);
   }
   function dispatchEvent(_ref) {
     var eventName = _ref.eventName,

package/dist/es2019/adapter/element-adapter.js

@@ -3,6 +3,7 @@ import { getElementFromPointWithoutHoneypot } from '../honey-pot-fix/get-element
 import { makeHoneyPotFix } from '../honey-pot-fix/make-honey-pot-fix';
 import { makeAdapter } from '../make-adapter/make-adapter';
 import { combine } from '../public-utils/combine';
+import { once } from '../public-utils/once';
 import { addAttribute } from '../util/add-attribute';
 import { androidFallbackText, isAndroid } from '../util/android';
 import { getInput } from '../util/get-input';
@@ -268,7 +269,7 @@ export function draggable(args) {
       });
     }
   }
-  return combine(
+  const cleanup = combine(
   // making the draggable register the adapter rather than drop targets
   // this is because you *must* have a draggable element to start a drag
   // but you _might_ not have any drop targets immediately
@@ -277,6 +278,10 @@ export function draggable(args) {
     attribute: 'draggable',
     value: 'true'
   }));
+
+  // Wrapping in `once` to prevent unexpected side effects if consumers call
+  // the clean up function multiple times.
+  return once(cleanup);
 }
 
 /** Common event payload for all events */

package/dist/es2019/make-adapter/make-drop-target.js

@@ -1,4 +1,5 @@
 import { combine } from '../public-utils/combine';
+import { once } from '../public-utils/once';
 import { addAttribute } from '../util/add-attribute';
 function copyReverse(array) {
   return array.slice(0).reverse();
@@ -35,10 +36,14 @@ export function makeDropTarget({
         .replace(/\s{2,}/g, ' ').trim());
       }
     }
-    return combine(addAttribute(args.element, {
+    const cleanup = combine(addAttribute(args.element, {
       attribute: dropTargetDataAtt,
       value: 'true'
     }), addToRegistry(args));
+
+    // Wrapping in `once` to prevent unexpected side effects if consumers call
+    // the clean up function multiple times.
+    return once(cleanup);
   }
   function getActualDropTargets({
     source,

package/dist/es2019/make-adapter/make-monitor.js

@@ -1,3 +1,4 @@
+import { once } from '../public-utils/once';
 export function makeMonitor() {
   const registry = new Set();
   let dragging = null;
@@ -22,14 +23,18 @@ export function makeMonitor() {
 
     // if there is an active drag we need to see if this new monitor is relevant
     tryAddToActive(entry);
-    return function cleanup() {
+    function cleanup() {
       registry.delete(entry);
 
       // We need to stop publishing events during a drag to this monitor!
       if (dragging) {
         dragging.active.delete(entry);
       }
-    };
+    }
+
+    // Wrapping in `once` to prevent unexpected side effects if consumers call
+    // the clean up function multiple times.
+    return once(cleanup);
   }
   function dispatchEvent({
     eventName,

package/dist/esm/adapter/element-adapter.js

@@ -4,6 +4,7 @@ import { getElementFromPointWithoutHoneypot } from '../honey-pot-fix/get-element
 import { makeHoneyPotFix } from '../honey-pot-fix/make-honey-pot-fix';
 import { makeAdapter } from '../make-adapter/make-adapter';
 import { combine } from '../public-utils/combine';
+import { once } from '../public-utils/once';
 import { addAttribute } from '../util/add-attribute';
 import { androidFallbackText, isAndroid } from '../util/android';
 import { getInput } from '../util/get-input';
@@ -263,7 +264,7 @@ export function draggable(args) {
       });
     }
   }
-  return combine(
+  var cleanup = combine(
   // making the draggable register the adapter rather than drop targets
   // this is because you *must* have a draggable element to start a drag
   // but you _might_ not have any drop targets immediately
@@ -272,6 +273,10 @@ export function draggable(args) {
     attribute: 'draggable',
     value: 'true'
   }));
+
+  // Wrapping in `once` to prevent unexpected side effects if consumers call
+  // the clean up function multiple times.
+  return once(cleanup);
 }
 
 /** Common event payload for all events */

package/dist/esm/make-adapter/make-drop-target.js

@@ -6,6 +6,7 @@ function _createForOfIteratorHelper(r, e) { var t = "undefined" != typeof Symbol
 function _unsupportedIterableToArray(r, a) { if (r) { if ("string" == typeof r) return _arrayLikeToArray(r, a); var t = {}.toString.call(r).slice(8, -1); return "Object" === t && r.constructor && (t = r.constructor.name), "Map" === t || "Set" === t ? Array.from(r) : "Arguments" === t || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(t) ? _arrayLikeToArray(r, a) : void 0; } }
 function _arrayLikeToArray(r, a) { (null == a || a > r.length) && (a = r.length); for (var e = 0, n = Array(a); e < a; e++) n[e] = r[e]; return n; }
 import { combine } from '../public-utils/combine';
+import { once } from '../public-utils/once';
 import { addAttribute } from '../util/add-attribute';
 function copyReverse(array) {
   return array.slice(0).reverse();
@@ -39,10 +40,14 @@ export function makeDropTarget(_ref) {
         .replace(/\s{2,}/g, ' ').trim());
       }
     }
-    return combine(addAttribute(args.element, {
+    var cleanup = combine(addAttribute(args.element, {
       attribute: dropTargetDataAtt,
       value: 'true'
     }), addToRegistry(args));
+
+    // Wrapping in `once` to prevent unexpected side effects if consumers call
+    // the clean up function multiple times.
+    return once(cleanup);
   }
   function getActualDropTargets(_ref2) {
     var _args$getData, _args$getData2, _args$getDropEffect, _args$getDropEffect2;

package/dist/esm/make-adapter/make-monitor.js

@@ -4,6 +4,7 @@ function _unsupportedIterableToArray(r, a) { if (r) { if ("string" == typeof r)
 function _arrayLikeToArray(r, a) { (null == a || a > r.length) && (a = r.length); for (var e = 0, n = Array(a); e < a; e++) n[e] = r[e]; return n; }
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
+import { once } from '../public-utils/once';
 export function makeMonitor() {
   var registry = new Set();
   var dragging = null;
@@ -26,14 +27,18 @@ export function makeMonitor() {
 
     // if there is an active drag we need to see if this new monitor is relevant
     tryAddToActive(entry);
-    return function cleanup() {
+    function cleanup() {
       registry.delete(entry);
 
       // We need to stop publishing events during a drag to this monitor!
       if (dragging) {
         dragging.active.delete(entry);
       }
-    };
+    }
+
+    // Wrapping in `once` to prevent unexpected side effects if consumers call
+    // the clean up function multiple times.
+    return once(cleanup);
   }
   function dispatchEvent(_ref) {
     var eventName = _ref.eventName,

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/pragmatic-drag-and-drop",
-	"version": "1.7.0",
+	"version": "1.7.2",
 	"description": "The core package for Pragmatic drag and drop - enabling fast drag and drop for any experience on any tech stack",
 	"repository": "https://github.com/atlassian/pragmatic-drag-and-drop",
 	"author": "Atlassian Pty Ltd",
@@ -62,14 +62,13 @@
 		"./types": "./src/entry-point/types.ts"
 	},
 	"dependencies": {
-		"@atlaskit/link": "^3.2.0",
-		"@atlaskit/platform-feature-flags": "^1.1.0",
 		"@babel/runtime": "^7.0.0",
 		"bind-event-listener": "^3.0.0",
 		"raf-schd": "^4.0.3"
 	},
 	"devDependencies": {
 		"@af/integration-testing": "workspace:^",
+		"@atlaskit/link": "^3.2.0",
 		"@atlaskit/visual-regression": "workspace:^",
 		"@emotion/react": "^11.7.1",
 		"@testing-library/dom": "^10.1.0",
@@ -105,10 +104,5 @@
 			]
 		}
 	},
-	"homepage": "https://atlassian.design/components/pragmatic-drag-and-drop/",
-	"platform-feature-flags": {
-		"dst-a11y__replace-anchor-with-link__design-system-": {
-			"type": "boolean"
-		}
-	}
+	"homepage": "https://atlassian.design/components/pragmatic-drag-and-drop/"
 }