@aliou/pi-guardrails 0.4.0 → 0.4.1

package/config.ts

@@ -98,20 +98,25 @@ class ConfigLoader {
     return merged;
   }
 
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  private mergeInto(target: any, source: any): void {
-    for (const key in source) {
-      if (source[key] === undefined) continue;
+  private mergeInto<TTarget extends object, TSource extends object>(
+    target: TTarget,
+    source: TSource,
+  ): void {
+    const t = target as Record<string, unknown>;
+    const s = source as Record<string, unknown>;
+
+    for (const key in s) {
+      if (s[key] === undefined) continue;
 
       if (
-        typeof source[key] === "object" &&
-        !Array.isArray(source[key]) &&
-        source[key] !== null
+        typeof s[key] === "object" &&
+        !Array.isArray(s[key]) &&
+        s[key] !== null
       ) {
-        if (!target[key]) target[key] = {};
-        this.mergeInto(target[key], source[key]);
+        if (!t[key]) t[key] = {};
+        this.mergeInto(t[key] as object, s[key] as object);
       } else {
-        target[key] = source[key];
+        t[key] = s[key];
       }
     }
   }
@@ -138,7 +143,7 @@ class ConfigLoader {
     config: GuardrailsConfig,
   ): Promise<void> {
     await mkdir(dirname(path), { recursive: true });
-    await writeFile(path, JSON.stringify(config, null, 2) + "\n", "utf-8");
+    await writeFile(path, `${JSON.stringify(config, null, 2)}\n`, "utf-8");
   }
 
   hasGlobalConfig(): boolean {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@aliou/pi-guardrails",
-  "version": "0.4.0",
+  "version": "0.4.1",
   "type": "module",
   "private": false,
   "keywords": [

package/settings-command.ts

@@ -3,12 +3,41 @@ import { getSettingsListTheme } from "@mariozechner/pi-coding-agent";
 import { Key, matchesKey } from "@mariozechner/pi-tui";
 import { ArrayEditor } from "./array-editor";
 import { configLoader } from "./config";
-import type { GuardrailsConfig } from "./config-schema";
+import type { GuardrailsConfig, ResolvedConfig } from "./config-schema";
 import { PatternEditor } from "./pattern-editor";
 import { SectionedSettings, type SettingsSection } from "./sectioned-settings";
 
 type Tab = "local" | "global";
 
+// Typed feature UI definitions. Adding a key to ResolvedConfig.features
+// without adding it here will cause a type error.
+type FeatureKey = keyof ResolvedConfig["features"];
+
+interface FeatureUiDef {
+  label: string;
+  description: string;
+}
+
+const FEATURE_UI: Record<FeatureKey, FeatureUiDef> = {
+  preventBrew: {
+    label: "Prevent Homebrew",
+    description: "Block brew commands",
+  },
+  preventPython: {
+    label: "Prevent Python",
+    description: "Block python/pip/poetry commands. Use uv instead.",
+  },
+  protectEnvFiles: {
+    label: "Protect .env files",
+    description: "Block access to .env files containing secrets",
+  },
+  permissionGate: {
+    label: "Permission gate",
+    description:
+      "Prompt for confirmation on dangerous commands (rm -rf, sudo, etc.)",
+  },
+};
+
 export function registerSettingsCommand(pi: ExtensionAPI): void {
   pi.registerCommand("guardrails:settings", {
     description: "Configure guardrails (local/global)",
@@ -168,45 +197,26 @@ export function registerSettingsCommand(pi: ExtensionAPI): void {
               : configLoader.getGlobalConfig();
           const resolved = configLoader.getConfig();
 
+          const featureItems = (Object.keys(FEATURE_UI) as FeatureKey[]).map(
+            (key) => {
+              const def = FEATURE_UI[key];
+              return {
+                id: `features.${key}`,
+                label: def.label,
+                description: def.description,
+                currentValue:
+                  (config.features?.[key] ?? resolved.features[key])
+                    ? "enabled"
+                    : "disabled",
+                values: ["enabled", "disabled"],
+              };
+            },
+          );
+
           const sections: SettingsSection[] = [
             {
               label: "Features",
-              items: [
-                {
-                  id: "features.preventBrew",
-                  label: "Prevent Homebrew",
-                  description: "Block brew commands",
-                  currentValue:
-                    (config.features?.preventBrew ??
-                    resolved.features.preventBrew)
-                      ? "enabled"
-                      : "disabled",
-                  values: ["enabled", "disabled"],
-                },
-                {
-                  id: "features.protectEnvFiles",
-                  label: "Protect .env files",
-                  description: "Block access to .env files containing secrets",
-                  currentValue:
-                    (config.features?.protectEnvFiles ??
-                    resolved.features.protectEnvFiles)
-                      ? "enabled"
-                      : "disabled",
-                  values: ["enabled", "disabled"],
-                },
-                {
-                  id: "features.permissionGate",
-                  label: "Permission gate",
-                  description:
-                    "Prompt for confirmation on dangerous commands (rm -rf, sudo, etc.)",
-                  currentValue:
-                    (config.features?.permissionGate ??
-                    resolved.features.permissionGate)
-                      ? "enabled"
-                      : "disabled",
-                  values: ["enabled", "disabled"],
-                },
-              ],
+              items: featureItems,
             },
             {
               label: "Env Files",