@abaplint/transpiler-cli 2.7.162 → 2.7.163

package/build/bundle.js

@@ -21519,7 +21519,8 @@ class TypeUtils {
                 }
                 return false;
             }
-            else if (target instanceof cgeneric_type_1.CGenericType) {
+            else if (target instanceof cgeneric_type_1.CGenericType
+                || target instanceof basic_1.GenericObjectReferenceType) {
                 return false;
             }
             else if (target instanceof basic_1.XSequenceType || target instanceof basic_1.XStringType) {
@@ -21709,8 +21710,14 @@ class TypeUtils {
             if (source instanceof basic_1.TableType && source.isWithHeader() === false) {
                 return false;
             }
+            else if ((target instanceof basic_1.StringType || target instanceof basic_1.CharacterType)
+                && source instanceof basic_1.StructureType
+                && this.isCharLike(source)) {
+                return true;
+            }
             else if (source instanceof basic_1.DataReference
                 || source instanceof basic_1.ObjectReferenceType
+                || source instanceof basic_1.StructureType
                 || source instanceof basic_1.GenericObjectReferenceType) {
                 return false;
             }
@@ -23289,19 +23296,22 @@ const let_1 = __webpack_require__(/*! ./let */ "./node_modules/@abaplint/core/bu
 class ConvBody {
     runSyntax(node, scope, filename) {
         if (node === undefined) {
-            return;
+            throw new Error("ConvBody, node undefined");
         }
         let scoped = false;
         const l = node.findDirectExpression(Expressions.Let);
         if (l) {
             scoped = new let_1.Let().runSyntax(l, scope, filename);
         }
-        for (const s of node.findDirectExpressions(Expressions.Source)) {
-            new source_1.Source().runSyntax(s, scope, filename);
+        const s = node.findDirectExpression(Expressions.Source);
+        if (s === undefined) {
+            throw new Error("ConvBody, no source found");
         }
+        const sourceType = new source_1.Source().runSyntax(s, scope, filename);
         if (scoped === true) {
             scope.pop(node.getLastToken().getEnd());
         }
+        return sourceType;
     }
 }
 exports.ConvBody = ConvBody;
@@ -25647,6 +25657,7 @@ const _builtin_1 = __webpack_require__(/*! ../_builtin */ "./node_modules/@abapl
 const attribute_chain_1 = __webpack_require__(/*! ./attribute_chain */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/attribute_chain.js");
 const dereference_1 = __webpack_require__(/*! ./dereference */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/dereference.js");
 const _typed_identifier_1 = __webpack_require__(/*! ../../types/_typed_identifier */ "./node_modules/@abaplint/core/build/src/abap/types/_typed_identifier.js");
+const _type_utils_1 = __webpack_require__(/*! ../_type_utils */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_type_utils.js");
 /*
 * Type interference, valid scenarios:
 * typed = VALUE #( ... ).         right hand side must follow left hand type
@@ -25730,7 +25741,10 @@ class Source {
                 case "CONV":
                     {
                         const foundType = this.determineType(node, scope, filename, targetType);
-                        new conv_body_1.ConvBody().runSyntax(node.findDirectExpression(Expressions.ConvBody), scope, filename);
+                        const bodyType = new conv_body_1.ConvBody().runSyntax(node.findDirectExpression(Expressions.ConvBody), scope, filename);
+                        if (new _type_utils_1.TypeUtils(scope).isAssignable(foundType, bodyType) === false) {
+                            throw new Error("CONV: Types not compatible");
+                        }
                         this.addIfInferred(node, scope, filename, foundType);
                         return foundType;
                     }
@@ -27176,6 +27190,7 @@ const target_1 = __webpack_require__(/*! ../expressions/target */ "./node_module
 const basic_1 = __webpack_require__(/*! ../../types/basic */ "./node_modules/@abaplint/core/build/src/abap/types/basic/index.js");
 const fstarget_1 = __webpack_require__(/*! ../expressions/fstarget */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/fstarget.js");
 const inline_data_1 = __webpack_require__(/*! ../expressions/inline_data */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/expressions/inline_data.js");
+const _type_utils_1 = __webpack_require__(/*! ../_type_utils */ "./node_modules/@abaplint/core/build/src/abap/5_syntax/_type_utils.js");
 // todo: issue error for short APPEND if the source is without header line
 class Append {
     runSyntax(node, scope, filename) {
@@ -27218,7 +27233,17 @@ class Append {
             else if (targetType instanceof basic_1.VoidType) {
                 rowType = targetType;
             }
-            new source_1.Source().runSyntax(source, scope, filename, rowType);
+            const sourceType = new source_1.Source().runSyntax(source, scope, filename, rowType);
+            if (node.findDirectTokenByText("LINES")) {
+                if (new _type_utils_1.TypeUtils(scope).isAssignable(sourceType, targetType) === false) {
+                    throw new Error("Incompatible types");
+                }
+            }
+            else {
+                if (new _type_utils_1.TypeUtils(scope).isAssignable(sourceType, rowType) === false) {
+                    throw new Error("Incompatible types");
+                }
+            }
         }
         const from = node.findExpressionAfterToken("FROM");
         if (from && from.get() instanceof Expressions.Source) {
@@ -29146,7 +29171,11 @@ class GetReference {
         const type = new source_1.Source().runSyntax(s, scope, filename);
         const target = node.findDirectExpression(Expressions.Target);
         const inline = target === null || target === void 0 ? void 0 : target.findDirectExpression(Expressions.InlineData);
+        // todo: error if inline field symbol
         if (inline) {
+            if (type instanceof basic_1.AnyType) {
+                throw new Error("GET REFERENCE generic and inline declaration not possible");
+            }
             new inline_data_1.InlineData().runSyntax(inline, scope, filename, type ? new basic_1.DataReference(type) : undefined);
         }
         else if (target) {
@@ -30586,8 +30615,8 @@ class ReadTable {
         const fromSource = node.findExpressionAfterToken("FROM");
         if (fromSource) {
             const fromType = new source_1.Source().runSyntax(fromSource, scope, filename);
-            if (new _type_utils_1.TypeUtils(scope).isAssignable(fromType, basic_1.IntegerType.get()) === false) {
-                throw new Error("READ TABLE, FROM must be simple");
+            if (new _type_utils_1.TypeUtils(scope).isAssignable(fromType, rowType) === false) {
+                throw new Error("READ TABLE, FROM must be compatible");
             }
         }
         for (const s of sources) {
@@ -31929,7 +31958,10 @@ const _reference_1 = __webpack_require__(/*! ../_reference */ "./node_modules/@a
 class Write {
     runSyntax(node, scope, filename) {
         // todo, more
-        const second = node.getChildren()[1];
+        let second = node.getChildren()[1];
+        if (second.get() instanceof Expressions.WriteOffsetLength) {
+            second = node.getChildren()[2];
+        }
         for (const s of node.findAllExpressions(Expressions.Source)) {
             const type = new source_1.Source().runSyntax(s, scope, filename);
             if (s === second
@@ -50246,7 +50278,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.105.21";
+        return "2.105.26";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -56164,7 +56196,7 @@ ${indentation}CREATE OBJECT ${uniqueName2} EXPORTING textid = ${uniqueName1}.\n`
         return undefined;
     }
     downportRefSimple(high, lowFile, highSyntax) {
-        var _a;
+        var _a, _b;
         if (!(high.get() instanceof Statements.Move)
             || high.getChildren().length !== 4
             || high.getChildren()[2].getFirstToken().getStr().toUpperCase() !== "REF") {
@@ -56189,7 +56221,20 @@ ENDIF.
 GET REFERENCE OF <${uniqueName}> INTO ${target.concatTokens()}`;
         }
         else {
-            code = `GET REFERENCE OF ${sourceRef.concatTokens()} INTO ${target.concatTokens()}`;
+            const concat = target.concatTokens();
+            code = `GET REFERENCE OF ${sourceRef.concatTokens()} INTO ${concat}`;
+            // workaround for handling generic ANY type,
+            if (concat.toUpperCase().startsWith("DATA(")) {
+                const spag = highSyntax.spaghetti.lookupPosition(high.getFirstToken().getStart(), lowFile.getFilename());
+                if (spag !== undefined) {
+                    const found = spag.findVariable(sourceRef.concatTokens());
+                    const tt = found === null || found === void 0 ? void 0 : found.getType();
+                    if (tt instanceof basic_1.AnyType) {
+                        const tname = (_b = target.findFirstExpression(Expressions.TargetField)) === null || _b === void 0 ? void 0 : _b.concatTokens();
+                        code = `DATA ${tname} TYPE REF TO data.\nGET REFERENCE OF ${sourceRef.concatTokens()} INTO ${tname}`;
+                    }
+                }
+            }
         }
         const start = high.getFirstToken().getStart();
         const end = high.getLastToken().getStart();
@@ -78438,7 +78483,7 @@ class DataTranspiler {
         }
         const found = scope.findVariable(token.getStr());
         if (found === undefined) {
-            throw new Error("DataTranspiler, var not found, \"" + token.getStr() + "\"");
+            throw new Error("DataTranspiler, var not found, \"" + token.getStr() + "\", " + traversal.getFilename() + ", line: " + token.getRow());
         }
         let value = "";
         if (found.getValue() !== undefined && node.concatTokens().includes(" & ")) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@abaplint/transpiler-cli",
-  "version": "2.7.162",
+  "version": "2.7.163",
   "description": "Transpiler - Command Line Interface",
   "funding": "https://github.com/sponsors/larshp",
   "bin": {
@@ -26,12 +26,12 @@
   "author": "abaplint",
   "license": "MIT",
   "devDependencies": {
-    "@abaplint/transpiler": "^2.7.162",
+    "@abaplint/transpiler": "^2.7.163",
     "@types/glob": "^8.1.0",
     "glob": "=7.2.0",
     "@types/progress": "^2.0.7",
-    "@types/node": "^20.11.20",
-    "@abaplint/core": "^2.105.21",
+    "@types/node": "^20.11.22",
+    "@abaplint/core": "^2.105.26",
     "progress": "^2.0.3",
     "webpack": "^5.90.3",
     "webpack-cli": "^5.1.4",