@a11yfred/neighbor 1.0.3 → 1.0.4

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## 1.0.4  -  2026-05-13
+
+### Bug fixes
+
+- **`no-placeholder-only`** — no longer false-positives on `<input>` elements inside a `role="search"` landmark with an accessible name. The input is correctly labeled at the group level in that pattern.
+- **`no-dialog-without-close`** — no longer false-positives on `role="dialog"` elements whose children are passed dynamically (`{children}`). When a close button cannot be statically detected, the rule skips rather than reporting.
+
+---
+
 ## 1.0.0  -  2026-05-12
 
 ### Breaking change

package/lib/rules.js

@@ -845,6 +845,11 @@ export function makeNoPlaceholderOnly(h) {
           if (h.getElementName(node) !== 'input') return
           if (!h.hasAttr(node, 'placeholder')) return
           if (h.hasAccessibleName(node)) return
+          // An input inside a search landmark with an accessible name is labeled at group level.
+          // e.g. <form role="search" aria-label="..."><input placeholder="..." /></form>
+          for (const ancestor of h.getAncestors(node)) {
+            if (h.getRoleValue(ancestor) === 'search' && h.hasAccessibleName(ancestor)) return
+          }
           context.report({ node: h.getAttr(node, 'placeholder'), messageId: 'placeholderOnly' })
         },
       }
@@ -1206,6 +1211,13 @@ export function makeNoDialogWithoutClose(h) {
         [h.elementWithChildrenVisitor](node) {
           const opening = h.getOpeningElement(node)
           if (h.getRoleValue(opening) !== 'dialog') return
+          // If any child is a JSX expression container or spread, children are
+          // passed dynamically and cannot be statically inspected for a close button.
+          const children = node.children ?? []
+          const hasDynamicChildren = children.some(
+            c => c.type === 'JSXExpressionContainer' || c.type === 'JSXSpreadChild'
+          )
+          if (hasDynamicChildren) return
           const hasClose = h.getChildOpeningElementsFromWrapper(node).some(child => {
             const el = h.getElementName(child)
             const role = h.getRoleValue(child)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@a11yfred/neighbor",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "description": "Accessibility linting for a11yfred  -  ESLint (markup + content), Stylelint (CSS). Won't you be my neighbor?",
   "type": "module",
   "license": "MIT",
@@ -78,7 +78,7 @@
     }
   },
   "devDependencies": {
-    "@a11yfred/neighbor": "^1.0.1",
+    "@a11yfred/neighbor": "^1.0.3",
     "eslint": "^9.39.4",
     "eslint-plugin-jsx-a11y": "^6.10.2",
     "stylelint": "^17.11.0"