zuora_connect 2.0.57zc → 2.0.57

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0f5d12d5e34b5917eaf15c805ea90654725699822cb086f3461a20cd67401552
-  data.tar.gz: c00aed1135d2ce2efa0380f2079af2688fdbec7062f827931356ccacf9a4320c
+  metadata.gz: ae04188bc84b9fd594f1a2453128a9f7f8d489e9edd9ffd053ef51c09c32b02d
+  data.tar.gz: 3f19d9ed178c02807f44dbed319f5d2c5b47301de9bdc6666ce5df320cc8c40c
 SHA512:
-  metadata.gz: 7d01328db6ff56b2ae3470c7aa027a53f46ee4ab0802a0344d4bc6bb27afdba0147b257cfc92a8977a778e6af84cec8c1a80cd169fbbb8ba6f15efacfcf2135a
-  data.tar.gz: cce5a5fbbc65781d1cd17764c1b6d889b40b7eda3bfb5d5a491b961494a2789f3a8c04c1478ff53fb2901b58c249991b68cea315ef0b5d36ec86802a10d83000
+  metadata.gz: 9a1249ce65d708fe4bd792c890b49946ce1dea1c1ffba97a98ef397d98e69014e5f24021b700f0b2c980c2ce2292b601fbbb9550110f7e66b4099908ee0467ac
+  data.tar.gz: d40bdadd5ccbe7e2416f3ab354830f05aadec4c1c5faea71dccf8a87f1df0e012bfe4a49f1ed7f0a6e29c97ac4e3c04d8548ba48094f81d01f30c55c4484753b

data/app/assets/javascripts/hallway_wrapper/after.js

@@ -4,31 +4,12 @@ window.define = previousDefine;
 if (isHallway()) {
   $( document ).ajaxError(function( event, jqxhr, settings, thrownError ) {
     if ( jqxhr.status === 401) {
-      fetch("https://" + window.location.host + "/apps/v1/navigation").then(response => {
-        if (response.status === 401) {
-          deleteAllCookies();
-          window.location.href = '/apps/newlogin.do?retURL=' + window.location.pathname;
-        }
-      });
+      window.location.href = '/apps/newlogin.do?retURL=' + window.location.pathname;
     }
   });
 }
 
 function isHallway() {
-  var regex = new RegExp("(?<=\\/)services\\/.*");
-  if (regex.test(window.location.pathname)) {
-    return window.location.pathname.match(regex)[0]
-  }
-  return null;
-}
-
-function deleteAllCookies() {
-  var cookies = document.cookie.split(";");
-
-  for (var i = 0; i < cookies.length; i++) {
-    var cookie = cookies[i];
-    var eqPos = cookie.indexOf("=");
-    var name = eqPos > -1 ? cookie.substr(0, eqPos) : cookie;
-    document.cookie = name + "=;expires=Thu, 01 Jan 1970 00:00:00 GMT;path=/";
-  }
+  var regex = new RegExp("^/services/");
+  return window.location.pathname.match(regex);
 }

data/app/controllers/zuora_connect/static_controller.rb

@@ -1,11 +1,10 @@
 module ZuoraConnect
   class StaticController < ApplicationController
-    before_action :authenticate_connect_app_request, :except => [:metrics, :health, :initialize_app, :provision]
-    before_action :clear_connect_app_session,        :only =>   [:metrics, :health, :initialize_app, :provision]
-    after_action :persist_connect_app_session,       :except => [:metrics, :health, :initialize_app, :provision]
-
-    skip_before_action :verify_authenticity_token, :only => [:initialize_app, :provision]
-    http_basic_authenticate_with name: ENV['PROVISION_USER'], password: ENV['PROVISION_SECRET'], :only => [:provision]
+    before_action :authenticate_connect_app_request, :except => [:metrics, :health, :initialize_app]
+    before_action :clear_connect_app_session,        :only =>   [:metrics, :health, :initialize_app]
+    after_action :persist_connect_app_session,       :except => [:metrics, :health, :initialize_app]
+    
+    skip_before_action :verify_authenticity_token, :only => [:initialize_app]
 
     def metrics
       type = params[:type].present? ? params[:type] : "versions"
@@ -35,13 +34,11 @@ module ZuoraConnect
     def initialize_app
       begin
         authenticate_connect_app_request
-        unless performed?
-          @appinstance.new_session(:session => @appinstance.data_lookup(:session => session))
-          render json: {
-            message: 'Success',
-            status: 200
-          }, status: 200
-        end
+        @appinstance.new_session(:session => @appinstance.data_lookup(:session => session))
+        render json: {
+          message: "Success",
+          status: 200
+        }, status: 200
       rescue => ex
         Rails.logger.error("Failed to Initialize application", ex)
         if performed?
@@ -55,28 +52,6 @@ module ZuoraConnect
       end
     end
 
-    def provision
-      create_new_instance
-      unless performed?
-        render json: {
-          status: 200,
-          message: 'Success',
-          app_instance_id: @appinstance.id
-        }, status: 200
-      end
-    rescue StandardError => e
-      message = 'Failed to provision new instance'
-      if performed?
-        Rails.logger.error("#{message}: #{performed?}", e)
-      else
-        Rails.logger.error(message, e)
-        render json: {
-          status: 500,
-          message: message
-        }, status: 500
-      end
-    end
-
     private
 
     def clear_connect_app_session

data/app/models/zuora_connect/app_instance_base.rb

@@ -20,7 +20,7 @@ module ZuoraConnect
     BLANK_OBJECT_ID_LOOKUP = 'BlankValueSupplied'
     HOLDING_PATTERN_SLEEP = 5.seconds
     CONNECT_APPLICATION_ID = 0
-    CONNECT_COMMUNICATION_SLEEP = Rails.env.test? ? 0.seconds : 5.seconds
+    CONNECT_COMMUNICATION_SLEEP= 5.seconds
     IGNORED_LOCALS = ['fr', 'ja', 'es', 'zh', 'de']
     INTERNAL_HOSTS = []
     LOGIN_TENANT_DESTINATION = 'target_login'
@@ -98,9 +98,7 @@ module ZuoraConnect
         Redis.current.zrem("InstanceRefreshing", self.id)
       end
       if defined?(Resque.redis)
-        Resque.redis.zrange("PauseQueue", 0, -1).each do |key|
-          Resque.redis.zrem("PauseQueue", key) if key.split("__").first.to_i == self.id
-        end
+        Resque.redis.zrem("PauseQueue", self.id)
       end
       return true
     end
@@ -163,7 +161,6 @@ module ZuoraConnect
         end
 
         self.build_task(task_data: mock_task_data, session: session)
-        self.last_refresh = Time.now.to_i
       else
         time_expire = (session["#{self.id}::last_refresh"] || Time.now).to_i - INSTANCE_REFRESH_WINDOW.ago.to_i
 
@@ -205,14 +202,14 @@ module ZuoraConnect
           else
             self.new_session_message = "REBUILDING - Expires in #{time_expire} seconds"
           end
-          ZuoraConnect.logger.debug(self.new_session_message, self.default_ougai_items)
+          ZuoraConnect.logger.debug(self.new_session_message)
           self.build_task(task_data: session["#{self.id}::task_data"], session: session)
         end
       end
       return self
     rescue ZuoraConnect::Exceptions::HoldingPattern => ex
       while self.marked_for_refresh?
-        ZuoraConnect.logger.info("Holding - Expires in #{self.reset_mark_expires_at}. '#{self.new_session_message}'", self.default_ougai_items)
+        ZuoraConnect.logger.info("Holding - Expires in #{self.reset_mark_expires_at}. '#{self.new_session_message}'")
         sleep(HOLDING_PATTERN_SLEEP)
       end
       self.reload_attributes([:refresh_token, :oauth_expires_at, :access_token])
@@ -221,17 +218,17 @@ module ZuoraConnect
     rescue ZuoraConnect::Exceptions::MissMatch => ex
       self.delete_app_instance
       session = {}
-      ZuoraConnect.logger.error(ex, self.default_ougai_items.merge({app_instance_id_new: self.task_data['id']}))
+      ZuoraConnect.logger.error(ex, app_instance_id_new: self.task_data['id'])
       retry
     rescue ZuoraConnect::Exceptions::InvalidCredentialSet => ex
       raise
     rescue => ex
       if recoverable_session
-        ZuoraConnect.logger.warn("REBUILDING - Using backup expired cache", ex, self.default_ougai_items)
+        ZuoraConnect.logger.warn("REBUILDING - Using backup expired cache", ex)
         self.build_task(task_data: session["#{self.id}::task_data"], session: session)
         return self
       else
-        ZuoraConnect.logger.error("Failed new session", ex, self.default_ougai_items)
+        ZuoraConnect.logger.error("Failed new session", ex)
         raise
       end
     ensure
@@ -279,8 +276,11 @@ module ZuoraConnect
         #Check how app was deployed
         if self.id < 25000000 && !skip_connect 
           self.check_oauth_state
+          start = Time.now
           response = HTTParty.get(ZuoraConnect.configuration.url + "/api/#{self.api_version}/tools/tasks/#{self.id}.json",:body => {:access_token => self.access_token})
+          response_time = Time.now - start
 
+          ZuoraConnect.logger.debug("REFRESH TASK - Connect Task Info Request Time #{response_time.round(2).to_s}")
           if response.code == 200
             begin
               parsed_json = JSON.parse(response.body)
@@ -312,7 +312,7 @@ module ZuoraConnect
         refresh_count += 1
         if refresh_count < 3
           sleep(10)
-          ZuoraConnect.logger.debug("REFRESH TASK - Connection Failure Retrying(#{refresh_count})", ex, self.default_ougai_items)
+          ZuoraConnect.logger.debug("REFRESH TASK - Connection Failure Retrying(#{refresh_count})", ex)
           retry
         else
           ZuoraConnect.logger.fatal("REFRESH TASK - Connection Failed", ex)
@@ -321,17 +321,17 @@ module ZuoraConnect
       rescue ZuoraConnect::Exceptions::ConnectCommunicationError => ex
         refresh_count += 1
         if refresh_count < 3
-          ZuoraConnect.logger.debug("REFRESH TASK - Communication Failure Retrying(#{refresh_count})", ex, self.default_ougai_items)
+          ZuoraConnect.logger.debug("REFRESH TASK - Communication Failure Retrying(#{refresh_count})", ex)
           self.refresh_oauth if ex.code == 401
           retry
         else
-          ZuoraConnect.logger.fatal("REFRESH TASK - Communication Failed #{ex.code}", ex, self.default_ougai_items)
+          ZuoraConnect.logger.fatal("REFRESH TASK - Communication Failed #{ex.code}", ex)
           raise
         end
       end
     rescue => ex
       if self['zuora_logins'].present?
-        ZuoraConnect.logger.warn("REFRESH TASK - Fallback to local encrypted store", ex, self.default_ougai_items)
+        ZuoraConnect.logger.warn("REFRESH TASK - Fallback to local encrypted store", ex)
         skip_connect = true
         retry
       end
@@ -653,12 +653,16 @@ module ZuoraConnect
       end
 
       def refresh_oauth
-        refresh_oauth_count ||= 0        
-        response = HTTParty.post("#{ZuoraConnect.configuration.url}/oauth/token", body: {
-          :grant_type => "refresh_token",
-          :redirect_uri => ZuoraConnect.configuration.oauth_client_redirect_uri,
-          :refresh_token => self.refresh_token
-        })
+        refresh_oauth_count ||= 0
+        start = Time.now
+        params = {
+                  :grant_type => "refresh_token",
+                  :redirect_uri => ZuoraConnect.configuration.oauth_client_redirect_uri,
+                  :refresh_token => self.refresh_token
+                }
+        response = HTTParty.post("#{ZuoraConnect.configuration.url}/oauth/token",:body => params)
+        response_time = Time.now - start
+        ZuoraConnect.logger.debug("REFRESH OAUTH - In #{response_time.round(2).to_s}")
 
         if response.code == 200
           response_body = JSON.parse(response.body)
@@ -672,11 +676,11 @@ module ZuoraConnect
         end
       rescue *(ZuoraAPI::Login::CONNECTION_EXCEPTIONS + ZuoraAPI::Login::CONNECTION_READ_EXCEPTIONS) => ex
         if (refresh_oauth_count += 1) < 3
-          sleep(CONNECT_COMMUNICATION_SLEEP)
-          ZuoraConnect.logger.debug("REFRESH OAUTH - Connection Failure Retrying(#{refresh_oauth_count})", ex, self.default_ougai_items)
+          sleep(5)
+          ZuoraConnect.logger.debug("REFRESH OAUTH - Connection Failure Retrying(#{refresh_oauth_count})", ex)
           retry
         else
-          Rails.logger.fatal("REFRESH OAUTH - Connection Failed", ex, self.default_ougai_items)
+          ZuoraConnect.logger.fatal("REFRESH OAUTH - Connection Failed", ex)
           raise
         end
       rescue ZuoraConnect::Exceptions::ConnectCommunicationError => ex
@@ -687,10 +691,10 @@ module ZuoraConnect
         return if !self.oauth_expired?
 
         if (refresh_oauth_count += 1) < 3
-          ZuoraConnect.logger.debug("REFRESH OAUTH - Communication Failure Retrying(#{refresh_oauth_count})", ex, self.default_ougai_items)
+          ZuoraConnect.logger.debug("REFRESH OAUTH - Communication Failure Retrying(#{refresh_oauth_count})", ex)
           retry
         else
-          ZuoraConnect.logger.fatal("REFRESH OAUTH - Communication Failed #{ex.code}", ex, self.default_ougai_items)
+          ZuoraConnect.logger.fatal("REFRESH OAUTH - Communication Failed #{ex.code}", ex)
           raise
         end
       end
@@ -740,10 +744,10 @@ module ZuoraConnect
             end
           end
           if cached_instance.blank?
-            ZuoraConnect.logger.debug("Cached AppInstance Missing", self.default_ougai_items)
+            ZuoraConnect.logger.debug("Cached AppInstance Missing")
             return session
           else
-            ZuoraConnect.logger.debug("Cached AppInstance Found", self.default_ougai_items)
+            ZuoraConnect.logger.debug("Cached AppInstance Found")
             return decrypt_data(data: cached_instance, rescue_return: session).merge(session)
           end
         else
@@ -759,7 +763,7 @@ module ZuoraConnect
         if defined?(Redis.current)
           #Task data must be present and the last refresh cannot be old. We dont want to overwite new cache data with old
           if self.task_data.present? &&  (self.last_refresh.to_i > INSTANCE_REFRESH_WINDOW.ago.to_i)
-            ZuoraConnect.logger.debug("Caching AppInstance", self.default_ougai_items)
+            ZuoraConnect.logger.debug("Caching AppInstance")
             Redis.current.setex("AppInstance:#{self.id}", INSTANCE_REDIS_CACHE_PERIOD.to_i, self.encrypt_data(data: self.save_data))
           end
         end
@@ -823,10 +827,10 @@ module ZuoraConnect
           begin
             return JSON.parse(encryptor.decrypt_and_verify(CGI::unescape(data)))
           rescue ActiveSupport::MessageVerifier::InvalidSignature => ex
-            ZuoraConnect.logger.error("Error Decrypting", ex, self.default_ougai_items) if log_fatal
+            ZuoraConnect.logger.error("Error Decrypting", ex) if log_fatal
             return rescue_return
           rescue JSON::ParserError => ex
-            ZuoraConnect.logger.error("JSON Parse Error", ex, self.default_ougai_items) if log_fatal
+            ZuoraConnect.logger.error("JSON Parse Error", ex) if log_fatal
             return encryptor.decrypt_and_verify(CGI::unescape(data))
           end
         end
@@ -1123,15 +1127,6 @@ module ZuoraConnect
       # Data from each schema will be loaded into table(aggregate_name) into the public schema
       def self.refresh_aggregate_table(aggregate_name: 'all_tasks_processing', table_name: 'tasks', where_clause: "where status in ('Processing', 'Queued')", index_table: true, ignore_indexes: [])
         self.update_functions
-
-        sql_result = ActiveRecord::Base.connection.execute <<-eos
-          SELECT pid, relname, mode
-          FROM pg_locks l
-          JOIN pg_class t ON l.relation = t.oid AND t.relkind = 'r'
-          WHERE t.relname = '#{aggregate_name}' AND l.mode ='AccessExclusiveLock';
-        eos
-        raise ZuoraConnect::Exceptions::Error.new("An existing lock detected while dropping table '#{aggregate_name}'") if sql_result.count > 0
-
         if index_table
           ActiveRecord::Base.connection.execute('SELECT "shared_extensions".refresh_aggregate_table(\'%s\', \'%s\', %s, \'Index\', \'{%s}\');' % [aggregate_name, table_name, ActiveRecord::Base.connection.quote(where_clause), ignore_indexes.map { |index| "\"#{index}\"" }.join(',')])
         else
@@ -1219,16 +1214,6 @@ module ZuoraConnect
       end
     end
 
-    def self.without_sticking
-       if self.connection.respond_to?(:without_sticking)
-        self.connection.without_sticking do 
-          yield
-        end
-      else
-        yield
-      end
-    end
-
     method_hook :updateOption, :update_logins, :before => :check_oauth_state
     method_hook :new_session, :refresh, :build_task, :after => :apartment_switch
   end

data/app/views/zuora_connect/static/launch.html.erb

@@ -3,7 +3,12 @@
     <title>Select Task ID</title>
     <meta name="viewport" content="width=device-width,initial-scale=1">
     <style>
-      .connect-dialog {
+      body {
+        background-color: #EFEFEF;
+        margin: 0;
+      }
+
+      div.connect-dialog {
         width: 95%;
         max-width: 33em;
         margin: 4em auto 0;
@@ -11,11 +16,7 @@
         text-align: center;
       }
 
-      .connect-dialog div {
-        background-color: white;
-        color: #2E2F30;
-        text-align: center;
-        font-family: arial, sans-serif;
+      div.connect-dialog > div {
         margin: 0 0 1em;
         border: 1px solid #CCC;
         border-right-color: #999;
@@ -26,17 +27,19 @@
         border-top-right-radius: 9px;
         border-bottom-left-radius: 9px;
         border-bottom-right-radius: 9px;
+        background-color: white;
         padding: 7px 12% 0;
         box-shadow: 0 3px 8px rgba(50, 50, 50, 0.17);
       }
 
-      .connect-dialog h1 {
+      div.connect-dialog > h1 {
         font-size: 100%;
         color: #3D4B5A;
         line-height: 1.5em;
       }
 
-      .connect-dialog .launch_button {
+        
+      div.connect-dialog > div.launch_button {
         margin: 1em 0 1em;
         margin-right: auto;
         margin-left: auto;

data/config/routes.rb

@@ -3,10 +3,6 @@ ZuoraConnect::Engine.routes.draw do
   get '/internal/data' => 'static#metrics'
   post '/initialize_app' => 'static#initialize_app'
 
-  if ENV['PROVISION_USER'].present? && ENV['PROVISION_SECRET'].present?
-    post '/provision' => 'static#provision'
-  end
-
   namespace :api do
     namespace :v1 do
       resources :app_instance, :only => [:index], defaults: {format: :json} do

data/lib/resque/plugins/app_instance_job.rb

@@ -24,13 +24,9 @@ module Resque
           @appinstance.new_session(holding_pattern: true)
         rescue ActiveRecord::RecordNotFound => exception
           # If we can't find app_instance let make sure we cleanup
-          if Redis.current.zscore("AppInstance:Deleted", args['app_instance_id'].to_i).present?
-            Rails.logger.info("No instance found, purge")
-            ZuoraConnect::AppInstance.new(id: args['app_instance_id'].to_i).prune_data
-            return
-          else
-            raise
-          end
+          Rails.logger.info("No instance found, purge")
+          ZuoraConnect::AppInstance.new(id: args['app_instance_id'].to_i).prune_data
+          return
         rescue ActiveRecord::StatementInvalid => exception
           if (connection_count += 1) <= 3 &&
             (

data/lib/zuora_connect.rb

@@ -23,8 +23,6 @@ module ZuoraConnect
       case Rails.env.to_s
       when 'development'
         Rails.logger
-       when 'test'
-        Rails.logger
       else
         @logger ||= custom_logger(name: "Connect", level: Rails.logger.level)
       end

data/lib/zuora_connect/configuration.rb

@@ -7,7 +7,7 @@ module ZuoraConnect
 
     attr_accessor :oauth_client_id, :oauth_client_secret, :oauth_client_redirect_uri
 
-    attr_accessor :dev_mode_logins, :dev_mode_options, :dev_mode_mode, :dev_mode_appinstance, :dev_mode_user, :dev_mode_pass, :dev_mode_admin, :dev_mode_secret_access_key,:dev_mode_access_key_id,:aws_region, :s3_bucket_name, :s3_folder_name, :json_logging, :insert_migrations
+    attr_accessor :dev_mode_logins, :dev_mode_options, :dev_mode_mode, :dev_mode_appinstance, :dev_mode_user, :dev_mode_pass, :dev_mode_admin, :dev_mode_secret_access_key,:dev_mode_access_key_id,:aws_region, :s3_bucket_name, :s3_folder_name, :json_logging
 
     def initialize
       @default_locale = :en
@@ -19,7 +19,6 @@ module ZuoraConnect
       @additional_apartment_models = []
       @silencer_resque_finish = true
       @blpop_queue = false
-      @insert_migrations = true
 
       # Setting the app name for telegraf write
       @enable_metrics = false
@@ -43,7 +42,7 @@ module ZuoraConnect
       @aws_region = "us-west-2"
       @s3_bucket_name = "rbm-apps"
       @s3_folder_name = Rails.application.class.parent_name
-      @json_logging = Rails.env.development? || Rails.env.test? ? false : true
+      @json_logging = Rails.env.to_s == 'development' ? false : true
     end
 
     def private_key

data/lib/zuora_connect/controllers/helpers.rb

@@ -19,6 +19,7 @@ module ZuoraConnect
               ElasticAPM.set_label(:trace_id, request.uuid) if defined?(ElasticAPM) && ElasticAPM.running?
             end
           end
+          start_time = Time.now
           if request.headers["API-Token"].present?
             @appinstance = ZuoraConnect::AppInstance.find_by(:api_token => request.headers["API-Token"])
             ZuoraConnect.logger.debug("API REQUEST - API token") if @appinstance.present?
@@ -47,7 +48,7 @@ module ZuoraConnect
               render json: {"status": 401, "message": "Missing mapping or no deployment for '#{zuora_host}-#{zuora_entity_id}' ."}, status: :unauthorized
               return
             elsif appinstances.size > 1
-              render json: {"status": 401, "message": "More than one app instance binded to host and entity ids. Please indicate correct instance via 'zuora-instance-id' header", "instances": appinstances.map {|instance| instance.id }.sort }, status: :unauthorized
+              render json: {"status": 401, "message": "More than one app instance binded to host and entity ids. Please indicate correct instance via 'zuora-instance-id' header"}, status: :unauthorized
               return
             else
               @appinstance = appinstances.first
@@ -64,6 +65,10 @@ module ZuoraConnect
           else
             check_instance
           end
+
+          if @appinstance.present?
+            ZuoraConnect.logger.debug("Authenticate App API Request Completed In - #{(Time.now - start_time).round(2)}s")
+          end
         end
       end
 
@@ -96,6 +101,7 @@ module ZuoraConnect
               ElasticAPM.set_label(:trace_id, request.uuid)
             end
           end
+          start_time = Time.now
 
           if ZuoraConnect.configuration.mode == "Production"
             setup_instance_via_prod_mode
@@ -135,30 +141,32 @@ module ZuoraConnect
           rescue
             ZuoraConnect.logger.error(ex)
           end
+
+          ZuoraConnect.logger.debug("Authenticate App Request Completed In - #{(Time.now - start_time).round(2)}s")
         end
       rescue ZuoraConnect::Exceptions::InvalidCredentialSet => ex
         id = @appinstance.id
         ZuoraConnect::AppInstance.destroy(id)
         Apartment::Tenant.drop(id)
         render "zuora_connect/static/error_handled", :locals => {
-          :title => "Application Setup Error",
+          :title => "Application Setup Error", 
           :message => "Application cannot be run using Zuora Session. Delete old application \
           deployment and create new with Zuora Basic or OAuth credentials."
         }, :layout => false
-        return
+        return 
       rescue ZuoraConnect::Exceptions::AccessDenied => ex
         respond_to do |format|
-          format.html {
+          format.html { 
             render "zuora_connect/static/error_handled", :locals => {
-                :title => "Application State Error",
+                :title => "Application State Error", 
                 :message => ex.message
-              }, status: 401, layout: false
+              }, status: 401, layout: false 
           }
-          format.js {
+          format.js { 
             render "zuora_connect/static/error_handled", :locals => {
-                :title => "Application State Error",
+                :title => "Application State Error", 
                 :message => ex.message
-              }, status: 401, layout: false
+              }, status: 401, layout: false 
           }
           format.json { render json: {'errors' => ex.message}, status: 401 }
           format.all { render json: ex.message, status: 401 }
@@ -188,17 +196,17 @@ module ZuoraConnect
           raise ZuoraConnect::Exceptions::AccessDenied.new("User is not an authorized admin for this application") if raise_error
 
           respond_to do |format|
-            format.html {
+            format.html { 
               render "zuora_connect/static/error_handled", :locals => {
-                  :title => "Unauthorized",
+                  :title => "Unauthorized", 
                   :message => "User is not an authorized admin for this application"
                 }, status: 401, :layout => false
             }
-            format.js {
+            format.js { 
               render "zuora_connect/static/error_handled", :locals => {
-                  :title => "Unauthorized",
+                  :title => "Unauthorized", 
                   :message => "User is not an authorized admin for this application"
-                }, status: 401, :layout => false
+                }, status: 401, :layout => false 
             }
             format.json { render json: {'errors' => ex.message}, status: 401 }
             format.all { render json: ex.message, status: 401 }
@@ -219,80 +227,6 @@ module ZuoraConnect
         return (request.headers['ZuoraCurrentEntity'].present? || cookies['ZuoraCurrentEntity'].present?)
       end
 
-      def create_new_instance
-        ZuoraConnect::AppInstance.read_master_db do
-          Thread.current[:appinstance] = nil
-          ZuoraConnect.logger.with_fields = {} if ZuoraConnect.logger.is_a?(Ougai::Logger)
-          Rails.logger.with_fields = {} if Rails.logger.is_a?(Ougai::Logger)
-
-          if defined?(ElasticAPM) && ElasticAPM.running? && ElasticAPM.respond_to?(:set_label)
-            ElasticAPM.set_label(:trace_id, request.uuid)
-          end
-
-          zuora_host = request.headers['zuora-host']
-          zuora_entity_id = (request.headers['zuora-entity-ids'] || '').gsub(
-            '-',
-            ''
-          ).split(',').first
-
-          # Validate host present
-          if zuora_host.blank?
-            render json: {
-              status: 401,
-              message: 'zuora-host header was not supplied.'
-            }, status: :unauthorized
-            return
-          end
-
-          # Validate entity-ids present
-          if zuora_entity_id.blank?
-            render json: {
-              status: 401,
-              message: 'zuora-entity-ids header was not supplied.'
-            }, status: :unauthorized
-            return
-          end
-
-          rest_domain = ZuoraAPI::Login.new(url: "https://#{zuora_host}").rest_domain
-          app_instance_id = ZuoraConnect::AppInstance.where(
-            'zuora_entity_ids ?& array[:entities] AND zuora_domain = :host',
-            entities: [zuora_entity_id],
-            host: rest_domain
-          ).pluck(:id).first
-
-          if app_instance_id.present?
-            render json: {
-              status: 409,
-              message: 'Instance already exists.',
-              app_instance_id: app_instance_id
-            }, status: 409
-          else
-            Apartment::Tenant.switch!("public")
-            retry_count = 3
-            begin
-              @appinstance = new_instance(
-                next_instance_id,
-                zuora_entity_id,
-                rest_domain,
-                retry_count: retry_count
-              )
-            rescue ActiveRecord::RecordNotUnique
-              retry if (retry_count -= 1).positive?
-              return
-            end
-
-            app_instance_id = @appinstance.id
-          end
-
-          begin
-            Apartment::Tenant.switch!('public')
-            Apartment::Tenant.create(app_instance_id.to_s)
-          rescue Apartment::TenantExists
-            ZuoraConnect.logger.debug('Tenant Already Exists')
-          end
-        end
-      end
-
     private
       def setup_instance_via_prod_mode
         zuora_entity_id = request.headers['ZuoraCurrentEntity'] || cookies['ZuoraCurrentEntity']
@@ -300,7 +234,7 @@ module ZuoraConnect
         if zuora_entity_id.present?
           zuora_tenant_id = cookies['Zuora-Tenant-Id']
           zuora_user_id = cookies['Zuora-User-Id']
-          zuora_host = request.headers['HTTP_X_FORWARDED_HOST'] || request.headers['Zuora-Host'] || 'apisandbox.zuora.com'
+          zuora_host = request.headers["HTTP_X_FORWARDED_HOST"] || "apisandbox.zuora.com"
 
           zuora_details = {'host' => zuora_host, 'user_id' => zuora_user_id, 'tenant_id' => zuora_tenant_id, 'entity_id' => zuora_entity_id}
           auth_headers = {}
@@ -312,7 +246,7 @@ module ZuoraConnect
             auth_headers.merge!({'Authorization' => "ZSession-a3N2w #{zuora_client.get_session(prefix: false, auth_type: :basic)}"})
           else
             render "zuora_connect/static/error_handled", :locals => {
-              :title => "Missing Authorization Token",
+              :title => "Missing Authorization Token", 
               :message => "Zuora 'Zuora-Auth-Token' header and 'ZSession' cookie not present."
             }, :layout => false
             return
@@ -334,34 +268,27 @@ module ZuoraConnect
                 if zuora_tenant_id.to_s == "10548"
                   session.clear
                   render "zuora_connect/static/error_handled", :locals => {
-                    :title => "Security Testing",
+                    :title => "Security Testing", 
                     :message => "Ya we know it you"
                   }, :layout => false
                   return
                 else
-                  raise ZuoraConnect::Exceptions::Error.new("Header entity id does not match identity call entity id.")
+                  raise ZuoraConnect::Exceptions::Error.new("Header entity id does not match identity call entity id.") 
                 end
               end
 
-              ##
-              # If the ZSession was refreshed, but it's still the same user and they aren't launching from the side bar,
-              # we don't need to continue
-              is_different_user = identity.slice("entityId", "tenantId", "userId", "userProfileId") == (session["ZuoraCurrentIdentity"] || {}).slice("entityId", "tenantId", "userId", "userProfileId")
-              zuora_details["identity"]["entityId"] = identity['entityId']
               session["ZuoraCurrentIdentity"] = identity
               session["ZuoraCurrentEntity"] = identity['entityId']
               session["ZSession"] = cookies['ZSession']
-              if is_different_user || params[:sidebar_launch].to_s.to_bool
-                zuora_instance_id = nil
-                ZuoraConnect.logger.debug("UI Authorization", zuora: zuora_details)
-
-                client_describe, response = zuora_client.rest_call(
-                    url: zuora_client.rest_endpoint("genesis/user/info").gsub('v1/', ''),
-                    session_type: zuora_client.class == ZuoraAPI::Oauth ? :bearer : :basic,
-                    headers: auth_headers
-                )
-                session["ZuoraCurrentUserInfo"] = client_describe
-              end
+              zuora_instance_id = nil
+              zuora_details["identity"]["entityId"] = identity['entityId']
+
+              client_describe, response = zuora_client.rest_call(
+                url: zuora_client.rest_endpoint("genesis/user/info").gsub('v1/', ''), 
+                session_type: zuora_client.class == ZuoraAPI::Oauth ? :bearer : :basic, 
+                headers: auth_headers
+              )
+              session["ZuoraCurrentUserInfo"] = client_describe
             end
 
             #Find matching app instances.
@@ -369,7 +296,7 @@ module ZuoraConnect
               appinstances = ZuoraConnect::AppInstance.where("zuora_entity_ids ?& array[:entities] = true AND zuora_domain = :host AND id = :id", entities: [zuora_entity_id], host: zuora_client.rest_domain, id: zuora_instance_id.to_i).pluck(:id, :name)
             else
               #if app_instance_ids is present then permissions still controlled by connect
-              if params[:app_instance_ids].present?
+              if params[:app_instance_ids].present? 
                 navbar, response = zuora_client.rest_call(url: zuora_client.rest_endpoint("navigation"))
                 urls = navbar['menus'].map {|x| x['url']}
                 app_env = ENV["DEIS_APP"] || "xyz123"
@@ -377,39 +304,33 @@ module ZuoraConnect
                 if url.blank?
                   if navbar['menus'].map {|x| x['label']}.include?('Link Connect Account')
                     render "zuora_connect/static/error_handled", :locals => {
-                      :title => "Link Account",
+                      :title => "Link Account", 
                       :message => "Link Connect account to gain access to application."
                     }, :layout => false
                     return
                   end
-                  raise ZuoraConnect::Exceptions::APIError.new(message: "#{app_env} navbar url was blank", response: response)
+                  ZuoraConnect::Exceptions::APIError.new(message: "#{app_env} navbar url was blank", response: response)
                 else
-                  query_params = CGI.parse(URI.parse(url).query)
-                  app_instance_ids = query_params["app_instance_ids"][0]
-                  if app_instance_ids.present?
-                    begin
-                      task_ids = JSON.parse(Base64.urlsafe_decode64(app_instance_ids))
-
-                      appinstances = ZuoraConnect::AppInstance.where(:id => task_ids).pluck(:id, :name)
-                    rescue => ex
-                      raise ZuoraConnect::Exceptions::APIError.new(message: "Failure in parsing the navbar urls.", response: response)
-                    end
+                  begin
+                    task_ids = JSON.parse(Base64.urlsafe_decode64(CGI.parse(URI.parse(url).query)["app_instance_ids"][0]))
+                  rescue => ex
+                    raise ZuoraConnect::Exceptions::APIError.new(message: "Failure in parsing the navbar urls.", response: response)
                   end
                 end
+                appinstances = ZuoraConnect::AppInstance.where(:id => task_ids).pluck(:id, :name)
+              else
+                appinstances = ZuoraConnect::AppInstance.where("zuora_entity_ids ?& array[:entities] = true AND zuora_domain = :host", entities: [zuora_entity_id], host: zuora_client.rest_domain).pluck(:id, :name)
               end
-              appinstances ||= ZuoraConnect::AppInstance.where("zuora_entity_ids ?& array[:entities] = true AND zuora_domain = :host", entities: [zuora_entity_id], host: zuora_client.rest_domain).pluck(:id, :name)
             end
 
             zuora_user_id = cookies['Zuora-User-Id'] || session["ZuoraCurrentIdentity"]['userId']
 
+            #One deployed instance
             if appinstances.size == 1
               ZuoraConnect.logger.debug("Instance is #{appinstances.to_h.keys.first}")
               @appinstance = ZuoraConnect::AppInstance.find(appinstances.to_h.keys.first)
-            end
 
-            # One deployed instance with credentials
-            if defined?(@appinstance) && @appinstance['zuora_logins'].present?
-              #Add user/update
+              #Add user/update 
               begin
                 @zuora_user = ZuoraConnect::ZuoraUser.where(:zuora_user_id => zuora_user_id).first
               rescue ActiveRecord::StatementInvalid => ex
@@ -429,7 +350,7 @@ module ZuoraConnect
               else
                 ZuoraConnect.logger.debug("New zuora user object for #{zuora_user_id}")
                 @zuora_user = ZuoraConnect::ZuoraUser.create!(:zuora_user_id => zuora_user_id, :zuora_identity_response => {zuora_entity_id => session["ZuoraCurrentIdentity"]})
-              end
+              end 
               @zuora_user.session = session
               session["#{@appinstance.id}::user::localUserId"] = @zuora_user.id
               session["#{@appinstance.id}::user::email"] = session['ZuoraCurrentIdentity']["username"]
@@ -438,103 +359,97 @@ module ZuoraConnect
               session["appInstance"] = @appinstance.id
 
             #We have multiple, user must pick
-            elsif appinstances.size > 1
+            elsif appinstances.size > 1 
               ZuoraConnect.logger.debug("User must select instance. #{@names}")
               render "zuora_connect/static/launch", :locals => {:names => appinstances.to_h}, :layout => false
               return
 
             #We have no deployed instance for this tenant
-            else
-              #Ensure user can access oauth creation API
+            else 
+              #Ensure user can access oauth creation API 
               if !session["ZuoraCurrentUserInfo"]['permissions'].include?("permission.userManagement")
                 Thread.current[:appinstance] = nil
                 session["appInstance"] = nil
                 render "zuora_connect/static/error_handled", :locals => {
-                  :title => "Application can only complete its initial setup via platform administrator",
+                  :title => "Application can only complete its initial setup via platform administrator", 
                   :message => "Please contact admin who has user managment permissions in tenant and have them click and finish setup."
                 }, :layout => false
                 return
               end
               Apartment::Tenant.switch!("public")
-              retry_count = 3
-              task_data = {}
-              begin
-                ActiveRecord::Base.transaction do
-                  ActiveRecord::Base.connection.execute('LOCK public.zuora_users IN ACCESS EXCLUSIVE MODE')
+              ActiveRecord::Base.transaction do
+                ActiveRecord::Base.connection.execute('LOCK public.zuora_users IN ACCESS EXCLUSIVE MODE')
+                appinstances = ZuoraConnect::AppInstance.where("zuora_entity_ids ?& array[:entities] = true AND zuora_domain = :host", entities: [zuora_entity_id], host: zuora_client.rest_domain).pluck(:id, :name)
 
-                  unless defined?(@appinstance)
-                    appinstances = ZuoraConnect::AppInstance.where("zuora_entity_ids ?& array[:entities] = true AND zuora_domain = :host", entities: [zuora_entity_id], host: zuora_client.rest_domain).pluck(:id, :name)
+                if appinstances.size > 0
+                  redirect_to "https://#{zuora_host}/apps/newlogin.do?retURL=#{request.fullpath}"
+                  return
+                end
 
-                    if appinstances.size > 0
-                      redirect_to "https://#{zuora_host}/apps/newlogin.do?retURL=#{request.fullpath}"
-                      return
-                    end
-                  end
+                next_id = (ZuoraConnect::AppInstance.all.where('id > 24999999').order(id: :desc).limit(1).pluck(:id).first || 24999999) + 1
+                user = (ENV['DEIS_APP'] || "Application").split('-').map(&:capitalize).join(' ')
+                body = {
+                  'userId' => zuora_user_id, 
+                  'entityIds' => [zuora_entity_id.unpack("a8a4a4a4a12").join('-')], 
+                  'customAuthorities' => [], 
+                  'additionalInformation' => {
+                    'description' => "This user is for #{user} application.", 
+                    'name' => "#{user} API User #{next_id}"
+                  }
+                }
+
+                oauth_response, response = zuora_client.rest_call(
+                  method: :post, 
+                  body: body.to_json, 
+                  url: zuora_client.rest_endpoint("genesis/clients").gsub('v1/', ''), 
+                  session_type: zuora_client.class == ZuoraAPI::Oauth ? :bearer : :basic, 
+                  headers: auth_headers
+                )
 
-                  next_id = defined?(@appinstance) ? @appinstance.id : next_instance_id
-                  if task_data.blank?
-                    user = (ENV['DEIS_APP'] || "Application").split('-').map(&:capitalize).join(' ')
-                    body = {
-                      'userId' => zuora_user_id,
-                      'entityIds' => [zuora_entity_id.unpack("a8a4a4a4a12").join('-')],
-                      'customAuthorities' => [],
-                      'additionalInformation' => {
-                        'description' => "This user is for #{user} application.",
-                        'name' => "#{user} API User #{next_id}"
-                      }
-                    }
-
-                    oauth_response, response = zuora_client.rest_call(
-                      method: :post,
-                      body: body.to_json,
-                      url: zuora_client.rest_endpoint("genesis/clients").gsub('v1/', ''),
-                      session_type: zuora_client.class == ZuoraAPI::Oauth ? :bearer : :basic,
-                      headers: auth_headers
-                    )
-
-                    new_zuora_client = ZuoraAPI::Oauth.new(url: "https://#{zuora_host}", oauth_client_id: oauth_response["clientId"], oauth_secret: oauth_response["clientSecret"] )
-                    if session["ZuoraCurrentUserInfo"].blank?
-                      client_describe, response = new_zuora_client.rest_call(url: zuora_client.rest_endpoint("genesis/user/info").gsub('v1/', ''), session_type: :bearer)
-                    else
-                      client_describe = session["ZuoraCurrentUserInfo"]
-                    end
-
-                    available_entities = client_describe["accessibleEntities"].select {|entity| entity['id'] == zuora_entity_id}
-                    task_data = {
-                      "id": next_id,
-                      "name": client_describe["tenantName"],
-                      "mode": "Collections",
-                      "status": "Running",
-                      ZuoraConnect::AppInstance::LOGIN_TENANT_DESTINATION => {
-                        "tenant_type": "Zuora",
-                        "username": session["ZuoraCurrentIdentity"]["username"],
-                        "url": new_zuora_client.url,
-                        "status": "Active",
-                        "oauth_client_id": oauth_response['clientId'],
-                        "oauth_secret": oauth_response['clientSecret'],
-                        "authentication_type": "OAUTH",
-                        "entities": available_entities.map {|e| e.merge({'displayName' => client_describe["tenantName"]})}
-                      },
-                      "tenant_ids": available_entities.map{|e| e['entityId']}.uniq,
-                    }
-                  end
+                new_zuora_client = ZuoraAPI::Oauth.new(url: "https://#{zuora_host}", oauth_client_id: oauth_response["clientId"], oauth_secret: oauth_response["clientSecret"] )
+                if session["ZuoraCurrentUserInfo"].blank?
+                  client_describe, response = new_zuora_client.rest_call(url: zuora_client.rest_endpoint("genesis/user/info").gsub('v1/', ''), session_type: :bearer)
+                else
+                  client_describe = session["ZuoraCurrentUserInfo"]
+                end
 
-                  if defined?(@appinstance)
-                    @appinstance.zuora_logins = task_data
-                    @appinstance.save(:validate => false)
+                available_entities = client_describe["accessibleEntities"].select {|entity| entity['id'] == zuora_entity_id}
+                task_data = {
+                  "id": next_id,
+                  "name": client_describe["tenantName"],
+                  "mode": "Collections",
+                  "status": "Running",
+                  ZuoraConnect::AppInstance::LOGIN_TENANT_DESTINATION => {
+                    "tenant_type": "Zuora",
+                    "username": session["ZuoraCurrentIdentity"]["username"],
+                    "url": new_zuora_client.url,
+                    "status": "Active",
+                    "oauth_client_id": oauth_response['clientId'],
+                    "oauth_secret": oauth_response['clientSecret'],
+                    "authentication_type": "OAUTH",
+                    "entities": available_entities.map {|e| e.merge({'displayName' => client_describe["tenantName"]})}
+                  },
+                  "tenant_ids": available_entities.map{|e| e['entityId']}.uniq,
+                }
+                mapped_values = {:id => next_id, :api_token => rand(36**64).to_s(36), :token => rand(36**64).to_s(36), :zuora_logins => task_data, :oauth_expires_at => Time.now + 1000.years, :zuora_domain => zuora_client.rest_domain, :zuora_entity_ids => [zuora_entity_id]}
+                @appinstance = ZuoraConnect::AppInstance.new(mapped_values)
+                retry_count = 0
+                begin
+                  @appinstance.save(:validate => false)
+                rescue ActiveRecord::RecordNotUnique => ex
+                  if (retry_count += 1) < 3
+                    @appinstance.assign_attributes({:api_token => rand(36**64).to_s(36), :token => rand(36**64).to_s(36)})
+                    retry
                   else
-                    @appinstance = new_instance(
-                      next_id,
-                      zuora_entity_id,
-                      zuora_client.rest_domain,
-                      task_data: task_data,
-                      retry_count: retry_count
-                    )
+                    Thread.current[:appinstance] = nil
+                    session["appInstance"] = nil
+                    render "zuora_connect/static/error_handled", :locals => {
+                      :title => "Application could not create unique tokens.", 
+                      :message => "Please contact support or retry launching application."
+                    }, :layout => false
+                    return
                   end
                 end
-              rescue ActiveRecord::RecordNotUnique
-                retry if (retry_count -= 1).positive?
-                return
               end
 
               Apartment::Tenant.switch!("public")
@@ -557,27 +472,19 @@ module ZuoraConnect
               ZuoraConnect.logger.warn("UI Authorization Error", ex, zuora: zuora_details.merge({:error => response.body}))
             elsif final_error != "INVALID_SESSION"
               ZuoraConnect.logger.warn("UI Authorization Error", ex, zuora: zuora_details.merge({:error => final_error}))
-            else
-              ZuoraConnect.logger.info("UI Authorization Error", ex, zuora: zuora_details.merge({:error => final_error}))
             end
             redirect_to "https://#{zuora_host}/apps/newlogin.do?retURL=#{request.fullpath}"
             return
-
-          rescue ZuoraAPI::Exceptions::ZuoraAPIError, Exception => ex
-            if ex.message.include?("Referenced User resource(s) not found") && ex.class == ZuoraAPI::Exceptions::ZuoraAPIError
-              locals = {title: "Provisioning Error", message: "New tenats need to be provisioned by API Gateway('#{ex.message}'). Please contact support."}
-              render "zuora_connect/static/error_handled", locals: locals, status: 400, layout: false
-            else
-              session.clear
-              if defined?(ex.response) && ex.response.present? && defined?(ex.response.body)
-                zuora_details.merge!({:error => ex.response.body})
-              end
-              ZuoraConnect.logger.error("UI Authorization Error", ex, zuora: zuora_details)
-              render "zuora_connect/static/error_unhandled", locals: {exception: ex, skip_exception: true}, layout: false, status: 500
+          rescue => ex
+            session.clear
+            if defined?(ex.response) && ex.response.present? && defined?(ex.response.body)
+              zuora_details.merge!({:error => ex.response.body})
             end
-            return
+            ZuoraConnect.logger.error("UI Authorization Error", ex, zuora: zuora_details)
+            render "zuora_connect/static/error_unhandled", locals: {exception: ex, skip_exception: true}, layout: false, status: 500
+            return              
           end
-        elsif request["data"].present? && (request["connectInstanceId"].present? || /^([A-Za-z0-9+\/\-\_]{4})*([A-Za-z0-9+\/]{4}|[A-Za-z0-9+-_\/]{3}=|[A-Za-z0-9+\/]{2}==)$/.match(request["data"].to_s))
+        elsif request["data"] && /^([A-Za-z0-9+\/\-\_]{4})*([A-Za-z0-9+\/]{4}|[A-Za-z0-9+\/]{3}=|[A-Za-z0-9+\/]{2}==)$/.match(request["data"].to_s)
           session.clear
           values = JSON.parse(ZuoraConnect::AppInstance.decrypt_response(Base64.urlsafe_decode64(request["data"])))
           values.fetch("param_data", {}).each do |k ,v|
@@ -592,6 +499,8 @@ module ZuoraConnect
             session["#{values["appInstance"]}::user::email"] = values["current_user"]["email"]
           end
 
+          ZuoraConnect.logger.debug({msg: 'Setup values', connect: values}) if Rails.env != "production"
+
           @appinstance = ZuoraConnect::AppInstance.find_by(:id => values["appInstance"].to_i)
 
           if @appinstance.blank?
@@ -612,53 +521,16 @@ module ZuoraConnect
             else
               raise ZuoraConnect::Exceptions::AccessDenied.new("Authorization mismatch. Possible tampering with session.")
             end
-          end
+          end 
         else
           if session["appInstance"].present?
-            @appinstance = ZuoraConnect::AppInstance.find_by(:id => session["appInstance"])
+            @appinstance = ZuoraConnect::AppInstance.find_by(:id => session["appInstance"]) 
           else
             raise ZuoraConnect::Exceptions::AccessDenied.new("No application state or session found.")
           end
         end
       end
 
-      def next_instance_id
-        min_instance_id = 24_999_999
-        (ZuoraConnect::AppInstance.all.where("id > #{min_instance_id}").order(id: :desc).limit(1).pluck(:id).first || min_instance_id) + 1
-      end
-
-      def new_instance(id, zuora_entity_id, rest_domain, task_data: nil, retry_count: 0)
-        app_instance = ZuoraConnect::AppInstance.new(
-          :id => id,
-          :api_token => generate_token,
-          :token => generate_token,
-          :zuora_logins => task_data,
-          :oauth_expires_at => Time.now + 1000.years,
-          :zuora_domain => rest_domain,
-          :zuora_entity_ids => [zuora_entity_id]
-        )
-
-        begin
-          app_instance.save(:validate => false)
-        rescue ActiveRecord::RecordNotUnique
-          raise if retry_count > 1
-
-          Thread.current[:appinstance] = nil
-          session['appInstance'] = nil
-          render 'zuora_connect/static/error_handled', :locals => {
-            :title => 'Application could not create unique tokens.',
-            :message => 'Please contact support or retry launching application.'
-          }, :layout => false
-          return
-        end
-
-        app_instance
-      end
-
-      def generate_token
-        rand(36**64).to_s(36)
-      end
-
       def setup_instance_via_dev_mode
         session["appInstance"] = ZuoraConnect.configuration.dev_mode_appinstance
         user = ZuoraConnect.configuration.dev_mode_user

data/lib/zuora_connect/engine.rb

@@ -16,13 +16,10 @@ module ZuoraConnect
       end
     end
 
-
     initializer :append_migrations do |app|
-      if ZuoraConnect.configuration.insert_migrations
-        unless app.root.to_s.match root.to_s
-          config.paths["db/migrate"].expanded.each do |expanded_path|
-            app.config.paths["db/migrate"] << expanded_path
-          end
+      unless app.root.to_s.match root.to_s
+        config.paths["db/migrate"].expanded.each do |expanded_path|
+          app.config.paths["db/migrate"] << expanded_path
         end
       end
     end

data/lib/zuora_connect/railtie.rb

@@ -13,7 +13,6 @@ module ZuoraConnect
       PATH_INFO
       CONTENT_TYPE
       ORIGINAL_FULLPATH
-      QUERY_STRING
     )
 
     config.before_initialize do
@@ -47,7 +46,7 @@ module ZuoraConnect
       require 'lograge'
       
       Rails.configuration.logger = ZuoraConnect.custom_logger(name: "Rails") 
-      if !Rails.env.test? && !Rails.env.development?
+      if Rails.env != 'development'
         Rails.configuration.lograge.enabled = true
         Rails.configuration.colorize_logging = false
       end

data/lib/zuora_connect/version.rb

@@ -1,3 +1,3 @@
 module ZuoraConnect
-  VERSION = "2.0.57zc"
+  VERSION = "2.0.57"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: zuora_connect
 version: !ruby/object:Gem::Version
-  version: 2.0.57zc
+  version: 2.0.57
 platform: ruby
 authors:
 - Connect Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-06-26 00:00:00.000000000 Z
+date: 2020-04-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: apartment
@@ -42,16 +42,16 @@ dependencies:
   name: ougai-formatters-customizable
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: zuora_api
   requirement: !ruby/object:Gem::Requirement
@@ -120,20 +120,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: aws-sdk-rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: mono_logger
   requirement: !ruby/object:Gem::Requirement
@@ -429,9 +415,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubygems_version: 3.0.3
 signing_key: