zuck 0.0.7 → 0.0.8

data/CHANGELOG.markdown

@@ -1,3 +1,7 @@
+0.0.8
+-----
+- validate the countries before fetching a reach estimate
+
 0.0.7
 -----
 - don't downcase keywords when normalizing, it matters for keywords

data/VERSION

@@ -1 +1 @@
-0.0.7
+0.0.8

data/lib/zuck/facebook/targeting_spec.rb

@@ -7,7 +7,29 @@ module Zuck
   class InvalidGenderError  < InvalidSpecError; end
   class ParamsMissingError  < InvalidSpecError; end
 
-
+  # FB ads api wants uppercase 2 digit iso country codes
+  ISO_COUNTRY_CODES = %w{ AX AF AL DZ AS AD AO AI AQ AG AR
+                          AM AW AU AT AZ BS BH BD BB BY BE
+                          BZ BJ BM BT BO BA BW BV BR IO BN
+                          BG BF BI KH CM CA CV KY CF TD CL
+                          CN CX CC CO KM CD CG CK CR CI HR
+                          CU CY CZ DK DJ DM DO EC EG SV GQ
+                          ER EE ET FK FO FJ FI FR GF PF TF
+                          GA GM GE DE GH GI GR GL GD GP GU
+                          GT GN GW GY HT HM HN HK HU IS IN
+                          ID IR IQ IE IL IT JM JP JO KZ KE
+                          KI KP KR KW KG LA LV LB LS LR LY
+                          LI LT LU MO MK MG MW MY MV ML MT
+                          MH MQ MR MU YT MX FM MD MC MN MS
+                          MA MZ MM NA NR NP NL AN NC NZ NI
+                          NE NG NU NF MP NO OM PK PW PS PA
+                          PG PY PE PH PN PL PT PR QA RE RO
+                          RU RW SH KN LC PM VC WS SM ST SA
+                          SN CS SC SL SG SK SI SB SO ZA GS
+                          ES LK SD SR SJ SZ SE CH SY TW TJ
+                          TZ TH TL TG TK TO TT TN TR TM TC
+                          TV UG UA AE GB US UM UY UZ VU VA
+                          VE VN VG VI WF EH YE ZM ZW }
 
   #
   # Some helpers around https://developers.facebook.com/docs/reference/ads-api/targeting-specs/
@@ -56,7 +78,7 @@ module Zuck
       build_spec
     end
 
-    # @return [Hash] The reach for the options given in {#initialize}, see 
+    # @return [Hash] The reach for the options given in {#initialize}, see
     #   https://developers.facebook.com/docs/reference/ads-api/reachestimate/
     def fetch_reach
       validate_spec
@@ -160,12 +182,20 @@ module Zuck
       @spec[:countries]   = normalize_countries(@spec[:countries])
       @spec[:keywords]    = normalize_array(@spec[:keywords])
       @spec[:broad_age] ||= false
-      raise(InvalidCountryError, "Need to set :countries") unless @spec[:countries].present?
+      validate_countries
       unless @spec[:keywords].present? or @spec[:connections].present?
         raise(ParamsMissingError, "Need to set :keywords or :connections")
       end
     end
 
+    def validate_countries
+      raise(InvalidCountryError, "Need to set :countries") unless @spec[:countries].present?
+      raise(InvalidCountryError, "Must supply between 1 and 25 countries") if @spec[:countries].length > 25
+      invalid_countries = @spec[:countries] - Zuck::ISO_COUNTRY_CODES
+      return if invalid_countries.empty?
+      raise(InvalidCountryError, "Invalid countrie(s): #{invalid_countries}")
+    end
+
     def build_spec
       return unless @spec
       age = @spec.delete(:age_class)

data/spec/lib/zuck/facebook/targeting_spec_spec.rb

@@ -105,6 +105,14 @@ describe Zuck::TargetingSpec do
       }.to raise_error("Gender can only be male or female")
     end
 
+    it "does not accept invalid countries" do
+      expect{
+        z = Zuck::TargetingSpec.new(graph, ad_account, countries: ['XX'], keywords: ['foo'], gender: 'female')
+        z.send(:validate_spec)
+      }.to raise_error('Invalid countrie(s): ["XX"]')
+    end
+
+
     it "does not accept targetings with neither :keywords nor :connections" do
       expect{
         ts = Zuck::TargetingSpec.new(graph, ad_account, countries: ['US'], gender: 'female')

data/zuck.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "zuck"
-  s.version = "0.0.7"
+  s.version = "0.0.8"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Jannis Hermanns"]
-  s.date = "2013-06-19"
+  s.date = "2013-07-01"
   s.description = "This gem allows to easily access facebook's ads api in ruby. See https://developers.facebook.com/docs/reference/ads-api/"
   s.email = "jannis@gmail.com"
   s.extra_rdoc_files = [

metadata

@@ -2,14 +2,14 @@
 name: zuck
 version: !ruby/object:Gem::Version
   prerelease: 
-  version: 0.0.7
+  version: 0.0.8
 platform: ruby
 authors:
 - Jannis Hermanns
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-19 00:00:00.000000000 Z
+date: 2013-07-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rvm
@@ -371,7 +371,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       segments:
       - 0
-      hash: -190800530639217496
+      hash: -4054154295877984613
       version: '0'
   none: false
 required_rubygems_version: !ruby/object:Gem::Requirement