zoom_rb 0.8.1 → 0.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 771899544953b6b67911aad77c629938839f2942637fa1bbe0a633a2dab50a16
-  data.tar.gz: a25c504655e94701ea41d60912af9e505f33afdae244def78504ab06ab06ab54
+  metadata.gz: 4721f6d74fda716d1e2ddd654d86b1609c421b415186db4277424fb3d52242af
+  data.tar.gz: cf96f9fc938c62b9bd453232f2dc8030506d628a9dc6d302a607c7553edcf353
 SHA512:
-  metadata.gz: 34e6fae6ea6e5e7c17e0ed82eadbce2139eae11aea858320459c51cf2aa43e14dd5660fa194bcbf6322d38e9fbe3a3de47f3852946c08c0ea7e10e710bc762a7
-  data.tar.gz: 17926672d35bb693e3d73f839f007695ec9f1034c2dde19233d4642778eade7a3bf484d5b9ea2d1885874dd89b32374e6a1ed13ff3966efd8d32f344477e3b2b
+  metadata.gz: 1a8ccb722f1dd4cc279d4da8751ef799649d06bd7b0d0eb0ca8b57f8012f96d095097187d39b6fc8a2a558072fb27c81fe8ffe2d5781bbf3c12bbb8bc4e096ee
+  data.tar.gz: 409d4446a67bdc8c67b0d178fe3ba470a0fdbaa965b5c5b5e87b0bf951108255585e0ff82e49b85e98d386951d711fd174f47fbeb281c7dc8e25cf7f2adb2478

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    zoom_rb (0.8.0)
+    zoom_rb (0.8.1)
       httparty (~> 0.13)
       json (>= 1.8)
       jwt

data/README.md

@@ -19,7 +19,7 @@ Or install it yourself as:
 ## Usage
 
 ```ruby
-require 'zoom_rb'
+require 'zoom'
 
 Zoom.configure do |c|
   c.api_key = 'xxx'

data/lib/zoom.rb

@@ -2,7 +2,7 @@
 
 $:.unshift File.dirname(__FILE__)
 
-require 'zoom/defaults'
+require 'zoom/constants'
 require 'zoom/params'
 require 'zoom/utils'
 require 'zoom/actions/account'

data/lib/zoom/actions/im/chat.rb

@@ -21,8 +21,6 @@ module Zoom
           # TODO implement `next_page_token`, will be returned whenever the set of available chat history list exceeds 100. The expiration period is 30 minutes.
           Utils.parse_response self.class.post('/chat/list', query: options)
         end
-
-        Utils.define_bang_methods(self)
       end
     end
   end

data/lib/zoom/actions/meeting.rb

@@ -73,8 +73,6 @@ module Zoom
         # TODO Handle `option_auto_record_type`, Can be "local", “cloud” or "none".
         Utils.parse_response self.class.post('/meeting/update', query: options)
       end
-
-      Utils.define_bang_methods(self)
     end
   end
 end

data/lib/zoom/actions/metrics.rb

@@ -22,8 +22,6 @@ module Zoom
         Utils.require_params(%i[meeting_id type], options)
         Utils.parse_response self.class.post('/metrics/meetingdetail', query: options)
       end
-
-      Utils.define_bang_methods(self)
     end
   end
 end

data/lib/zoom/actions/recording.rb

@@ -28,8 +28,6 @@ module Zoom
         Utils.require_params([:meeting_id], options)
         Utils.parse_response self.class.post('/recording/delete', query: options)
       end
-
-      Utils.define_bang_methods(self)
     end
   end
 end

data/lib/zoom/actions/report.rb

@@ -22,8 +22,6 @@ module Zoom
         Utils.require_params(%i[year month], options)
         Utils.parse_response self.class.post('/report/getdailyreport', query: options)
       end
-
-      Utils.define_bang_methods(self)
     end
   end
 end

data/lib/zoom/actions/user.rb

@@ -13,7 +13,7 @@ module Zoom
       def user_create(*args)
         params = Zoom::Params.new(Utils.extract_options!(args))
         params.require(%i[email type first_name last_name password])
-        Utils.parse_response self.class.post('/users', body: { action: 'create', user_info: params }, query: { access_token: access_token })
+        Utils.parse_response self.class.post('/users', body: { action: 'create', user_info: params }.to_json, query: { access_token: access_token })
       end
 
       def user_get(*args)
@@ -139,8 +139,6 @@ module Zoom
         # options = Utils.extract_options!(args)
         raise Zoom::NotImplemented, 'user_vanity_name_check is not yet implemented'
       end
-
-      Utils.define_bang_methods(self)
     end
   end
 end

data/lib/zoom/actions/webinar.rb

@@ -21,8 +21,8 @@ module Zoom
                                         :timezone, :password, :agenda,
                                         recurrence: RECURRENCE_KEYS,
                                         settings: SETTINGS_KEYS)
-        # process recurrence keys based on defaults
-        # process settings keys based on defaults
+        # process recurrence keys based on constants
+        # process settings keys based on constants
         Utils.parse_response self.class.post("/users/#{params[:host_id]}/webinars", body: params.except(:host_id).to_json, query: { access_token: access_token })
       end
 
@@ -103,8 +103,6 @@ module Zoom
         # options = Utils.extract_options!(args)
         raise Zoom::NotImplemented, 'past_webinars_list is not yet implemented'
       end
-
-      Utils.define_bang_methods(self)
     end
   end
 end

data/lib/zoom/{defaults.rb → constants.rb}

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Zoom
-  class Defaults
+  class Constants
     ACCOUNT_OPTIONS_PAY_MODES = { 'Master account holder pays' => 'master', # default
                                   'Sub account holder pays' => 'sub'
                                 }.freeze

data/lib/zoom/utils.rb

@@ -12,7 +12,7 @@ module Zoom
       end
 
       def raise_if_error!(response)
-        if response['code'] == 300
+        if response&.[]('code') && response['code'] >= 300
           error_hash = { base: response['message']}
           raise Error, error_hash unless response['errors']
           error_hash[response['message']] = response['errors']
@@ -23,8 +23,7 @@ module Zoom
       end
 
       def parse_response(http_response)
-        response = http_response.parsed_response
-        response.nil? ? http_response.code : JSON.parse(response)
+        raise_if_error!(http_response.parsed_response) || http_response.code
       end
 
       def require_params(params, options)
@@ -42,14 +41,14 @@ module Zoom
       end
 
       # Dynamically defines bang methods for Actions modules
-      def define_bang_methods(klass)
-        klass.instance_methods.each do |m|
-          klass.send(:define_method, "#{m}!") do |*args|
-            response = send(m, *args)
-            Utils.raise_if_error!(response)
-          end
-        end
-      end
+      # def define_bang_methods(klass)
+      #   klass.instance_methods.each do |m|
+      #     klass.send(:define_method, "#{m}!") do |*args|
+      #       response = send(m, *args)
+      #       Utils.raise_if_error!(response)
+      #     end
+      #   end
+      # end
 
       def extract_options!(array)
         array.last.is_a?(::Hash) ? array.pop : {}

data/spec/fixtures/error/already_exists.json

@@ -0,0 +1,4 @@
+{
+  "code": 1005,
+  "message": "User already in the account: foo@bar.com"
+}

data/spec/fixtures/error/not_found.json

@@ -0,0 +1,4 @@
+{
+  "code": 1010,
+  "message": "User not belong to this account"
+}

data/spec/lib/zoom/actions/user/create_spec.rb

@@ -13,57 +13,63 @@ describe Zoom::Actions::User do
   end
 
   describe '#user_create' do
-    before :each do
-      stub_request(
-        :post,
-        zoom_url('/users')
-      ).to_return(body: json_response('user', 'create'))
-    end
+    context 'with 201 response' do
+      before :each do
+        stub_request(
+          :post,
+          zoom_url('/users')
+        ).to_return(status: 201,
+                    body: json_response('user', 'create'),
+                    headers: {"Content-Type"=> "application/json"})
+      end
 
-    it 'requires email param' do
-      expect { zc.user_create(filter_key(args, :email)) }.to raise_error(Zoom::ParameterMissing, [:email].to_s)
-    end
+      it 'requires email param' do
+        expect { zc.user_create(filter_key(args, :email)) }.to raise_error(Zoom::ParameterMissing, [:email].to_s)
+      end
 
-    it 'requires first_name param' do
-      expect { zc.user_create(filter_key(args, :first_name)) }.to raise_error(Zoom::ParameterMissing, [:first_name].to_s)
-    end
+      it 'requires first_name param' do
+        expect { zc.user_create(filter_key(args, :first_name)) }.to raise_error(Zoom::ParameterMissing, [:first_name].to_s)
+      end
 
-    it 'requires last_name param' do
-      expect { zc.user_create(filter_key(args, :last_name)) }.to raise_error(Zoom::ParameterMissing, [:last_name].to_s)
-    end
+      it 'requires last_name param' do
+        expect { zc.user_create(filter_key(args, :last_name)) }.to raise_error(Zoom::ParameterMissing, [:last_name].to_s)
+      end
 
-    it 'requires type param' do
-      expect { zc.user_create(filter_key(args, :type)) }.to raise_error(Zoom::ParameterMissing, [:type].to_s)
-    end
+      it 'requires type param' do
+        expect { zc.user_create(filter_key(args, :type)) }.to raise_error(Zoom::ParameterMissing, [:type].to_s)
+      end
 
-    it 'requires password param' do
-      expect { zc.user_create(filter_key(args, :password)) }.to raise_error(Zoom::ParameterMissing, [:password].to_s)
-    end
+      it 'requires password param' do
+        expect { zc.user_create(filter_key(args, :password)) }.to raise_error(Zoom::ParameterMissing, [:password].to_s)
+      end
 
-    it 'returns a hash' do
-      expect(zc.user_create(args)).to be_kind_of(Hash)
-    end
+      it 'returns a hash' do
+        expect(zc.user_create(args)).to be_kind_of(Hash)
+      end
 
-    it 'returns same params' do
-      res = zc.user_create(args)
+      it 'returns same params' do
+        res = zc.user_create(args)
 
-      expect(res['email']).to eq(args[:email])
-      expect(res['first_name']).to eq(args[:first_name])
-      expect(res['last_name']).to eq(args[:last_name])
-      expect(res['type']).to eq(args[:type])
+        expect(res['email']).to eq(args[:email])
+        expect(res['first_name']).to eq(args[:first_name])
+        expect(res['last_name']).to eq(args[:last_name])
+        expect(res['type']).to eq(args[:type])
+      end
     end
-  end
 
-  describe '#user_create! action' do
-    before :each do
-      stub_request(
-        :post,
-        zoom_url('/users')
-      ).to_return(body: json_response('error', 'validation'))
-    end
+    context 'with 409 response' do
+      before :each do
+        stub_request(
+          :post,
+          zoom_url('/users')
+        ).to_return(status: 409,
+                    body: json_response('error', 'already_exists'),
+                    headers: {"Content-Type"=> "application/json"})
+      end
 
-    it 'raises Zoom::Error exception' do
-      expect { zc.user_create!(args) }.to raise_error(Zoom::Error)
+      it 'raises an error' do
+        expect { zc.user_create(args) }.to raise_error(Zoom::Error)
+      end
     end
   end
 end

data/spec/lib/zoom/actions/user/delete_spec.rb

@@ -7,34 +7,38 @@ describe Zoom::Actions::User do
   let(:args) { { id: 'eIimBAXqSrWOcB_EOIXTog' } }
 
   describe '#user_delete' do
-    before :each do
-      stub_request(
-        :delete,
-        zoom_url("/users/#{args[:id]}")
-      ).to_return(status: 204, body: json_response('user', 'delete'))
-    end
+    context 'with a 204 response' do
+      before :each do
+        stub_request(
+          :delete,
+          zoom_url("/users/#{args[:id]}")
+        ).to_return(status: 204,
+                    body: json_response('user', 'delete'),
+                    headers: {"Content-Type"=> "application/json"})
+      end
 
-    it 'requires id param' do
-      expect { zc.user_delete(filter_key(args, :id)) }.to raise_error(Zoom::ParameterMissing, [:id].to_s)
-    end
+      it 'requires id param' do
+        expect { zc.user_delete(filter_key(args, :id)) }.to raise_error(Zoom::ParameterMissing, [:id].to_s)
+      end
 
-    it 'returns the http status code as a number' do
-      expect(zc.user_delete(args)).to eql(204)
+      it 'returns the http status code as a number' do
+        expect(zc.user_delete(args)).to eql(204)
+      end
     end
-  end
 
-  describe '#user_delete!' do
-    before :each do
-      stub_request(
-        :delete,
-        zoom_url("/users/#{args[:id]}")
-      ).to_return(status: 404, body: json_response('error', 'validation'))
-    end
+    context 'with a 4xx when the user is not found' do
+      before :each do
+        stub_request(
+          :delete,
+          zoom_url("/users/#{args[:id]}")
+        ).to_return(status: 404,
+                    body: json_response('error', 'not_found'),
+                    headers: {"Content-Type"=> "application/json"})
+      end
 
-    it 'raises Zoom::Error exception' do
-      expect {
-        zc.user_delete!(args)
-      }.to raise_error(Zoom::Error)
+      it 'raises an error' do
+        expect { zc.user_delete(args) }.to raise_error(Zoom::Error)
+      end
     end
   end
 end

data/spec/lib/zoom/actions/user/get_spec.rb

@@ -7,44 +7,48 @@ describe Zoom::Actions::User do
   let(:args) { { id: 'ufR9342pRyf8ePFN92dttQ' } }
 
   describe '#user_get action' do
-    before :each do
-      stub_request(
-        :get,
-        zoom_url("/users/#{args[:id]}")
-        ).to_return(body: json_response('user', 'get'))
+    context 'with a valid response' do
+      before :each do
+        stub_request(
+          :get,
+          zoom_url("/users/#{args[:id]}")
+          ).to_return(status: 200,
+                      body: json_response('user', 'get'),
+                      headers: {"Content-Type"=> "application/json"})
+      end
+
+      it 'requires id param' do
+        expect { zc.user_get(filter_key(args, :id)) }.to raise_error(Zoom::ParameterMissing, '[:id]')
+      end
+
+      it 'returns a hash' do
+        expect(zc.user_get(args)).to be_kind_of(Hash)
+      end
+
+      it 'returns same params' do
+        res = zc.user_get(args)
+
+        expect(res['id']).to eq(args[:id])
+        expect(res).to have_key('first_name')
+        expect(res).to have_key('last_name')
+        expect(res).to have_key('email')
+        expect(res).to have_key('type')
+      end
     end
 
-    it 'requires id param' do
-      expect { zc.user_get(filter_key(args, :id)) }.to raise_error(Zoom::ParameterMissing, '[:id]')
-    end
-
-    it 'returns a hash' do
-      expect(zc.user_get(args)).to be_kind_of(Hash)
-    end
-
-    it 'returns same params' do
-      res = zc.user_get(args)
-
-      expect(res['id']).to eq(args[:id])
-      expect(res).to have_key('first_name')
-      expect(res).to have_key('last_name')
-      expect(res).to have_key('email')
-      expect(res).to have_key('type')
-    end
-  end
-
-  describe '#user_get! action' do
-    before :each do
-      stub_request(
-        :get,
-        zoom_url("/users/#{args[:id]}")
-      ).to_return(body: json_response('error', 'validation'))
-    end
-
-    it 'raises Zoom::Error exception' do
-      expect {
-        zc.user_get!(args)
-      }.to raise_error(Zoom::Error)
+    context 'with a 4xx response' do
+      before :each do
+        stub_request(
+          :get,
+          zoom_url("/users/#{args[:id]}")
+        ).to_return(status: 404,
+                    body: json_response('error', 'validation'),
+                    headers: {"Content-Type"=> "application/json"})
+      end
+
+      it 'raises Zoom::Error exception' do
+        expect { zc.user_get(args) }.to raise_error(Zoom::Error)
+      end
     end
   end
 end

data/spec/lib/zoom/actions/user/list_spec.rb

@@ -6,42 +6,45 @@ describe Zoom::Actions::User do
   let(:zc) { zoom_client }
 
   describe '#user_list action' do
-    before :each do
-      stub_request(
-        :get,
-        zoom_url('/users')
-      ).to_return(body: json_response('user', 'list'))
+    context 'with a valid response' do
+      before :each do
+        stub_request(
+          :get,
+          zoom_url('/users')
+        ).to_return(body: json_response('user', 'list'),
+                    headers: {"Content-Type"=> "application/json"})
+      end
+
+      it 'returns a hash' do
+        expect(zc.user_list).to be_kind_of(Hash)
+      end
+
+      it "returns 'total_records" do
+        expect(zc.user_list['total_records']).to eq(1)
+      end
+
+      it "returns 'users' Array" do
+        expect(zc.user_list['users']).to be_kind_of(Array)
+      end
+
+      it 'raises an error when passed an invalid option' do
+        expect { zc.user_list(foo: 'bar', status: 'active') }.to raise_error(Zoom::ParameterNotPermitted, [:foo].to_s)
+      end
     end
 
-    it 'returns a hash' do
-      expect(zc.user_list).to be_kind_of(Hash)
-    end
-
-    it "returns 'total_records" do
-      expect(zc.user_list['total_records']).to eq(1)
-    end
-
-    it "returns 'users' Array" do
-      expect(zc.user_list['users']).to be_kind_of(Array)
-    end
-
-    it 'raises an error when passed an invalid option' do
-      expect { zc.user_list(foo: 'bar', status: 'active') }.to raise_error(Zoom::ParameterNotPermitted, [:foo].to_s)
-    end
-  end
-
-  describe '#user_list! action' do
-    before :each do
-      stub_request(
-        :get,
-        zoom_url('/users')
-      ).to_return(body: json_response('error', 'validation'))
-    end
-
-    it 'raises Zoom::Error exception' do
-      expect {
-        zc.user_list!
-      }.to raise_error(Zoom::Error)
+    context 'with a 4xx response' do
+      before :each do
+        stub_request(
+          :get,
+          zoom_url('/users')
+        ).to_return(status: 404,
+                    body: json_response('error', 'not_found'),
+                    headers: {"Content-Type"=> "application/json"})
+      end
+
+      it 'raises Zoom::Error exception' do
+        expect { zc.user_list }.to raise_error(Zoom::Error)
+      end
     end
   end
 end

data/spec/lib/zoom/actions/user/update_spec.rb

@@ -9,32 +9,37 @@ describe Zoom::Actions::User do
                  last_name: 'Foo' } }
 
   describe '#user_update' do
-    before :each do
-      stub_request(
-        :patch,
-        zoom_url("/users/#{args[:id]}")
-      ).to_return(status: 204, body: json_response('user', 'update'))
-    end
-
-    it 'requires id param' do
-      expect { zc.user_update(filter_key(args, :id)) }.to raise_error(Zoom::ParameterMissing, [:id].to_s)
-    end
+    context 'with a valid response' do
+      before :each do
+        stub_request(
+          :patch,
+          zoom_url("/users/#{args[:id]}")
+        ).to_return(status: 204,
+                    body: json_response('user', 'update'),
+                    headers: {"Content-Type"=> "application/json"})
+      end
 
-    it 'returns the http status code as a number' do
-      expect(zc.user_update(args)).to eql(204)
-    end
-  end
+      it 'requires id param' do
+        expect { zc.user_update(filter_key(args, :id)) }.to raise_error(Zoom::ParameterMissing, [:id].to_s)
+      end
 
-  describe '#user_update!' do
-    before :each do
-      stub_request(
-        :patch,
-        zoom_url("/users/#{args[:id]}")
-      ).to_return(status: 404, body: json_response('error', 'validation'))
+      it 'returns the http status code as a number' do
+        expect(zc.user_update(args)).to eql(204)
+      end
     end
+    context 'with a 4xx response' do
+      before :each do
+        stub_request(
+          :patch,
+          zoom_url("/users/#{args[:id]}")
+        ).to_return(status: 404,
+                    body: json_response('error', 'validation'),
+                    headers: {"Content-Type"=> "application/json"})
+      end
 
-    it 'raises Zoom::Error exception' do
-      expect { zc.user_update!(args) }.to raise_error(Zoom::Error)
+      it 'raises an error' do
+        expect { zc.user_update(args) }.to raise_error(Zoom::Error)
+      end
     end
   end
 end

data/spec/lib/zoom/actions/webinar/create_spec.rb

@@ -7,46 +7,48 @@ RSpec.describe Zoom::Actions::Webinar do
   let(:args) { { host_id: 'test_user_id' } }
 
   describe '#webinar_create' do
-    before :each do
-      stub_request(
-        :post,
-        zoom_url("/users/#{args[:host_id]}/webinars")
-      ).to_return(body: json_response('webinar', 'create'))
+    context 'with a valid response' do
+      before :each do
+        stub_request(
+          :post,
+          zoom_url("/users/#{args[:host_id]}/webinars")
+        ).to_return(body: json_response('webinar', 'create'),
+                    headers: {"Content-Type"=> "application/json"})
+      end
+
+      it "requires a 'host_id' argument" do
+        expect { zc.webinar_create(filter_key(args, :host_id)) }.to raise_error(Zoom::ParameterMissing, [:host_id].to_s)
+      end
+
+      it 'returns a hash' do
+        expect(zc.webinar_create(args)).to be_kind_of(Hash)
+      end
+
+      it 'returns the setted params' do
+        res = zc.webinar_create(args)
+        expect(res['host_id']).to eq(args[:host_id])
+      end
+
+      it "returns 'start_url' and 'join_url'" do
+        res = zc.webinar_create(args)
+
+        expect(res['start_url']).to_not be_nil
+        expect(res['join_url']).to_not be_nil
+      end
     end
 
-    it "requires a 'host_id' argument" do
-      expect { zc.webinar_create(filter_key(args, :host_id)) }.to raise_error(Zoom::ParameterMissing, [:host_id].to_s)
-    end
-
-    it 'returns a hash' do
-      expect(zc.webinar_create(args)).to be_kind_of(Hash)
-    end
-
-    it 'returns the setted params' do
-      res = zc.webinar_create(args)
-      expect(res['host_id']).to eq(args[:host_id])
-    end
-
-    it "returns 'start_url' and 'join_url'" do
-      res = zc.webinar_create(args)
-
-      expect(res['start_url']).to_not be_nil
-      expect(res['join_url']).to_not be_nil
-    end
-  end
-
-  describe '#webinar_create!' do
-    before :each do
-      stub_request(
-        :post,
-        zoom_url("/users/#{args[:host_id]}/webinars")
-      ).to_return(body: json_response('error', 'validation'))
-    end
-
-    it 'raises Zoom::Error exception' do
-      expect {
-        zc.webinar_create!(args)
-      }.to raise_error(Zoom::Error)
+    context 'with a 4xx response' do
+      before :each do
+        stub_request(
+          :post,
+          zoom_url("/users/#{args[:host_id]}/webinars")
+        ).to_return(body: json_response('error', 'validation'),
+                    headers: {"Content-Type"=> "application/json"})
+      end
+
+      it 'raises Zoom::Error exception' do
+        expect { zc.webinar_create(args) }.to raise_error(Zoom::Error)
+      end
     end
   end
 end

data/spec/lib/zoom/actions/webinar/delete_spec.rb

@@ -7,34 +7,38 @@ describe Zoom::Actions::Webinar do
   let(:args) { { id: '123456789' } }
 
   describe '#webinar_delete' do
-    before :each do
-      stub_request(
-        :delete,
-        zoom_url("/webinars/#{args[:id]}")
-      ).to_return(status: 204, body: json_response('webinar', 'delete'))
-    end
+    context 'with a valid response' do
+      before :each do
+        stub_request(
+          :delete,
+          zoom_url("/webinars/#{args[:id]}")
+        ).to_return(status: 204,
+                    body: json_response('webinar', 'delete'),
+                    headers: {"Content-Type"=> "application/json"})
+      end
 
-    it "requires a 'id' argument" do
-      expect { zc.webinar_delete(filter_key(args, :id)) }.to raise_error(Zoom::ParameterMissing, [:id].to_s)
-    end
+      it "requires a 'id' argument" do
+        expect { zc.webinar_delete(filter_key(args, :id)) }.to raise_error(Zoom::ParameterMissing, [:id].to_s)
+      end
 
-    it 'returns the http status code as a number' do
-      expect(zc.webinar_delete(args)).to eql(204)
+      it 'returns the http status code as a number' do
+        expect(zc.webinar_delete(args)).to eql(204)
+      end
     end
-  end
 
-  describe '#webinar_delete!' do
-    before :each do
-      stub_request(
-        :delete,
-        zoom_url("/webinars/#{args[:id]}")
-      ).to_return(body: json_response('error', 'validation'))
-    end
+    context 'with a 4xx response' do
+      before :each do
+        stub_request(
+          :delete,
+          zoom_url("/webinars/#{args[:id]}")
+        ).to_return(status: 404,
+                    body: json_response('error', 'validation'),
+                    headers: {"Content-Type"=> "application/json"})
+      end
 
-    it 'raises Zoom::Error exception' do
-      expect {
-        zc.webinar_delete!(args)
-      }.to raise_error(Zoom::Error)
+      it 'raises Zoom::Error exception' do
+        expect { zc.webinar_delete(args) }.to raise_error(Zoom::Error)
+      end
     end
   end
 end

data/spec/lib/zoom/actions/webinar/get_spec.rb

@@ -17,7 +17,8 @@ xdescribe Zoom::Actions::Webinar do
       stub_request(
         :post,
         zoom_url('/webinar/get')
-      ).to_return(body: json_response('webinar_get'))
+      ).to_return(body: json_response('webinar_get'),
+                  headers: {"Content-Type"=> "application/json"})
     end
 
     it "requires a 'host_id' argument" do

data/spec/lib/zoom/actions/webinar/list_spec.rb

@@ -7,42 +7,44 @@ RSpec.describe Zoom::Actions::Webinar do
   let(:args) { { host_id: 'test_user_id' } }
 
   describe '#webinar_list' do
-    before :each do
-      stub_request(
-        :get,
-        zoom_url("/users/#{args[:host_id]}/webinars")
-      ).to_return(body: json_response('webinar', 'list'))
+    context 'with a valid response' do
+      before :each do
+        stub_request(
+          :get,
+          zoom_url("/users/#{args[:host_id]}/webinars")
+        ).to_return(body: json_response('webinar', 'list'),
+                    headers: {"Content-Type"=> "application/json"})
+      end
+
+      it "requires a 'host_id' argument" do
+        expect { zc.webinar_list }.to raise_error(Zoom::ParameterMissing, [:host_id].to_s)
+      end
+
+      it 'returns a hash' do
+        expect(zc.webinar_list(args)).to be_kind_of(Hash)
+      end
+
+      it "returns 'total_records'" do
+        expect(zc.webinar_list(args)['total_records']).to eq(1)
+      end
+
+      it "returns 'webinars' Array" do
+        expect(zc.webinar_list(args)['webinars']).to be_kind_of(Array)
+      end
     end
 
-    it "requires a 'host_id' argument" do
-      expect { zc.webinar_list }.to raise_error(Zoom::ParameterMissing, [:host_id].to_s)
-    end
-
-    it 'returns a hash' do
-      expect(zc.webinar_list(args)).to be_kind_of(Hash)
-    end
-
-    it "returns 'total_records'" do
-      expect(zc.webinar_list(args)['total_records']).to eq(1)
-    end
-
-    it "returns 'webinars' Array" do
-      expect(zc.webinar_list(args)['webinars']).to be_kind_of(Array)
-    end
-  end
-
-  describe '#webinar_list! action' do
-    before :each do
-      stub_request(
-        :get,
-        zoom_url("/users/#{args[:host_id]}/webinars")
-      ).to_return(body: json_response('error', 'validation'))
-    end
-
-    it 'raises Zoom::Error exception' do
-      expect {
-        zc.webinar_list!(args)
-      }.to raise_error(Zoom::Error)
+    context 'with a 4xx response' do
+      before :each do
+        stub_request(
+          :get,
+          zoom_url("/users/#{args[:host_id]}/webinars")
+        ).to_return(body: json_response('error', 'validation'),
+                    headers: {"Content-Type"=> "application/json"})
+      end
+
+      it 'raises Zoom::Error exception' do
+        expect { zc.webinar_list(args) }.to raise_error(Zoom::Error)
+      end
     end
   end
 end

data/spec/lib/zoom/actions/webinar/registrants/add_spec.rb

@@ -10,51 +10,55 @@ RSpec.describe Zoom::Actions::Webinar do
                  email: 'foo@bar.com' } }
 
   describe '#webinar_registrant_add' do
-    before :each do
-      stub_request(
-        :post,
-        zoom_url("/webinars/#{args[:id]}/registrants")
-      ).to_return(status: 201, body: json_response('webinar', 'registrant', 'add'))
-    end
+    context 'with a valid response' do
+      before :each do
+        stub_request(
+          :post,
+          zoom_url("/webinars/#{args[:id]}/registrants")
+        ).to_return(status: 201,
+                    body: json_response('webinar', 'registrant', 'add'),
+                    headers: {"Content-Type"=> "application/json"})
+      end
 
-    it "requires a 'id' argument" do
-      expect { zc.webinar_registrant_add(filter_key(args, :id)) }.to raise_error(Zoom::ParameterMissing, [:id].to_s)
-    end
+      it "requires a 'id' argument" do
+        expect { zc.webinar_registrant_add(filter_key(args, :id)) }.to raise_error(Zoom::ParameterMissing, [:id].to_s)
+      end
 
-    it "requires a 'first_name' argument" do
-      expect { zc.webinar_registrant_add(filter_key(args, :first_name)) }.to raise_error(Zoom::ParameterMissing, [:first_name].to_s)
-    end
+      it "requires a 'first_name' argument" do
+        expect { zc.webinar_registrant_add(filter_key(args, :first_name)) }.to raise_error(Zoom::ParameterMissing, [:first_name].to_s)
+      end
 
-    it "requires a 'last_name' argument" do
-      expect { zc.webinar_registrant_add(filter_key(args, :last_name)) }.to raise_error(Zoom::ParameterMissing, [:last_name].to_s)
-    end
+      it "requires a 'last_name' argument" do
+        expect { zc.webinar_registrant_add(filter_key(args, :last_name)) }.to raise_error(Zoom::ParameterMissing, [:last_name].to_s)
+      end
 
-    it "requires a 'email' argument" do
-      expect { zc.webinar_registrant_add(filter_key(args, :email)) }.to raise_error(Zoom::ParameterMissing, [:email].to_s)
-    end
+      it "requires a 'email' argument" do
+        expect { zc.webinar_registrant_add(filter_key(args, :email)) }.to raise_error(Zoom::ParameterMissing, [:email].to_s)
+      end
 
-    it 'returns an Hash' do
-      expect(zc.webinar_registrant_add(args)).to be_kind_of(Hash)
-    end
+      it 'returns an Hash' do
+        expect(zc.webinar_registrant_add(args)).to be_kind_of(Hash)
+      end
 
-    it 'returns a "join_url"' do
-      res = zc.webinar_registrant_add(args)
-      expect(res['join_url']).not_to be nil
+      it 'returns a "join_url"' do
+        res = zc.webinar_registrant_add(args)
+        expect(res['join_url']).not_to be nil
+      end
     end
-  end
 
-  describe '#webinar_registrant_add!' do
-    before :each do
-      stub_request(
-        :post,
-        zoom_url("/webinars/#{args[:id]}/registrants")
-      ).to_return(status: 404, body: json_response('error', 'validation'))
-    end
+    context 'with a 4xx response' do
+      before :each do
+        stub_request(
+          :post,
+          zoom_url("/webinars/#{args[:id]}/registrants")
+        ).to_return(status: 404,
+                    body: json_response('error', 'not_found'),
+                    headers: {"Content-Type"=> "application/json"})
+      end
 
-    it 'raises Zoom::Error exception' do
-      expect {
-        zc.webinar_registrant_add!(args)
-      }.to raise_error(Zoom::Error)
+      it 'raises Zoom::Error exception' do
+        expect { zc.webinar_registrant_add(args) }.to raise_error(Zoom::Error)
+      end
     end
   end
 end

data/spec/lib/zoom/actions/webinar/registrants/list_spec.rb

@@ -7,34 +7,37 @@ RSpec.describe Zoom::Actions::Webinar do
   let(:args) { { id: 'webinar_id' } }
 
   describe '#webinar_registrants_list' do
-    before :each do
-      stub_request(
-        :get,
-        zoom_url("/webinars/#{args[:id]}/registrants")
-      ).to_return(body: json_response('webinar', 'registrant', 'list'))
-    end
+    context 'with a valid response' do
+      before :each do
+        stub_request(
+          :get,
+          zoom_url("/webinars/#{args[:id]}/registrants")
+        ).to_return(body: json_response('webinar', 'registrant', 'list'),
+                    headers: {"Content-Type"=> "application/json"})
+      end
 
-    it "requires a 'id' argument" do
-      expect { zc.webinar_registrants_list(filter_key(args, :id)) }.to raise_error(Zoom::ParameterMissing, [:id].to_s)
-    end
+      it "requires a 'id' argument" do
+        expect { zc.webinar_registrants_list(filter_key(args, :id)) }.to raise_error(Zoom::ParameterMissing, [:id].to_s)
+      end
 
-    it 'returns an Array of registrants' do
-      expect(zc.webinar_registrants_list(args)['registrants']).to be_kind_of(Array)
+      it 'returns an Array of registrants' do
+        expect(zc.webinar_registrants_list(args)['registrants']).to be_kind_of(Array)
+      end
     end
-  end
 
-  describe '#webinar_registrants_list!' do
-    before :each do
-      stub_request(
-        :get,
-        zoom_url("/webinars/#{args[:id]}/registrants")
-      ).to_return(status: 404, body: json_response('error', 'validation'))
-    end
+    context 'with a 4xx response' do
+      before :each do
+        stub_request(
+          :get,
+          zoom_url("/webinars/#{args[:id]}/registrants")
+        ).to_return(status: 404,
+                    body: json_response('error', 'validation'),
+                    headers: {"Content-Type"=> "application/json"})
+      end
 
-    it 'raises Zoom::Error exception' do
-      expect {
-        zc.webinar_registrants_list!(args)
-      }.to raise_error(Zoom::Error)
+      it 'raises Zoom::Error exception' do
+        expect { zc.webinar_registrants_list(args) }.to raise_error(Zoom::Error)
+      end
     end
   end
 end

data/spec/lib/zoom/actions/webinar/update_spec.rb

@@ -7,34 +7,38 @@ describe Zoom::Actions::Webinar do
   let(:args) { { id: '123456789' } }
 
   describe '#webinar_update' do
-    before :each do
-      stub_request(
-        :patch,
-        zoom_url("/webinars/#{args[:id]}")
-      ).to_return(status: 204, body: json_response('webinar', 'update'))
-    end
+    context 'with a valid response' do
+      before :each do
+        stub_request(
+          :patch,
+          zoom_url("/webinars/#{args[:id]}")
+        ).to_return(status: 204,
+                    body: json_response('webinar', 'update'),
+                    headers: {"Content-Type"=> "application/json"})
+      end
 
-    it "requires a 'id' argument" do
-      expect { zc.webinar_update(filter_key(args, :id)) }.to raise_error(Zoom::ParameterMissing, [:id].to_s)
-    end
+      it "requires a 'id' argument" do
+        expect { zc.webinar_update(filter_key(args, :id)) }.to raise_error(Zoom::ParameterMissing, [:id].to_s)
+      end
 
-    it 'returns the http status code as a number' do
-      expect(zc.webinar_update(args)).to eql(204)
+      it 'returns the http status code as a number' do
+        expect(zc.webinar_update(args)).to eql(204)
+      end
     end
-  end
 
-  describe '#webinar_update!' do
-    before :each do
-      stub_request(
-        :patch,
-        zoom_url("/webinars/#{args[:id]}")
-      ).to_return(status: 404, body: json_response('error', 'validation'))
-    end
+    context 'with a 4xx response' do
+      before :each do
+        stub_request(
+          :patch,
+          zoom_url("/webinars/#{args[:id]}")
+        ).to_return(status: 404,
+                    body: json_response('error', 'not_found'),
+                    headers: {"Content-Type"=> "application/json"})
+      end
 
-    it 'raises Zoom::Error exception' do
-      expect {
-        zc.webinar_update!(args)
-      }.to raise_error(Zoom::Error)
+      it 'raises an error' do
+        expect { zc.webinar_update(args) }.to raise_error(Zoom::Error)
+      end
     end
   end
 end

data/spec/lib/zoom/utils_spec.rb

@@ -55,19 +55,4 @@ xdescribe Zoom::Utils do
                 bar: '2000-01-01T20:15:01Z' })
     end
   end
-
-  xdescribe '#define_bang_methods' do
-    before :each do
-      stub_request(:post, zoom_url('/user/custcreate')).to_timeout
-    end
-
-    it 'raises Zoom::GatewayTimeout on timeout' do
-      args = { email: 'foo@bar.com',
-               first_name: 'Foo',
-               last_name: 'Bar',
-               type: 1 }
-
-      expect { zoom_client.user_custcreate!(args) }.to raise_error(Zoom::GatewayTimeout)
-    end
-  end
 end

data/zoom_rb.gemspec

@@ -25,5 +25,5 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.name          = 'zoom_rb'
   gem.require_paths = ['lib']
-  gem.version       = '0.8.1'
+  gem.version       = '0.8.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zoom_rb
 version: !ruby/object:Gem::Version
-  version: 0.8.1
+  version: 0.8.2
 platform: ruby
 authors:
 - Kyle Boe
@@ -164,13 +164,15 @@ files:
 - lib/zoom/actions/user.rb
 - lib/zoom/actions/webinar.rb
 - lib/zoom/client.rb
-- lib/zoom/defaults.rb
+- lib/zoom/constants.rb
 - lib/zoom/error.rb
 - lib/zoom/interface.rb
 - lib/zoom/params.rb
 - lib/zoom/utils.rb
 - spec/fixtures/chat/get.json
 - spec/fixtures/chat/list.json
+- spec/fixtures/error/already_exists.json
+- spec/fixtures/error/not_found.json
 - spec/fixtures/error/validation.json
 - spec/fixtures/mc_recording_list.json
 - spec/fixtures/meeting/create.json
@@ -340,6 +342,8 @@ summary: zoom.us API wrapper
 test_files:
 - spec/fixtures/chat/get.json
 - spec/fixtures/chat/list.json
+- spec/fixtures/error/already_exists.json
+- spec/fixtures/error/not_found.json
 - spec/fixtures/error/validation.json
 - spec/fixtures/mc_recording_list.json
 - spec/fixtures/meeting/create.json