zonesync 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 00751af08d69afada768a779c3e2344b3e728e0b3ee9162436f82f936737bcab
-  data.tar.gz: 772a439ddfd4f9e9cd96bffeade456ba7023732e221a81ef48c39595f0e2328d
+  metadata.gz: b070a5e3abcb48ba61c4b751babd7e0cd96bce294de28bebdd2a32af9f0e8104
+  data.tar.gz: 0b947cfa076f5ece8f69d093fc3c8512820369f3df2c85ea505517fb6b8aefb0
 SHA512:
-  metadata.gz: 896d74bfd34d5f4609c5e4ab9d79bcad73b812b694941ab24f3807f6d3a08f9d25c28b13dc73201a6e6ed318ae475e43f641f7c9376c8b4af612ea0ba0c3d78d
-  data.tar.gz: a6568612418b311a6c3c89bf8a8e680214336d0075e05373aad7ca7ad32938e000175ed72c198d230dc3d9c7ecfbfcc6ce37b4125c14cf3376d83834ba9e9b4b
+  metadata.gz: bb90f015f8692698c7a922640cdc0b35e67d0e81298201ff4eda130a8c52cde32cabaf86c7bb10e1d92e7c4365079ebaa9d701933e6d73f79aa0350531ee0287
+  data.tar.gz: 3239bb7f0b41cdbd61a4a0c6b0b73d8452ec732eb34deae66ed16788e96a7d66fd4a780bef79a033fd72634e63005445985222f6babd014565ebb89e30958948

data/lib/zonesync/cloudflare.rb

@@ -35,18 +35,31 @@ module Zonesync
       @records ||= begin
         response = http.get(nil)
         response["result"].reduce({}) do |map, attrs|
-          map.merge attrs["id"] => Record.new(
-            attrs["name"] + ".", # normalize to trailing period
-            attrs["type"],
-            attrs["ttl"].to_i,
-            attrs["content"],
-          ).to_h
-        end.invert
+          map.merge to_record(attrs) => attrs["id"]
+        end
       end
     end
 
     private
 
+    def to_record attrs
+      rdata = attrs["content"]
+      if %w[CNAME MX].include?(attrs["type"])
+        rdata = normalize_trailing_period(rdata)
+      end
+
+      Record.new(
+        normalize_trailing_period(attrs["name"]),
+        attrs["type"],
+        attrs["ttl"].to_i,
+        rdata,
+      ).to_h
+    end
+
+    def normalize_trailing_period value
+      value =~ /\.$/ ? value : value + "."
+    end
+
     def http
       return @http if @http
       @http = HTTP.new("https://api.cloudflare.com/client/v4/zones/#{credentials[:zone_id]}/dns_records")

data/lib/zonesync/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Zonesync
-  VERSION = "0.4.0"
+  VERSION = "0.4.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zonesync
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Micah Geisel