zombie_scout 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cd9585ab8fa23daa27c71cfc11fcf41ebc6a371c
-  data.tar.gz: dec2c2a121cc1fb3f3ab9bd9bafdccc1f865ad72
+  metadata.gz: cc91be8df398812d74758f0f52b4fb5314debcbe
+  data.tar.gz: 908249e99886cd2546e40a59d6a68cbe379ed2df
 SHA512:
-  metadata.gz: 43c329a1bdfd59df278b325ff65e1d9d879b9ee8dfa0e12195a5db39a63b516ef928e3ef8a7b0c5166f3e6e79e16612a05871d08d10709a81d2340514618eaf8
-  data.tar.gz: 1365f7a6b810c2ec97447d8efeb52d4c055f9f9a62dd688ba9587baa6308c11f365a7db9b0e2e1c73d078c9c47b8c6337d3bfb337097a97471ab596346ea538a
+  metadata.gz: a2854512c5126c80f7c33dd118ec0577adfab4adeba60c823eaa47602933eee4fc81c3c91a6b9483f927a262de8cae58524e5a7d4138475c5f718e0552310b97
+  data.tar.gz: ad6e1a064157c087b9b081c0aa889af10f85f337d47eb9beab4c52a141f9143265f0a406338cae3c6c50a0cbf9c5055750625f991e00a9fd256465eae54d51d1

data/README.md

@@ -53,7 +53,7 @@ The basics:
 
 Or, add this to your Gemfile:
 
-    gem 'zombie_scout', github: 'danbernier/zombie_scout'
+    gem 'zombie_scout'
 
 ## Usage
 

data/lib/zombie_scout/method_finder.rb

@@ -34,8 +34,8 @@ module ZombieScout
 
     def on_send(node)
       receiver, method_name, *args = *node
-      if respond_to?(:"on_#{method_name}", true)
-        send(:"on_#{method_name}", args, node)
+      if respond_to?(:"handle_#{method_name}", true)
+        send(:"handle_#{method_name}", args, node)
       elsif receiver.nil?  # Then it's a private method call
         @private_method_calls << method_name
         process_all(args)
@@ -44,47 +44,56 @@ module ZombieScout
 
     private
 
-    def on_attr_reader(args, node)
+    def handle_attr_reader(args, node)
       args.each do |arg|
-        attr_method_name = symbol(arg)
-        stash_method(attr_method_name, node)
+        if_symbol(arg) do |attr_method_name|
+          stash_method(attr_method_name, node)
+        end
       end
     end
 
-    def on_attr_writer(args, node)
+    def handle_attr_writer(args, node)
       args.each do |arg|
-        attr_method_name = symbol(arg)
-        stash_method(:"#{attr_method_name}=", node)
+        if_symbol(arg) do |attr_method_name|
+          stash_method(:"#{attr_method_name}=", node)
+        end
       end
     end
 
-    def on_attr_accessor(args, node)
+    def handle_attr_accessor(args, node)
       args.each do |arg|
-        attr_method_name = symbol(arg)
-        stash_method(attr_method_name, node)
-        stash_method(:"#{attr_method_name}=", node)
+        if_symbol(arg) do |attr_method_name|
+          stash_method(attr_method_name, node)
+          stash_method(:"#{attr_method_name}=", node)
+        end
       end
     end
 
-    def on_def_delegators(args, node)
+    def handle_def_delegators(args, node)
       args.drop(1).each do |arg|
-        attr_method_name = symbol(arg)
-        stash_method(attr_method_name, node)
+        if_symbol(arg) do |attr_method_name|
+          stash_method(attr_method_name, node)
+        end
       end
     end
 
-    def on_def_delegator(args, node)
-      attr_method_name = symbol(args.last)
-      stash_method(attr_method_name, node)
+    def handle_def_delegator(args, node)
+      if_symbol(args.last) do |attr_method_name|
+        stash_method(attr_method_name, node)
+      end
     end
 
-    def on_scope(args, node)
-      attr_method_name = symbol(args.first)
-      stash_method(attr_method_name, node)
+    def handle_scope(args, node)
+      if_symbol(args.first) do |attr_method_name|
+        stash_method(attr_method_name, node)
+      end
     end
 
-    def symbol(node)
-      SymbolExtracter.new.process(node)
+    def if_symbol(node)
+      maybe_symbol = SymbolExtracter.new.process(node)
+      if maybe_symbol.is_a? Symbol
+        yield maybe_symbol
+      end
     end
 
     def stash_method(method_name, node)

data/lib/zombie_scout/version.rb

@@ -1,3 +1,3 @@
 module ZombieScout
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/zombie_scout/method_finder_spec.rb

@@ -32,41 +32,79 @@ describe ZombieScout::MethodFinder, '#find_methods' do
   end
 
   context 'when a ruby file has attr_readers' do
-    let(:ruby_code) { 
-      "class Book
-         attr_reader :title, :author
-       end"
-    }
-
-    it 'can find attr_readers' do
-      expect(zombies.map(&:name)).to eq(%i[author title])
+    context "when they're declared with symbols, the normal way" do
+      let(:ruby_code) {
+        "class Book
+           attr_reader :title, :author
+         end"
+      }
+      it 'can find attr_readers' do
+        expect(zombies.map(&:name)).to eq(%i[author title])
+      end
+    end
+    context "when they're declare with a splat from an array of symbols" do
+      let(:ruby_code) {
+        "class Book
+           attributes = %i(title author)
+           attr_reader *attributes
+         end"
+      }
+      it 'will ignore them' do
+        expect(zombies).to be_empty
+      end
     end
   end
 
   context 'when a ruby file has attr_writers' do
-    let(:ruby_code) { 
-      "class Book
-         attr_writer :title, :author
-       end"
-    }
-    it 'can find attr_writers' do
-      expect(zombies.map(&:name)).to eq(%i[author= title=])
+    context "when they're declared with symbols, the normal way" do
+      let(:ruby_code) {
+        "class Book
+           attr_writer :title, :author
+         end"
+      }
+      it 'can find attr_writers' do
+        expect(zombies.map(&:name)).to eq(%i[author= title=])
+      end
+    end
+    context "when they're declare with a splat from an array of symbols" do
+      let(:ruby_code) {
+        "class Book
+           attributes = %i(title author)
+           attr_reader *attributes
+         end"
+      }
+      it 'will ignore them' do
+        expect(zombies).to be_empty
+      end
     end
   end
 
   context 'when a ruby file has attr_accessors' do
-    let(:ruby_code) {
-      "class Book
-         attr_accessor :title, :author
-       end"
-    }
-    it 'can find attr_accessors' do
-      expect(zombies.map(&:name)).to eq(%i[author author= title title=])
+    context "when they're declared with symbols, the normal way" do
+      let(:ruby_code) {
+        "class Book
+           attr_accessor :title, :author
+         end"
+      }
+      it 'can find attr_accessors' do
+        expect(zombies.map(&:name)).to eq(%i[author author= title title=])
+      end
+    end
+    context "when they're declare with a splat from an array of symbols" do
+      let(:ruby_code) {
+        "class Book
+           attributes = %i(title author)
+           attr_accessor *attributes
+         end"
+      }
+      it 'will ignore them' do
+        expect(zombies).to be_empty
+      end
     end
   end
 
   context 'when a ruby file uses Forwardable::def_delegator' do
-    let(:ruby_code) { 
+    let(:ruby_code) {
       "class RecordCollection
          extend Forwardable
          def_delegator :@records, :[], :record_number

metadata

@@ -1,55 +1,55 @@
 --- !ruby/object:Gem::Specification
 name: zombie_scout
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Dan Bernier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-26 00:00:00.000000000 Z
+date: 2014-02-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.1'
 - !ruby/object:Gem::Dependency
   name: thor
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.18'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.18'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
 description: "zombie_scout finds methods in classes in your ruby project, \nand then
@@ -61,11 +61,11 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .ruby-gemset
-- .ruby-version
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".ruby-gemset"
+- ".ruby-version"
+- ".travis.yml"
 - Gemfile
 - Gemfile.lock
 - LICENSE
@@ -95,17 +95,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.10
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Find dead methods in your Ruby app