zold 0.23.9 → 0.23.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6adc05e3a39654916c6db0930e0cc0e2040c911ae82224e43e8fd08f534977ef
-  data.tar.gz: 5426a3ef89226b32836cbe793949d05e352af6f33e0dbfc09dc0618a72cb71ed
+  metadata.gz: f5719b8dfeb390eb155df8e38deaa12243ae7223f31c51a86dbc1a56abd1174d
+  data.tar.gz: 2c83351b136b14629b2640897d1eecf8bc7a7d3907e1b7b21b3c8ddaa4d9c44d
 SHA512:
-  metadata.gz: 97154e00aef0b0a65f1d13a72f2577c8aec2e0d820c852f0c855b008c0e51512cffa962ab9634dc80e0661d8b6cc57d28e35ae94c89f046ea2b61d2de91256c5
-  data.tar.gz: 77d6c919564d1412e65bfe7344006408e08d3994457c9ab6fb37c02284073146f16cfa099ca6f7274dfb12ee26b052df237d80f59e42ebafba17232f9091f9f7
+  metadata.gz: 85ede5d5163fb9dcb2f14796258ab4efcfd3f1017f1c82f226c695ca66ae74ea6bb9b13aa7f91ef85c05ec225579a3345ead7d2876a6120424e04efe46bb3f31
+  data.tar.gz: e2b44d53856b92af6503e1c505e044aa76329137bd016b1be2eaabfdbeb2ae514e8dc0bdbf0e4d1e70f75899bd50d73666f7c564ff5d5d61b189418034d75a1a

data/INSTALL.md

@@ -63,9 +63,15 @@ Without homebrew:
 ## Windows
 
 Download and install [RubyInstaller (with Devkit)](https://rubyinstaller.org/downloads/).
-If Windows Defender (or antivirus software) throws an error, ignore it and allow the file. This file is known to trigger [false positives](https://groups.google.com/forum/#!topic/rubyinstaller/LCR-CbBoGOI).
+If Windows Defender (or antivirus software) throws an error, ignore it and allow the file.
+This file is known to trigger [false positives](https://groups.google.com/forum/#!topic/rubyinstaller/LCR-CbBoGOI).
 Download and install [RubyGems](https://rubygems.org/pages/download). Manual install `ruby setup.rb` works.
-Install [Zold gem](https://rubygems.org/gems/zold) `gem install --no-ri --no-rdoc zold`
+
+Install [Zold gem](https://rubygems.org/gems/zold):
+
+```
+gem install zold
+```
 
 ## CentOS 7.5
 

data/lib/zold/commands/remote.rb

@@ -74,7 +74,7 @@ Available commands:
     #{Rainbow('remote trim').green}
       Remove the least reliable nodes
     #{Rainbow('remote select [options]').green}
-      Select the strongest n nodes.
+      Select the most reliable N nodes.
     #{Rainbow('remote update').green}
       Check each registered remote node for availability
 Available options:"
@@ -211,16 +211,16 @@ Available options:"
       end
       return unless ping(host, port, opts)
       if @remotes.exists?(host, port)
-        @log.info("#{host}:#{port} already exists among #{@remotes.all.count} others")
+        @log.debug("#{host}:#{port} already exists among #{@remotes.all.count} others")
       else
         @remotes.add(host, port)
-        @log.info("#{host}:#{port} added to the list, #{@remotes.all.count} total")
+        @log.debug("#{host}:#{port} added to the list, #{@remotes.all.count} total")
       end
     end
 
     def remove(host, port, _)
       @remotes.remove(host, port)
-      @log.info("#{host}:#{port} removed from the list, #{@remotes.all.count} total")
+      @log.debug("#{host}:#{port} removed from the list, #{@remotes.all.count} total")
     end
 
     # Returns an array of Zold::Score
@@ -256,9 +256,9 @@ Available options:"
       all.each do |r|
         next if r[:errors] <= opts['tolerate']
         @remotes.remove(r[:host], r[:port]) if !opts['masters-too'] || !r[:master]
-        @log.info("#{r[:host]}:#{r[:port]} removed because of #{r[:errors]} errors (over #{opts['tolerate']})")
+        @log.debug("#{r[:host]}:#{r[:port]} removed because of #{r[:errors]} errors (over #{opts['tolerate']})")
       end
-      @log.info("The list of #{all.count} remotes trimmed, #{@remotes.all.count} nodes left there")
+      @log.info("The list of #{all.count} remotes trimmed down to #{@remotes.all.count} nodes")
     end
 
     def update(opts)
@@ -284,7 +284,7 @@ Available options:"
               add(s['host'], s['port'], opts)
             end
             capacity << { host: score.host, port: score.port, count: json['all'].count }
-            @log.info("#{r}: the score is #{Rainbow(score.value).green} (#{json['version']}) in #{Age.new(start)}")
+            @log.debug("#{r}: the score is #{Rainbow(score.value).green} (#{json['version']}) in #{Age.new(start)}")
           end
         end
       end
@@ -345,13 +345,13 @@ it's recommended to reboot, but I don't do it because of --never-reboot")
     end
 
     def select(opts)
-      @remotes.all.sort_by { |r| r[:score] }.reverse.each_with_index do |r, idx|
+      @remotes.all.sort_by { |r| r[:errors] }.reverse.each_with_index do |r, idx|
         next if idx < opts['max-nodes']
         next if r[:master] && !opts['masters-too']
         @remotes.remove(r[:host], r[:port])
-        @log.info("Remote #{r[:host]}:#{r[:port]}/#{r[:score]} removed from the list, #{@remotes.all.count} left")
+        @log.debug("Remote #{r[:host]}:#{r[:port]}/#{r[:score]}/#{r[:errors]}e removed from the list")
       end
-      @log.info("#{@remotes.all.count} remote nodes left in the list")
+      @log.info("#{@remotes.all.count} remote nodes were selected to stay in the list")
     end
 
     def terminate

data/lib/zold/remotes.rb

@@ -189,7 +189,6 @@ module Zold
       modify do |list|
         list.reject { |r| r[:host] == host.downcase && r[:port] == port }
       end
-      unerror(host, port)
     end
 
     # Go through the list of remotes and call a provided block for each
@@ -230,7 +229,6 @@ module Zold
 
     def unerror(host, port = PORT)
       assert_host_info(host, port)
-
       if_present(host, port) do |remote|
         remote[:errors] -= 1 if (remote[:errors]).positive?
       end

data/lib/zold/version.rb

@@ -25,7 +25,7 @@
 # Copyright:: Copyright (c) 2018 Yegor Bugayenko
 # License:: MIT
 module Zold
-  VERSION = '0.23.9'
+  VERSION = '0.23.10'
   PROTOCOL = 2
   REPO = 'zold-io/zold'
 end

data/test/commands/test_remote.rb

@@ -183,11 +183,12 @@ class TestRemote < Zold::Test
       (1..11).each do |i|
         cmd.run(%W[remote add localhost #{i} --skip-ping])
         remotes.rescore('localhost', i, i)
+        i.times { remotes.error('localhost', i) }
       end
       cmd.run(%w[remote select --max-nodes=5])
       assert_equal(5, remotes.all.count)
       scores = remotes.all.map { |r| r[:score] }
-      assert_equal([11, 10, 9, 8, 7], scores)
+      assert_equal([7, 8, 9, 10, 11], scores.sort)
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zold
 version: !ruby/object:Gem::Version
-  version: 0.23.9
+  version: 0.23.10
 platform: ruby
 authors:
 - Yegor Bugayenko
@@ -753,7 +753,7 @@ licenses:
 - MIT
 metadata: {}
 post_install_message: |-
-  Thanks for installing Zold 0.23.9!
+  Thanks for installing Zold 0.23.10!
     Study our White Paper: https://papers.zold.io/wp.pdf
     Read our blog posts: https://blog.zold.io
     Try ZLD online wallet at: https://wts.zold.io