zoho_invoice 0.1.1 → 0.2.0

data/lib/zoho_invoice.rb

@@ -3,6 +3,8 @@ require 'faraday_middleware'
 require 'nokogiri'
 require 'multi_xml'
 
+require 'zoho_invoice/core_ext/string'
+
 require 'zoho_invoice/configurable'
 require 'zoho_invoice/auth_token'
 require 'zoho_invoice/defaults'

data/lib/zoho_invoice/base.rb

@@ -27,6 +27,27 @@ module ZohoInvoice
       self.new(client, options).save
     end
 
+    # TODO need to build a class that is something like ActiveRecord::Relation
+    # TODO need to be able to handle associations when hydrating objects
+    #
+    def self.search(client, input_text, options = {})
+      result_hash = client.get("/api/view/search/#{self.to_s.split('::').last.downcase}s", :searchtext => input_text).body
+      objects_to_hydrate = result_hash['Response']["#{self.to_s.split('::').last}s"]["#{self.to_s.split('::').last}"]
+      if objects_to_hydrate.nil?
+        return []
+      else
+        objects_to_hydrate.map do |result|
+          new_hash = {}
+          result.each do |key, value|
+            new_hash[key.to_underscore.to_sym] = value if !value.is_a?(Hash) && !value.is_a?(Array)
+          end
+          self.new(client, new_hash)
+        end
+      end
+    rescue Faraday::Error::ClientError => e
+      return []
+    end
+
     def initialize(client, options = {})
       @client = client
 

data/lib/zoho_invoice/client.rb

@@ -37,11 +37,12 @@ module ZohoInvoice
     def connection
       @connection ||= Faraday.new(@client_options) do |c|
         c.use       Faraday::Response::RaiseError
-        c.response  :xml, :content_type => 'application/xml'
 
         c.request :multipart
         c.request :url_encoded
 
+        c.response  :xml, :content_type => /\bxml$/
+
         c.adapter Faraday.default_adapter
       end
     end

data/lib/zoho_invoice/core_ext/string.rb

@@ -0,0 +1,18 @@
+module ZohoInvoiceStringExt
+  def camelcase
+    return self if self !~ /_/ && self =~ /[A-Z]+.*/
+    split('_').map{|e| e.capitalize}.join
+  end
+
+  def to_underscore!
+    g = gsub!(/(.)([A-Z])/,'\1_\2'); d = downcase!
+    g || d
+  end
+
+  def to_underscore
+    dup.tap { |s| s.to_underscore! }
+  end
+end
+class String
+  include ZohoInvoiceStringExt
+end

data/lib/zoho_invoice/customer.rb

@@ -21,8 +21,5 @@ module ZohoInvoice
 
     has_many :contacts
 
-    def self.search(client, input_text)
-    end
-
   end
 end

data/lib/zoho_invoice/version.rb

@@ -1,3 +1,3 @@
 module ZohoInvoice
-  VERSION = "0.1.1"
+  VERSION = "0.2.0"
 end

data/spec/spec_helper.rb

@@ -14,7 +14,6 @@ require 'zoho_invoice'
 require 'webmock/rspec'
 require 'pry'
 
-Coveralls.wear!
 WebMock.disable_net_connect!
 
 RSpec.configure do |config|

data/spec/zoho_invoice/base_spec.rb

@@ -95,7 +95,7 @@ describe ZohoInvoice::Base do
     end
   end
 
-  describe "saving an object" do
+  describe "interactions" do
     before do
       class Something < ZohoInvoice::Base
         define_object_attrs :something_id, :blah
@@ -103,54 +103,106 @@ describe ZohoInvoice::Base do
       @test_obj = Something.new(@client)
     end
 
-    it "calls the create path if its a new record" do
-      @test_obj.something_id = nil
-      body_params = default_credentials.merge(:XMLString => @test_obj.to_xml)
-      stub_post('/api/somethings/create').
-        with(:body => body_params).
-        to_return(:status => 200, :body => successful_something_response('5555'), :headers => {:content_type => 'application/xml'})
-      @test_obj.save
-      expect(a_post('/api/somethings/create').with(:body => body_params)).to have_been_made
-    end
-
-    it "calls the update path if its a dirty record" do
-      @test_obj.something_id = '123456'
-      body_params = default_credentials.merge(:XMLString => @test_obj.to_xml)
-      stub_post('/api/somethings/update').
-        with(:body => body_params).
-        to_return(:status => 200, :body => successful_something_response('123456'), :headers => {:content_type => 'application/xml'})
-      @test_obj.save
-      expect(a_post('/api/somethings/update').with(:body => body_params)).to have_been_made
-    end
-
-    it "can happen via .create" do
-      @test_obj.blah = '1234'
-      body_params = default_credentials.merge(:XMLString => @test_obj.to_xml)
-      stub_post('/api/somethings/create').
-        with(:body => body_params).
-        to_return(:status => 200, :body => successful_something_response("1234"), :headers => { :content_type => 'application/xml' })
-      test_obj = Something.create(@client, :blah => '1234')
-      expect(a_post('/api/somethings/create').with(:body => body_params)).to have_been_made
-      expect(test_obj.something_id).to eq('1')
-    end
-
-    it "returns the object and has an error method" do
-      @test_obj.blah = '1234'
-      body_params = default_credentials.merge(:XMLString => @test_obj.to_xml)
-      stub_post('/api/somethings/create').with(:body => body_params).to_return(:status => 500, :body => fixture('500_internal_server_error'), :headers => { :content_type => 'application/xml' })
-      test_obj = Something.create(@client, :blah => '1234')
-      expect(test_obj.something_id).to be_nil
-      expect(test_obj.errors.length).to eq(1)
-      error = test_obj.errors.first
-      expect(error.message).to eq("Invalid value passed for XMLString")
-      expect(error.code).to eq('2')
-      expect(error.status).to eq('0')
-      expect(error.http_status).to eq(500)
+    describe "saving" do
+      it "calls the create path if its a new record" do
+        @test_obj.something_id = nil
+        body_params = default_credentials.merge(:XMLString => @test_obj.to_xml)
+        stub_post('/api/somethings/create').
+          with(:body => body_params).
+          to_return(:status => 200, :body => successful_something_response('5555'), :headers => {:content_type => 'application/xml'})
+        @test_obj.save
+        expect(a_post('/api/somethings/create').with(:body => body_params)).to have_been_made
+      end
+
+      it "calls the update path if its a dirty record" do
+        @test_obj.something_id = '123456'
+        body_params = default_credentials.merge(:XMLString => @test_obj.to_xml)
+        stub_post('/api/somethings/update').
+          with(:body => body_params).
+          to_return(:status => 200, :body => successful_something_response('123456'), :headers => {:content_type => 'application/xml'})
+        @test_obj.save
+        expect(a_post('/api/somethings/update').with(:body => body_params)).to have_been_made
+      end
+
+      it "can happen via .create" do
+        @test_obj.blah = '1234'
+        body_params = default_credentials.merge(:XMLString => @test_obj.to_xml)
+        stub_post('/api/somethings/create').
+          with(:body => body_params).
+          to_return(:status => 200, :body => successful_something_response("1234"), :headers => { :content_type => 'application/xml' })
+        test_obj = Something.create(@client, :blah => '1234')
+        expect(a_post('/api/somethings/create').with(:body => body_params)).to have_been_made
+        expect(test_obj.something_id).to eq('1')
+      end
+
+      it "returns the object and has an error method" do
+        @test_obj.blah = '1234'
+        body_params = default_credentials.merge(:XMLString => @test_obj.to_xml)
+        stub_post('/api/somethings/create').with(:body => body_params).to_return(:status => 500, :body => fixture('500_internal_server_error'), :headers => { :content_type => 'application/xml' })
+        test_obj = Something.create(@client, :blah => '1234')
+        expect(test_obj.something_id).to be_nil
+        expect(test_obj.errors.length).to eq(1)
+        error = test_obj.errors.first
+        expect(error.message).to eq("Invalid value passed for XMLString")
+        expect(error.code).to eq('2')
+        expect(error.status).to eq('0')
+        expect(error.http_status).to eq(500)
+      end
+    end
+
+    describe "searching" do
+      it "returns an array if it can find anything" do
+        body_params = default_credentials.merge(:searchtext => '1234')
+        stub_get('/api/view/search/somethings').
+          with(:query => body_params).
+          to_return(:status => 200, :body => successful_multiple_record_response('1234'), :headers => {:content_type => 'application/xml'})
+        result = Something.search(@client, '1234')
+        expect(a_get('/api/view/search/somethings').with(query: body_params)).to have_been_made
+        expect(result.class).to eq(Array)
+        expect(result.length).to eq(2)
+        result.each_with_index do |r, i|
+          expect(r.class).to eq(Something)
+          expect(r.something_id).to eq((i+1).to_s)
+          expect(r.blah).to eq('1234')
+        end
+      end
+
+      it "returns an empty array if it cant find anything" do
+        body_params = default_credentials.merge(:searchtext => '1234')
+        stub_get('/api/view/search/somethings').
+          with(:query => body_params).
+          to_return(:status => 200, :body => successful_empty_response, :headers => {:content_type => 'application/xml'})
+        result = Something.search(@client, '1234')
+        expect(a_get('/api/view/search/somethings').with(query: body_params)).to have_been_made
+        expect(result.class).to eq(Array)
+        expect(result.length).to eq(0)
+      end
+
+      # TODO Needs to change because you'll have no idea an error happened
+      #
+      it "should return an empty array if theres an error" do
+        body_params = default_credentials.merge(:searchtext => '1234')
+        stub_get('/api/view/search/somethings').
+          with(:query => body_params).
+          to_return(:status => 500)
+        result = Something.search(@client, '1234')
+        expect(a_get('/api/view/search/somethings').with(query: body_params)).to have_been_made
+        expect(result.class).to eq(Array)
+        expect(result.length).to eq(0)
+      end
     end
 
     def successful_something_response(blah_payload)
       "<Something><SomethingID>1</SomethingID><Blah>#{blah_payload}</Blah></Something>"
     end
+
+    def successful_multiple_record_response(payload)
+      "<Response><Somethings uri='/api/views/search/somethings'><Something><SomethingID>1</SomethingID><Blah>#{payload}</Blah></Something><Something><SomethingID>2</SomethingID><Blah>#{payload}</Blah></Something></Somethings></Response>"
+    end
+
+    def successful_empty_response
+      "<Response><Somethings uri='/api/views/search/somethings'></Somethings></Response>"
+    end
   end
 
   describe "nested associations" do

data/spec/zoho_invoice/string_spec.rb

@@ -0,0 +1,30 @@
+require 'spec_helper'
+
+describe String do
+
+  it "should make a snake case string into camel case" do
+    expect("something_else".camelcase).to eq("SomethingElse")
+  end
+
+  it "should make a single word camelcase" do
+    expect("something".camelcase).to eq("Something")
+  end
+
+  it "should handle a string thats already camelcase" do
+    expect("Something".camelcase).to eq("Something")
+    expect("SomethingElse".camelcase).to eq("SomethingElse")
+  end
+
+  it "should convert a class name to underscore" do
+    expect(String.to_s.to_underscore).to eq('string')
+  end
+
+  it "should convert a string to underscore not creating copy" do
+    str = "SomethingElse"
+    id  = str.object_id
+    rst = str.to_underscore!
+    expect(rst).to eq("something_else")
+    expect(id).to eq(rst.object_id)
+  end
+
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zoho_invoice
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-10 00:00:00.000000000 Z
+date: 2013-04-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -113,6 +113,7 @@ files:
 - lib/zoho_invoice/collection.rb
 - lib/zoho_invoice/configurable.rb
 - lib/zoho_invoice/contact.rb
+- lib/zoho_invoice/core_ext/string.rb
 - lib/zoho_invoice/customer.rb
 - lib/zoho_invoice/defaults.rb
 - lib/zoho_invoice/error.rb
@@ -134,6 +135,7 @@ files:
 - spec/zoho_invoice/client_spec.rb
 - spec/zoho_invoice/collection_spec.rb
 - spec/zoho_invoice/contact_spec.rb
+- spec/zoho_invoice/string_spec.rb
 - spec/zoho_invoice_spec.rb
 - zoho_invoice.gemspec
 homepage: https://github.com/neovintage/zoho_invoice
@@ -175,4 +177,5 @@ test_files:
 - spec/zoho_invoice/client_spec.rb
 - spec/zoho_invoice/collection_spec.rb
 - spec/zoho_invoice/contact_spec.rb
+- spec/zoho_invoice/string_spec.rb
 - spec/zoho_invoice_spec.rb