ziptax 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3c03de0d5649f47596a9c9faddaeb2f51aa30501
-  data.tar.gz: 7f4ec97a2e2200d2a33f136c7a3f14ffaada37bf
+  metadata.gz: a6afdbbb88bb11f22b44fb7d6fefd6e8aa84af92
+  data.tar.gz: ff6e331acea9618d9f7fdf57e7797766739a611d
 SHA512:
-  metadata.gz: 17bc5d039af1a6db1993176a36a59453ff8fe410214a33b1d2af12bc2cde7da40bad84bda8c520f807ac72d7ab03e54500498a99e3d3f829f464155d711981fb
-  data.tar.gz: cda8978e29f8a71fe83eea5574df2316c058886e9fbcd69bf67ddc270ee12fd9e262e531bfb36912b2bb0e364bf736d6c68f63aae6d2f03b9ab2542d1f183343
+  metadata.gz: 46c1d75684d29bf3b861d15e2250f09d8182a1b4a9cb122d1186a0ce6bbd87eccbcaaec005bbe688945a41ad87a92ac2c8830d571f85d99929047d2e5bf5f4c0
+  data.tar.gz: ce18de858d8d6f78a3c12f5eb2a8d300de22062163c6e802626d206cdbe23d1d6092d87fbc2d8a52732a16ca2308cd5068f8a8dba8f99899331d851ba33896e2

data/lib/zip_tax.rb

@@ -1,4 +1,7 @@
 module ZipTax
+  class << self
+    attr_accessor :api_key
+  end
 end
 
 require "zip_tax/version"

data/lib/zip_tax/response.rb

@@ -10,8 +10,14 @@ module ZipTax
       # it is supported in the API
       hsh = JSON.parse(response_hsh)
       resp = ZipTax::Response.new(hsh)
-      resp.results = hsh['results'].collect { |result| ZipTax::Result.new(result) }
+      resp.results = hsh['results'].collect do |result|
+        self.create_result_from_response(result)
+      end
       resp
     end
+
+    def self.create_result_from_response(result)
+      ZipTax::Result.new(result)
+    end
   end
 end

data/lib/zip_tax/sales_tax.rb

@@ -8,12 +8,12 @@ module ZipTax
 
     BASE_URL="http://api.zip-tax.com/request/v20"
 
-    def initialize(key: nil,
-                   postalcode: nil,
+    def initialize(postalcode: nil,
                    state: nil,
                    city: nil)
 
-      fail ArgumentError, "postalcode and key (api key) are required arguments" if !key || !postalcode
+      fail ArgumentError, 'ZipTax.api_key must be set' if ZipTax.api_key.nil?
+      fail ArgumentError, "postalcode is a required argument" if !postalcode
       @key = key
       @postalcode = postalcode.to_s
       @state = state
@@ -22,7 +22,8 @@ module ZipTax
     end
 
     def request_url
-      query = {key: @key, postalcode: @postalcode, state: @state, city: @city, format: @format}
+      query = {postalcode: @postalcode, state: @state, city: @city, format: @format}
+      query.merge!(key: ZipTax.api_key)
       "#{BASE_URL}?#{Rack::Utils.build_query(query)}"
     end
 
@@ -32,10 +33,11 @@ module ZipTax
       ZipTax::Response.new_from_http_request(resp)
     end
 
-    def self.request_for(key: nil, postalcode: nil, state: nil, city: nil)
+    def self.request_for(postalcode: nil, state: nil, city: nil)
 
-      rt = self.new(key: key, postalcode: postalcode, state: state, city: city)
+      rt = self.new(postalcode: postalcode, state: state, city: city)
       rt.request_tax
     end
+
   end
 end

data/lib/zip_tax/version.rb

@@ -1,3 +1,3 @@
 module ZipTax
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/lib/zip_tax/sales_tax_spec.rb

@@ -31,25 +31,41 @@ describe ZipTax::SalesTax do
       }
     STR
   }
-  describe "#new" do
-    it "errors if key or postal code are not set" do
-     expect {
-       ZipTax::SalesTax.new(postalcode: '001245')
-     }.to raise_exception(ArgumentError, /api key/i)
 
+  let(:generic_request) {
+    ZipTax.api_key = 'abc123'
+    ZipTax::SalesTax.new(postalcode: '00124')
+  }
+
+  describe "must set api key" do
+    it "sets an api key via class attribute" do
+      expect(ZipTax.api_key).to be_falsey
+      ZipTax.api_key = 'abc123'
+      expect(ZipTax.api_key).to_not be_nil
+    end
+  end
+
+  describe "#new" do
+    it "errors if postal code are not set" do
      expect {
-       ZipTax::SalesTax.new(key: 'abc123')
+       ZipTax::SalesTax.new
      }.to raise_exception(ArgumentError, /postalcode/i)
     end
 
+    it "errors if api_key is not set" do
+      expect(ZipTax).to receive(:api_key).and_return(nil)
+      expect {
+        ZipTax::SalesTax.new(postalcode: '10023')
+      }.to raise_exception(ArgumentError, /api_key/i)
+    end
+
     it "sets all possible parameters to the api" do
-      rq = ZipTax::SalesTax.new(key: 'abc123',
-                                postalcode: '000123',
+      rq = ZipTax::SalesTax.new(postalcode: '000123',
                                 state: 'NY',
                                 city: 'New York'
                                )
       expect(rq).to be_kind_of ZipTax::SalesTax
-      [:key, :postalcode, :state, :city].each do |attr|
+      [:postalcode, :state, :city].each do |attr|
         expect(rq.send(attr.to_sym)).to_not be_nil
       end
     end
@@ -59,8 +75,7 @@ describe ZipTax::SalesTax do
     context "success" do
       it "returns a json response" do
         expect(Net::HTTP).to receive(:get).and_return(fake_response)
-        rq = ZipTax::SalesTax.new(key: 'abc123', postalcode: 000123)
-        resp = rq.request_tax
+        resp = generic_request.request_tax
         expect(resp).to be_kind_of ZipTax::Response
       end
     end
@@ -68,15 +83,14 @@ describe ZipTax::SalesTax do
 
   describe "#request_url" do
     it "includes the keys/values included as get params on the base url" do
-      rq = ZipTax::SalesTax.new(key: 'abc123', postalcode: "00012")
-      expect(rq.request_url).to eql("#{ZipTax::SalesTax::BASE_URL}?key=abc123&postalcode=00012&state&city&format=json")
+      expect(generic_request.request_url).to eql("#{ZipTax::SalesTax::BASE_URL}?postalcode=00124&state&city&format=json&key=abc123")
     end
   end
 
   describe ".request_for" do
     it "calls the API endpoing in one method call" do
       expect(Net::HTTP).to receive(:get).and_return(fake_response)
-      rq = ZipTax::SalesTax.request_for(key: 'abc123', postalcode: '00123')
+      rq = ZipTax::SalesTax.request_for(postalcode: '00123')
       expect(rq).to be_kind_of ZipTax::Response
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ziptax
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Bryce McDonnell
@@ -14,56 +14,56 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.6'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.3'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.1'
 - !ruby/object:Gem::Dependency
   name: rack
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.4'
 description: Fetch calculated sales tax rate at the zip code area of specificity by
@@ -74,8 +74,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
+- ".gitignore"
+- ".rspec"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -99,12 +99,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []