zipcode_ja 0.0.2 → 0.0.3

data/lib/zipcode_ja/version.rb

@@ -1,3 +1,3 @@
 module ZipcodeJa
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/zipcode_ja.rb

@@ -4,21 +4,34 @@ require "csv"
 
 module ZipcodeJa
   @_zipcodes = {}
+  @_cache_length = 20
   
   class << self
     def find(zipcode)
-      return nil unless zipcode =~ /^[0-9]{7}$/
+      zipcode =~ /^[0-9]{7}$/ or return
 
       cc = zipcode[0, 2].to_sym
       if !@_zipcodes[cc]
+        zip_path = File.join(File.dirname(__FILE__), "../data/zipcode-#{cc}xxxxx.csv")
+        FileTest.file?(zip_path) or return
+
         @_zipcodes[cc] = {}
-        zip_path = File.open(File.join(File.dirname(__FILE__), "../data/zipcode-#{cc}xxxxx.csv"))
-        CSV.foreach(zip_path) do |row|
+        CSV.foreach(File.open(zip_path)) do |row|
           @_zipcodes[cc][row[2]] = row
         end
+
+        clear_cache if @_zipcodes.length > @_cache_length
       end
 
       @_zipcodes[cc][zipcode]
     end
+
+    private
+
+    def clear_cache
+      cc = @_zipcodes.first[0]
+      @_zipcodes[cc].clear
+      @_zipcodes.delete(cc)
+    end
   end
 end

data/spec/zipcode_ja_spec.rb

@@ -23,6 +23,18 @@ describe ZipcodeJa do
   end
 
   it 'notfound region from zipcode' do
-    expect('986074'.to_region).to eq(nil)
+    expect('9999999'.to_region).to eq(nil)
+  end
+
+  it do
+    ZipcodeJa.instance_eval { @_cache_length = 5 }
+    expect {
+      10.times do |i|
+        ("%0d" % i + '00000').to_region
+      end
+      10.times do |i|
+        ("%0d" % i + '00001').to_region
+      end
+    }.to_not raise_error
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zipcode_ja
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-07 00:00:00.000000000 Z
+date: 2013-06-15 00:00:00.000000000 Z
 dependencies: []
 description: ZipcodeJa allows you to convert Japanese zipcode into a region.
 email: