zimdb 0.0.2 → 0.0.3

data/README.md

@@ -15,6 +15,11 @@ Now you can do things like this:
 	movie.director     # => "Todd Phillips"
 	# and more...
 
+You may also find a movie via its IMDb id:
+
+	movie = Zimdb::Movie.new(:id => "tt0151804")
+	movie.title        # => "Office Space"
+
 Check out [this spec file](https://github.com/indrode/zimdb/blob/master/spec/movie_spec.rb) to see which movie attributes are currently available.
 
 ##License

data/Rakefile

@@ -1 +1,17 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
+
+desc 'Default: run specs.'
+task :default => :spec
+
+desc "Run specs"
+RSpec::Core::RakeTask.new do |t|
+  t.pattern = "./spec/**/*_spec.rb" # default behavior
+end
+
+desc "Generate code coverage"
+RSpec::Core::RakeTask.new(:coverage) do |t|
+  t.pattern = "./spec/**/*_spec.rb" # default behavior
+  t.rcov = true
+  t.rcov_opts = ['--exclude', 'spec']
+end

data/lib/zimdb/movie.rb

@@ -2,8 +2,11 @@ module Zimdb
   class Movie
     
     def initialize(params)
-      title = URI::encode(params[:title])
-      @json = JSON.parse(HTTParty.get("http://www.imdbapi.com/?t=#{title}")).symbolize_keys
+      @json = params[:id].nil? ? get_movie("t", URI::encode(params[:title])) : get_movie("i", params[:id])
+    end
+    
+    def get_movie(param, val)
+      JSON.parse(HTTParty.get("http://www.imdbapi.com/?#{param}=#{val}")).symbolize_keys
     end
     
     def response

data/lib/zimdb/version.rb

@@ -1,3 +1,3 @@
 module Zimdb
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/movie_spec.rb

@@ -1,77 +1,98 @@
 require 'spec_helper'
 
 describe Zimdb::Movie do
-  before(:each) do
-    @movie = Zimdb::Movie.new(:title => "Hangover")
-    @movie.response.should == true
-  end  
-  
-  it "should return a false response if not found" do
-    movie2 = Zimdb::Movie.new(:title => "asdasd")
-    movie2.response.should == false
-    movie2.title.should be_nil
-  end
-
-  it "should allow more than one word in movie title" do
-    movie3 = Zimdb::Movie.new(:title => "The Hangover")
-    movie3.response.should == true
-    movie3.title.should == "The Hangover"
-    movie3.year.should == 2009
-  end
-
-  it "should return the title" do
-    @movie.title.should == "The Hangover"
-  end
-  
-  it "should return the year" do
-    @movie.year.should == 2009
-  end
-  
-  it "should return the rating" do
-    @movie.rated.should == "R"
-  end
-  
-  it "should return the release date" do
-    @movie.released.should == "5 Jun 2009"
-  end
-  
-  it "should return the genre" do
-    @movie.genre.should == "Comedy, Crime"
-  end
-  
-  it "should return the director" do
-    @movie.director.should == "Todd Phillips"
-  end
-  
-  it "should return the writer" do
-    @movie.writer.should == "Jon Lucas, Scott Moore"
-  end
-  
-  it "should return the actors" do
-    @movie.actors.should == "Zach Galifianakis, Bradley Cooper, Justin Bartha, Ed Helms"
-  end
-  
-  it "should return the plot" do
-    @movie.plot.should == "A Las Vegas-set comedy centered around three groomsmen who lose their about-to-be-wed buddy during their drunken misadventures, then must retrace their steps in order to find him."
-  end
-  
-  it "should return the poster URL" do
-    @movie.poster.should == "http://ia.media-imdb.com/images/M/MV5BMTU1MDA1MTYwMF5BMl5BanBnXkFtZTcwMDcxMzA1Mg@@._V1._SX320.jpg"
-  end
-  
-  it "should return the runtime" do
-    @movie.runtime.should == "1 hr 40 mins"
-  end
-  
-  it "should return the rating" do
-    @movie.rating.should == 7.9
-  end
-  
-  it "should return the number of votes" do
-    @movie.votes.should == 142757
+  describe "by movie title" do
+    before(:each) do
+      @movie = Zimdb::Movie.new(:title => "Hangover")
+      @movie.response.should == true
+    end
+    
+    it "should return a false response if not found" do
+      movie2 = Zimdb::Movie.new(:title => "asdasd")
+      movie2.response.should == false
+      movie2.title.should be_nil
+    end
+    
+    it "should allow more than one word in movie title" do
+      movie3 = Zimdb::Movie.new(:title => "The Hangover")
+      movie3.response.should == true
+      movie3.title.should == "The Hangover"
+      movie3.year.should == 2009
+    end
+    
+    it "should return the title" do
+      @movie.title.should == "The Hangover"
+    end
+    
+    it "should return the year" do
+      @movie.year.should == 2009
+    end
+    
+    it "should return the rating" do
+      @movie.rated.should == "R"
+    end
+    
+    it "should return the release date" do
+      @movie.released.should == "5 Jun 2009"
+    end
+    
+    it "should return the genre" do
+      @movie.genre.should == "Comedy, Crime"
+    end
+    
+    it "should return the director" do
+      @movie.director.should == "Todd Phillips"
+    end
+    
+    it "should return the writer" do
+      @movie.writer.should == "Jon Lucas, Scott Moore"
+    end
+    
+    it "should return the actors" do
+      @movie.actors.should == "Zach Galifianakis, Bradley Cooper, Justin Bartha, Ed Helms"
+    end
+    
+    it "should return the plot" do
+      @movie.plot.should == "A Las Vegas-set comedy centered around three groomsmen who lose their about-to-be-wed buddy during their drunken misadventures, then must retrace their steps in order to find him."
+    end
+    
+    it "should return the poster URL" do
+      @movie.poster.should == "http://ia.media-imdb.com/images/M/MV5BMTU1MDA1MTYwMF5BMl5BanBnXkFtZTcwMDcxMzA1Mg@@._V1._SX320.jpg"
+    end
+    
+    it "should return the runtime" do
+      @movie.runtime.should == "1 hr 40 mins"
+    end
+    
+    it "should return the rating" do
+      @movie.rating.should == 7.9
+    end
+    
+    it "should return the number of votes" do
+      @movie.votes.should == 142757
+    end
+    
+    it "should return the id" do
+      @movie.imdb_id.should == "tt1119646"
+    end
   end
   
-  it "should return the id" do
-    @movie.imdb_id.should == "tt1119646"
+  describe "by IMDB id" do
+    before(:each) do
+      @movie_by_id = Zimdb::Movie.new(:id => "tt0151804")
+      @movie_by_id.response.should == true
+    end
+    
+    it "should return the title" do
+      @movie_by_id.title.should == "Office Space"
+    end
+    
+    it "should return the year" do
+      @movie_by_id.year.should == 1999
+    end
+    
+    it "should return the id" do
+      @movie_by_id.imdb_id.should == "tt0151804"
+    end
   end
 end

data/spec/spec_helper.rb

@@ -9,8 +9,10 @@ RSpec.configure do |config|
     File.dirname(__FILE__) + '/fixtures/' + filename
   end
   
+  config.color_enabled = true
+  
   FakeWeb.register_uri(:get, "http://www.imdbapi.com/?t=Hangover", :body => open(fixture("hangover.json")))
   FakeWeb.register_uri(:get, "http://www.imdbapi.com/?t=The%20Hangover", :body => open(fixture("hangover.json")))
   FakeWeb.register_uri(:get, "http://www.imdbapi.com/?t=asdasd", :body => open(fixture("asdasd.json")))
-  
+  FakeWeb.register_uri(:get, "http://www.imdbapi.com/?i=tt0151804", :body => open(fixture("office_space.json")))
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zimdb
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-11-17 00:00:00.000000000 Z
+date: 2011-12-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
-  requirement: &70313887340500 !ruby/object:Gem::Requirement
+  requirement: &70267884995940 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70313887340500
+  version_requirements: *70267884995940
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70313887338240 !ruby/object:Gem::Requirement
+  requirement: &70267884994620 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: '2.6'
   type: :development
   prerelease: false
-  version_requirements: *70313887338240
+  version_requirements: *70267884994620
 - !ruby/object:Gem::Dependency
   name: fakeweb
-  requirement: &70313887316060 !ruby/object:Gem::Requirement
+  requirement: &70267884993980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,7 +43,7 @@ dependencies:
         version: '1.3'
   type: :development
   prerelease: false
-  version_requirements: *70313887316060
+  version_requirements: *70267884993980
 description: Access movie information from IMDb via the API offered by http://www.imdbapi.com/
 email:
 - indro.de@gmail.com