zero_downtime_migrations 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c98c1cbcf271026706fc6d40043d1fcba981ef04
-  data.tar.gz: aa219a884d42a7024256b9763f08decbfb6950d4
+  metadata.gz: b7c11ffb1f189aa72d6e3f293ed8b002a237fd0a
+  data.tar.gz: 9c21a8f52fa53bcc6e37968e98934f1eed21cae5
 SHA512:
-  metadata.gz: 862eaac1afae554f4727fad033c8f1ac023973c3dc2d849535eb715fb2a18ec87c770aca6a591d604417d18fd23c9116f8c02684cf1914ee5d28d3df30950bd0
-  data.tar.gz: 30bbf4dd92155ae61b48721d8088f9cee339ba502634b775f6169cc5e4b7405d3109261da0d93bd127b1cb5fb72d77628e85e51b7db5a3be6b5e7debb389705b
+  metadata.gz: a0f57e9b8d06259aaec58f60145ec790188b847e3c78e824b65be954e16a9da44f053d439718cf8edda9e1c55d375258435d72ffa5b0054404f7c50389fa7ae2
+  data.tar.gz: acddd8d588ffdb007be328a1b932a96583b6762be95859cfd7860afd4d7db3191c561989676360db8ed3641ee8ce64ff9249a7874c4c7782e216e4fb31cef76b

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    zero_downtime_migrations (0.0.2)
+    zero_downtime_migrations (0.0.3)
       activerecord
 
 GEM

data/lib/zero_downtime_migrations/error.rb

@@ -6,9 +6,5 @@ module ZeroDowntimeMigrations
   end
 
   class UnsafeMigrationError < Error
-    def initialize(error, correction)
-      error_with_type = "#{self.class.name}: #{error}"
-      super("#{error_with_type}\n\n#{correction}")
-    end
   end
 end

data/lib/zero_downtime_migrations/validation.rb

@@ -2,11 +2,11 @@ module ZeroDowntimeMigrations
   class Validation
     def self.validate!(type, migration = nil, *args)
       return unless Migration.migrating? && Migration.unsafe?
-      validator = type.to_s.classify
 
-      if const_defined?(validator)
+      begin
+        validator = type.to_s.classify
         const_get(validator).new(migration, *args).validate!
-      else
+      rescue NameError
         raise UndefinedValidationError.new(validator)
       end
     end
@@ -18,8 +18,8 @@ module ZeroDowntimeMigrations
       @args = args
     end
 
-    def error!(*args)
-      raise UnsafeMigrationError.new(*args)
+    def error!(message)
+      raise UnsafeMigrationError.new(message)
     end
 
     def migration_name

data/lib/zero_downtime_migrations/validation/add_column.rb

@@ -3,14 +3,15 @@ module ZeroDowntimeMigrations
     class AddColumn < Validation
       def validate!
         return if options[:default].nil? # only nil is safe
-        message = "Adding a column with a default is unsafe!"
-        error!(message, correction)
+        error!(message)
       end
 
       private
 
-      def correction
+      def message
         <<-MESSAGE.strip_heredoc
+          Adding a column with a default is unsafe!
+
           This action can potentially lock your database table!
 
           Instead, let's first add the column without a default.

data/lib/zero_downtime_migrations/validation/add_index.rb

@@ -3,14 +3,15 @@ module ZeroDowntimeMigrations
     class AddIndex < Validation
       def validate!
         return if concurrent? && migration.ddl_disabled?
-        message = "Adding a non-concurrent index is unsafe!"
-        error!(message, correction)
+        error!(message)
       end
 
       private
 
-      def correction
+      def message
         <<-MESSAGE.strip_heredoc
+          Adding a non-concurrent index is unsafe!
+
           This action can potentially lock your database table!
 
           Instead, let's add the index concurrently in its own migration with

data/lib/zero_downtime_migrations/validation/ddl_migration.rb

@@ -3,14 +3,15 @@ module ZeroDowntimeMigrations
     class DdlMigration < Validation
       def validate!
         return unless migration.ddl_disabled? && !Migration.index?
-        message = "Disabling the DDL transaction is unsafe!"
-        error!(message, correction)
+        error!(message)
       end
 
       private
 
-      def correction
+      def message
         <<-MESSAGE.strip_heredoc
+          Disabling the DDL transaction is unsafe!
+
           The DDL transaction should only be disabled for migrations that add indexes.
 
           Any other data or schema changes must live in their own migration files with

data/lib/zero_downtime_migrations/validation/find_each.rb

@@ -2,14 +2,15 @@ module ZeroDowntimeMigrations
   class Validation
     class FindEach < Validation
       def validate!
-        message = "Using `ActiveRecord::Relation#each` is unsafe!"
-        error!(message, correction)
+        error!(message)
       end
 
       private
 
-      def correction
+      def message
         <<-MESSAGE.strip_heredoc
+          Using `ActiveRecord::Relation#each` is unsafe!
+
           Let's use the `find_each` method to fetch records in batches instead.
 
           Otherwise we may accidentally load tens or hundreds of thousands of

data/lib/zero_downtime_migrations/validation/mixed_migration.rb

@@ -3,14 +3,15 @@ module ZeroDowntimeMigrations
     class MixedMigration < Validation
       def validate!
         return unless Migration.mixed?
-        message = "Mixing data/index/schema changes in the same migration is unsafe!"
-        error!(message, correction)
+        error!(message)
       end
 
       private
 
-      def correction
+      def message
         <<-MESSAGE.strip_heredoc
+          Mixing data/index/schema changes in the same migration is unsafe!
+
           Instead, let's split apart these types of migrations into separate files.
 
           * Introduce schema changes with methods like `create_table` or `add_column` in one file.

data/spec/zero_downtime_migrations/validation_spec.rb

@@ -8,7 +8,7 @@ RSpec.describe ZeroDowntimeMigrations::Validation do
     let(:error) { ZeroDowntimeMigrations::UndefinedValidationError }
 
     it "raises UndefinedValidationError if one does not exist" do
-      expect { described_class.validate!(:invalid) }.to raise_error(error)
+      expect { described_class.validate!(:invalid?) }.to raise_error(error)
     end
   end
 
@@ -18,12 +18,12 @@ RSpec.describe ZeroDowntimeMigrations::Validation do
     end
   end
 
-  describe "#error" do
-    let(:args) { [:one, :two] }
+  describe "#error!" do
     let(:error) { ZeroDowntimeMigrations::UnsafeMigrationError }
+    let(:message) { "test" }
 
     it "raises a new UnsafeMigrationError" do
-      expect { subject.error!(*args) }.to raise_error(error)
+      expect { subject.error!(message) }.to raise_error(error)
     end
   end
 

data/zero_downtime_migrations.gemspec

@@ -11,7 +11,7 @@ Gem::Specification.new do |s|
   s.required_ruby_version = ">= 2.0.0"
   s.summary               = "Zero downtime migrations with ActiveRecord and PostgreSQL"
   s.test_files            = `git ls-files -- spec/*`.split("\n")
-  s.version               = "0.0.2"
+  s.version               = "0.0.3"
 
   s.add_dependency "activerecord"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zero_downtime_migrations
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - LendingHome