zenodo 0.0.6 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 076dae0b2d6a7b61716e7d8a47dee8c03d9f0eec
-  data.tar.gz: 444a4c8a9f793930cb0d8dd77501d64cb498c8c0
+  metadata.gz: e6153bc89b1c47f039c53c1ba75a2534196ad77f
+  data.tar.gz: 636baf182e8874f1f7dc286968388af74503c4d8
 SHA512:
-  metadata.gz: b0bf1bc1add5b02c77ba839091dd6a1715ba6e79854350d5a5b7f5c390ad7a43a01f5fe9417518531ebc654223a9ebb9d5b01982d9979d848561938a25ab36e9
-  data.tar.gz: 66204e3d312e07fbf534de48c3365bd1019d61d2dd9bb6afae7e1efe3a6123f2654050f22480afad57fd5eae90656b6bad25f378188d4b16a7ba06af6647bdcc
+  metadata.gz: e951ea20795e76dd03c3d6733bab2099c3e08111894d689d2848548e400ca4add3c9198e93a326e60f2e1536211392471db306c98c866e36f706f732f5b137e9
+  data.tar.gz: cb71634a7505cfb3e1dbf3fdca9f9292838934b7785e23e0198b294b919e3ca2a1810d5104fc04eec20c7e7a7483b62a13316988b5e57e9ef62f633fc9def4e0

data/lib/zenodo/client.rb

@@ -56,10 +56,10 @@ module Zenodo
         when 200..299
           return response
         when 404
-          raise ResourceNotFoundError.new(response: response)
+          raise ResourceNotFoundError.new(method: method, url:token_url, headers:headers, response: response)
         else
-          raise ClientError.new(response: response)
+          raise ClientError.new(method: method, url:token_url, headers:headers, response: response)
       end
     end
   end
-end
+end

data/lib/zenodo/errors/client_error.rb

@@ -1,9 +1,15 @@
 module Zenodo
   module Errors
     class ClientError < StandardError
-      def initialize(response:)
+      def initialize(method:, url:, headers:, response:)
+        super <<-STR.gsub(/^\s*/, '')
+          HTTP #{method} #{url}
+          Request Headers: #{headers}
+          Response Headers: #{response.headers}\n
+          Response Body:\n#{response.body}
+        STR
         @response = response
       end
     end
   end
-end
+end

data/lib/zenodo/resources/object/attributes.rb

@@ -47,8 +47,8 @@ module Zenodo::Resources::Object::Attributes
   end
 
   def method_missing(name, *args, &block)
-    attribute = name.to_s.upcase
-    if __getobj__.key?(attribute)
+    name = name.to_s
+    if __getobj__.key?(name)
       self.class.define_attribute_accessor(name)
       deserialize_attribute(name, self.class.attributes[name.to_sym])
     else

data/lib/zenodo/version.rb

@@ -1,3 +1,3 @@
 module Zenodo
-  VERSION = "0.0.6"
+  VERSION = "0.0.7"
 end

data/spec/zenodo/errors_spec.rb

@@ -0,0 +1,37 @@
+require 'spec_helper'
+
+shared_examples "zenodo/errors/client_error" do
+  subject(:client_error){ described_class.new(
+    method:method,
+    url:url,
+    headers:headers,
+    response:response
+  )}
+
+  let(:method){ "POST" }
+  let(:url){ "http://www.example.com" }
+  let(:headers){ "request headers here" }
+  let(:response){ double("Response", headers: "response headers", body: "response body") }
+
+  it "prints out a helpful error message" do
+    expected_error_message = <<-ERROR.gsub(/^\s*/, '')
+       HTTP POST http://www.example.com
+       Request Headers: request headers here
+       Response Headers: response headers
+       Response Body:
+       response body
+    ERROR
+
+    expect{
+      raise client_error
+    }.to raise_error(Zenodo::Errors::ClientError, expected_error_message)
+  end
+end
+
+describe Zenodo::Errors::ClientError  do
+  include_examples "zenodo/errors/client_error"
+end
+
+describe Zenodo::Errors::ResourceNotFoundError  do
+  include_examples "zenodo/errors/client_error"
+end

data/zenodo.gemspec

@@ -26,7 +26,7 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency 'faraday', '~> 0.9'
   spec.add_dependency 'activesupport', '~> 4.1'
-  spec.add_dependency 'mime-types', '~> 1.2'
+  spec.add_dependency 'mime-types', '~> 2.6'
 
   spec.add_development_dependency 'bundler', '~> 1.7'
   spec.add_development_dependency 'rake', '~> 10.0'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: zenodo
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
 - David Iorns
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-30 00:00:00.000000000 Z
+date: 2015-07-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '2.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '2.6'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -165,6 +165,7 @@ files:
 - spec/zenodo/dsl/deposition_actions_spec.rb
 - spec/zenodo/dsl/deposition_files_spec.rb
 - spec/zenodo/dsl/depositions_spec.rb
+- spec/zenodo/errors_spec.rb
 - zenodo.gemspec
 homepage: https://github.com/sprotocols/zenodo
 licenses:
@@ -198,4 +199,5 @@ test_files:
 - spec/zenodo/dsl/deposition_actions_spec.rb
 - spec/zenodo/dsl/deposition_files_spec.rb
 - spec/zenodo/dsl/depositions_spec.rb
+- spec/zenodo/errors_spec.rb
 has_rdoc: