zendesk_apps_tools 1.8.0 → 1.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 58cbebaeeee200b0db8ead6cbeffc425dec1a394
-  data.tar.gz: 6474700092a46dfca452f9a58f3805955035d028
+  metadata.gz: 6acdb26a9908ab70af045d8f6ad781a500fefd65
+  data.tar.gz: 187552d8ccf957e944edca4c256cf86cfa416816
 SHA512:
-  metadata.gz: 81fdca0acd54cbfb5b1ec39d59e10566d3c6a447fd89bf20d655e92677c02d611d8efe4fc677684075ff4c3c9389f3b49f4d80a9867b692f4c98c654a3b61356
-  data.tar.gz: d67444c03deee64316a8894f81a6befebe6f6fadf2db7b6c527171efcf5b7c2f5f53ead665f6e8013b574a46bd0aead3d446375b3a1ba1c1bf49d0871ba2724f
+  metadata.gz: 6cea64bcd79091ebaefe815ab2927f1e3a0a6f9c432e6dc54e8c37f8bf66bc4e9c360fb9f611c32142a3f20da59599a1e0ba86e3b8ed4e7c2c3318ff129c3a7d
+  data.tar.gz: 6eb16f0f532f6678fd7d96230630c07b4097e49c0ff8ad039be1066db74b263b316d2b257152dc999bbaff73db127239b25e9d7234ee371bb0a11a45c8edfd00

data/app_template/README.md

@@ -0,0 +1,15 @@
+# App name
+
+[brief description of the app]
+
+### The following information is displayed:
+
+* info1
+* info2
+* info3
+
+Please submit bug reports to [Insert Link](). Pull requests are welcome.
+
+### Screenshot(s):
+[put your screenshots down here.]
+

data/features/package.feature

@@ -13,3 +13,10 @@ Feature: package a zendesk app into a zip file
     And the command output should contain "adding translations/en.json"
     And the command output should contain "created"
     And the zip file should exist in directory "tmp/aruba/tmp"
+
+
+  Scenario: package a zendesk app by running 'zat package' command
+    When I create a symlink from "./templates/translation.erb.tt" to "tmp/aruba/assets/translation.erb.tt"
+    Then "tmp/aruba/assets/translation.erb.tt" should be a symlink
+    When I run the command "zat package --path tmp/aruba" to package the app
+    Then the zip file in "tmp/aruba/tmp" should not contain any symlinks

data/features/step_definitions/app_steps.rb

@@ -1,4 +1,5 @@
 require 'fileutils'
+require 'zip/zip'
 
 When /^I move to the app directory$/ do
   @previous_dir = Dir.pwd
@@ -38,6 +39,12 @@ When /^I run "(.*?)" command with the following details:$/ do |cmd, table|
   end
 end
 
+When  /^I create a symlink from "(.*?)" to "(.*?)"$/ do |src, dest|
+  @link_destname = File.basename(dest)
+  # create a symlink
+  FileUtils.ln_s(src, dest)
+end
+
 When /^I run the command "(.*?)" to (validate|package|clean) the app$/ do |cmd, action|
   IO.popen(cmd, "w+") do |pipe|
     pipe.puts "\n"
@@ -83,3 +90,13 @@ end
 Then /^the command output should contain "(.*?)"$/ do |output|
   @output.join.should =~ /#{output}/
 end
+
+Then /^"(.*?)" should be a symlink$/ do |path|
+  File.symlink?(path).should be_true
+end
+
+Then /^the zip file in "(.*?)" should not contain any symlinks$/ do |path|
+  Zip::ZipFile.foreach Dir[path+'/app-*.zip'][0] do |p|
+   p.symlink?.should be_false
+  end
+end

data/lib/zendesk_apps_tools/command.rb

@@ -89,8 +89,14 @@ module ZendeskAppsTools
 
       Zip::ZipFile.open(archive_path, 'w') do |zipfile|
         app_package.files.each do |file|
-          say_status "package", "adding #{file.relative_path}"
-          zipfile.add(file.relative_path, app_dir.join(file.relative_path).to_s)
+          path = file.relative_path
+          say_status "package", "adding #{path}"
+
+          # resolve symlink to source path
+          if File.symlink? file.absolute_path
+            path = File.readlink(file.absolute_path)
+          end
+          zipfile.add(file.relative_path, app_dir.join(path).to_s)
         end
       end
 

data/lib/zendesk_apps_tools/settings.rb

@@ -16,15 +16,24 @@ module ZendeskAppsTools
           input = user_input.get_value_from_stdin("Enter a value for optional parameter '#{param[:name]}' or press 'Return' to skip:\n", :allow_empty => true)
         end
 
-        unless input.empty?
-          input = (input =~ /^(true|t|yes|y|1)$/i) ? true : false if param[:type] == 'checkbox'
-          settings[param[:name]] = input
+        if param[:type] == 'checkbox'
+          input = convert_to_boolean_for_checkbox(input)
         end
 
+        settings[param[:name]] = input if input != ''
         settings
       end
     end
 
+    private
+
+    def convert_to_boolean_for_checkbox(input)
+      if ![TrueClass, FalseClass].include?(input.class)
+        return (input =~ /^(true|t|yes|y|1)$/i) ? true : false
+      end
+      input
+    end
+
   end
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_tools
 version: !ruby/object:Gem::Version
-  version: 1.8.0
+  version: 1.9.0
 platform: ruby
 authors:
 - James A. Rosen
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-02 00:00:00.000000000 Z
+date: 2013-12-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor
@@ -75,14 +75,14 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.8.0
+        version: 1.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.8.0
+        version: 1.9.0
 - !ruby/object:Gem::Dependency
   name: cucumber
   requirement: !ruby/object:Gem::Requirement
@@ -161,6 +161,7 @@ files:
 - app_template/assets/logo.png
 - app_template/assets/promotion-image.png
 - app_template/manifest.json.tt
+- app_template/README.md
 - app_template/templates/layout.hdbs
 - app_template/translations/en.json
 - templates/translation.erb.tt
@@ -193,7 +194,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
 summary: Tools to help you develop Zendesk Apps.