zendesk_apps_support 4.6.1 → 4.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2606213b113bb33822d480147204c96413ca811f
-  data.tar.gz: a75bceb9a99922779a630a6788ef85d6c2ca3556
+  metadata.gz: 45992fa4944c849d21b3520e9c30876cb5fb2f90
+  data.tar.gz: c55fa1f788097d2bae83513551330978c41b318e
 SHA512:
-  metadata.gz: 4065b212cb191878ca73eb4404117d25eb3079fe1635e7f870eff0c92d8db85a7351dcd66bc664e856298c97aef32090d2d95fdabf1f6a13744fa4cebc30d2c7
-  data.tar.gz: 37bb13b7f53c1fd2f06dc05b683a4eacd9b0b5976b45442f111afd4ff2e5514ab3f7639316d948748aa1f2e84b50cd1747cf8da12722e65c1e0d5cdd73b251b8
+  metadata.gz: 973e63b7b9337a61df53bc55156bf8d2cbd3048e5efd340e08bffa8fde43621b93cc5d1a232cd4cdda822e9ef2939465cfb7a6868773fb5a49ff5eab610d33f3
+  data.tar.gz: db1cfe07a3f274b225521c6eb9eab6fa54f2d16fc4d5ed768d8763182f229fb7c64607545039a2fd8e7dfb15b82851f8bc9631e9dd1889efde6e99dc44c58ac2

data/config/locales/en.yml

@@ -22,7 +22,7 @@ en:
             no_app_js_required: Do not set your app to requirements only if you need
               app.js
             manifest_not_json: manifest is not proper JSON. %{errors}
-            duplicate_manifest_keys: There are duplicate keys specified in the manifest.json
+            duplicate_manifest_keys: Duplicate keys are specified in the manifest.json
               file. %{errors}
             missing_manifest: Could not find manifest.json
             nested_manifest: Could not find manifest.json in the root of the zip file,
@@ -59,7 +59,7 @@ en:
             banner:
               invalid_format: Banner image must be a PNG file.
               invalid_size: Invalid banner image dimensions. Must be %{required_banner_width}x%{required_banner_height}px.
-            dirty_svg: "%{svg} contains invalid markup and was unable to be automatically
+            dirty_svg: "%{svg} contains invalid markup and could not be automatically
               regenerated."
             oauth_keys:
               missing:
@@ -124,5 +124,5 @@ en:
             deprecated_version: You are targeting a deprecated version of the framework.
               Your app will work, but it might break when the new framework version
               is deployed.
-            sanitised_svg: The markup in %{svg} has been edited for use in Zendesk,
+            sanitised_svg: The markup in %{svg} has been edited for use in Zendesk
               and may not display as intended.

data/config/locales/translations/zendesk_apps_support.yml

@@ -46,8 +46,8 @@ parts:
       value: "manifest is not proper JSON. %{errors}"
   - translation:
       key: "txt.apps.admin.error.app_build.duplicate_manifest_keys"
-      title: "App builder job: duplicate keys in manifest"
-      value: "There are duplicate keys specified in the manifest.json file. %{errors}"
+      title: "App builder job: duplicate keys in manifest.json file (do not localize file name). Placeholders loads errors"
+      value: "Duplicate keys are specified in the manifest.json file. %{errors}"
   - translation:
       key: "txt.apps.admin.error.app_build.missing_manifest"
       title: "App builder job: missing manifest error"

data/lib/zendesk_apps_support/validations/manifest.rb

@@ -230,7 +230,7 @@ module ZendeskAppsSupport
         def invalid_location_error(package)
           errors = []
           package.manifest.location_options.each do |location_options|
-            if location_options.url && !location_options.url.empty?
+            if location_options.url.is_a?(String) && !location_options.url.empty?
               errors << invalid_location_uri_error(package, location_options.url)
             elsif location_options.auto_load?
               errors << ValidationError.new(:blank_location_uri, location: location_options.location.name)
@@ -242,7 +242,7 @@ module ZendeskAppsSupport
             next if invalid_locations.empty?
             errors << ValidationError.new(:invalid_location,
                                           invalid_locations: invalid_locations.join(', '),
-                                          host_name: product.name,
+                                          host_name: product.name.capitalize,
                                           count: invalid_locations.length)
           end
 

data/lib/zendesk_apps_support/validations/translations.rb

@@ -81,7 +81,7 @@ module ZendeskAppsSupport
             return ValidationError.new(
               'translation.missing_required_key_for_product',
               file: file_path,
-              product: product,
+              product: product.capitalize,
               missing_key: missing_keys.join(', ')
             )
           end
@@ -94,8 +94,8 @@ module ZendeskAppsSupport
           ValidationError.new(
             'translation.products_do_not_match_manifest_products',
             file: file_path,
-            translation_products: products.join(', '),
-            manifest_products: manifest_products.join(', ')
+            translation_products: products.map(&:capitalize).join(', '),
+            manifest_products: manifest_products.map(&:capitalize).join(', ')
           )
         end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_support
 version: !ruby/object:Gem::Version
-  version: 4.6.1
+  version: 4.6.2
 platform: ruby
 authors:
 - James A. Rosen
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-20 00:00:00.000000000 Z
+date: 2017-11-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n