zendesk_apps_support 4.6.0 → 4.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 64de3713a3278aa1401945176018eb8251dabe2b
-  data.tar.gz: 12900df7de9e00ef76386f5f0b8597de02ca2cd1
+  metadata.gz: 2606213b113bb33822d480147204c96413ca811f
+  data.tar.gz: a75bceb9a99922779a630a6788ef85d6c2ca3556
 SHA512:
-  metadata.gz: 5dfa543b1937ef9a1fc90ef04e22bd0e5bee34279512557a0f6e1fbebfdead52c062b7434b259d5127710494d8f95df08cb271a50b4200f92c51f480ff9cdba3
-  data.tar.gz: a5743c976fb414931c707afc21fffa8137420c5448d9526daff454dabb6c2e04ef767e5c7f96f46828128ac70512b7adac86f41b13823f147beb5601f81fae0b
+  metadata.gz: 4065b212cb191878ca73eb4404117d25eb3079fe1635e7f870eff0c92d8db85a7351dcd66bc664e856298c97aef32090d2d95fdabf1f6a13744fa4cebc30d2c7
+  data.tar.gz: 37bb13b7f53c1fd2f06dc05b683a4eacd9b0b5976b45442f111afd4ff2e5514ab3f7639316d948748aa1f2e84b50cd1747cf8da12722e65c1e0d5cdd73b251b8

data/lib/zendesk_apps_support/validations/svg.rb

@@ -4,25 +4,32 @@ require 'loofah'
 module ZendeskAppsSupport
   module Validations
     module Svg
-      @strip_declaration = Loofah::Scrubber.new do |node|
-        node.remove if node.name == 'xml' && node.children.empty?
-      end
-
-      @empty_malformed_markup = Loofah::Scrubber.new do |node|
-        node.next.remove while node.name == 'svg' && node.next
-      end
+      # whitelist elements and attributes used in Zendesk Garden assets
+      Loofah::HTML5::WhiteList::ALLOWED_ELEMENTS_WITH_LIBXML2.add 'symbol'
+      Loofah::HTML5::WhiteList::ACCEPTABLE_CSS_PROPERTIES.add 'position'
 
       # CRUFT: ignore a (very specific) style attribute which Loofah would otherwise scrub.
       # This attribute is deprecated (https://www.w3.org/TR/filter-effects/#AccessBackgroundImage)
       # but is included in many of the test apps used in fixtures for tests in ZAM, ZAT etc.
-      @remove_enable_background = Loofah::Scrubber.new do |node|
-        match_pattern = Regexp.new("enable-background:.*?(\;|\z)")
+      Loofah::HTML5::WhiteList::ACCEPTABLE_CSS_PROPERTIES.add 'enable-background'
+
+      @strip_declaration = Loofah::Scrubber.new do |node|
+        node.remove if node.name == 'xml' && node.children.empty?
+      end
+
+      # Loofah's default scrubber strips spaces between CSS attributes. Passing the input markup through this scrubber
+      # first ensures that this stripped whitespace in the output doesn't register as a diff.
+      @strip_spaces_between_css_attrs = Loofah::Scrubber.new do |node|
+        match_pattern = Regexp.new(/\;\s+/)
         if node.name == 'svg' && node['style']
-          node['style'] = node['style'].gsub(match_pattern, '')
-          node.attributes['style'].remove if node['style'].empty?
+          node['style'] = node['style'].gsub(match_pattern, ';')
         end
       end
 
+      @empty_malformed_markup = Loofah::Scrubber.new do |node|
+        node.next.remove while node.name == 'svg' && node.next
+      end
+
       class << self
         def call(package)
           errors = []
@@ -30,7 +37,7 @@ module ZendeskAppsSupport
           package.svg_files.each do |svg|
             markup = Loofah.xml_fragment(svg.read)
                            .scrub!(@strip_declaration)
-                           .scrub!(@remove_enable_background)
+                           .scrub!(@strip_spaces_between_css_attrs)
                            .to_xml.strip
 
             clean_markup = Loofah.xml_fragment(markup)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_support
 version: !ruby/object:Gem::Version
-  version: 4.6.0
+  version: 4.6.1
 platform: ruby
 authors:
 - James A. Rosen
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-19 00:00:00.000000000 Z
+date: 2017-10-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -273,7 +273,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Support to help you develop Zendesk Apps.