zendesk_apps_support 4.4.0 → 4.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e72293eff17b81b124a52b13846a4fa5960d0f09
-  data.tar.gz: 4187e6abb5b4d2f8c1d2c923c91e5b18ae3d8029
+  metadata.gz: 3ca887b91a9c145b4714cd80b37c346064fdf9f0
+  data.tar.gz: 6439af11eca81816dc44a7999a7cd5b9b4891508
 SHA512:
-  metadata.gz: 0debb87a845b756dd8baa4610d29d06b0cc0aef16b2a8623a1cfc0134c32f45d0b2432d76cf2d7d0439b73107c91ad2be1e436c5cce6d3fd9088b349d4207ad1
-  data.tar.gz: 912cd57cc7ce6e5448a0b28124038760ae9d98a700edd0ebfc49f935f4d255128cb4233f1bac6ac656855be291cbeac0989aa3883d8f767cd20bd8fbce684e2d
+  metadata.gz: 6a6ecfc6ce4154238be60b5daba6323ec6e75069f6b56a4a26ef8e1db30f98c20ab2fdbe1afcf408fd603043ab45bb127c43b7481f53b31a93ac7bbaaca9dcaa
+  data.tar.gz: cbe1950ae18916d69691734e7ef50518500111d85984522a439de5862ace924c5abdcdcc64c17008f4332b22585f4727599524c4f1de4cf87a2a163f4b95fdce

data/config/locales/en.yml

@@ -57,7 +57,6 @@ en:
             banner:
               invalid_format: Banner image must be a PNG file.
               invalid_size: Invalid banner image dimensions. Must be %{required_banner_width}x%{required_banner_height}px.
-            dirty_svg: '%{svg} contains invalid markup and was unable to be automatically regenerated.'
             oauth_keys:
               missing:
                 one: 'Missing required oauth field in manifest: %{missing_keys}'
@@ -119,4 +118,3 @@ en:
             deprecated_version: You are targeting a deprecated version of the framework.
               Your app will work, but it might break when the new framework version
               is deployed.
-          sanitised_svg: "The markup in %{svg} has been edited for use in Zendesk, and may not display as intended."

data/lib/zendesk_apps_support.rb

@@ -27,7 +27,6 @@ module ZendeskAppsSupport
     autoload :Stylesheets,           'zendesk_apps_support/validations/stylesheets'
     autoload :Requirements,          'zendesk_apps_support/validations/requirements'
     autoload :Banner,                'zendesk_apps_support/validations/banner'
-    autoload :Svg,                   'zendesk_apps_support/validations/svg'
   end
 
   class Manifest

data/lib/zendesk_apps_support/package.rb

@@ -30,7 +30,6 @@ module ZendeskAppsSupport
     def validate(marketplace: true)
       [].tap do |errors|
         errors << Validations::Manifest.call(self)
-
         if has_manifest?
           errors << Validations::Marketplace.call(self) if marketplace
           errors << Validations::Source.call(self)
@@ -44,7 +43,6 @@ module ZendeskAppsSupport
         end
 
         errors << Validations::Banner.call(self) if has_banner?
-        errors << Validations::Svg.call(self) if has_svgs?
 
         errors.flatten!.compact!
       end
@@ -93,10 +91,6 @@ module ZendeskAppsSupport
       @lib_files ||= js_files.select { |f| f =~ %r{^lib/} }
     end
 
-    def svg_files
-      @svg_files ||= files.select { |f| f =~ %r{^assets/.*\.svg$} }
-    end
-
     def template_files
       files.select { |f| f =~ %r{^templates/.*\.hdbs$} }
     end
@@ -274,10 +268,6 @@ module ZendeskAppsSupport
       has_file?('assets/banner.png')
     end
 
-    def has_svgs?
-      svg_files.any?
-    end
-
     def location_icons
       Hash.new { |h, k| h[k] = {} }.tap do |location_icons|
         manifest.location_options.each do |location_options|

data/lib/zendesk_apps_support/validations/banner.rb

@@ -7,7 +7,7 @@ module ZendeskAppsSupport
       BANNER_WIDTH = 830
       BANNER_HEIGHT = 200
 
-      class << self
+      class <<self
         def call(package)
           File.open(package.path_to('assets/banner.png'), 'rb') do |fh|
             begin

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_support
 version: !ruby/object:Gem::Version
-  version: 4.4.0
+  version: 4.4.1
 platform: ruby
 authors:
 - James A. Rosen
@@ -111,34 +111,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.3.0
-- !ruby/object:Gem::Dependency
-  name: loofah
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: nokogiri
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.6.8.1
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.6.8.1
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -195,20 +167,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.46.0
-- !ruby/object:Gem::Dependency
-  name: byebug
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Support to help you develop Zendesk Apps.
 email:
 - dev@zendesk.com
@@ -249,7 +207,6 @@ files:
 - lib/zendesk_apps_support/validations/requirements.rb
 - lib/zendesk_apps_support/validations/source.rb
 - lib/zendesk_apps_support/validations/stylesheets.rb
-- lib/zendesk_apps_support/validations/svg.rb
 - lib/zendesk_apps_support/validations/templates.rb
 - lib/zendesk_apps_support/validations/translations.rb
 - lib/zendesk_apps_support/validations/validation_error.rb
@@ -265,7 +222,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.0'
+      version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="

data/lib/zendesk_apps_support/validations/svg.rb

@@ -1,28 +0,0 @@
-# frozen_string_literal: true
-require 'loofah'
-
-module ZendeskAppsSupport
-  module Validations
-    module Svg
-      class << self
-        def call(package)
-          errors = []
-          package.svg_files.each do |svg|
-            markup = svg.read
-            clean_markup = Loofah.scrub_xml_document(markup, :prune).to_html
-            filepath = svg.relative_path
-
-            next if clean_markup == markup
-            begin
-              IO.write(filepath, clean_markup)
-              package.warnings << I18n.t('txt.apps.admin.warning.sanitised_svg', svg: filepath)
-            rescue
-              errors << ValidationError.new(:dirty_svg, svg: filepath)
-            end
-          end
-          errors
-        end
-      end
-    end
-  end
-end