zendesk_apps_support 4.33.0 → 4.34.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '0358535696ec34c00e8eb9b6d2aa3c0575ddca2dec7df2f516e15099788f96c2'
-  data.tar.gz: 178611fb26e2bd7552c8e6b82c520854f40455ef71b3fa685690f2666df8e1a9
+  metadata.gz: daadfd24b104643d1232b9d0806cccfd9019e73f3e124eb25eea78215deadebf
+  data.tar.gz: 101976ef21c36e7c07249ed91aac765861a57b7fa87fb02a57d00aaf353a57dd
 SHA512:
-  metadata.gz: 6a2cfbba4f1726d72874e64d4e59612b43cfc429a0d2944896824e8751ea8445953bb52576b885967b4601a0faa5a6c727667b8768b13d0bf06b8fdee5a1e104
-  data.tar.gz: dc364377373e42668dce9f13cb30abf30e64d360c18f2c0d7bd3401c4005c2b22c3774fdf56c77d26ab0e077416d2853562e7daed87e2f396faa74950b82e205
+  metadata.gz: d3535f5a0f2da21a3865a5891d4d2ad35d38876dd54ff6ece6c41933935f133681e7b45d95a8efe1abd5acc93421a37cac2150586e90d95c563f01894011d579
+  data.tar.gz: 9d15fa32361ce1979f4dccbd1eba7e630d337b929c85e54eafbddf4651d741babaa5f99bff06d657e3b6cd28dabafb1aea74e2dcd21acf95809785ad9d98bcea

data/config/locales/en.yml

@@ -148,6 +148,7 @@ en:
               other: "%{invalid_locations} are invalid locations in framework v1."
             oauth_parameter_cannot_be_secure: oauth parameter cannot be set to be
               secure.
+            invalid_url: '%{field} must be a valid URL, got "%{value}".'
         warning:
           app_build:
             deprecated_version: You are targeting a deprecated version of the framework.

data/config/locales/translations/zendesk_apps_support.yml

@@ -412,3 +412,7 @@ parts:
       key: "txt.apps.admin.error.app_build.oauth_parameter_cannot_be_secure"
       title: "oauth parameter cannot be set to be secure."
       value: "oauth parameter cannot be set to be secure."
+  - translation:
+      key: "txt.apps.admin.error.app_build.invalid_url"
+      title: "App builder job: this value needs to be a valid URL, but something else was passed in. placeholder value is taken from user input. You can translate as: The value %{field} must be a valid URL... to avoid any gender issues."
+      value: "%{field} must be a valid URL, got \"%{value}\"."

data/lib/zendesk_apps_support/validations/manifest.rb

@@ -39,6 +39,7 @@ module ZendeskAppsSupport
             type_checks(manifest),
             oauth_error(manifest),
             default_locale_error(manifest, package),
+            validate_urls(manifest),
             validate_parameters(manifest),
             if manifest.requirements_only? || manifest.marketing_only?
               [ ban_location(manifest),
@@ -63,6 +64,20 @@ module ZendeskAppsSupport
           ]
         end
 
+        def validate_urls(manifest)
+          errors = []
+
+          if manifest.terms_conditions_url && !valid_url?(manifest.terms_conditions_url)
+            errors << ValidationError.new(:invalid_url, field: 'terms_conditions_url', value: manifest.terms_conditions_url)
+          end
+
+          author = manifest.author
+          if author && author["url"] && !valid_url?(author["url"])
+            errors << ValidationError.new(:invalid_url, field: 'author url', value: author["url"])
+          end
+          errors
+        end
+
         def validate_parameters(manifest)
           if manifest.marketing_only?
             marketing_only_errors(manifest)
@@ -416,6 +431,13 @@ module ZendeskAppsSupport
             ValidationError.new(:invalid_no_template)
           end
         end
+
+        def valid_url?(value)
+          uri = URI.parse(value)
+          uri.is_a?(URI::HTTP) && !uri.host.nil?
+        rescue URI::InvalidURIError
+          false
+        end
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_support
 version: !ruby/object:Gem::Version
-  version: 4.33.0
+  version: 4.34.0
 platform: ruby
 authors:
 - James A. Rosen
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-05-19 00:00:00.000000000 Z
+date: 2022-05-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n