zendesk_apps_support 4.16.0 → 4.17.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7629b25072aa14d2fc633c4061efe052835f0893e221c131881124ecf1bb9989
-  data.tar.gz: 31827636b35c8b029e80e96cf7511b17f25b64319ba26725bc57fee0c38abda8
+  metadata.gz: b9e6c1b0f73a414798ff651dfa81572508499a30a54c4edf6e5fd09b13391424
+  data.tar.gz: a889c5ccf500f94aae9bc6ab1cd13a64dbe9cb9b0f916dbf048e5367381a5187
 SHA512:
-  metadata.gz: c84e515174af4129cd536c670279113588893de7f684523edd35521dac6fa0f1d1c33e1b7648239e56e88ef697899f11bb87c64f250c960a1dd4296709e35752
-  data.tar.gz: 1279372798bf6ba5a1672408046d308ae7feaf00d99cfdddb96122ce1ad4be3780e2c49223be5311146426ed4e5549c1647c8503401659b001f648a3946a8196
+  metadata.gz: 22f0f135b839ee5bba993f1907f713bfd0585272bbd928e79fbae9c47d1e0e5f0bdae08b91f85f5ab84aad223f1c6ea844b71a176ba29d7bbaa303ef5bdf77be
+  data.tar.gz: 0e94c79424df86521f7887b40829e87704b923d43d22f439127740c25f4f566a990583b132a70acd7a551998e07bfc1b23da47f24af4342006017f19f6e61b06

data/lib/zendesk_apps_support.rb

@@ -21,6 +21,7 @@ module ZendeskAppsSupport
     autoload :ValidationError,       'zendesk_apps_support/validations/validation_error'
     autoload :Manifest,              'zendesk_apps_support/validations/manifest'
     autoload :Marketplace,           'zendesk_apps_support/validations/marketplace'
+    autoload :Mime,                  'zendesk_apps_support/validations/mime'
     autoload :Secrets,               'zendesk_apps_support/validations/secrets'
     autoload :Source,                'zendesk_apps_support/validations/source'
     autoload :Templates,             'zendesk_apps_support/validations/templates'

data/lib/zendesk_apps_support/app_file.rb

@@ -15,6 +15,10 @@ module ZendeskAppsSupport
       File.read @file.path
     end
 
+    def extension
+      File.extname relative_path
+    end
+
     def =~(regex)
       relative_path =~ regex
     end

data/lib/zendesk_apps_support/package.rb

@@ -46,6 +46,7 @@ module ZendeskAppsSupport
 
       errors << Validations::Banner.call(self) if has_banner?
       errors << Validations::Svg.call(self) if has_svgs?
+      errors << Validations::Mime.call(self)
 
       # warning only validators
       Validations::Secrets.call(self)

data/lib/zendesk_apps_support/validations/mime.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+require 'mimemagic'
+
+module ZendeskAppsSupport
+  module Validations
+    module Mime
+      UNSUPPORTED_MIME_TYPES = %w[
+        vnd.rar rar zip gzip pdf doc docx avi bin bz bz2 csh sh jar mp3 mpeg odt pptx ppt xls xlsx 7z
+      ].freeze
+
+      class << self
+        def call(package)
+          unsupported_files =
+            package.files.find_all { |app_file| block_listed?(app_file) }.map(&:relative_path)
+
+          [mime_type_warning(unsupported_files)] if unsupported_files.any?
+        end
+
+        private
+
+        def block_listed?(app_file)
+          mime_type = MimeMagic.by_magic(app_file.read)
+
+          content_subtype = mime_type.subtype if mime_type
+          extension_name = app_file.extension.delete('.')
+
+          ([content_subtype, extension_name] & UNSUPPORTED_MIME_TYPES).any?
+        end
+
+        def mime_type_warning(file_names)
+          ValidationError.new(
+            :unsupported_mime_type_detected,
+            file_names: file_names.join(', '),
+            count: file_names.count
+          )
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_support
 version: !ruby/object:Gem::Version
-  version: 4.16.0
+  version: 4.17.0
 platform: ruby
 authors:
 - James A. Rosen
@@ -153,6 +153,20 @@ dependencies:
     - - '='
       - !ruby/object:Gem::Version
         version: 0.9.10
+- !ruby/object:Gem::Dependency
+  name: mimemagic
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.3.3
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.3.3
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -261,6 +275,7 @@ files:
 - lib/zendesk_apps_support/validations/banner.rb
 - lib/zendesk_apps_support/validations/manifest.rb
 - lib/zendesk_apps_support/validations/marketplace.rb
+- lib/zendesk_apps_support/validations/mime.rb
 - lib/zendesk_apps_support/validations/requirements.rb
 - lib/zendesk_apps_support/validations/secrets.rb
 - lib/zendesk_apps_support/validations/source.rb