zendesk_apps_support 4.9.1 → 4.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 7dbd4a9dbbf9424033bd8c1194985d61b1df4b13
-  data.tar.gz: b911d0565982c5fc80b676e2ddb0af99bd17ea9d
+SHA256:
+  metadata.gz: d10ac2adce861c9b73ab9101e7606305d34b1741db038c458e22cc574e37a5d3
+  data.tar.gz: d41cc50438b65b960d20baaa26a5ab14f522cd935e3aa84cabf51a63835ea806
 SHA512:
-  metadata.gz: 9e0518cb6f9c12ae6645de44eb7bf245db885acc9e62e0d295c481a14fb4514a875d1b58da064deefe3d24f5166e8c595cd8ff51a2c28df9885bb2c0d0fb8bb8
-  data.tar.gz: 21373506c95063e03c5497188c5988ab33eedfd5f6d3de74ce5a0923e6e6548952644f5a37ba1cf7504f10ef576ac6dee6491f0ade50b8b42edb1e951ad28bc1
+  metadata.gz: 698940e0eb1029f3181251dba53d537333c029ca1bed06831045b1c26b1508035ab0b7f3b15b83d428c796d151ed9531a9d6f90e599507cf44c5e4b5f692c295
+  data.tar.gz: bd61dc59a6b09dff757172bd03eef673df6138257a00d3d36df12b1867036e93f2c13839c6f440015e74a0bc94cf6407a2fccbd63386f3d88d283900b12822d2

data/config/locales/en.yml

@@ -79,6 +79,8 @@ en:
             blank_location_uri: "%{location} location does not specify a URI."
             invalid_location_uri: "%{uri} is either an invalid location URI, refers
               to a missing asset, or does not use HTTPS."
+            signed_setting_uri: the url (%{uri}) cannot use a setting because it is
+              a signed url
             duplicate_location:
               one: "%{duplicate_locations} is a duplicate location."
               other: "%{duplicate_locations} are duplicate locations."

data/config/locales/translations/zendesk_apps_support.yml

@@ -184,6 +184,11 @@ parts:
       key: "txt.apps.admin.error.app_build.invalid_location_uri"
       title: "App builder job: invalid URI for an iframe in the manifest"
       value: "%{uri} is either an invalid location URI, refers to a missing asset, or does not use HTTPS."
+  - translation:
+      key: "txt.apps.admin.error.app_build.signed_setting_uri"
+      title: "App builder job: invalid URI for an iframe in the manifest. The `manifest` is a setting file, the `signed url` is https://cloud.google.com/storage/docs/access-control/signed-urls"
+      value: "the url (%{uri}) cannot use a setting because it is a signed url"
+      screenshot: "https://drive.google.com/open?id=1oQmBeGfNT5EDaEH3oEQoNjaCzBw5XAvL"
   - translation:
       key: "txt.apps.admin.error.app_build.duplicate_location.one"
       title: "App builder job: duplicate locations"

data/lib/zendesk_apps_support/validations/manifest.rb

@@ -231,7 +231,7 @@ module ZendeskAppsSupport
           errors = []
           package.manifest.location_options.each do |location_options|
             if location_options.url.is_a?(String) && !location_options.url.empty?
-              errors << invalid_location_uri_error(package, location_options.url)
+              errors << invalid_location_uri_error(package, location_options)
             elsif location_options.auto_load?
               errors << ValidationError.new(:blank_location_uri, location: location_options.location.name)
             end
@@ -270,8 +270,12 @@ module ZendeskAppsSupport
           end
         end
 
-        def invalid_location_uri_error(package, path)
+        def invalid_location_uri_error(package, location_options)
+          path = location_options.url
           return nil if path == ZendeskAppsSupport::Manifest::LEGACY_URI_STUB
+          if path.include?('{{setting.')
+            return location_options.signed ? ValidationError.new(:signed_setting_uri, uri: path) : nil
+          end
           validation_error = ValidationError.new(:invalid_location_uri, uri: path)
           uri = URI.parse(path)
           unless uri.absolute? ? valid_absolute_uri?(uri) : valid_relative_uri?(package, uri)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_support
 version: !ruby/object:Gem::Version
-  version: 4.9.1
+  version: 4.10.0
 platform: ruby
 authors:
 - James A. Rosen
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-26 00:00:00.000000000 Z
+date: 2018-03-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -274,7 +274,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Support to help you develop Zendesk Apps.