zendesk_apps_support 3.3.4 → 3.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c2cdd80ab3e773cb08066ad7b85e520150249eee
-  data.tar.gz: 2c2ed26d634b62778a2807c8122afca66929623d
+  metadata.gz: 19222b64e8ff67b0afffaf3c9fe90ea2e7b84336
+  data.tar.gz: e3947b4cf588795edcf1a2ad094e4ab568da46d9
 SHA512:
-  metadata.gz: 6bb71ca453c6f05e157e2a650bb435ae7efe0753d7426dc04baeba82dfe5f33dfeb6f910f14b1cea25d5c699c69ce28d2f65803def6f9fc72c9a06801d0726e7
-  data.tar.gz: 448acbd4700429e4ed500a5a3750452f63d38a3df43dd1b7a09fd48938b8ef0695fc2dcb0262bfefa793b11f9fc3920460793b29c2eabc0b21fd1e08dd21ce9a
+  metadata.gz: 1dca48bfc664508930843c1b8d9954e126ccb0d0db5bd8275530f3f99a855697aef9aca2f4880c186acfd8c5937a3b0606e263f770440bc7757139a507020043
+  data.tar.gz: b05e60e7d88015ee3bd496b27aeefdaac5e80d24fc5f4853210aaaee4a4a867339614ea42903a4add1aaa6a9dfa1f816430d4a48cbb7c3d1a8a4c53aee2198e6

data/config/locales/en.yml

@@ -10,10 +10,11 @@ en:
               one: 'JSHint error in %{file}: %{errors}'
               other: 'JSHint errors in %{file}: %{errors}'
             no_template_deprecated_in_v2: 'noTemplate is deprecated and cannot be
-              used with frameworkVersion 2 or above. Set the autoLoad or autoHide
+              used with framework version 2 or above. Set the autoLoad or autoHide
               property for each specific location instead. Learn more: %{link}.'
             no_parameters_required: Parameters can't be defined for marketing-only
               apps
+            marketing_only_app_cant_be_private: Marketing-only apps must not be private
             no_location_required: Locations can't be defined when you specify requirements
               only
             no_framework_version_required: Framework versions can't be set when you

data/config/locales/translations/zendesk_apps_support.yml

@@ -23,6 +23,10 @@ parts:
       key: "txt.apps.admin.error.app_build.no_parameters_required"
       title: "App builder job: prevent adding parameters while marketing only"
       value: "Parameters can't be defined for marketing-only apps"
+  - translation:
+      key: "txt.apps.admin.error.app_build.marketing_only_app_cant_be_private"
+      title: "App builder job: prevent creating a private marketing only app"
+      value: "Marketing-only apps must not be private"
   - translation:
       key: "txt.apps.admin.error.app_build.no_location_required"
       title: "App builder job: ban location while requirements only"

data/lib/zendesk_apps_support/manifest.rb

@@ -47,12 +47,10 @@ module ZendeskAppsSupport
 
     def products
       @products ||=
-        if requirements_only?
+        if requirements_only? || marketing_only?
           [ Product::SUPPORT ]
         else
-          location_options.map { |lo| lo.location.product_code }
-                          .uniq
-                          .map { |code| Product.find_by(code: code) }
+          products_from_locations
         end
     end
 
@@ -134,6 +132,12 @@ module ZendeskAppsSupport
 
     attr_reader :locations
 
+    def products_from_locations
+      location_options.map { |lo| lo.location.product_code }
+                      .uniq
+                      .map { |code| Product.find_by(code: code) }
+    end
+
     def set_locations_and_hosts
       @locations =
         case original_locations

data/lib/zendesk_apps_support/validations/manifest.rb

@@ -22,6 +22,7 @@ module ZendeskAppsSupport
 
         private
 
+        # rubocop:disable Metrics/AbcSize
         def collate_manifest_errors(package)
           manifest = package.manifest
 
@@ -33,6 +34,7 @@ module ZendeskAppsSupport
 
           if manifest.marketing_only?
             errors << ban_parameters(manifest)
+            errors << private_marketing_app_error(manifest)
           else
             errors << parameters_error(manifest)
             errors << invalid_hidden_parameter_error(manifest)
@@ -57,6 +59,7 @@ module ZendeskAppsSupport
 
           errors.flatten.compact
         end
+        # rubocop:enable Metrics/AbcSize
 
         def boolean_error(manifest)
           booleans = %i(requirements_only marketing_only single_install signed_urls private)
@@ -100,6 +103,10 @@ module ZendeskAppsSupport
           ValidationError.new(:no_framework_version_required) unless manifest.framework_version.nil?
         end
 
+        def private_marketing_app_error(manifest)
+          ValidationError.new(:marketing_only_app_cant_be_private) if manifest.private?
+        end
+
         def oauth_error(manifest)
           return unless manifest.oauth
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_support
 version: !ruby/object:Gem::Version
-  version: 3.3.4
+  version: 3.3.5
 platform: ruby
 authors:
 - James A. Rosen
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-03 00:00:00.000000000 Z
+date: 2017-01-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n